From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DAE8C83F07 for ; Mon, 7 Jul 2025 07:58:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F6598D000D; Mon, 7 Jul 2025 03:58:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CDD08D0002; Mon, 7 Jul 2025 03:58:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BD3A8D000D; Mon, 7 Jul 2025 03:58:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EE03F8D0002 for ; Mon, 7 Jul 2025 03:58:58 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7182F10AA02 for ; Mon, 7 Jul 2025 07:58:58 +0000 (UTC) X-FDA: 83636717556.07.36FA5D1 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf13.hostedemail.com (Postfix) with ESMTP id 8CFB920017 for ; Mon, 7 Jul 2025 07:58:56 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=JHEK4QpY; spf=pass (imf13.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.178 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751875136; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OTPtMw8HQb4L5f8OeutCZQxDgspI5HCxCvqaYmgltWo=; b=8Erw1hgZB94eCgKRyVkdTyABdtGtujwFXOY/pJbbqIQEMmWYshC31HRJwUSwz2Edi4xcTR BZ5pCoa1fjtx57v5w4wA82Ll5NBlaCTDK5gVjOfQRmvjvjuXRoEdgd+RVMNw26X8XaEe2P LovuhchInsw5iAltxHJimKDAevDgTgA= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=JHEK4QpY; spf=pass (imf13.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.178 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751875136; a=rsa-sha256; cv=none; b=y5i3b4IomCDYzaAZ/c3i7E7qIu8ucbtSZIiJXrLzV1LYuOyPf1iySm0/YAdi/WCTPY/FS3 vHPuYsGfBUFyHRgnloELe+UodtdsX1r5wk1j13F/5wzuNHZRSy7l4bdI6/dPDoyzsxgxdO DT6DgNdKraUYvnxa1DdXhADeKCydKb8= Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-7490cb9a892so1580899b3a.0 for ; Mon, 07 Jul 2025 00:58:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1751875135; x=1752479935; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OTPtMw8HQb4L5f8OeutCZQxDgspI5HCxCvqaYmgltWo=; b=JHEK4QpY/AbSfqF1NWvocOYCwbYwxso48lzw9+JBar7YpOad/FnfhtpDofSGoe9UBN kuRbJgl5GsHOZ4Xr3yWFoULfoUYVmyiYSjWknnn7Z26Q44SZAoE+Qt/nnvhrDHZR6fLX qN+ok9BfDoIsQYaX30gQglrBU4gji4ZBqTu3E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751875135; x=1752479935; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OTPtMw8HQb4L5f8OeutCZQxDgspI5HCxCvqaYmgltWo=; b=iXgd7I9oU9+/GqJzrxrYe0BDtAbFVvtOI/pMxCnL4DJ3S4fisC5zz80sKACIvUIlxG sg34s478qheQtlUoRx3xAne4mYue6u8OSsOQMAlimF6e0NaVI3ZgPZgPClA6XWIVg6/+ EBlPL4NudUzqtkQ+02wadDnyigWEQHsoPd1f2Cv91y18C/RHaa5yNX+TK+rTiNhBuyKy IegoJn6r1lTv6SEJYgN+jf2hanVZSAlohnXX3YS3GNe7jZBfnhZO5mBavELECwXsaxvj RHTAv2I64Kqecz76tvMie4wVZzoas8uVkUjkj0eJRc3Nx4Fnyxl1/4intwaZRPQE7wec DS2Q== X-Forwarded-Encrypted: i=1; AJvYcCVPJxJ3abcYXjwLnEV6CbnJeeS3Khf212YgDJkXH/rqY7gHGTGfza1tLfK8FD029npzo2xLcGFlcQ==@kvack.org X-Gm-Message-State: AOJu0YwRqVma15gfFCQxYfCU+IysDrbRAMadnoY/+1QtaY/K2BCpalH8 XwM9UzHPRjZOdETjXwZIWdSRAzR8yNWEbeV0fjE42ag1R+8l0GWW6RyOz5jwEXn84A== X-Gm-Gg: ASbGncsprI85VIM6+pvBA33vPNi9d3jESMPzPdh+Tl1ip1Rm0yWZfwPouvtU9NxU6H8 vRM8FUVplAosrq2znpdqU4WBm0BEBOM//OoQfuwXyyCJrOcoxUL8hPt5LeuxWiryPXm76rvzYn/ /6TkFSn5/ocqmo+byrSMQu63AsirqTqtbLQ0qGTeUyvPU46iXgpO6Ez1Rroi2a40KsX7rz/wnBt jgOSGxhZhiUo9qSizI2sePBaranuN1bFjSaC46R8AudCM/fZzeekfs6pcnqaostT0X/NIsyeFyQ dM59Ig1bpcIJCiLtl2BjjpTC7Go5DhRJBubtnct0l+aOdu9vYQGnrsx6Vz7NcnK//A== X-Google-Smtp-Source: AGHT+IEK5EtOBzyfZ2irKKdKJ5yA76QHgOFTf0rbbII+tFWb39ZzUOI/RILDQ9dMA3Gky1EGCo+7QA== X-Received: by 2002:a05:6a00:174c:b0:740:9a4b:fb2a with SMTP id d2e1a72fcca58-74cf6fd0b77mr10437438b3a.20.1751875135471; Mon, 07 Jul 2025 00:58:55 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:5470:7382:9666:68b0]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74ce35cc32fsm8422139b3a.52.2025.07.07.00.58.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Jul 2025 00:58:54 -0700 (PDT) Date: Mon, 7 Jul 2025 16:58:50 +0900 From: Sergey Senozhatsky To: Harry Yoo Cc: akpm@linux-foundation.org, Minchan Kim , Sergey Senozhatsky , David Hildenbrand , linux-mm@kvack.org, stable@vger.kernel.org Subject: Re: [PATCH v1 mm-hotfixes] mm/zsmalloc: do not pass __GFP_MOVABLE if CONFIG_COMPACTION=n Message-ID: References: <20250704103053.6913-1-harry.yoo@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250704103053.6913-1-harry.yoo@oracle.com> X-Stat-Signature: d8p97f75etq3bz766zcc6j7f3geygx5y X-Rspamd-Queue-Id: 8CFB920017 X-Rspamd-Server: rspam11 X-Rspam-User: X-HE-Tag: 1751875136-975653 X-HE-Meta: U2FsdGVkX1+EofnI184O+EDIIvfNpfVT1fGPUF0V1t8/7OgGlbzZfGXmgHrdZVNXzdWDQBOs0QoWe65qzY5kR3aoHyJLJ4gAavrRic5jAzqnrr8h/SQk77pL1VnO/BwcURoQPhVZF/h9goKI315aJ7jwNObqqrajBUFxkYfI5GjaeowEqs4kSsMJuaZ1BqWJrDvElk/kVXCfnf33PTEQAtp6TeWf2QTuypfmsd2xv1GQO3hoJzkioTRYxrLXO9zLTxLvs2vFy5buSxXyIk1qDMMWKqrsqosEU86Y59G9sp3n/uhVglKY7uZLGAQKlSjfY6VXb0bCIv4BQHTicZGSZN3Mi53TE/Y13OuMAhmjjjzb7tnIgGQjF1Au/rjuEN0Ulu101H+upE1fusF9JPMCcsHJ6gEjPM+OHqHmvMXDNjGUbZuFG7lzZY6qPVg6HeQ2BQOgfXfpYeIMKK2aPZjuY49nnKfzLqMWP1iXgPTtDGU7gxEKVdzBeT8/A92N0UCmKt5UZ8MhuFcrObxTlTmtJIzJc+UrXIFKIdkuLsB5gdoVOkc6d94kULNhER9OBD2fu+9XTiA9zvweEP8jmtHR28Bj6RwonJv0TvUKpcd49SMRUMByFMd7Y33g7iyqXH9ES2DK1wxPg2zEWuxH0+5kBSYyOGlUC+7s1B0+GxAHWRgmeamlUlVqnaG8kdCHcL7XhdINljJHb5OlKHFtBvsqK8NfQAnkijfhJ5O6OKOKdrnxS9fRfuUdIgmmw3v0U/Wbug+3GGMPLpTUklKNhprPnghBckjyqJnZ71ox+WeLqgR56pcXS5zCWdAVlgYAU0S6z0VVXvR56ft+0sejx8XF9EZG8pbEf1dNyzFCoaPrwlG8nNSpBwPw4NTEF3Zt+5thGHlzaf50AoYmlohX4pbLKdIL/CGuvxujHsDyOx1rOmcTHaMdiLfxXVCV+SjNII86JlsSPQuzrC0UGzZMqfC +kzbnPr8 fNdBY2ynkwD0dy9TankaMC5GMZnbjZrFYbQwmoR5cVLJDDjnc2UsJO//TE3yh+mtZ4XNQh20ue/rjHY3m9KYW0jxw00/T2lkESgdjiOkV3iWm9cv2eS2FrrjDXN6BdIXVHx+7P/Or373F3PaZjtfCj1GcVqHeguAfg20S0XYBBQjjqtbVfzK4WRrvoUE16/oWcT+L8mwyroxvOmpJL8TD3G8HeMthG9c9pBaGcUkpjcqxuJe1ATKeHggJI6xYvJ7NIZSPYf4EC0QQtDnse4KPKnysSr7USpd+o13s8LETgyF6NYomq9qBKqdEcdiTN2OKEimu4B/u5QK+TKYVOzhwaYFCOGGB8xFMT7NrK15zxv8+ncnwATXnQpZPTRjIDluZ77Wpk4/WlKsylztnXJJSb/o2UHEbKNLJX76oddLV40NTvtGS8o+CSSyRXKL9mIF5drdgwPwkSBsM+0zf/ILZYakkiw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/07/04 19:30), Harry Yoo wrote: > Commit 48b4800a1c6a ("zsmalloc: page migration support") added support > for migrating zsmalloc pages using the movable_operations migration > framework. However, the commit did not take into account that zsmalloc > supports migration only when CONFIG_COMPACTION is enabled. > Tracing shows that zsmalloc was still passing the __GFP_MOVABLE flag > even when compaction is not supported. > > This can result in unmovable pages being allocated from movable page > blocks (even without stealing page blocks), ZONE_MOVABLE and CMA area. > > Clear the __GFP_MOVABLE flag when !IS_ENABLED(CONFIG_COMPACTION). > > Cc: stable@vger.kernel.org > Fixes: 48b4800a1c6a ("zsmalloc: page migration support") > Signed-off-by: Harry Yoo Reviewed-by: Sergey Senozhatsky