From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Harry Yoo <harry.yoo@oracle.com>
Cc: akpm@linux-foundation.org, Minchan Kim <minchan@kernel.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
David Hildenbrand <david@redhat.com>,
linux-mm@kvack.org, stable@vger.kernel.org
Subject: Re: [PATCH v1 mm-hotfixes] mm/zsmalloc: do not pass __GFP_MOVABLE if CONFIG_COMPACTION=n
Date: Mon, 7 Jul 2025 16:58:50 +0900 [thread overview]
Message-ID: <i7tgsnsk4zqmij7h6ujrjkdhupk7mffciqodtbqyfla6zxalro@sjcgdsf4bwrs> (raw)
In-Reply-To: <20250704103053.6913-1-harry.yoo@oracle.com>
On (25/07/04 19:30), Harry Yoo wrote:
> Commit 48b4800a1c6a ("zsmalloc: page migration support") added support
> for migrating zsmalloc pages using the movable_operations migration
> framework. However, the commit did not take into account that zsmalloc
> supports migration only when CONFIG_COMPACTION is enabled.
> Tracing shows that zsmalloc was still passing the __GFP_MOVABLE flag
> even when compaction is not supported.
>
> This can result in unmovable pages being allocated from movable page
> blocks (even without stealing page blocks), ZONE_MOVABLE and CMA area.
>
> Clear the __GFP_MOVABLE flag when !IS_ENABLED(CONFIG_COMPACTION).
>
> Cc: stable@vger.kernel.org
> Fixes: 48b4800a1c6a ("zsmalloc: page migration support")
> Signed-off-by: Harry Yoo <harry.yoo@oracle.com>
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
prev parent reply other threads:[~2025-07-07 7:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 10:30 Harry Yoo
2025-07-04 10:38 ` Harry Yoo
2025-07-04 10:42 ` David Hildenbrand
2025-07-07 7:58 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=i7tgsnsk4zqmij7h6ujrjkdhupk7mffciqodtbqyfla6zxalro@sjcgdsf4bwrs \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=harry.yoo@oracle.com \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox