From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1917C25B75 for ; Fri, 31 May 2024 22:42:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB8C46B007B; Fri, 31 May 2024 18:42:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D69776B0085; Fri, 31 May 2024 18:42:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C57616B009A; Fri, 31 May 2024 18:42:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A65246B007B for ; Fri, 31 May 2024 18:42:44 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 173A0120B60 for ; Fri, 31 May 2024 22:42:44 +0000 (UTC) X-FDA: 82180167048.27.2C27429 Received: from out-176.mta0.migadu.com (out-176.mta0.migadu.com [91.218.175.176]) by imf23.hostedemail.com (Postfix) with ESMTP id 5F780140002 for ; Fri, 31 May 2024 22:42:41 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=uXJnOGHf; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf23.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.176 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717195361; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=42+HF/lg9ToKNNAC62AfkBIUQjk90D8+CQb9koVMHSI=; b=W3fn4ATW94AY6ExnB4fl9peTNabf/+EqBHEY0ibn5Vs4PgeNVsb6r5QwnlNbXRPAFtOgoJ MdKVhCfIC6LYM665WahYDqE7fwRVe+uXaz1JgO6HIZLKAxy6Vqokv7jxE29MXbI49/6f0D Wx5TwgAr59kLzDnk0aph5slyOAGtV/4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=uXJnOGHf; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf23.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.176 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717195361; a=rsa-sha256; cv=none; b=HcRN08fsuRBHC1TGJypQ6JRHW8fbaM+timbqQK9H6Of+5ZlGdszNSKFb0Gu24CEnIsO7Kl W0i5sUycu1EwJxwHD0o7igAuxWuH0Qf6vGqiT3jGggtS10A7DjFDeRs1lZeyJ2JQ7j5Rq8 ybDJOoNzX68MmE5ZsG9rv5UgANSyxIU= X-Envelope-To: pasha.tatashin@soleen.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717195359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=42+HF/lg9ToKNNAC62AfkBIUQjk90D8+CQb9koVMHSI=; b=uXJnOGHfEcr/IzgwqNuLMQ9RuiVUlcjbw0n6WpFsotQ58wpKM2VSlFd0g9fwiv/B6KPRp1 z5sNHTaRLEEkPq5hXfCmhvv44aayNUl/0d2rAxHswuUNfT66p9ec9GjXvdYaJVhAm5+iPW ixfX+ufyX+pMi/goMtSMLuynQ9ZhPU0= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: jpoimboe@kernel.org X-Envelope-To: kent.overstreet@linux.dev X-Envelope-To: peterz@infradead.org X-Envelope-To: nphamcs@gmail.com X-Envelope-To: cerasuolodomenico@gmail.com X-Envelope-To: surenb@google.com X-Envelope-To: lizhijian@fujitsu.com X-Envelope-To: willy@infradead.org X-Envelope-To: vbabka@suse.cz X-Envelope-To: ziy@nvidia.com X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: linux-mm@kvack.org Date: Fri, 31 May 2024 15:42:34 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Pasha Tatashin Cc: akpm@linux-foundation.org, jpoimboe@kernel.org, kent.overstreet@linux.dev, peterz@infradead.org, nphamcs@gmail.com, cerasuolodomenico@gmail.com, surenb@google.com, lizhijian@fujitsu.com, willy@infradead.org, vbabka@suse.cz, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3] vmstat: Kernel stack usage histogram Message-ID: References: <20240530170259.852088-1-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5F780140002 X-Stat-Signature: qsjh83nygxkhird6fymgp1mpyrks44et X-HE-Tag: 1717195361-916044 X-HE-Meta: U2FsdGVkX19D7pMEnuTeTTBIP20RcJDW/XcHKn6/evWCopgdoN7WXo3OoV8d7oOMcPUx2Et/mmbKdHoevQk6B/e8M/bw9NJQ2hdyS7sw/E49egL4TvSW2Hjv38hHXGk5zkQi5okv3hFu3LAdvMDlIajN5jsY8+ZHDKAuxJ0pW6PVDAIBEG1asM7BEUTzoz92R5XZtJuqnt39vdgqq/lgckX0dGEdBz2rXSPRaKPqR0YiPccUvcTntOea+AWZoH2YMYBT4VHmNOL/EdHXHq40kAz4OQzjTxlYsqFum4THDtsHDeriHsrO0RbpwrsIzuGtY7WUeEZAy9wFnV/f0uub2J7J10p40VkizY2mH0SdXrkxdif8DoHVYkDQsz0o19biD0j2t6lX2Ol9hBc5kx9sNqfwr7yOQ5UNTJvTzFm4gsLFDBFbAP+bQQd2F6PuLZhJzodHDfOpGeBU+SgPQcC2A0+KbploIS9A9lmVQG/oKGCdTQvZGmn4Jc/mXUTMPLzLkjkeh1fBYZvtnx7yl9ngpJO6Xq22WV0aWhqLHf490XGWICjGnldfFsLaHU7Git5iFcHkVIUhCfxOK8z6iKwUHZDp463iwRO7rgGGCNTVwrUmKk5gSUfftFsJ8R+sx5hY8A6QFhgkhMUTOdLP+XJqcjs6kISVemricGrUyxTfe2FXDR1bOhy57bKS3tYcof2xhZiotMbcAz4o+e78azavBTsLMnYSUcicK1sYf22MJb5fnRuc0B6zTFe+8wriEY/w55IVn0DKemN/IyF/BfSBxlIzqq/eZ3dXNDlEDcxK5omguEXS5tK2i4TRJPgpuWgemCl+d2b4ATg3nE/j0Ecp7eIfr4lC7/qSeOXzxrT2N0brhgpPuT7djrLWwws3mS6U9gGFkf8Lo+bZnysSCq+Q1lnnWTN96Sj0scvRr8q2fEfRm/0fl5z8YlmqhG5covHLEUWLi4SPyP22BYnTlgJ xktGSCrk bdb5kKMOFF8rZ3y16mbUx8h7/iqHvbRPTm0mGdg72S15OufyZevuT/Tr6ge4Svql+qu9D7j+p41ursFMvRTbNqFY1GQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 30, 2024 at 08:14:17PM GMT, Pasha Tatashin wrote: > Hi Shakeel, > > > Couple of questions: > > > > 1. In future with your on-demand kstack allocation feature, will these > > metrics still be useful? (I think so but I want to know your take) > > It depends on how on-demand allocation is implemented. On hardware > that supports faults on kernel stacks, Which hardware supports faults on kernel stacks and which do not? > we will have other metrics that > show the total number of pages allocated for stacks. Don't we already have a metric for that i.e. KernelStack in meminfo which is in kB unit? One more question: Is there any concern in making CONFIG_DEBUG_STACK_USAGE not a debug feature i.e. enable in default kernels instead of just debug kernels? thanks, Shakeel