linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Shakeel Butt <shakeel.butt@linux.dev>
To: Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: akpm@linux-foundation.org, jpoimboe@kernel.org,
	 kent.overstreet@linux.dev, peterz@infradead.org,
	nphamcs@gmail.com,  cerasuolodomenico@gmail.com,
	surenb@google.com, lizhijian@fujitsu.com, willy@infradead.org,
	 vbabka@suse.cz, ziy@nvidia.com, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH v3] vmstat: Kernel stack usage histogram
Date: Fri, 31 May 2024 15:42:34 -0700	[thread overview]
Message-ID: <i66bzhgnbql7bvuteqttpijml3ze3nngxapv32k7paqv25c5th@wd37oaastkvz> (raw)
In-Reply-To: <CA+CK2bCuiDAv05Xu6OuKB=gqJ5NM20F_uUyJV8E=XH=r47ik=Q@mail.gmail.com>

On Thu, May 30, 2024 at 08:14:17PM GMT, Pasha Tatashin wrote:
> Hi Shakeel,
> 
> > Couple of questions:
> >
> > 1. In future with your on-demand kstack allocation feature, will these
> > metrics still be useful? (I think so but I want to know your take)
> 
> It depends on how on-demand allocation is implemented. On hardware
> that supports faults on kernel stacks,

Which hardware supports faults on kernel stacks and which do not?

> we will have other metrics that
> show the total number of pages allocated for stacks.

Don't we already have a metric for that i.e. KernelStack in meminfo
which is in kB unit?

One more question: Is there any concern in making
CONFIG_DEBUG_STACK_USAGE not a debug feature i.e. enable in default
kernels instead of just debug kernels?

thanks,
Shakeel



  reply	other threads:[~2024-05-31 22:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-30 17:02 Pasha Tatashin
2024-05-30 21:56 ` Shakeel Butt
2024-05-31  0:14   ` Pasha Tatashin
2024-05-31 22:42     ` Shakeel Butt [this message]
2024-06-12 18:50       ` Shakeel Butt
2024-07-17 16:50         ` Pasha Tatashin
2024-07-18 23:19           ` Shakeel Butt
2024-07-19  2:56             ` Pasha Tatashin
2024-07-20  3:41               ` David Rientjes
2024-06-01  0:38     ` Andrew Morton
2024-06-06  0:03       ` Pasha Tatashin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=i66bzhgnbql7bvuteqttpijml3ze3nngxapv32k7paqv25c5th@wd37oaastkvz \
    --to=shakeel.butt@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=cerasuolodomenico@gmail.com \
    --cc=jpoimboe@kernel.org \
    --cc=kent.overstreet@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizhijian@fujitsu.com \
    --cc=nphamcs@gmail.com \
    --cc=pasha.tatashin@soleen.com \
    --cc=peterz@infradead.org \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox