From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF93BD1A431 for ; Sat, 12 Oct 2024 04:05:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E9A36B009A; Sat, 12 Oct 2024 00:05:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 298D06B009E; Sat, 12 Oct 2024 00:05:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 160EB6B00A0; Sat, 12 Oct 2024 00:05:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E09D56B009A for ; Sat, 12 Oct 2024 00:05:18 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 907111A1165 for ; Sat, 12 Oct 2024 04:05:09 +0000 (UTC) X-FDA: 82663610190.09.731CCB0 Received: from mail-m1973181.qiye.163.com (mail-m1973181.qiye.163.com [220.197.31.81]) by imf24.hostedemail.com (Postfix) with ESMTP id CC6E2180003 for ; Sat, 12 Oct 2024 04:05:14 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=ucloud.cn header.s=default header.b=KmJuawbz; dmarc=pass (policy=quarantine) header.from=ucloud.cn; spf=pass (imf24.hostedemail.com: domain of yuan.gao@ucloud.cn designates 220.197.31.81 as permitted sender) smtp.mailfrom=yuan.gao@ucloud.cn ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728705887; a=rsa-sha256; cv=none; b=intf6Z22dew/RxlyF3m4Z36OZW1VgMqiSPtvBZ/ttIWROxraqV5Ybp4te8pveP1B/ZyOZu Ku0bgSKMFKWZ5xpx8xmJT0lBO/hLKNojpYFDLF5bmINIyyggGhRKsP3JmGxadmHgCFSIhb YOAG4QzW9NO4DE9l+O1QrlQK801hgJw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=ucloud.cn header.s=default header.b=KmJuawbz; dmarc=pass (policy=quarantine) header.from=ucloud.cn; spf=pass (imf24.hostedemail.com: domain of yuan.gao@ucloud.cn designates 220.197.31.81 as permitted sender) smtp.mailfrom=yuan.gao@ucloud.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728705887; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G+BqwL9XXYYynAveH5DQ+xdOe+teFSG1ecILV2JYFLE=; b=VPiqY8p3uaKwNZjBAeQRZtKk29GqNU2f/UHm3bH/yuKRGzkH+ipL8wDseS2UTF9jbTy138 gx69xwyuzi0zhmERl2ZEf5WTS9L/DMLAvgG8r7fJVV3S5CdY/QE+zoDMKtnDxBZmxCMEvy 0T6zU6sLWRzbH8ZHvyK2Rs6/bf60cbQ= DKIM-Signature: a=rsa-sha256; b=KmJuawbzZFPhMIs1LwWRiKNQFDp0JBiVUBbO67d1SQX8AkpzFVaAT/2gcLN+p/o7P20nnGWGRx7M5OSGTWzMwO8QGfUK6+Nrdd53ON9ww6Fa1n/nl1Z1dVqqPXw6EThbQnYrj8S6CgCp6PM8Qxi2v67KeEdywtlLVEvI0yYmS00=; s=default; c=relaxed/relaxed; d=ucloud.cn; v=1; bh=G+BqwL9XXYYynAveH5DQ+xdOe+teFSG1ecILV2JYFLE=; h=date:mime-version:subject:message-id:from; Received: from localhost (unknown [106.75.231.159]) by smtp.qiye.163.com (Hmail) with ESMTPA id 43AAB66024F; Sat, 12 Oct 2024 12:04:27 +0800 (CST) Date: Sat, 12 Oct 2024 12:04:26 +0800 From: "yuan.gao" To: "Christoph Lameter (Ampere)" Cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] mm/slub: Avoid list corruption when removing a slab from the full list Message-ID: References: <20241011102020.58087-1-yuan.gao@ucloud.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFJQjdXWS1ZQUlXWQ8JGhUIEh9ZQVkZTkpMVk9PGUJLSUpKT0MeT1YVFAkWGhdVGRETFh oSFyQUDg9ZV1kYEgtZQVlKS01VTE5VSUhKVUpOQllXWRYaDxIVHRRZQVlPS0hVSktJT09PSFVKS0 tVSkJLS1kG X-HM-Tid: 0a927ee62e14023bkunm43aab66024f X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Oj46PQw6UTcsTj08FE4LKUga Vk9PCitVSlVKTElDTEtOQ01MTExDVTMWGhIXVQIOGhVVHBoUOw4YFxQOH1UYFUVZV1kSC1lBWUpL TVVMTlVJSEpVSk5CWVdZCAFZQUhJSUI3Bg++ X-Rspam-User: X-Stat-Signature: em6pp5qhoknxyddomnyhenyd7ufq6hsb X-Rspamd-Queue-Id: CC6E2180003 X-Rspamd-Server: rspam02 X-HE-Tag: 1728705914-169469 X-HE-Meta: U2FsdGVkX19ieWxrWrm9tbzs7IxgXuTdLxYyidXI25Pu5agvfwIkAVW78ia42pptQJztGShUf7viSkwcjsBgPYgPZXKOjnYlhZ/S4iZP/59sB4dL+o+5MDPASD1+f4Tbb7aIvAD6jt8Bp+AUXUClx7l5qjgjT53K3jpVhJu0TTfFPkbkgsXhkeE3U+0jRsfjXFEv2EIkLwpEx7EUAi5a5S26QaY4xlskTEiDYnmKI9kT0uVK6I0NDtZAI0H8sk/LKVkO3qV3p/XqAfddo0TrvUGNhNoTS2gB6wy7YxcEwudrS+o9BQL2fo5sL6hGplBB+4bjq/hYsb12Pnj35i8OkHAiy6z2TiSD0eGUiRjm1iLxO0Sd6MgsYUxcipsPWlYRpJC8eFUl2IDw0Spql5+tgKkNS14Omer9yOjZVGhysTdV2ZHRkWzX0gC/jBLhP3omEqku5wb3cxiv26UynYr8CBhDAXc09iPjW4/8/OXnuvqvnHE5na/fMqGgf7Iq7BEh4It09eZZGWZL00NgnYxP91YSFWkmPlXJKNxaRlVBxL0F4g6cmMuInLyimbcBSTDBuBf8WsfeeDZzXGbvroVs4LK21DK6l7CvNN/z0pEf7isO82HY67eQSvC5lFxS/Bzwi81HtBjvqF6F7V7BTHwgHLOM7iCOAflhDfCMsTOPxYIjxaI4nPseYNRdAaqfRtKZipcQi3yjVqnVnp5uByGIuCRwlDUX2HlQOtnm6lW+P6mtOG/KyUTQFl7T9Q+bnK9zMCJ/32SXtky3uN8PG6C7d3rPMl8jByhdiKVe2vAYpRLJA/JZqZa/CcCYXD+0Fgg5iIO4FU62ASZ4xWhW7E/wQb2C4Ph3XNXWB+VUgZchy/LwNfAjhYXrvYYxRx7jHf7Y0jn2Sj80cnzHBb354QqKTeA3LnwCzlw+HkcViyDQKf67JIoNCgjm4V4I8J64xm2CxJK92jSVCLtdHxOma5V DmsFnCY/ 5bNl5J8dyiaB6+aRXewA3RZHgL/j3EdgJ5s7/h8TNK7hBeHc6Au85iPT0ZQiu/IsIl+diCKnNInG76dblrg7nUWoqVymaneQAUxh6LYP2Zbku7j3r4LfrnL0zOD9sN4XI++B7tKFqtpViw9zVouN3E08fPA1SYCd4Qke+rq6LJJv60zD7zRsPDU+BJr4c2bzxbSRqPR0OaxxiJ74OIPiY3w7YiYeNYDPEvzj7DD+wJiBYLxYMra1s8+PTujIcfF4ikXBP+0x/iEluAGIBqwHrx0BCbML43RIyy8Zy0VE/owZztSpkaiiBktAZ+ViQpz4/EuHC88fwS92YvItNkHRxHK6i0DbFPVJigP+iocuvLDRblCQZyDapWM8VwpDaU38dmCfubHJwSILvY7Fs3zONTOgJG2vWpUPNub9sb5WV5THnGstQfxAH3e3eBulrl8pMsJjJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24/10/11 11:07AM, Christoph Lameter (Ampere) wrote: > On Fri, 11 Oct 2024, yuan.gao wrote: > > > When an object belonging to the slab got freed later, the remove_full() > > function is called. Because the slab is neither on the partial list nor > > on the full list, it eventually lead to a list corruption. > > We detect list poison.... > > > diff --git a/mm/slab.h b/mm/slab.h > > index 6c6fe6d630ce..7681e71d9a13 100644 > > --- a/mm/slab.h > > +++ b/mm/slab.h > > @@ -73,6 +73,10 @@ struct slab { > > struct { > > unsigned inuse:16; > > unsigned objects:15; > > + /* > > + * Reuse frozen bit for slab with debug enabled: > > "If slab debugging is enabled then the frozen bit can bereused to > indicate that the slab was corrupted" > > > index 5b832512044e..b9265e9f11aa 100644 > > --- a/mm/slub.c > > +++ b/mm/slub.c > > @@ -1423,6 +1423,11 @@ static int check_slab(struct kmem_cache *s, struct slab *slab) > > slab->inuse, slab->objects); > > return 0; > > } > > + if (slab->frozen) { > > + slab_err(s, slab, "Corrupted slab"); > > > "Slab folio disabled due to metadata corruption" ? > > Yes, that's what I meant. Perhaps I should change the description from "Corrupted slab" to "Metadata corrupt"? > > @@ -2744,7 +2750,10 @@ static void *alloc_single_from_partial(struct kmem_cache *s, > > slab->inuse++; > > > > if (!alloc_debug_processing(s, slab, object, orig_size)) { > > - remove_partial(n, slab); > > + if (folio_test_slab(slab_folio(slab))) { > > > Does folio_test_slab test for the frozen bit?? > For slab folios, slab->fronzen has been set to 1. For non-slab folios, we should not call remove_partial(). I'm not sure if I understand this correctly. Thanks