From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCDCBD149E7 for ; Fri, 25 Oct 2024 18:33:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6260C6B0082; Fri, 25 Oct 2024 14:33:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AF486B0088; Fri, 25 Oct 2024 14:33:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44FB76B0089; Fri, 25 Oct 2024 14:33:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 267CD6B0082 for ; Fri, 25 Oct 2024 14:33:25 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D8A05A0F1A for ; Fri, 25 Oct 2024 18:32:48 +0000 (UTC) X-FDA: 82712971278.09.75F4A75 Received: from slategray.cherry.relay.mailchannels.net (slategray.cherry.relay.mailchannels.net [23.83.223.169]) by imf27.hostedemail.com (Postfix) with ESMTP id 28E8E4000B for ; Fri, 25 Oct 2024 18:33:01 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b="Vsk/NPxE"; spf=pass (imf27.hostedemail.com: domain of dave@stgolabs.net designates 23.83.223.169 as permitted sender) smtp.mailfrom=dave@stgolabs.net; dmarc=none; arc=pass ("mailchannels.net:s=arc-2022:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729881124; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CT4I2WNs8+lv4enGsXMLmXV5yqvMUhh47eXWE7/RKS4=; b=iAKWwk5F9dTAEhUz3sV0Kb6CS1P7KiCEQsk9p2PP9szFXeQdlMsXBH0OLd6gVJDE1Sk+lS U8LKguWYND77VnB7AakAjpU+NglIwisdSLsgNULIoC3z5qcnVSuUlXY6Wo0JAuhEBSjJm7 VUYDzCwUP3M9nzUKHwbxyNj5Cmr+MHw= ARC-Authentication-Results: i=2; imf27.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b="Vsk/NPxE"; spf=pass (imf27.hostedemail.com: domain of dave@stgolabs.net designates 23.83.223.169 as permitted sender) smtp.mailfrom=dave@stgolabs.net; dmarc=none; arc=pass ("mailchannels.net:s=arc-2022:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729881124; a=rsa-sha256; cv=pass; b=k7YgZuHutxIU9ShftwCswctGFR1u6cOvsRPmy7d526bdVS9XiZqmsUS2bcW4IKLwuWgU9/ bj8BsfngsOilUZ1RtgoAck0GdCUy24+KDTtjMMa+CAuMg7yLFMZZQU5xLbzdRB6/tqzH4W iLAYROCjX0EzFxYizcVrpcGjzSIl1JM= X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 0AFF32C1B84; Fri, 25 Oct 2024 18:33:21 +0000 (UTC) Received: from pdx1-sub0-mail-a292.dreamhost.com (trex-13.trex.outbound.svc.cluster.local [100.102.223.228]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 6B0102C37D4; Fri, 25 Oct 2024 18:33:20 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1729881200; a=rsa-sha256; cv=none; b=j5P5Z6nwn7aUtQdqVV7veKxoLLw7vBdLodEdHWQdp1LHoWolNUAlXqqrctcTwvZhHFHXiw TkgquVIsGBgDuKxUuiLvGKpl2XUuhUYnWi0YTTvFzMLOHucI/V/l4rCWtJbcha+BqRz6Z2 t0/uikYaCtc/CJFjIe8gi+8a6q5oJRpHVWbiWXnfQH+5njbFy9ajA0mPbgveqpc9+mJ5EY v5Y3mxrChNoiplMMLt6uher97meKD+p5/ikXlchwz+yNezS/ciJT3UlmHr4neCMidepgNd KY7dJotH7L+XHldYRchMPS9Snlq1WLwIc4iECQjS8zQV4lh+FKHFgZQccDF61g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1729881200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CT4I2WNs8+lv4enGsXMLmXV5yqvMUhh47eXWE7/RKS4=; b=6DCSBlT2DFrC8tksm9jKSdTODKtWHI374gECEVPYRRl+2wAQvL+SxplT4unaTdgZ1TXOBk 7R55ocCqK//NFlFWJECZAirZt3peZo0pB0gb2dB2TeubXw2oipuy+WFPZ9roOx6Qa1WyGm ygvd7VsZlRaQwWh11lRjm5IksaEPjGMYbXqyR2nPRIoJHcr2OKkOdNLXX+N7NfA0Q/VK99 qOQ/8AdUNKKG2Mw7AGxkXygIJJ3yOfoBhfGSS2fM8y4hwVhcmQkX978x02DIO9raR4cUW/ 8TY4zmTo7D+4LFUvqWX6KyB56Db81DUptNqKKfS+pB2wVqYa8S7aWDHIl5jM1Q== ARC-Authentication-Results: i=1; rspamd-cdbbc7585-hgvf8; auth=pass smtp.auth=dreamhost smtp.mailfrom=dave@stgolabs.net X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|dave@stgolabs.net X-MailChannels-Auth-Id: dreamhost X-Industry-Reign: 7245a16350dd8199_1729881200793_2943900534 X-MC-Loop-Signature: 1729881200793:2559233038 X-MC-Ingress-Time: 1729881200792 Received: from pdx1-sub0-mail-a292.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.102.223.228 (trex/7.0.2); Fri, 25 Oct 2024 18:33:20 +0000 Received: from offworld (ip72-199-50-187.sd.sd.cox.net [72.199.50.187]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dave@stgolabs.net) by pdx1-sub0-mail-a292.dreamhost.com (Postfix) with ESMTPSA id 4XZry72Y0xz9p; Fri, 25 Oct 2024 11:33:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stgolabs.net; s=dreamhost; t=1729881200; bh=CT4I2WNs8+lv4enGsXMLmXV5yqvMUhh47eXWE7/RKS4=; h=Date:From:To:Cc:Subject:Content-Type; b=Vsk/NPxEuhRtgVp5TlB3DwcWvnMqm9mythIDgEulakohCN5GOnlLxeEj2sBHVMjBf yG9Bu7FazgHrrluyfbxugoCb9rr3UvgdX4LlVPfGjXWTWHmNm6RefJ9mqv8bpA8tDc PqLrL7jRRiGN7Uqqujeyoq50jPKnOnq8TQLgodb1+fMrIEyojUzChIc9q4Eh2qC60Y Fh4a7snuTbazI0oXvixGNjBhKecifSz4wqaixS6K2FueL3Ycx6SZh4ISUbip8YsMzC vrJBA2HPdby+MLKD0onAqWL/uJRi9eMAIG/mT089ImWGi2y/gXVBdSjtOYwdjToBX8 RWmnThY43TYow== Date: Fri, 25 Oct 2024 11:30:26 -0700 From: Davidlohr Bueso To: Peter Zijlstra Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, mingo@redhat.com, dvhart@infradead.org, andrealmeid@igalia.com, Andrew Morton , urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, Arnd Bergmann , linux-api@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, malteskarupke@web.de, cl@linux.com, llong@redhat.com Subject: Re: [PATCH 2/6] futex: Implement FUTEX2_NUMA Message-ID: Mail-Followup-To: Peter Zijlstra , tglx@linutronix.de, linux-kernel@vger.kernel.org, mingo@redhat.com, dvhart@infradead.org, andrealmeid@igalia.com, Andrew Morton , urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, Arnd Bergmann , linux-api@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, malteskarupke@web.de, cl@linux.com, llong@redhat.com References: <20241025090347.244183920@infradead.org> <20241025093944.485691531@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20241025093944.485691531@infradead.org> User-Agent: NeoMutt/20240425 X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 28E8E4000B X-Stat-Signature: hpku9e4jnfymbm7tyk7o6ozqh8nghoo3 X-HE-Tag: 1729881181-399894 X-HE-Meta: U2FsdGVkX1+PbgXV57n0dgBdgoWc+TodwZsWGrAH3VeUdhzkp/n+2lffLmdKf8/iv/cC8xtjY/Z38TMMypmTKSEekvNnwKmjSrTlPh8owEh50kxh61mXuxSckPm3yAvnubQtfLI3UHhIvxiLMoBjREFe7YbQJ5YFWwXJBZJSAnZU03uLqTXgzqCHrrilUdKzpJIzdzoLgPM3KnX8pMPmlQh32gPQ2H6URCL9FM5wFj5shK6Iy+X2oxSBPSLe5rNieZ5NkGJWnBSvLXxta4TOPXsHROHf08EpopW1CpwAI1dRDZi1Ml0oAB8bD2MfgfgeB9n5TbhZkKCghU/5s77b0RPr8Wgulad/D3Tit/0eVg4ll4XLxAVij0iwENWz+IOVgp4JVwqVrTHCgIaDGuvZ7l24ZcZSMYfsEOzTH0pNm6K8oGppyYadUUxmoetHPK1AX2ypeLLBzm2+pO+b++VokSpSCUPHleeF3Q0BgCHBfPXrolwHFbasXF/r8BDQTDtHPkU3maBo/KayGjY9JtrQWFbeiPVDWIVDw3iRnCLfYWgaWywthgecILFUN0NBVL5JC8ol4nIsjCVj/iQ76T5FrOm0kP4aqyUHy882pun9qlDkR5gLN3WXJp4XBUPmK4yoC0fi8YVwX3Iz1/TEbRkftvDlFiOZC8QUgvrHO3sAUNuxqjoTSbuDZu4MlAcAN+YP0nPujER5S7qHGmW5L0bXOKCMae7/9RjcHAHUoF1F9eJ+RIcg4OvlhxDvD6QNzmYxZA1172iBUXdC/WUtw8e7tII3YAuDMaYl5Ly8QiDxCEpvao5rlKI7fcqppTBKnXBNc5PYOEjj5BFAHM2WCUmXtdVRVd1p5H65QIGKAk84JTstN/0IGRa6eB+OVcpqc1YMkhX6H8/Mmk4ElXqIR4NyrVYyacScltuY8QGK11RF9jB2E3SFR3s2ORPVzfX/3klsXN0ffDahj7mZJqBzJrl 2129INBj eDbqWZ2dq2udNxjqLv2HWwaMnfmWpo0oe4uD1YYMFBrVoV4D0+MSpVYHkRvFG3+0kjmKYARi521EVxVMiDtyKQGh7cx4o7FnuVhPAenA5EHwY8T3WygTQUyn1LzqlXuePXhm/+FneIhZPjDLupb1BxmNAjDrgGxf/I9pf46/jXEJDQQmxpl4H3rB0Y1Zd1w4w8kI2qsMRXY827d9WjnzktQAtcaMGseJJc7RZfco5tnXHsHtPOg2HJ0BXITXBVewuCe/JuwJS2xLAsSxvdTFRZAz2WR6GJnq4R7Y1a8Sz9VhAnhOmyGJisFBsHOYkRfwSTr9T6cRkH6f+Zo7ekL4WUAlpBg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 25 Oct 2024, Peter Zijlstra wrote:\n > static int __init futex_init(void) > { >- unsigned int futex_shift; >- unsigned long i; >+ unsigned int order, n; >+ unsigned long size, i; > > #ifdef CONFIG_BASE_SMALL > futex_hashsize = 16; > #else >- futex_hashsize = roundup_pow_of_two(256 * num_possible_cpus()); >+ futex_hashsize = 256 * num_possible_cpus(); >+ futex_hashsize /= num_possible_nodes(); >+ futex_hashsize = roundup_pow_of_two(futex_hashsize); > #endif >+ futex_hashshift = ilog2(futex_hashsize); >+ size = sizeof(struct futex_hash_bucket) * futex_hashsize; >+ order = get_order(size); >+ >+ for_each_node(n) { Probably want to skip nodes that don't have CPUs, those will never have the remote for .node value.