From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D62F4C369C2 for ; Fri, 25 Apr 2025 09:13:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC67A6B0010; Fri, 25 Apr 2025 05:13:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C9A8C6B0011; Fri, 25 Apr 2025 05:13:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3A7B6B0012; Fri, 25 Apr 2025 05:13:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 970266B0010 for ; Fri, 25 Apr 2025 05:13:41 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9E4AE1CA0B2 for ; Fri, 25 Apr 2025 09:13:41 +0000 (UTC) X-FDA: 83372003442.26.9E676C2 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf25.hostedemail.com (Postfix) with ESMTP id 5C61BA000F for ; Fri, 25 Apr 2025 09:13:39 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=uQKULTGS; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=zQOWKp0D; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=uQKULTGS; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=zQOWKp0D; spf=pass (imf25.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=pfalcato@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745572419; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mXUDXhw17net05lqqHisrXbeaS6mPgXHDC3B6OTn9Tw=; b=TGdYj59RliaQkoe6TEWA2Q6ps8UNGFAdsf8UFvhiTgCT+9Du/TgEAqsi6ySJJmOINNREpr 1Xi4dO2subbAm+ePsz+bglzBhpB7LqYku7LAoJJZGjVmuv7vDex9spvYQw3YSf1q+iEV8R cvP2PTbOSSiw6HMTyXVCLapTYpMTmP0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=uQKULTGS; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=zQOWKp0D; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=uQKULTGS; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=zQOWKp0D; spf=pass (imf25.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=pfalcato@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745572419; a=rsa-sha256; cv=none; b=3xJCIa5bEkBpFf5T7GzroIA+7FTTVXPEHmlV7TkB0ZqYDvW+nPlqSt+K+eB8TbLoOADhYP bQBPgnf6T5JIlkKzO1iKLkrs3el9qGDEn1XPaJf7f2A5vDVmIkZxqGVUsOVKpT7PdbbPlA V3H71H8uriu8rzwPHzucVkKwmXQcXS0= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C0980210F4; Fri, 25 Apr 2025 09:13:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745572417; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mXUDXhw17net05lqqHisrXbeaS6mPgXHDC3B6OTn9Tw=; b=uQKULTGSfxBxxB8sSbNAYciYun+rFVkSX6rXzJ8igjByBX01eMidEmRR40uhfsFv1F8GPE 77pTqS0iKjs1QE3zw+8ZIB7tslPw+G3PRyqcUR7UaMvBTHhyPI0+wou9XaU/uFA0CInn27 4MJoMv5bDypIB50eyf1GSYN7ZN2Ov2Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745572417; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mXUDXhw17net05lqqHisrXbeaS6mPgXHDC3B6OTn9Tw=; b=zQOWKp0DzcJkhbXLeDO/rAe5OOcrVMOP+bV0DVJohyogkox4dVZTSi6MeVCRUv2M0Km7V1 qrT0yum3abR2IJAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745572417; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mXUDXhw17net05lqqHisrXbeaS6mPgXHDC3B6OTn9Tw=; b=uQKULTGSfxBxxB8sSbNAYciYun+rFVkSX6rXzJ8igjByBX01eMidEmRR40uhfsFv1F8GPE 77pTqS0iKjs1QE3zw+8ZIB7tslPw+G3PRyqcUR7UaMvBTHhyPI0+wou9XaU/uFA0CInn27 4MJoMv5bDypIB50eyf1GSYN7ZN2Ov2Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745572417; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mXUDXhw17net05lqqHisrXbeaS6mPgXHDC3B6OTn9Tw=; b=zQOWKp0DzcJkhbXLeDO/rAe5OOcrVMOP+bV0DVJohyogkox4dVZTSi6MeVCRUv2M0Km7V1 qrT0yum3abR2IJAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B43BC13A79; Fri, 25 Apr 2025 09:13:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id cc20KEBSC2jrDAAAD6G6ig (envelope-from ); Fri, 25 Apr 2025 09:13:36 +0000 Date: Fri, 25 Apr 2025 10:13:35 +0100 From: Pedro Falcato To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , David Hildenbrand , Kees Cook , Alexander Viro , Christian Brauner , Jan Kara , Suren Baghdasaryan , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] mm: move dup_mmap() to mm Message-ID: References: <4ee8edd6e54445b8af6077e6961543df6a639418.1745528282.git.lorenzo.stoakes@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4ee8edd6e54445b8af6077e6961543df6a639418.1745528282.git.lorenzo.stoakes@oracle.com> X-Stat-Signature: y15qrapxw6k9uopgehfyfyt8fbi1j4pj X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 5C61BA000F X-Rspam-User: X-HE-Tag: 1745572419-928572 X-HE-Meta: U2FsdGVkX1+/RyjxZBZY3KeTWPDIZAAbl1h3GnYLkkGKWyqHIcAl6z47ScaySU+tDoYuA3jQnV2OJ3hcWdmczadsVQh92u9/e6he/xVOxYfXMGklnLTJWWNqmPZk3O7/jxnBljvteQ24tyyPl7uYlG2YSYRcdm/+O3hWEutam0lfWh+MSCwpDn3AFxuhH5fjzG2xCw5GQi/W5TXRUvo/3NVT2hB7WsNOse4sHeXCxqU33o6Fx4/pNM9YXkU/fdCyU7fe7zzSh7CE1U1FX8+9lMTsMtakQDXlLQYR4lRpZOej0+/LhxzIPsHqrPBdhuOBzCHddZQHandvSHIaMfBmtE312nHgfO/yj4bx4RCaa69Vxp/9pwEBuLhqEdcz4IN7+Nd32tJA6UEp0BELAPeRbVcWyXvnAWrYDHqQ8Iy/LFGgM16POfhaNTNACrEjukxt0fbOazjvequtrxHvZJicNUAqCwWoe+kg393REE47uRBC0RNvOiz+fVlz7LpFbNc80rzEK/HeKbiFBsusQzcRKAHQbafbNg6w+Yhys4YiHQftpveCcSkESG8KmkEn+KLl7b/wdTnFjPYyUHir7u2+vl64j+di+A+3zv7A6s/DIFkOKGzphVGTqyEnMhAmle/BHnsqB0jOrWTSiGJGFrShVM1DWPPBgml2K4Ibeah7MGIhC0VYu/jpyY9804gMUyTWf2VrUO5Si0ebQ0Si+hjuOFmLNlX8jZEcWhxmQlPRSagtbTVNozz19wL0u08zu71LRnP9R+D4Rhie679crm+vUZb67WaDKGFk+IjzdoHO3VDhYNeX9nEZyRJ6LwUFr78Zc5eDSuYXTiwxu9tAzksR+i9RCmsZyVTuQlomcg7SZrMYyQlV65tWZhVwB+rTqVNbcQsm2yH2jczArGLfGGojWXFnFfc1G2CvusCSEuZftlWs06bJc01+cbNd45hWiHrYsV6rTa7X3fJ6uv9uuj8 A84vNj2e YZWH91K9mZH9cX6jsIoWDXGkcDDKIveCP2Qj998gBunH0o6G4mANLc0izA/jFPVhFML9jnhf8GabZRfy34+s0U84CCxIv+6nwUlWBeLOJUZTGyPqVLXg0Ba4pKgz/zpwALcjYjx7/NwA1fHFPZnTnwydU2m6B4YCqWJZPxP7XEHIH8/CreOgoQqYyDdUE2t76Y8YV1intnYCBIaxV4S4bdMdyXpTayMpF/y8SSHW2QnFeZ0JbeFXd6G6w/1ucHKCaNvALEo0xxcBPbpPbNjOmy6CNrnnD2i8cb+Hb6VDv5T0ocYlL7WwXJwK6D/2HAkFbISApFCEfyKv8kg/zPW892YSzVQPryZHLrZ/71NaQTSxT1Gn+fUu25hTOsA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 24, 2025 at 10:15:28PM +0100, Lorenzo Stoakes wrote: > This is a key step in our being able to abstract and isolate VMA allocation > and destruction logic. > > This function is the last one where vm_area_free() and vm_area_dup() are > directly referenced outside of mmap, so having this in mm allows us to > isolate these. > > We do the same for the nommu version which is substantially simpler. > > We place the declaration for dup_mmap() in mm/internal.h and have > kernel/fork.c import this in order to prevent improper use of this > functionality elsewhere in the kernel. > > While we're here, we remove the useless #ifdef CONFIG_MMU check around > mmap_read_lock_maybe_expand() in mmap.c, mmap.c is compiled only if > CONFIG_MMU is set. > > Suggested-by: Pedro Falcato > Signed-off-by: Lorenzo Stoakes Reviewed-by: Pedro Falcato Have I told you how awesome you are? Thank you so much for the series! -- Pedro