From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED479E66887 for ; Sat, 23 Nov 2024 21:35:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 42B0D6B0082; Sat, 23 Nov 2024 16:35:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3DB0A6B0083; Sat, 23 Nov 2024 16:35:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A2936B0085; Sat, 23 Nov 2024 16:35:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0C3DB6B0082 for ; Sat, 23 Nov 2024 16:35:34 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AA053140591 for ; Sat, 23 Nov 2024 21:35:33 +0000 (UTC) X-FDA: 82818666504.26.CD1A7E2 Received: from out-185.mta1.migadu.com (out-185.mta1.migadu.com [95.215.58.185]) by imf04.hostedemail.com (Postfix) with ESMTP id 2669D40008 for ; Sat, 23 Nov 2024 21:35:29 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=EDJg8xsV; spf=pass (imf04.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.185 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732397731; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zKxGTUmS4dcKGQY0jjq321pdX2jaD19pGhWKPewS3bE=; b=shdlr+3H25B+4uEEv13+zZ90K14V4I76ro9oGYRt3F/7QLFJ7rQlggqbxAgMumsyLhbrBM ayLL7PoenWYw5WU0u96wwthC/YdeTaZZdyYaIqfrLvOfyFqnOnS1NulB7Rtph4MB0BK62v 5Iv9pInALBsoTYljEtrXdJdZq5KXTWY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732397731; a=rsa-sha256; cv=none; b=JepcAn2dxwk0Sr9ZKuqAKp6Z7VyawfsiyFUe4AQV6iqmHZgZWlXTC+j+So5SdSIyO/i+76 rcU8VG4rg7t23skPw+SWGsz+mKSZi99GHWl4RtqG+GI/hibkHDBrL/buMOFOTn88ih0cny rKxMTtye/xo2FhrBn5FRMzILMxq/4QA= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=EDJg8xsV; spf=pass (imf04.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.185 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Sat, 23 Nov 2024 13:35:24 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1732397729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zKxGTUmS4dcKGQY0jjq321pdX2jaD19pGhWKPewS3bE=; b=EDJg8xsVJwYmr/wh/pu9cmlYQKYBUvtoJ+fitNPChNy4h0aMfZKTY+yQ4/nVDbBXOIDzDo G6gYk7Wvx+2PMYBhw9DtwJZCfoyeenad0lOg7pOg7zxyuisVFs9L5v8lCaThj1kj1A9QZm IAAz0wm/rUhTZU94ONkm9efwQLH8pzI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Matthew Wilcox Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Vlastimil Babka , Axel Rasmussen , Steven Rostedt , Suren Baghdasaryan , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [PATCH] mm: mmap_lock: optimize mmap_lock tracepoints Message-ID: References: <20241123060939.169978-1-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam10 X-Stat-Signature: ua6jhwd3tfpj5ewm48qyy6zjeaptrua3 X-Rspamd-Queue-Id: 2669D40008 X-Rspam-User: X-HE-Tag: 1732397729-783261 X-HE-Meta: U2FsdGVkX1/gm1m1iRbk4U7wU+WFhSE6v86Chpe3Vc5eHf/Tx3bFSeH3RkA3TcY3+yOM5kfYrMVxzTsRDnKsR1zTo4a+dLrzkQmtZNULEqBwfT3IPye4kLsLwRE/bo4gHj2IQWVbP8pNS07+pa7lsTFF4eb2D/TSEcgDOne6lTs10An7p/cDXtO9STFJXJwb07P4PQzL0yZ2hqaNsgZFW1xrYcq+wwpk9lNxcN8fNtXg+ZNyKoW8F4+NuLqmVFUMHupkqgnpVRF+nYPN0CE5dUP7N98WiGw5YKdBcEYpMs3FQ885LSb8d85xJyJf1aS0T+GLxvAYMMnsvpVFHiaMw1YnLXXkJ13Pz5EHyttNjyPQ+OH9IVP61eDzWoSexHWX7tqx5PJNFa1W0siU1tnnV1nG35U9LGTXAjMSTbc0pohV7Y8ChQZiH2bDNuuRo949iircGxpwOXSb2zFkW0SUBhD4GUiL/Ve6lIroKO0ZxxvEybsiAMeMra5qplmNgCqp1z7qje3nuKdKoiv37nW1ApfY2ldmgRX9x1KuHkGR8gcYMrqcH8GSLSQJjDgITRMYj4CSOwxLCWuAGBgnsH4PoKWNEGcQss0ILNcqPVQjmxr5vC0ZMCRO34WjWIfbyu1yodB5VUzuUnKpguAYofG56exYxPrssj47b/2H2cw1JT41jBCivHlF1uoC2hOyv5+uMBBElRL/nmXx6cjiQetpQXcSeEH8XHLwT6890dtOrr0GeuBpgNP6toueX32ZXDyqboIh35efiqt0nHI3a90p4G/6ndqnx39cefIHJRLkg8vV/OlEUrAKHObKmca0ktKcgwb3tG1R44uw+JMoFZnwo13hYXzrZ8FfbQ+IrKnxKgo9FMy3i9TbCVWBNZwp/5smzJ2y0Y4vFibQiS0eW8hPFFXVkKQHrTYyW5kzUUMlcQZ2d+UGkAPdp7djLMaMe0QllR7ttZflu7QvOg+pOQS hqNmTNm2 8X7P5ZGfx2x83XSn+aSHYPHzmje0smIUwZxfvqU7+QDsqb1BwyCaK70HPzmy0Ah1vQYnjGcmZ4OGhOkfThTUWyYH8/kRB9q0zClRUMZL0L8HiWBN3c9vnHYfF+DO5EwdaBOGPbFBNOHVCKplmInGCjQrSqC3wli2yLSuEsjf3hcliDOB+EXAfWAhuO33JRV2CGdpBByJ7upt4SHZl7XhoE9v99kImk4Pb4gNe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Nov 23, 2024 at 05:01:57PM +0000, Matthew Wilcox wrote: > On Fri, Nov 22, 2024 at 10:09:39PM -0800, Shakeel Butt wrote: > > TP_printk( > > - "mm=%p memcg_path=%s write=%s", > > - __entry->mm, > > - __get_str(memcg_path), > > + "mm=%p memcg_id=%llu write=%s", > > + __entry->mm, __entry->memcg_id, > > __entry->write ? "true" : "false" > > Is it actually useful to print out the (hashed) pointer of the mm? > Wouldn't the PID be more useful so you could actually associate it with > a task? > For our usecase i.e. bpftrace, we don't really care about these prints as we can directly access the arguments like mm in bpftrace. I wonder if others are using this hased pointer in some other way. I don't mind chaning it but I think that would be a separate patch.