From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A762AE77188 for ; Fri, 20 Dec 2024 15:12:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22AFA6B007B; Fri, 20 Dec 2024 10:12:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DA9F6B0082; Fri, 20 Dec 2024 10:12:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A2D46B0083; Fri, 20 Dec 2024 10:12:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DF50F6B007B for ; Fri, 20 Dec 2024 10:12:03 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 89311140AC7 for ; Fri, 20 Dec 2024 15:12:03 +0000 (UTC) X-FDA: 82915676970.05.04B559F Received: from fout-b1-smtp.messagingengine.com (fout-b1-smtp.messagingengine.com [202.12.124.144]) by imf15.hostedemail.com (Postfix) with ESMTP id 728BDA001F for ; Fri, 20 Dec 2024 15:11:08 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm3 header.b="H 3mh90P"; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=wJMDdXRq; dmarc=none; spf=pass (imf15.hostedemail.com: domain of kirill@shutemov.name designates 202.12.124.144 as permitted sender) smtp.mailfrom=kirill@shutemov.name ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734707505; a=rsa-sha256; cv=none; b=kUfLoyAMGfriX+DHC3VpQQb1GXslDtbAbda2GvTRQOGpWUVr+CCeCavw3c6ZY4yJ0krel3 BGfn3QafDl/7iiGsMl7Jbhnz7HvHNdq9v1LBn33ep5xKtjgoavw35YbUobCOf1eCbcTAqA is+2Aq6BjKkcUU6KM1c/c432lqh20oI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm3 header.b="H 3mh90P"; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=wJMDdXRq; dmarc=none; spf=pass (imf15.hostedemail.com: domain of kirill@shutemov.name designates 202.12.124.144 as permitted sender) smtp.mailfrom=kirill@shutemov.name ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734707505; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TPofL9HELSU37A75YREq16eJdd6AiIkVeEKwGxzWFQs=; b=KQsU3gT/lO3yy1DNDLfxTRydHnEyyKkTXktVnhvBpZMQZpRGZb6uo2EzcNeJ4SrLRpUol9 chLf3h82bnVOOr2FZDnjXz0mVHw57v4qJ39sKZY3J0ZDR6hmo/T4KFtGXqP9b2GQWmyOot hsfH4DJoSXPJx8cxgaqaUETMBlYkuq0= Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfout.stl.internal (Postfix) with ESMTP id 7A0EA11400BD; Fri, 20 Dec 2024 10:12:00 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Fri, 20 Dec 2024 10:12:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1734707520; x= 1734793920; bh=TPofL9HELSU37A75YREq16eJdd6AiIkVeEKwGxzWFQs=; b=H 3mh90PZQeZegF2Dy6wcIMrtCSsvZPyIIuQ4lk67k5pjVImodl9E1mJhnjRKZZe6c IEkqYUVGsVsfUpWVBl1LXiLV/TcQpNDmMZNcRgdHb37poaU8nl+uhVAyNrAE2rg8 scCskE+86yJjcgw12NEoE1wMv7PlE7LkpjBzKboucJGcHY21JJZ4kAG4Uo5Pca2G bn+1HU9uger3VRZZekJOgMALmgsQwJXhmhIl/8ypLO2ExAViGWVrg/dBas/7+R+J EHj3RXd0EUrtPNKNA/ZRzlIQeE7HlubLw4pUNw0/61eprT1JbKWV2nl3NKOMUyqt AJZYe371ICIFp55Ejbfgg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1734707520; x=1734793920; bh=TPofL9HELSU37A75YREq16eJdd6AiIkVeEK wGxzWFQs=; b=wJMDdXRqN6QJyw3L/TWM+hBR+tX11eEaiO5YPfawMIsqkk9UD0k FU7HUgirHDfgPwZr1dqay8aClvvcgbTL7kS1RSjnRES6LZPHEToI02i2HMrs+uUU 1frqqmVhvsw35pSXT6+5RMaPMvSCwrQuXi61dtjkyHamF9c/B9Ltk64E2vME2yYT JNMIujwbEzf/rGqGRK8acXSTcZw99QPBugPYWOB9EK4OBwCfTGEmbKinM1KTERDm 1jAeMQhapQkfz2BMQfo+AOOehsBVV9WN/VVi8jnnXllCCHjdq46SbYz0PPi7zPv1 PrKUk53ke8MtcO3e/hHvK9J4pthUgDo6W/w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddruddtvddgjedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggujgesthdtsfdttddtvden ucfhrhhomhepfdfmihhrihhllhcutedrucfuhhhuthgvmhhovhdfuceokhhirhhilhhlse hshhhuthgvmhhovhdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeffvdevueetudfhhfff veelhfetfeevveekleevjeduudevvdduvdelteduvefhkeenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehkihhrihhllhesshhhuhhtvghmohhv rdhnrghmvgdpnhgspghrtghpthhtohepuddtpdhmohguvgepshhmthhpohhuthdprhgtph htthhopeifihhllhihsehinhhfrhgruggvrggurdhorhhgpdhrtghpthhtoheprgigsgho vgeskhgvrhhnvghlrdgukhdprhgtphhtthhopehlihhnuhigqdhmmheskhhvrggtkhdroh hrghdprhgtphhtthhopehlihhnuhigqdhfshguvghvvghlsehvghgvrhdrkhgvrhhnvghl rdhorhhgpdhrtghpthhtohephhgrnhhnvghssegtmhhpgigthhhgrdhorhhgpdhrtghpth htoheptghlmhesmhgvthgrrdgtohhmpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghl sehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtohepsghfohhsthgvrhesrhgvug hhrghtrdgtohhmpdhrtghpthhtohepuggrvhhiugesrhgvughhrghtrdgtohhm X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 20 Dec 2024 10:11:56 -0500 (EST) Date: Fri, 20 Dec 2024 17:11:52 +0200 From: "Kirill A. Shutemov" To: Matthew Wilcox Cc: Jens Axboe , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org, bfoster@redhat.com, David Hildenbrand , Vlastimil Babka Subject: Re: [PATCH 04/11] mm: add PG_dropbehind folio flag Message-ID: References: <20241213155557.105419-1-axboe@kernel.dk> <20241213155557.105419-5-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 728BDA001F X-Stat-Signature: naypk8pk18juf7yj6y4aatnranaogp6h X-HE-Tag: 1734707468-157033 X-HE-Meta: U2FsdGVkX18X7Xp4e+Fn6AtDYSDsSxPDda9GoINifUoO+WnsGxlohUfOUqF3k8k/FKbuKDKHq9zKyCmW6fbqaoyrlxyTEVvrTpp9WSwX08wS4p/lILD7GbtVJl7jOXa1QO7VAkDsCSvAB65/ioL8ZzguZxw2p0/eYRxr5HWuqdEi5Ye8lCEnWkaFpuWteJiyifR9znA1Qhwlw7fyE+BBuOK+JUVG0gSiCw4LW5cDXP0Ya2/WRpe7G5xhQswf0+xj+Nr+JrzvRPyOpFayDCwL7MR0e0nTF+NQroN/KTsd3EoPcLkGIupdz60b7EIKqEvvP6kY2TGYYQkL6uq03i5wv+I9pjOZrpZbmpSDThmrDKFT0PupybAuSTC5Drlmd1/8ng1wjjna+N/tXBJIXRi/fgPvVUrMHsuWPUNKBMxaPpVWx1VWTY5vswD7uWOgijV1fGqvcc64XONh8uuAL4E/DUr3B5rUUq4IvkMYeW5q4D7H1cICBvNLoQJgSHTrBF7iUkviqpQZ0ryK7k1wZm2B+Icc9muZSWoRaXBMGXbKHYfpb6Em9NY1hlwRO11vLSSlyyUwtPo9BUtQp8yRLDCERgszQFth5MoRvLMf75wdrpEpFLuuXJBdvSPpV5JmfZDoAQStjfkmL/pQEQsRimudYRrjCJPWIwAyBo7CuzLGbDPGTdLwNtRDXbLQMgGBnGMejsxigr8tkQtgTHLwomVOSHXcfe5NBTAvefbDGbQ3OlNuIbDhhd/XlVLcAMWlau2n+yJhiIBYiBUcmnMWZ3DpIS28twd66Ol18CnjgdG9WNu6pniiT5p4IuKuO2TEdFsiHFSMblsSMP4qRfnfJRSoiWUc5U+FwUmYwIOzxirvnhQIhDUuNL8kRC5AEUMb9R5Wy2nzk6N6/t1Ow4qNKJS6ZQQ1G/gY/n0j1mqfgnoBlTCo4V20r5cmzMvGNuAvnCr+b4tkT35BTumFDC7px4L 6dlrKt2L GFRmRfPZQ4snE1yPyhH5pzSPGsGUbQuGwf4nks+6TESSFRy7R0LVCNBIePI1brns3IFqmYBALzMYB3+f7u6XbH95980lpvaCvSjnsqwzl+ZcfAgPeUWCpaKUi/Q2a+ZV6OkZCF4BrUql/gu1uVz1BAwOE084Uncg4U8psFcq0tVizAH7OvDfu2b+n9/IdR6oalhFFUfrfOofRwHFRIcpYF8OPfpxtiXGz572qhNK09AqGXCCWA+JRif+uVmdnFXpS92Rn1axKCoy2tZPduFPfGcLlAJak3nhZMZUP2PVnORqf+Xgfa0mLrmmH0dCtfOwkTZczjk9/n/8wAzRmeu/tcgrIngZMjX/kgmOKJgWr2ymNhmwk8GAUnXQ1qhyCpSlQ1PoVdOz3/6m9FlvLZY8d6QiV6VGcq8JveEUIk0UK0NaF5cJ3OMyAkrBHNeGYN9GQqwnPsTJVbfpls1yfSTkrGogyTwdPel9qYvWj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 20, 2024 at 02:38:09PM +0000, Matthew Wilcox wrote: > On Fri, Dec 20, 2024 at 01:08:39PM +0200, Kirill A. Shutemov wrote: > > On Fri, Dec 13, 2024 at 08:55:18AM -0700, Jens Axboe wrote: > > > Add a folio flag that file IO can use to indicate that the cached IO > > > being done should be dropped from the page cache upon completion. > > > > > > Signed-off-by: Jens Axboe > > > > Reviewed-by: Kirill A. Shutemov > > > > + David, Vlastimil. > > > > I think we should consider converting existing folio_set_reclaim() / > > SetPageReclaim() users to the new flag. From a quick scan, all of them > > would benefit from dropping the page after writeback is complete instead > > of leaving the folio on the LRU. > > Ooh, that would be nice. Removes the overloading of PG_reclaim with > PG_readahead, right? Yep. -- Kiryl Shutsemau / Kirill A. Shutemov