linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Shivank Garg <shivankg@amd.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	David Hildenbrand <david@kernel.org>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	Zi Yan <ziy@nvidia.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Nico Pache <npache@redhat.com>,
	Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
	Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mm/khugepaged: remove unnecessary goto 'skip' label
Date: Thu, 18 Dec 2025 11:41:15 -0500	[thread overview]
Message-ID: <hxn3cvnfglp5mtsc5ray3drhxccr3up25xsn7lzuigqjmhmyc2@oi2td6qjo2cl> (raw)
In-Reply-To: <20251216111139.95438-4-shivankg@amd.com>

* Shivank Garg <shivankg@amd.com> [251216 06:12]:
> Replace 'goto skip' with actual logic for better code readability.
> 
> No functional change.
> 
> Signed-off-by: Shivank Garg <shivankg@amd.com>

Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>

> ---
>  mm/khugepaged.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/khugepaged.c b/mm/khugepaged.c
> index 6c8c35d3e0c9..107146f012b1 100644
> --- a/mm/khugepaged.c
> +++ b/mm/khugepaged.c
> @@ -2442,14 +2442,15 @@ static unsigned int khugepaged_scan_mm_slot(unsigned int pages, int *result,
>  			break;
>  		}
>  		if (!thp_vma_allowable_order(vma, vma->vm_flags, TVA_KHUGEPAGED, PMD_ORDER)) {
> -skip:
>  			progress++;
>  			continue;
>  		}
>  		hstart = round_up(vma->vm_start, HPAGE_PMD_SIZE);
>  		hend = round_down(vma->vm_end, HPAGE_PMD_SIZE);
> -		if (khugepaged_scan.address > hend)
> -			goto skip;
> +		if (khugepaged_scan.address > hend) {
> +			progress++;
> +			continue;
> +		}
>  		if (khugepaged_scan.address < hstart)
>  			khugepaged_scan.address = hstart;
>  		VM_BUG_ON(khugepaged_scan.address & ~HPAGE_PMD_MASK);
> -- 
> 2.43.0
> 


  parent reply	other threads:[~2025-12-18 16:41 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-16 11:11 [PATCH 0/3] mm/khugepaged: minor cleanups Shivank Garg
2025-12-16 11:11 ` [PATCH 1/3] mm/khugepaged: remove unnecessary goto 'skip' label Shivank Garg
2025-12-16 15:27   ` Zi Yan
2025-12-19 12:20     ` Garg, Shivank
2025-12-19 16:00       ` Konstantin Ryabitsev
2025-12-19 16:07         ` Zi Yan
2025-12-17  2:48   ` Wei Yang
2025-12-19  9:24     ` Garg, Shivank
2025-12-20  0:38       ` Wei Yang
2025-12-20 18:32         ` Garg, Shivank
2025-12-21  1:16           ` Wei Yang
2025-12-18  9:14   ` David Hildenbrand (Red Hat)
2025-12-18 16:41   ` Liam R. Howlett [this message]
2025-12-16 11:11 ` [PATCH 2/3] mm/khugepaged: use enum scan_result for result variables Shivank Garg
2025-12-16 15:38   ` Zi Yan
2025-12-16 16:20     ` Garg, Shivank
2025-12-18  5:40     ` Garg, Shivank
2025-12-18  9:17       ` David Hildenbrand (Red Hat)
2025-12-18 15:54         ` Zi Yan
2025-12-19  9:45           ` Garg, Shivank
2025-12-16 11:11 ` [PATCH 3/3] mm/khugepaged: make khugepaged_collapse_control static Shivank Garg
2025-12-16 15:39   ` Zi Yan
2025-12-17  2:48   ` Wei Yang
2025-12-18  9:18   ` David Hildenbrand (Red Hat)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=hxn3cvnfglp5mtsc5ray3drhxccr3up25xsn7lzuigqjmhmyc2@oi2td6qjo2cl \
    --to=liam.howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=lance.yang@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=npache@redhat.com \
    --cc=ryan.roberts@arm.com \
    --cc=shivankg@amd.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox