linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Vlastimil Babka <vbabka@suse.cz>, Jann Horn <jannh@google.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: correct typo in MMAP_STATE() macro
Date: Mon, 18 Nov 2024 15:02:38 -0500	[thread overview]
Message-ID: <hxinljr62axgkndypsof3yvqp2f5my7sokvipndwoltx3c4wh4@bghfja7slw75> (raw)
In-Reply-To: <20241118175414.390827-1-lorenzo.stoakes@oracle.com>

* Lorenzo Stoakes <lorenzo.stoakes@oracle.com> [241118 12:54]:
> We mistakenly refer to len rather than len_ here. The only existing caller
> passes len to the len_ parameter so this has no impact on the code, but it
> is obviously incorrect to do this, so fix it.
> 
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>

Reviewed-by: Liam R. Howlett <Liam.Howlett@Oracle.com>

> ---
>  mm/vma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/vma.c b/mm/vma.c
> index 8a454a7bbc80..8e31b7e25aeb 100644
> --- a/mm/vma.c
> +++ b/mm/vma.c
> @@ -35,7 +35,7 @@ struct mmap_state {
>  		.mm = mm_,						\
>  		.vmi = vmi_,						\
>  		.addr = addr_,						\
> -		.end = (addr_) + len,					\
> +		.end = (addr_) + (len_),				\
>  		.pgoff = pgoff_,					\
>  		.pglen = PHYS_PFN(len_),				\
>  		.flags = flags_,					\
> -- 
> 2.47.0
> 


  reply	other threads:[~2024-11-18 20:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-18 17:54 Lorenzo Stoakes
2024-11-18 20:02 ` Liam R. Howlett [this message]
2024-11-19 10:02 ` Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=hxinljr62axgkndypsof3yvqp2f5my7sokvipndwoltx3c4wh4@bghfja7slw75 \
    --to=liam.howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=jannh@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox