From: Jan Kara <jack@suse.cz>
To: Tal Zussman <tz2294@columbia.edu>
Cc: David Howells <dhowells@redhat.com>,
Marc Dionne <marc.dionne@auristor.com>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Chris Li <chrisl@kernel.org>,
Kairui Song <kasong@tencent.com>,
Kemeng Shi <shikemeng@huaweicloud.com>,
Nhat Pham <nphamcs@gmail.com>, Baoquan He <bhe@redhat.com>,
Barry Song <baohua@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Dan Williams <dan.j.williams@intel.com>, Jan Kara <jack@suse.cz>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Paulo Alcantara <pc@manguebit.org>,
Trond Myklebust <trondmy@kernel.org>,
Anna Schumaker <anna@kernel.org>, Mark Fasheh <mark@fasheh.com>,
Joel Becker <jlbec@evilplan.org>,
Joseph Qi <joseph.qi@linux.alibaba.com>,
Steve French <sfrench@samba.org>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>,
Bharath SM <bharathsm@microsoft.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tursulin@ursulin.net>, Chris Mason <clm@fb.com>,
David Sterba <dsterba@suse.com>,
Ilya Dryomov <idryomov@gmail.com>,
Alex Markuze <amarkuze@redhat.com>,
Viacheslav Dubeyko <slava@dubeyko.com>,
Andreas Gruenbacher <agruenba@redhat.com>,
Muchun Song <muchun.song@linux.dev>,
Oscar Salvador <osalvador@suse.de>,
Ryusuke Konishi <konishi.ryusuke@gmail.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Chuck Lever <chuck.lever@oracle.com>,
Jeff Layton <jlayton@kernel.org>, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Jason Gunthorpe <jgg@ziepe.ca>,
John Hubbard <jhubbard@nvidia.com>, Peter Xu <peterx@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
Jann Horn <jannh@google.com>, Pedro Falcato <pfalcato@suse.de>,
Brendan Jackman <jackmanb@google.com>, Zi Yan <ziy@nvidia.com>,
Hugh Dickins <hughd@google.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Axel Rasmussen <axelrasmussen@google.com>,
Yuanchu Xie <yuanchu@google.com>, Wei Xu <weixugc@google.com>,
Qi Zheng <zhengqi.arch@bytedance.com>,
linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev,
linux-ext4@vger.kernel.org, netfs@lists.linux.dev,
linux-nfs@vger.kernel.org, ocfs2-devel@lists.linux.dev,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org,
gfs2@lists.linux.dev, linux-nilfs@vger.kernel.org,
linux-xfs@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [PATCH v2 2/4] fs: Remove unncessary pagevec.h includes
Date: Thu, 26 Feb 2026 14:12:51 +0100 [thread overview]
Message-ID: <hulhfdnrv4bbm6nvy3x4xbuxmc5ypmhpwdpt3jurfkibq5t2pu@6dcvs2uzzr46> (raw)
In-Reply-To: <20260225-pagevec_cleanup-v2-2-716868cc2d11@columbia.edu>
On Wed 25-02-26 18:44:26, Tal Zussman wrote:
> Remove unused pagevec.h includes from .c files. These were found with
> the following command:
>
> grep -rl '#include.*pagevec\.h' --include='*.c' | while read f; do
> grep -qE 'PAGEVEC_SIZE|folio_batch' "$f" || echo "$f"
> done
>
> There are probably more removal candidates in .h files, but those are
> more complex to analyze.
>
> Signed-off-by: Tal Zussman <tz2294@columbia.edu>
If it compiles than it's nice to get rid of. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/afs/write.c | 1 -
> fs/dax.c | 1 -
> fs/ext4/file.c | 1 -
> fs/ext4/page-io.c | 1 -
> fs/ext4/readpage.c | 1 -
> fs/f2fs/file.c | 1 -
> fs/mpage.c | 1 -
> fs/netfs/buffered_write.c | 1 -
> fs/nfs/blocklayout/blocklayout.c | 1 -
> fs/nfs/dir.c | 1 -
> fs/ocfs2/refcounttree.c | 1 -
> fs/smb/client/connect.c | 1 -
> fs/smb/client/file.c | 1 -
> 13 files changed, 13 deletions(-)
>
> diff --git a/fs/afs/write.c b/fs/afs/write.c
> index 93ad86ff3345..fcfed9d24e0a 100644
> --- a/fs/afs/write.c
> +++ b/fs/afs/write.c
> @@ -10,7 +10,6 @@
> #include <linux/fs.h>
> #include <linux/pagemap.h>
> #include <linux/writeback.h>
> -#include <linux/pagevec.h>
> #include <linux/netfs.h>
> #include <trace/events/netfs.h>
> #include "internal.h"
> diff --git a/fs/dax.c b/fs/dax.c
> index b78cff9c91b3..a5237169b467 100644
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -15,7 +15,6 @@
> #include <linux/memcontrol.h>
> #include <linux/mm.h>
> #include <linux/mutex.h>
> -#include <linux/pagevec.h>
> #include <linux/sched.h>
> #include <linux/sched/signal.h>
> #include <linux/uio.h>
> diff --git a/fs/ext4/file.c b/fs/ext4/file.c
> index f1dc5ce791a7..5e02f6cf653e 100644
> --- a/fs/ext4/file.c
> +++ b/fs/ext4/file.c
> @@ -27,7 +27,6 @@
> #include <linux/dax.h>
> #include <linux/filelock.h>
> #include <linux/quotaops.h>
> -#include <linux/pagevec.h>
> #include <linux/uio.h>
> #include <linux/mman.h>
> #include <linux/backing-dev.h>
> diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c
> index a8c95eee91b7..98da200d11c8 100644
> --- a/fs/ext4/page-io.c
> +++ b/fs/ext4/page-io.c
> @@ -16,7 +16,6 @@
> #include <linux/string.h>
> #include <linux/buffer_head.h>
> #include <linux/writeback.h>
> -#include <linux/pagevec.h>
> #include <linux/mpage.h>
> #include <linux/namei.h>
> #include <linux/uio.h>
> diff --git a/fs/ext4/readpage.c b/fs/ext4/readpage.c
> index 830f3b8a321f..3c7aabde719c 100644
> --- a/fs/ext4/readpage.c
> +++ b/fs/ext4/readpage.c
> @@ -43,7 +43,6 @@
> #include <linux/mpage.h>
> #include <linux/writeback.h>
> #include <linux/backing-dev.h>
> -#include <linux/pagevec.h>
>
> #include "ext4.h"
> #include <trace/events/ext4.h>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index c8a2f17a8f11..c6b6a1465d08 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -17,7 +17,6 @@
> #include <linux/compat.h>
> #include <linux/uaccess.h>
> #include <linux/mount.h>
> -#include <linux/pagevec.h>
> #include <linux/uio.h>
> #include <linux/uuid.h>
> #include <linux/file.h>
> diff --git a/fs/mpage.c b/fs/mpage.c
> index 7dae5afc2b9e..e5285fbfcf09 100644
> --- a/fs/mpage.c
> +++ b/fs/mpage.c
> @@ -28,7 +28,6 @@
> #include <linux/mm_inline.h>
> #include <linux/writeback.h>
> #include <linux/backing-dev.h>
> -#include <linux/pagevec.h>
> #include "internal.h"
>
> /*
> diff --git a/fs/netfs/buffered_write.c b/fs/netfs/buffered_write.c
> index 22a4d61631c9..05ea5b0cc0e8 100644
> --- a/fs/netfs/buffered_write.c
> +++ b/fs/netfs/buffered_write.c
> @@ -10,7 +10,6 @@
> #include <linux/mm.h>
> #include <linux/pagemap.h>
> #include <linux/slab.h>
> -#include <linux/pagevec.h>
> #include "internal.h"
>
> static void __netfs_set_group(struct folio *folio, struct netfs_group *netfs_group)
> diff --git a/fs/nfs/blocklayout/blocklayout.c b/fs/nfs/blocklayout/blocklayout.c
> index cb0a645aeb50..11f9f69cde61 100644
> --- a/fs/nfs/blocklayout/blocklayout.c
> +++ b/fs/nfs/blocklayout/blocklayout.c
> @@ -36,7 +36,6 @@
> #include <linux/namei.h>
> #include <linux/bio.h> /* struct bio */
> #include <linux/prefetch.h>
> -#include <linux/pagevec.h>
>
> #include "../pnfs.h"
> #include "../nfs4session.h"
> diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
> index 2402f57c8e7d..0d276441206b 100644
> --- a/fs/nfs/dir.c
> +++ b/fs/nfs/dir.c
> @@ -32,7 +32,6 @@
> #include <linux/nfs_fs.h>
> #include <linux/nfs_mount.h>
> #include <linux/pagemap.h>
> -#include <linux/pagevec.h>
> #include <linux/namei.h>
> #include <linux/mount.h>
> #include <linux/swap.h>
> diff --git a/fs/ocfs2/refcounttree.c b/fs/ocfs2/refcounttree.c
> index c1cdececdfa4..b4acd081bbc4 100644
> --- a/fs/ocfs2/refcounttree.c
> +++ b/fs/ocfs2/refcounttree.c
> @@ -31,7 +31,6 @@
> #include <linux/blkdev.h>
> #include <linux/slab.h>
> #include <linux/writeback.h>
> -#include <linux/pagevec.h>
> #include <linux/swap.h>
> #include <linux/security.h>
> #include <linux/string.h>
> diff --git a/fs/smb/client/connect.c b/fs/smb/client/connect.c
> index 33dfe116ca52..9e57812b7b95 100644
> --- a/fs/smb/client/connect.c
> +++ b/fs/smb/client/connect.c
> @@ -20,7 +20,6 @@
> #include <linux/delay.h>
> #include <linux/completion.h>
> #include <linux/kthread.h>
> -#include <linux/pagevec.h>
> #include <linux/freezer.h>
> #include <linux/namei.h>
> #include <linux/uuid.h>
> diff --git a/fs/smb/client/file.c b/fs/smb/client/file.c
> index 18f31d4eb98d..853ce1817810 100644
> --- a/fs/smb/client/file.c
> +++ b/fs/smb/client/file.c
> @@ -15,7 +15,6 @@
> #include <linux/stat.h>
> #include <linux/fcntl.h>
> #include <linux/pagemap.h>
> -#include <linux/pagevec.h>
> #include <linux/writeback.h>
> #include <linux/task_io_accounting_ops.h>
> #include <linux/delay.h>
>
> --
> 2.39.5
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2026-02-26 13:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 23:44 [PATCH v2 0/4] mm: Remove stray references to pagevec Tal Zussman
2026-02-25 23:44 ` [PATCH v2 1/4] mm: Remove stray references to struct pagevec Tal Zussman
2026-02-25 23:44 ` [PATCH v2 2/4] fs: Remove unncessary pagevec.h includes Tal Zussman
2026-02-26 13:12 ` Jan Kara [this message]
2026-02-25 23:44 ` [PATCH v2 3/4] folio_batch: Rename pagevec.h to folio_batch.h Tal Zussman
2026-02-26 13:14 ` Jan Kara
2026-02-26 13:18 ` David Hildenbrand (Arm)
2026-02-25 23:44 ` [PATCH v2 4/4] folio_batch: Rename PAGEVEC_SIZE to FOLIO_BATCH_SIZE Tal Zussman
2026-02-26 13:14 ` Jan Kara
2026-02-26 13:20 ` David Hildenbrand (Arm)
2026-02-26 0:41 ` [PATCH v2 0/4] mm: Remove stray references to pagevec Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=hulhfdnrv4bbm6nvy3x4xbuxmc5ypmhpwdpt3jurfkibq5t2pu@6dcvs2uzzr46 \
--to=jack@suse.cz \
--cc=Dai.Ngo@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=adilger.kernel@dilger.ca \
--cc=agruenba@redhat.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=amarkuze@redhat.com \
--cc=anna@kernel.org \
--cc=axelrasmussen@google.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=bharathsm@microsoft.com \
--cc=bhe@redhat.com \
--cc=brauner@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=chao@kernel.org \
--cc=chrisl@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=clm@fb.com \
--cc=dan.j.williams@intel.com \
--cc=david@kernel.org \
--cc=dhowells@redhat.com \
--cc=djwong@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsterba@suse.com \
--cc=gfs2@lists.linux.dev \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=idryomov@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jackmanb@google.com \
--cc=jaegeuk@kernel.org \
--cc=jani.nikula@linux.intel.com \
--cc=jannh@google.com \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=jlayton@kernel.org \
--cc=jlbec@evilplan.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=kasong@tencent.com \
--cc=konishi.ryusuke@gmail.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marc.dionne@auristor.com \
--cc=mark@fasheh.com \
--cc=mhocko@suse.com \
--cc=mripard@kernel.org \
--cc=muchun.song@linux.dev \
--cc=neil@brown.name \
--cc=netfs@lists.linux.dev \
--cc=nphamcs@gmail.com \
--cc=nvdimm@lists.linux.dev \
--cc=ocfs2-devel@lists.linux.dev \
--cc=okorniev@redhat.com \
--cc=osalvador@suse.de \
--cc=pc@manguebit.org \
--cc=peterx@redhat.com \
--cc=pfalcato@suse.de \
--cc=rodrigo.vivi@intel.com \
--cc=roman.gushchin@linux.dev \
--cc=ronniesahlberg@gmail.com \
--cc=rppt@kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=shakeel.butt@linux.dev \
--cc=shikemeng@huaweicloud.com \
--cc=simona@ffwll.ch \
--cc=slava@dubeyko.com \
--cc=sprasad@microsoft.com \
--cc=surenb@google.com \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
--cc=tursulin@ursulin.net \
--cc=tytso@mit.edu \
--cc=tz2294@columbia.edu \
--cc=tzimmermann@suse.de \
--cc=vbabka@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=weixugc@google.com \
--cc=willy@infradead.org \
--cc=yuanchu@google.com \
--cc=zhengqi.arch@bytedance.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox