From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E92DC021A7 for ; Thu, 13 Feb 2025 07:21:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D3DAE6B0098; Thu, 13 Feb 2025 02:21:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CECF66B0099; Thu, 13 Feb 2025 02:21:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB4A3280001; Thu, 13 Feb 2025 02:21:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9EE706B0098 for ; Thu, 13 Feb 2025 02:21:42 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 52B1D12079B for ; Thu, 13 Feb 2025 07:21:41 +0000 (UTC) X-FDA: 83114076402.07.BFCA75D Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf03.hostedemail.com (Postfix) with ESMTP id 5499520004 for ; Thu, 13 Feb 2025 07:21:39 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Xl1OD3Ia; spf=pass (imf03.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.175 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739431299; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BU3EWX6NrO4XjLrf6OxWj7A2H39JQ/DGxsHXZ8vqb08=; b=55pUmNBgLkAB69PFDUoLhEbWMW1PofzKU8XB4DH1lGWBNGCy68zdqTor6X4j/OUgzHCLLY SwqVEgGrV/fXbZH8hhPHLO5cfJNVqeuUW7tw1z8rrN3ORavHI9KSEn7e/84FUP4/oOT0y4 l2WfbE5ZTt7EKcQGaNVWaVArNvKCwWQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739431299; a=rsa-sha256; cv=none; b=xBFQ8NISgRi7VYVZzKpnfNh7+c31bB23ztCt4Pl4px7dztK9N3NQVx9oMFaEUFQMuKuw4D UkmEB51vYP/nRtkChXEQ1d7Y+BKtDxl+fm0W9tGMjYmjlMBOI56bj+Zy+hHR+7tXBBiJvu zZvInRPm7gY/EheM4vUNVXDpbRuXqAs= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Xl1OD3Ia; spf=pass (imf03.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.175 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-220c2a87378so7236715ad.1 for ; Wed, 12 Feb 2025 23:21:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1739431298; x=1740036098; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BU3EWX6NrO4XjLrf6OxWj7A2H39JQ/DGxsHXZ8vqb08=; b=Xl1OD3IaDo/2ZQS2yYN0guUboJUU9+jRffDsAU3McTY1UEe8GA3D4HgT0Q1bHo+4P3 1DxbqoxVh+LE2Wh+9GwG25MSgsl/d1+O9NMK3XNa7b+I8EsxuUZJcyDQiMI48bFrY5+5 LRT2iB1/3A0j3lMP0zYQTWW040IqO9xBet2kM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739431298; x=1740036098; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BU3EWX6NrO4XjLrf6OxWj7A2H39JQ/DGxsHXZ8vqb08=; b=M1e4eDE+25hMt1+6Q2i9xaiCswE1GYA17RCIpmv7fen0GggDpzhaDMuD/JH+KeOrpb RviA+AByR7oTV6yWK1HUhiUGzEUzq0qesJW0xV9J+NYOZKatj/20C2l+odaNKYDjIOPw GC4xft4gm3qMexlStKp0fUGtW9ZX7in7/DYfWdUgtHDlawE3YxCJWTqtNr+k7cIAoo2t uwe4g4OFgNuLNUkxX4WqluX8810DFZRRQkc/ZjoCHCpb/YdIYnbhL7QnC1zmEUt+V7Lx HH0dz78CX2fubdjJ3Pdth9GzhzyS2zDajEdh0y5kcjFraWY9YoyAQuCokySIjqqlfTX6 5xLw== X-Forwarded-Encrypted: i=1; AJvYcCUhTKvR+VzfSRxsYIGHC4tcXelygXterXUMaWkMNQPRButIy+VF8DxnirJRttk9DmnGT3WaVRDT8A==@kvack.org X-Gm-Message-State: AOJu0YyxCSaepktdQJZhBrw/+dExPjBZ2hICPrmebIp4T5h0cHW+4qeo 1yeuK24OYg2K4I3gznCT+4IR4Xv0BMFNva96N8MQerxglrkOG3m8Phl1HoZKUQ== X-Gm-Gg: ASbGncvWvChBIXOHSsO02GAA1MpzPpKGijAKhk9l6Gzy2RIClOuxNTmivGw2Hx2IZpJ TtyBKcezORI5KiHdOcoaB+MFNCOdVtno+NNB1hN5Sv40iM4Rl8Apk3V8z0TGmkEdAmpsaf1mslb CUGDxepLEovOpuYzFQCMsGUy4yY4xZLYYt1tsm4TJqE3fV4y/H+8uNurGnX7k9mMEWtxJ0Pq5II fHG23qM/lGGUnjFbYtFws8M2GKSExs3AEMvDQ0ssQQ7mU6oOA49umZFJmgsY6g1lbkBHpqbaQVW wqhZ0B4ihonew6qAugU= X-Google-Smtp-Source: AGHT+IGrrMRSC9vH8hDZG+Sr73gos+a8WvcZbQzmGErKu6FhLXQnnI1jbWLKVzxORygaoGElOvivdg== X-Received: by 2002:a05:6a21:78a8:b0:1e1:cdff:5f18 with SMTP id adf61e73a8af0-1ee5c72e4f4mr10509093637.4.1739431298139; Wed, 12 Feb 2025 23:21:38 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:3ed3:97ce:5f5f:1f61]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-adb57c5e00dsm573320a12.12.2025.02.12.23.21.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 23:21:37 -0800 (PST) Date: Thu, 13 Feb 2025 16:21:32 +0900 From: Sergey Senozhatsky To: Yosry Ahmed Cc: Sergey Senozhatsky , Andrew Morton , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kairui Song Subject: Re: [PATCHv4 14/17] zsmalloc: make zspage lock preemptible Message-ID: References: <6vtpamir4bvn3snlj36tfmnmpcbd6ks6m3sdn7ewmoles7jhau@nbezqbnoukzv> <6uhsj4bckhursiblkxe54azfgyqal6tq2de3lpkxw6omkised6@uylodcjruuei> <25268fbedb82a06ba0c13e2c490b164846ef508b@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <25268fbedb82a06ba0c13e2c490b164846ef508b@linux.dev> X-Rspam-User: X-Rspamd-Queue-Id: 5499520004 X-Rspamd-Server: rspam07 X-Stat-Signature: 7jhneddcfw4ukmfwnzidtytp8z31tzpa X-HE-Tag: 1739431299-485749 X-HE-Meta: U2FsdGVkX1/zadqmijs/Z+YXJjmsvvkPfpICijbq9AzOyl2NiFfyqdgKXrZJeqb6SYGU3A+WPXJkwydBHUSSx7YhxrbQbA3xayK6lwEZLyqvY+ujesxac9EzGZ8rxHe6L77Ls+jY0GbRSqlIqGL6WPJMUOmX1Bbxy7stX+4WyhH27/T1VaSrgyf91ArU2gaAx+sGOC3OwdqyDVFruB6IBFjgnaSDL7hG8nYs99Z0LUNaFKCHm9vo8khQ0YwkDsBOwxJIIPaWnGo8e7A7AEgzHOTlr1eat3NioTD/p1EK9/gf6H9MKIJvLW6OZ54a8ULCb0gOA97otE72nXUzMGkj/Eqst+exIMl5HzqpUf4GBhmdc3+fxHSSgCf5KahRQhMyzsQYEBBe7kbiGYc7NuHrb2o6AFcfz1gr84v/jwEme9lUqyW1AGfZoMhnhVOXN/YIpb86SKS0Ea3du+eNZpBE3SV1YL9Hblo9xEt5A2tDMo929jWGC38WfMpKP5iOascF2J/lOpqdXzrLuo4lSj/7ALP5BemEiCLiNHPbxrIJXWtIB2jBmTug3CtMgOqmZSuPwuG4evYAH96P8lgbZtaUvboNja9Wej8ZT04VwxH3SYTMf0Fc2cvDVkg1ixssFbd9J25632ta6XbcZLiee2+OyfHoIi15dKj3OVRzKjvpgzHxGfmg57hzwbtwsyEtHXTlUQcTZd6AZB0CQJZ+wmf+eCIQyAdyCvqHQIzwlL9EY+X7ioDy+xwcQgf2q3/OGqLzKXuqX10Az1Fy7mtRi1cCl/PGZWQfTCXg1QPauZUjxpwLO1Y8uTuuabj+ZNwMclMdOMDKctb7VRDoarioyGT+thxTUu/iUAAMEV4Wj2iFkLBMKolVfHjkUSxUVjLtMV7rINhNdN+rFN56umdVzJH7g1QGfU9uTg9RHlodqIHIciPgFT4x5xRKbkQIIIeh7WHnvup/mCTPH4nUVZ/D2Ao VcM6dFr2 T1Cge8+CoNcVlMhz5xpsaRymUMs0emmpTo180r6WxWtRkovjNeZ7hw/SF9mvY2elNR1RxoPwDmJpiu02vA869RbdcZ+02wtMofcJibAsMBNEuhrPPgmb/EOLd0jW77+kEdcBsjT2XOWAsWe5FC5YQ8mWYmC7S6TqTISn9MaPOeCmavnIU52HBr3Y/KZTazXbnGXtICYBXjTrZNLmsd2S9PbHFUlykLSXIQSw6stZFH/EFVGrzpzgNvjQd8CHNNIqMJGyynfdf/Xb6sur44fNslUHRIJ/MGF3uh5MQ/eC97z5QGeXhNHu3NR2mpLIyY2p6cDILJAiJmLLv/n69L81Uc2dsVsdjnFkv0pLu2HYMKahKeW0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.377297, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/02/13 02:57), Yosry Ahmed wrote: > > > I think we also need some high level testing (e.g. concurrent > > > > > > swapins/swapouts) to find that out. I think that's what Kairui's testing > > > > > > covers. > > > > > > > I do a fair amount of high-level testing: heavy parallel (make -j36 and > > > > parallel dd) workloads (multiple zram devices configuration - zram0 ext4, > > > > zram1 writeback device, zram2 swap) w/ and w/o lockdep. In addition I also > > > > run these workloads under heavy memory pressure (a 4GB VM), when oom-killer > > > > starts to run around with a pair of scissors. But it's mostly regression > > > > testing. > > // JFI it seems your email client/service for some reason injects a lot // of empty lines > If we can get some numbers from these parallel workloads that would be better than the perf stats imo. make -j24 CONFIG_PREEMPT BASE ==== 1363.64user 157.08system 1:30.89elapsed 1673%CPU (0avgtext+0avgdata 825692maxresident)k lock stats class name con-bounces contentions waittime-min waittime-max waittime-total waittime-avg acq-bounces acquisitions holdtime-min holdtime-max holdtime-total holdtime-avg &pool->migrate_lock-R: 0 0 0.00 0.00 0.00 0.00 10001 702081 0.14 104.74 125571.64 0.18 &class->lock: 1 1 0.25 0.25 0.25 0.25 6320 840542 0.06 809.72 191214.87 0.23 &zspage->lock-R: 0 0 0.00 0.00 0.00 0.00 6452 664129 0.12 660.24 201888.61 0.30 &zram->table[index].lock: 0 0 0.00 0.00 0.00 0.00 1716362 3096466 0.07 811.10 365551.24 0.12 &zstrm->lock: 0 0 0.00 0.00 0.00 0.00 0 664129 1.68 1004.80 14853571.32 22.37 PATCHED ======= 1366.50user 154.89system 1:30.33elapsed 1684%CPU (0avgtext+0avgdata 825692maxresident)k lock stats class name con-bounces contentions waittime-min waittime-max waittime-total waittime-avg acq-bounces acquisitions holdtime-min holdtime-max holdtime-total holdtime-avg &pool->lock#3-R: 0 0 0.00 0.00 0.00 0.00 3648 701979 0.12 44.09 107333.02 0.15 &class->lock: 0 0 0.00 0.00 0.00 0.00 5038 840434 0.06 1245.90 211814.60 0.25 zsmalloc-page-R: 0 0 0.00 0.00 0.00 0.00 0 664078 0.05 699.35 236641.75 0.36 zram-entry->lock: 0 0 0.00 0.00 0.00 0.00 0 3098328 0.06 2987.02 313339.11 0.10 &per_cpu_ptr(comp->stream, cpu)->lock: 0 0 0.00 0.00 0.00 0.00 23 664078 1.77 7071.30 14838397.61 22.34