From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5120C52D7B for ; Fri, 9 Aug 2024 00:55:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E61C6B0089; Thu, 8 Aug 2024 20:55:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 295E86B008A; Thu, 8 Aug 2024 20:55:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 184E16B008C; Thu, 8 Aug 2024 20:55:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EFAA46B0089 for ; Thu, 8 Aug 2024 20:55:30 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 61A214043D for ; Fri, 9 Aug 2024 00:55:30 +0000 (UTC) X-FDA: 82430888820.10.451FCE7 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf03.hostedemail.com (Postfix) with ESMTP id 584EB2002E for ; Fri, 9 Aug 2024 00:55:28 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IHhZUR2S; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of andi.shyti@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=andi.shyti@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723164880; a=rsa-sha256; cv=none; b=4I8IhZFesxifRkFSkYLDqePCDYsYO8pLpk/nf1logLEumkJEJJXondR7VLUACMANKA6tGo MpYdDjBOd38ONIAR+S4jISYOj2xDKIaQS44lnvcbN7fbwL1lT+ygNMUNp8jVdpoeZTj8GT q1KYoPAQocfMGF3P5hxYW2Yvo/BsprY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IHhZUR2S; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of andi.shyti@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=andi.shyti@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723164880; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bkPFa76xYjxJHMk/I2TB/mlj6u1i4vq3JBjFaeeZj/4=; b=6CDj+2zHSVcrAYgCXQICRmv1q+uSIyiOXk5dw0sisY6DL0Ho7CgzXUhTMhn7vKwGBCZVg7 ZpHQ2RIffFZFgXjpKZ83R+Tt2QMq/U1kJD021USwErILcZrg6iH9xCSs2/U60p1LAhWkJm zHQs5SWeyL5pE6jXhQK27afwKxRlktE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 3B8ADCE16AA; Fri, 9 Aug 2024 00:55:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96FF6C32782; Fri, 9 Aug 2024 00:55:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723164923; bh=RhQojpL0Hy01EezhbkD+iRO1/vupD1lsoA7uPl1jJMc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IHhZUR2SRY7BtMppDISbqjYffmLrzp9GKeqK0Kvo3UMTq8I5oROFFBsXz/JGJ/l8C ySX96N9sTxiEXzxjjvCiedx3PgJGuMl0Y7nWm8aq/KGQLDjpAy7/34pn+M9A2VFdoZ rD5903+FwF7GO+QEf4pKqcyPwjGp/wcJmq9Wwwbeer7YZboKtkoUsSG0JgjXk7IRx8 mq7HAx+gvRK0N0kymjIHKjsI0rmW6yzQdzxK7L3Ncs0XnqXJc9yUhUoNNTCKHn8aLO JWEWaim50NzL8pv4Vz21URdXMoAZ2oaym+kyYNgCbAKCDyIUyCSkzS1b738ZpgXlfQ dSXxNnP/Re8qA== Date: Fri, 9 Aug 2024 01:55:17 +0100 From: Andi Shyti To: Mary Strodl Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org, linux-mm@kvack.org, lee@kernel.org, linux-i2c@vger.kernel.org, s.hauer@pengutronix.de, christian.gmeiner@gmail.com Subject: Re: [PATCH v3 2/2] i2c: Add Congatec CGEB I2C driver Message-ID: References: <20240808183527.3950120-1-mstrodl@csh.rit.edu> <20240808183527.3950120-3-mstrodl@csh.rit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240808183527.3950120-3-mstrodl@csh.rit.edu> X-Rspamd-Queue-Id: 584EB2002E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: raetwfsu3mt8t4nk8bsgdu5wxoyyh4y4 X-HE-Tag: 1723164928-428916 X-HE-Meta: U2FsdGVkX1/ktxjd427a9gscEuSzRF7kZwU0o/F8Y4VhwdTf+w7cQHaNdxJBLB0fRXlUUSD62IM/c6CxoA4LAv7sAw69REEG66p/cwYkX8Q7i7zXZBi2ALHn8lOiWYjbT6BitwOjZbBZnfjpbn6Ic/oz1OlUu/HaGksx3EtIHrnUxg/HYmKDBovQ/SNJ7dy35Ys3gqZxHhj+IgSQPL7n2BCYNMsP/NTzIA7yTpRypOD2sxVw6hctHqFyj1ePMLFYBRblRMC8FL8bwEB+iqO/9NKr0WHs9cIw+zkcQxyxZlcc7nUpTgWB9cICAJ6ZuRli1cynHORtoV1U0EndrT2zSCvhZ9XXYquO5SCtNGVCGhXu/fYT7V6miVp2lmE7UwWGSCDXbNeC4MzgCGdSLxqgTxThkbRT9rzG9v0mKlHi+bRgwDszW1g6F2RdSdWcvR4NWyjWGiIWhaq0Hx64Rsm5r/CvxNbnOBeGeEGuRtVG3buSxuydwa6Hb/n8DP2h5lOU+mGV0TO+qHggYWl7aa3MxF16mmQoWSMP/iddA+CNjTvbVb4nPISd/B01fyTDCmxZamVwK+7EXWpmFhg50mLvwOtLjLk9IYtvi2+O3Dz0HOMuoN4RlXqeV/fx3D9gvaWOU22tXiluGzDRrew7pq5CTUfOaFezWHE3yQep1gGn25s9whrVWCt7aQYrxEQPlRiJ1OMEnBo8Azy8I4++AK2bEpfN+nxISd0iHiAWInGTkOUBFiKRW0xRqwFHRrTtcSnF9yE0ZocInv4PuZMV3rTCStOMQ6827+N/NdvLQRHcm5H2XxSfGlPQgDe/dujAq7YHCZOJJ8qHhPi0X0SCw1LAK568BHV1uIZYJVTGaMonxPcVDvhlHp7lsjE2IdKXYuMW7HAokDhcfW97e7oFHuWcU2SaQrrt4Y5SUh5APVMslg2ORgyQNoF1Zx85O/uxdNBbtrMmI5j8EISpoXE0jT8 F7RV9XqL wyfx8eW4xHoEY7qTgWM/gy9cXwp71zCq2CfNOU5UBLW3RpBaB+JOLk+iFSkD0Xw0jNoTR7wEDSMig6R4ZOo1WFgp3M3geT6eenbw2s9x+ZFMfklg1+T+WSjiRH0yzph/+XonEJp+kJlbcLsUFeRZ5leiqfDQV9MDNnjx0FQKwXkcEeTsM3295jQi3OXI2ZdUdr+vvA8XwjV7Tiau2m4BhMDOFtP/yRmhbaHS0Emd3N+WoLsAXep/Zze4nvN/YHdKTzroTC5URf+nFqhZUaMRaDfImvfoNFV8RR5KE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Mary, just skimmed through fast... > + dev_dbg(&adapter->dev, > + "%s: rd: %p/%ld wr: %p/%ld flags: 0x%08lx %s\n", > + __func__, rdbuf, rdlen, raw_wrbuf, wrlen + 1, > + flags, > + msgs[i].flags & I2C_M_RD ? "READ" : "WRITE"); please mind the alignment: align everuthyng under the "(". ... > + ret = i2c_add_adapter(&priv->adapter); > + if (ret < 0) { > + dev_err(&pdev->dev, "registration failed\n"); > + return ret; please use dev_err_probe(); Andi