From: Andi Shyti <andi.shyti@kernel.org>
To: Mary Strodl <mstrodl@csh.rit.edu>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
urezki@gmail.com, hch@infradead.org, linux-mm@kvack.org,
lee@kernel.org, linux-i2c@vger.kernel.org,
s.hauer@pengutronix.de, christian.gmeiner@gmail.com
Subject: Re: [PATCH v3 2/2] i2c: Add Congatec CGEB I2C driver
Date: Fri, 9 Aug 2024 01:55:17 +0100 [thread overview]
Message-ID: <htilttfnytacgk6rqsnmeamyvoaglfwhwbgkc6cxkxt5h4yk3n@l65rbpa6mkfy> (raw)
In-Reply-To: <20240808183527.3950120-3-mstrodl@csh.rit.edu>
Hi Mary,
just skimmed through fast...
> + dev_dbg(&adapter->dev,
> + "%s: rd: %p/%ld wr: %p/%ld flags: 0x%08lx %s\n",
> + __func__, rdbuf, rdlen, raw_wrbuf, wrlen + 1,
> + flags,
> + msgs[i].flags & I2C_M_RD ? "READ" : "WRITE");
please mind the alignment: align everuthyng under the "(".
...
> + ret = i2c_add_adapter(&priv->adapter);
> + if (ret < 0) {
> + dev_err(&pdev->dev, "registration failed\n");
> + return ret;
please use dev_err_probe();
Andi
prev parent reply other threads:[~2024-08-09 0:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 18:35 [PATCH v3 0/2] Add support for Congatec CGEB BIOS interface Mary Strodl
2024-08-08 18:35 ` [PATCH v3 1/2] x86: Add basic support for the " Mary Strodl
2024-08-09 0:46 ` Andi Shyti
2024-08-12 11:45 ` Mary Strodl
2024-08-12 20:16 ` Andi Shyti
2024-08-13 12:26 ` kernel test robot
2024-08-08 18:35 ` [PATCH v3 2/2] i2c: Add Congatec CGEB I2C driver Mary Strodl
2024-08-09 0:55 ` Andi Shyti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=htilttfnytacgk6rqsnmeamyvoaglfwhwbgkc6cxkxt5h4yk3n@l65rbpa6mkfy \
--to=andi.shyti@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=christian.gmeiner@gmail.com \
--cc=hch@infradead.org \
--cc=lee@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mstrodl@csh.rit.edu \
--cc=s.hauer@pengutronix.de \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox