From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86D71C369A2 for ; Mon, 14 Apr 2025 13:58:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21F7528005C; Mon, 14 Apr 2025 09:58:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CF23280054; Mon, 14 Apr 2025 09:58:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0968528005C; Mon, 14 Apr 2025 09:58:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DDB99280054 for ; Mon, 14 Apr 2025 09:58:44 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7569E160266 for ; Mon, 14 Apr 2025 13:58:45 +0000 (UTC) X-FDA: 83332805010.21.1900C94 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf22.hostedemail.com (Postfix) with ESMTP id 2B2D6C000E for ; Mon, 14 Apr 2025 13:58:42 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2pZWZYIE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=2yiLDnu2; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2pZWZYIE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=2yiLDnu2; dmarc=none; spf=pass (imf22.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744639123; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S554XvRIlWkgLTpvedrrQNLZ/frGNoctW5TsSBt6TJQ=; b=UsmhvnY2oBZVk3ctjMSUxS7aiCLr4UWPTO5BRAuCVihBCNV5tV5RUPxVyZbLNDdDjO2Nyj R2hLYdmXY5/jvg1iFIGrH01eGjtg/R3NNv509vC9YudAibRz6QJI5m4jR1+HWZiGvpCUi5 cqW1ZgXfCx0kIZSW9mA7nudxdGCFXmY= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2pZWZYIE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=2yiLDnu2; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2pZWZYIE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=2yiLDnu2; dmarc=none; spf=pass (imf22.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744639123; a=rsa-sha256; cv=none; b=aBpB33UIcm3QIJpV1E7XmIByOObVJbeRFXGjlVAvrEidjTDeq8El4dOjvrFknb6N4hDm7K OiEQfc1rUgUxDUo9HDLzMk2r7/oKiDvEEW9Zf5gRUJ6b7dJl/J38zGB6eS+EgDNJJ7y5Oc O3hSrpJfk6Rl3g6ZsVlNiOGjwdgzMVg= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 921EB218E6; Mon, 14 Apr 2025 13:58:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1744639121; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S554XvRIlWkgLTpvedrrQNLZ/frGNoctW5TsSBt6TJQ=; b=2pZWZYIEjCofs/R29J+7qTVlmdikpwP/8b+aZ88TFhs6hO70XvZbg0T/M//wvG2GOwk7yk K1p0JJ4McJTbToK1YSJzM0IiudHATAR5+rm2aQUh+ELms91s0FaEu+kAP8p/2pd3/yyvcG ZEmlqN75jL/1StG2VlP+CFaAcNpFz8E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1744639121; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S554XvRIlWkgLTpvedrrQNLZ/frGNoctW5TsSBt6TJQ=; b=2yiLDnu2Gw02ttvu1SoIsu9bir8hR4awMZ8B0p/Ms9hKMSViNNqxURfzrhafk6EXEoNv8e tLn550NIg3P42mDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1744639121; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S554XvRIlWkgLTpvedrrQNLZ/frGNoctW5TsSBt6TJQ=; b=2pZWZYIEjCofs/R29J+7qTVlmdikpwP/8b+aZ88TFhs6hO70XvZbg0T/M//wvG2GOwk7yk K1p0JJ4McJTbToK1YSJzM0IiudHATAR5+rm2aQUh+ELms91s0FaEu+kAP8p/2pd3/yyvcG ZEmlqN75jL/1StG2VlP+CFaAcNpFz8E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1744639121; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S554XvRIlWkgLTpvedrrQNLZ/frGNoctW5TsSBt6TJQ=; b=2yiLDnu2Gw02ttvu1SoIsu9bir8hR4awMZ8B0p/Ms9hKMSViNNqxURfzrhafk6EXEoNv8e tLn550NIg3P42mDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 82FDA136A7; Mon, 14 Apr 2025 13:58:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id IP75H5EU/Wf+BwAAD6G6ig (envelope-from ); Mon, 14 Apr 2025 13:58:41 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 338BAA094B; Mon, 14 Apr 2025 15:58:37 +0200 (CEST) Date: Mon, 14 Apr 2025 15:58:37 +0200 From: Jan Kara To: Cabbaken Q Cc: Kees Cook , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Alexander Viro , Christian Brauner , Jan Kara Subject: Re: [PATCH] Fix comment style of `do_execveat_common()` Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Action: no action X-Rspamd-Server: rspam01 X-Stat-Signature: 4nrqw139rdxoew5uifbqjxpg6te9auga X-Rspam-User: X-Rspamd-Queue-Id: 2B2D6C000E X-HE-Tag: 1744639122-277586 X-HE-Meta: U2FsdGVkX18Iz1SGAFNTqWWAR5b756uvt5FZfTbIm2TPzTArFA+SS7KFYLWE3bQ2qiSRk5fAKu5T0IEgT+DAm3D2w2FZxgXJZhD74X7e+OXKn8UqoWnIaXlIjn/hX2HF++dLKH3DgjYIDvwbWaHDj/G1MLocUvzUU1T7pH+LSe0fYmh2+yDITWkIlCQ2EEQWu5TFHS4a1TDKzRK8wJHnt1HMlj1eGwQwbkocaOOnsPPG3kPxdTZ+F5cvYbIF3KP6JZl5zicRxHFJ11Vw6A5Pjqx5N4WkrMkOSrBzGGcCz4cmYy957JU0tAeuEI5d+VoiT5LuCuQwwiP/GOzhSMb73y8ilXuwLVW/Km/CUnU7TiRZEUWxEYF4XFBEWLKAGL+TcnBHMgbYH6MBUvxC2uy+YuBCN6hPgbXPF1DoFRX0bpRFsbPDnl53/ii8V9VRiy4hoZp0ey9K+0fboh67NzK7qZLVxTZvdbKl4Uiw7DEi6DdkDY1mKLLupkq6cxKVZohGbz7cJqiqviXczaSNmnCm3G8iW6HzmkOkAK05L6bPX7GucbxChsMPLDWxi5UEi1xulvlLGactJHaZns5StisXzEfDJG7lhj9J7IQ16nbG2MWDyEWy1HLu+GJLBFJf7o4JEXcMD93iaC0xqo9SRc6hab2/KySVL9o9rGbCHJu2cN9gvLeiFwecbNIW9PyArGYIauWK8ms65x6YLXrTpPriXPq03iXRoyNLkYQmg7kmlGMguvgJo5S8syYN4ylsRdIM19PHgR0B78hkvscHjPTrpwYtDLeZkB16Eyfbd35XEgTQ86GEndZwVTDr7PYwpeBRsXxfbNo7rAZtL9QgKySGb+ir3+F65xRPPIEGxICqlZHfiDHROYTrwS9cBc2wWnPRCJkF/2iq4HFK6MvTZZuQS6JOZFOVho8Q5TEOmQ5y0u8mLz66dF24P5qsbi3/r7+6DoUl4iD61aYSOmdMmIS aeG4OR0q FT+0HkgylWhylM3qEd1svOqwwgOrTfgnP4hNIwZMLS08jGK2V1Mxax2ZDM2oCli5tL7L9N9ENOuJMZE47ciGndLXeqVobXFKqlugzjLeK4mTgET3FgtIqz5au/nK7nsUraAzHpQg5i/mWIBMtTheLVlV0tlIsFkFmtOcV8hZ3bGRQLvIZoGOjrmlUwN8IsrrPP25M/EqV9Q56pBAoQy2ojHLcQH/tj0GSun78bmY1yFoZ5Gqlhun5QKFLxlyUEcTqOUlZSh9yPnkuJkx/DFZCz+VHa0ldHxqbnOl30vIFd2f+/ttIgf3hywxmMGlj/iXK2OjIq8GTZ9hhqOAvgEi+eIK+vOFTXn+F8B2Xn7ErA1r4wqXFUH/0o9FwUgRbM6rIwO8DANZAtwdZdSTskk+mBIvYDJajo5g9aVnH2YexigrQN5kR3Wpad0vtI18/ZA5sXyjrCPMcjzUTF4Za5yDVuqpRiHBNlOTqh2av X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 14-04-25 07:07:57, Cabbaken Q wrote: > From 46fab5ecc860f26f790bec2a902a54bae58dfca7 Mon Sep 17 00:00:00 2001 > From: Ruoyu Qiu > Date: Mon, 14 Apr 2025 14:56:28 +0800 > Subject: [PATCH] Fix comment style of `do_execveat_common()` > > Signed-off-by: Ruoyu Qiu Thanks for the patch but I think fixing one extra space in a comment isn't really worth the effort of all the people involved in handling a patch. Honza > --- > fs/exec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/exec.c b/fs/exec.c > index 8e4ea5f1e64c..51dad7af5083 100644 > --- a/fs/exec.c > +++ b/fs/exec.c > @@ -1903,7 +1903,7 @@ static int do_execveat_common(int fd, struct filename *filename, >      /* >       * We move the actual failure in case of RLIMIT_NPROC excess from >       * set*uid() to execve() because too many poorly written programs > -      * don't check setuid() return code. Here we additionally recheck > +      * don't check setuid() return code. Here we additionally recheck >       * whether NPROC limit is still exceeded. >       */ >      if ((current->flags & PF_NPROC_EXCEEDED) && > -- > 2.49.0 > > -- Jan Kara SUSE Labs, CR