From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A2CEC83F3E for ; Tue, 5 Sep 2023 14:10:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA4738D0008; Tue, 5 Sep 2023 10:10:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C54A58D0001; Tue, 5 Sep 2023 10:10:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACF098D0008; Tue, 5 Sep 2023 10:10:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8ABC08D0001 for ; Tue, 5 Sep 2023 10:10:16 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 501E040786 for ; Tue, 5 Sep 2023 14:10:16 +0000 (UTC) X-FDA: 81202728432.26.9CB055F Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf10.hostedemail.com (Postfix) with ESMTP id EB0DFC002A for ; Tue, 5 Sep 2023 14:10:13 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="GsWx/gC+"; spf=pass (imf10.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693923014; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UfXW8hhd1XlJUbKT2y+Z8z/xpNcq0SYP8MPtpS/4cLs=; b=OvsMVISkixMcGmTuw0TckkuNamNr1BcNeSAmCC4gTGTUrNpn5WDweHOWotPTXR6ASBLr0L yN96EhYytdZ0kd9KOP0mLbxXUIsDE2TuzdywtDYcy4AoN+j0RMgG/mKHNIN0EzBqCls2+h FxhV9H7KoptG//YLRFmdByvaDWT5SNU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693923014; a=rsa-sha256; cv=none; b=5pp6MrVaGBLDega7jCgXcisWCt6JapVzgi+UhFmjdbAuGJzgqf2jNiqYaErSSLJRIbyF6U kRjfzYC2QK665iZcJ8EF72BJYBxHvz9BwUV/c9FsKCOF8e4knLTwG5Oew4OUsn8asu7xil 9J4A2P24R7S+zedi4vztF2keGGrX218= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="GsWx/gC+"; spf=pass (imf10.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CC5E721B46; Tue, 5 Sep 2023 14:10:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1693923011; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UfXW8hhd1XlJUbKT2y+Z8z/xpNcq0SYP8MPtpS/4cLs=; b=GsWx/gC+utWM4y3FM5UmDf/N2Yi6LqI1Q+E9qdDmspRlfhrmUO1gLMTtaIHxDWpCFfk9mn WkMV+6NSQv+LHG1vE2yUVWJfqytQfDGh4nbNWuHnn7DYijpnglIxeGrjCJF9SBLXDBAuYj qqDr8WTCv+a0GQ8kG0G1vHstZ++C+vw= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9DC8013911; Tue, 5 Sep 2023 14:10:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ziSTJcM292Q1TgAAMHmgww (envelope-from ); Tue, 05 Sep 2023 14:10:11 +0000 Date: Tue, 5 Sep 2023 16:10:10 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Michal Hocko Cc: Yosry Ahmed , Andrew Morton , Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , Ivan Babrou , Tejun Heo , Waiman Long , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/4] mm: memcg: let non-unified root stats flushes help unified flushes Message-ID: References: <20230831165611.2610118-1-yosryahmed@google.com> <20230831165611.2610118-4-yosryahmed@google.com> <6tne52ip62ucev7nmnim3m7fhcydnwcytyxynrlxxgaf4cbqea@r4hec425izap> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5xl6u4xlnnymxuii" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: EB0DFC002A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: iwuomxa8m1otfo8jdtugz5yw4swzp4j1 X-HE-Tag: 1693923013-880651 X-HE-Meta: U2FsdGVkX1/xOWPyqASETvOngljHn12+U/c0L9/I7/zZmaGkcHOA75VDPcJKUQZcrTsh8CssVwXyg6yUSMnp0ZGSsPE2QimaDNq6/IHW4Shv+kH4VBGbelzRDqPoHjhZ4ED6QgtYxpavnze0iBggKCC2G1VUMNrrkUF3fVNauyHWZwpSCj9ydJ3nJ/sOr3PK+h7Gu6G0fypPjw1e0GA2K+6yHPswiG7qyiPifOp8yvJUtj0owynGWqtIxxj5NxuNeibPpAireOJIP0TVdaauxm39Qbs0Ngyg+1hOuMAVmQdrE0YijXwCDzHpIGn3E1NmIshvS7AYyCvPhYo1JTrKUoq+hI5z5GWleev2tbEWZgm9/AAw6M7f25CjTZYl49Wv4E0ZQM1ggpZ4plWiUcbDdWGh1kK1H3CcTVFKashprfOtbUPyc0S9tJs2d1n+Su9TYFGpHsYWgx+mwQq+Nhw7mFDpqSDmsShlCm2hzJVR4IOnBNqHH2WZRyOuK3lRkNi94W6KOBIkOvVr9hVMsTr79q9RU7Nb4U/WNr4gEqXyXCn50o96utV0vbyzNiVZ7TEftcLZttiIiDZ0qptWyVB7yixwlQNDMZpJW+UHz2tdPzA4lpJ/O2KgaFHKlZ9xvxLhFVgj0X8QLs1VcjBlfOEJkGGsaJwIjRZDuYaBoJGexL+k+fs8ztifiHzFkVd2TQytTdBxRVP1/TetGbEOPc7Qzq1NL8JMlTF3jjltbSLDYFfN3fGbDRW6VQbnR7VC83cwehLRgGTpYxWdfJi1kKF7Vg3F06KoA3cNzZUQAcPpAQO3tR5SE2tt/Or440gQFYDCNP42L0xtRhYJBHDdhx6nZ1tb+2mk2WJ++eMu6AK7uYVawmqietZSUvTNVTbRnP/zXUPWWCuwrbcaPF+PLDybOy3lhMhuM8JRjwzuQZIigWdbmllVPtxH2linENmAoEMvpFyXUUhZs+vsJjdWAvM UWhpTtsp kMtR9u62sfC2IF/eGjWNK+SDIcrlFI3LflU2FFXN57B7PSHBDnN8tC6MCkEXk/ckC5G/1x2sdkqSwD0k/6gJDQVLDroS32Ewggu69ZUtdgaYDTkyPf21jTBgbEINroRXr0dai/ANy/4VienIh8ps4Fm6b5HY6gfF2s6eF8euIB00jjk+xYM0Lpx3wk0DQ6ztceWCqOKmZjbxtwkoxIN83Ns7+JWwwvXSx2rtkJkm19aYiBGoXGln2+31hmM/RIOvAZiXkHai0owDp0QaeVig0gAp27QiwelbY/jkmuHrbng55Yyfi9TbOAsHus7il9Xqa4gOarphdRAvkE/FumBrteUoZeg4NXY5EBiGVvRS+0QJBLXu2/RsldaXTAA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --5xl6u4xlnnymxuii Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 04, 2023 at 05:41:10PM +0200, Michal Hocko wr= ote: > So it also creates an undocumented but userspace visible behavior. > Something that userspace might start depending on, right? Yes but - - depending on undocumented behavior is a mistake, - breaking the dependency would manifest (in the case I imagine) as a performance regression (and if there are some users, the future can allow them configuring periodic kernel flush to compensate for that). Or do you suggest these effects should be documented (that would require deeper analysis of the actual effect)?=20 Thanks, Michal --5xl6u4xlnnymxuii Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZPc2wAAKCRAGvrMr/1gc jlxaAP46l8gRlfACegKealpEqf4LldUZ6wJpB4fTVFaOGIrwtgD8C5FMCJxGkTXl 1GdDHiGP3h6e0MohvE8iIjMLkW8eyQk= =yjdi -----END PGP SIGNATURE----- --5xl6u4xlnnymxuii--