From: "Michal Koutný" <mkoutny@suse.com>
To: Michal Hocko <mhocko@suse.com>
Cc: Yosry Ahmed <yosryahmed@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeelb@google.com>,
Muchun Song <muchun.song@linux.dev>,
Ivan Babrou <ivan@cloudflare.com>, Tejun Heo <tj@kernel.org>,
Waiman Long <longman@redhat.com>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/4] mm: memcg: let non-unified root stats flushes help unified flushes
Date: Tue, 5 Sep 2023 16:10:10 +0200 [thread overview]
Message-ID: <hrpw2bjsrs3pzxympb7cz4nohyeztnxkmdtzbzlfdba6ugkken@dhcdbbbrv4fn> (raw)
In-Reply-To: <ZPX6luPGqypp68+L@dhcp22.suse.cz>
[-- Attachment #1: Type: text/plain, Size: 630 bytes --]
On Mon, Sep 04, 2023 at 05:41:10PM +0200, Michal Hocko <mhocko@suse.com> wrote:
> So it also creates an undocumented but userspace visible behavior.
> Something that userspace might start depending on, right?
Yes but -
- depending on undocumented behavior is a mistake,
- breaking the dependency would manifest (in the case I imagine) as a
performance regression (and if there are some users, the future can
allow them configuring periodic kernel flush to compensate for that).
Or do you suggest these effects should be documented (that would require
deeper analysis of the actual effect)?
Thanks,
Michal
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-09-05 14:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 16:56 [PATCH v4 0/4] memcg: non-unified flushing for userspace stats Yosry Ahmed
2023-08-31 16:56 ` [PATCH v4 1/4] mm: memcg: properly name and document unified stats flushing Yosry Ahmed
2023-09-04 14:44 ` Michal Hocko
2023-09-05 15:55 ` Yosry Ahmed
2023-08-31 16:56 ` [PATCH v4 2/4] mm: memcg: add a helper for non-unified " Yosry Ahmed
2023-09-04 14:45 ` Michal Hocko
2023-08-31 16:56 ` [PATCH v4 3/4] mm: memcg: let non-unified root stats flushes help unified flushes Yosry Ahmed
2023-09-04 14:50 ` Michal Hocko
2023-09-04 15:29 ` Michal Koutný
2023-09-04 15:41 ` Michal Hocko
2023-09-05 14:10 ` Michal Koutný [this message]
2023-09-05 15:54 ` Yosry Ahmed
2023-09-05 16:07 ` Michal Koutný
2023-09-12 11:03 ` Michal Hocko
2023-08-31 16:56 ` [PATCH v4 4/4] mm: memcg: use non-unified stats flushing for userspace reads Yosry Ahmed
2023-09-04 15:15 ` Michal Hocko
2023-09-05 15:57 ` Yosry Ahmed
2023-09-08 0:52 ` Wei Xu
2023-09-08 1:02 ` Ivan Babrou
2023-09-08 1:11 ` Yosry Ahmed
2023-09-11 13:11 ` Michal Hocko
2023-09-11 19:15 ` Wei Xu
2023-09-11 19:34 ` Michal Hocko
2023-09-11 20:01 ` Wei Xu
2023-09-11 20:21 ` Tejun Heo
2023-09-11 20:28 ` Yosry Ahmed
2023-09-12 11:03 ` Michal Hocko
2023-09-12 11:09 ` Yosry Ahmed
2023-08-31 17:18 ` [PATCH v4 0/4] memcg: non-unified flushing for userspace stats Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=hrpw2bjsrs3pzxympb7cz4nohyeztnxkmdtzbzlfdba6ugkken@dhcdbbbrv4fn \
--to=mkoutny@suse.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=ivan@cloudflare.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=tj@kernel.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox