From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B209C3ABC9 for ; Tue, 13 May 2025 07:33:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68ACD6B0085; Tue, 13 May 2025 03:33:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 638DA6B0088; Tue, 13 May 2025 03:33:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FFAA6B0089; Tue, 13 May 2025 03:33:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 32B546B0085 for ; Tue, 13 May 2025 03:33:30 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A51FD81A91 for ; Tue, 13 May 2025 07:33:31 +0000 (UTC) X-FDA: 83437069422.01.AB2F32E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id EB69CC000A for ; Tue, 13 May 2025 07:33:29 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=h1cuC8NK; spf=pass (imf22.hostedemail.com: domain of joel.granados@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=joel.granados@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=h1cuC8NK; spf=pass (imf22.hostedemail.com: domain of joel.granados@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=joel.granados@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747121610; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FAlUnh3YUaSEkSUJdxnFw3mk0yKLCPEkBPynnOwTZ3c=; b=JSUtI1C/A6CJYQEXJjaUhA2HIYVHjd3ZHSylJF+lQ+9Gr9WtgYXN56h7usvCvVNzgnyDDs MSV/6ELw/a4A9XqSb9p/XNwzgl6qRNnuP+nd8rGWl8MMrNr5l3pXZwZqWrrX8Kpyrgwgcr Uaw7nDFf47OcxFSTx2PatynXNMgdcUI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747121610; a=rsa-sha256; cv=none; b=gPFDoRpPCfO0Pim/bYBAi3dtOo7ega7AJrtZh/DKxiKDRspZ56DWBWhEnbifCxiW5vxial Q0xJ4XVRWBoQESgxwlpArF1DzIswjAajDKLwwoBC5v/JmEITZBRbXNKJ/fzPs8Y0Bov/zg 5KZq5klOXPxPnXsmQpPXkHA49AEWff4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id ACF555C5E68; Tue, 13 May 2025 07:31:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38272C4CEE4; Tue, 13 May 2025 07:33:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747121608; bh=oydnFwFzyvTFZLytjGu4FLOFoRfASVhdPt5sskdlZPs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h1cuC8NKAbWGk5N4z9eoNPIQ6NBkZHWfTFBOMG6WcDqpnNYaelJWfkZf82BqvkDSl P/SajPouty4fKsU9symCU24kVd6HIGfDEqjl8fysrHGn06p2mqEb6M0ny0gYBoxxBk KeV2K9sjGbcqfaahL5nhnRXWUj06irpfg80ARwqSV7eG2SqwwBAwTjvK/K/HmYNC+3 ClsSUW2zxuP5+BIRP9Uh8Sg+1e8cC47UVPi/e6Hv3UN5bc6ttmhPXS1uHrb7nlx2Hl 1bxJvfmr+aeiyc8BpGfu5tpnm9UEP2MWYHDM53CjBoe7hXKGFQZU+2v+E1qoSj2UG6 EapmAmIgZLQyQ== Date: Tue, 13 May 2025 09:33:23 +0200 From: Joel Granados To: Kees Cook Cc: Luis Chamberlain , Petr Pavlu , Sami Tolvanen , Daniel Gomez , Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , "Paul E. McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Uladzislau Rezki , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , "James E.J. Bottomley" , Helge Deller , Greg Kroah-Hartman , Jiri Slaby , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, rcu@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH 09/12] sysctl: move cad_pid into kernel/pid.c Message-ID: References: <20250509-jag-mv_ctltables_iter2-v1-0-d0ad83f5f4c3@kernel.org> <20250509-jag-mv_ctltables_iter2-v1-9-d0ad83f5f4c3@kernel.org> <202505091200.FC2683DD@keescook> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5fouo2tqrgcca44q" Content-Disposition: inline In-Reply-To: <202505091200.FC2683DD@keescook> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: EB69CC000A X-Stat-Signature: 6omdqtqcs1jagz4sa9gqqctnpu785waz X-Rspam-User: X-HE-Tag: 1747121609-543455 X-HE-Meta: U2FsdGVkX1+vWRESmnm9gzWAiSdTDQ65EIZTlKeth7ju7O2lY/4QV7a/JXLtW6dqYp0svrNG2vyqrpejLs7Xk26K016SCY1CJFjsQm2BYybPqg6UZonF453AC0QauTzKoGmyJJVOTvFPVzw66qooIbaxBAoIWA3wAiQ2PXxa8Z0PW69VNnPpiShlZXL+jXFbn+N6kLDbdIRETwW9JT5KZlAVEDlbhUi9C7wUav9K15urXSGnBB/Gz7Kdn9SQiA0cBipTMam7jEvbmQGdv8yPTLjMzYqKSu3SaIYRgKQXlJibiHZtVr1rSumo9C4ZSEwQuwJmOC0xf+9TFSWH1bpIv1irfyZ+6RnsdOVgnHW8OWf6KMx/9ExyazFciFeLzkKF/dFPZQ3r5QWufS33WfmvXWgWcNS8bbQTdY1RG76/Qgy1La80htJi2EcqGKXMUmwPJXZd2I0SW/Nv6aXF6+FJqQsimt433aZXNkgBP4Jl2NRpJQNM9pvVPWUwL3zuR+2IGyOENk3Ife9ZFCyYEf5njNzVcJOL66QVF64qNKw7SU1g1spwJDgFWTxpMaS8WB2MElQaZnahDXtG7kqI44ZI5fX95eqzbcASDUMOY8mHSxbN9WF0AISht75iSKgwGefL8kh+ahi7nSrUCvnpLzkoOlEtOSNp9BVfVIVK2IcVw5T7ec+Z/kC7LEQ7QQlTQ205Lh23ry8Blgf7zjfOpqVVnpcA9ASwRi1/pJ3KDQahMuVMotlMZE1U8mdtk523WBlEeAAby+c9NB45kdxE2ok8/LPX1U8WlzlKGSYZkasO5iraK7Am+9uXynE1OYUvXvAalHp+jk834QiTHwTkHJIjtKE8zaDw5yLbJ2hKkXwQFwUVzLBRCstdVEgC4wfmHdqpGsjg8ik1Q3/Qdgy+5DLveMiF6QSa5gU+AvEtcqoO26AtV+UxeHNUjjYuNAhBxRZqMVJ9Ax6v+QCD+i8Un0S FyEeNJ01 HwEIbJFyoP6HRapvZyw4B+YilCMsbTy4dahhwR0o3EQ6xLJm9nPFxeR2TTWVRr4lDjJ39tRYIWY66nSw4b6TuR6zdi3oy2mUzVmduTShtJm5UYtHe9bza8oOmYCejV3fN7CIvjeeGGgkSLMDfSezpaGK7CDAwYc6R7h5vkLhud0DisPiPORl4fg0lChlrM/QpmPKPJla8WESo57nONCBXBzx4jgImH0BQyE1i6WkLd3xkOufmXrAnBB0b1dxyiPvb7ToNNi+8RAqBQz8mn7iwXFv4gfBHvr2kUGxePQsPh1fJ3x9qh/z9XSGyavGwjjZXkPW05xed5Q+O/j7c6ID7a7OJpmX9klqf+B+GCYPJhnTPAsMX4m1vEEpmzrcFv59Iy7L92F+rz2NUtJFl2n5/csAuR4Ni5k5WWD63ZpKtU2QmmTF7X1cwCMgXjrIqA5LptuTfT9myo13gjitygcuf5HJW+Wuz2keG3Sa9c5HR0Rf+RjLyHQ9p5CcdvA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --5fouo2tqrgcca44q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 09, 2025 at 12:01:24PM -0700, Kees Cook wrote: > On Fri, May 09, 2025 at 02:54:13PM +0200, Joel Granados wrote: > > Move cad_pid as well as supporting function proc_do_cad_pid into > > kernel/pic.c. Replaced call to __do_proc_dointvec with proc_dointvec > > inside proc_do_cad_pid which requires the copy of the ctl_table to > > handle the temp value. > >=20 > > This is part of a greater effort to move ctl tables into their > > respective subsystems which will reduce the merge conflicts in > > kernel/sysctl.c. > >=20 > > Signed-off-by: Joel Granados > > --- > > kernel/pid.c | 32 ++++++++++++++++++++++++++++++++ > > kernel/sysctl.c | 31 ------------------------------- > > 2 files changed, 32 insertions(+), 31 deletions(-) > >=20 > > diff --git a/kernel/pid.c b/kernel/pid.c > > index 4ac2ce46817fdefff8888681bb5ca3f2676e8add..bc87ba08ae8b7c67f3457b3= 1309b56b5d90f8c52 100644 > > --- a/kernel/pid.c > > +++ b/kernel/pid.c > > @@ -717,6 +717,29 @@ static struct ctl_table_root pid_table_root =3D { > > .set_ownership =3D pid_table_root_set_ownership, > > }; > > =20 > > +static int proc_do_cad_pid(const struct ctl_table *table, int write, v= oid *buffer, > > + size_t *lenp, loff_t *ppos) > > +{ > > + struct pid *new_pid; > > + pid_t tmp_pid; > > + int r; > > + struct ctl_table tmp_table =3D *table; > > + > > + tmp_pid =3D pid_vnr(cad_pid); > > + tmp_table.data =3D &tmp_pid; > > + > > + r =3D proc_dointvec(&tmp_table, write, buffer, lenp, ppos); > > + if (r || !write) > > + return r; > > + > > + new_pid =3D find_get_pid(tmp_pid); > > + if (!new_pid) > > + return -ESRCH; > > + > > + put_pid(xchg(&cad_pid, new_pid)); > > + return 0; > > +} > > + > > static const struct ctl_table pid_table[] =3D { > > { > > .procname =3D "pid_max", > > @@ -727,6 +750,15 @@ static const struct ctl_table pid_table[] =3D { > > .extra1 =3D &pid_max_min, > > .extra2 =3D &pid_max_max, > > }, > > +#ifdef CONFIG_PROC_SYSCTL > > + { > > + .procname =3D "cad_pid", > > + .data =3D NULL, >=20 > nit: this is redundant, any unspecified member will be zero-initialized. Thx. Changed it locally, but will not resend for this. >=20 > Regardless: >=20 > Reviewed-by: Kees Cook =2E.. > > - .data =3D NULL, > > - .maxlen =3D sizeof (int), > > - .mode =3D 0600, > > - .proc_handler =3D proc_do_cad_pid, > > - }, > > #endif > > { > > .procname =3D "overflowuid", > >=20 > > --=20 > > 2.47.2 > >=20 > >=20 >=20 > --=20 > Kees Cook --=20 Joel Granados --5fouo2tqrgcca44q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmgi9bkACgkQupfNUreW QU9gYwv9HmmGGJZHXMl5xZnY6+FsJWyyJPwiDmBpHKqnKUS42gx1LYy2Q2iMzgFt YcxKJxmpLBMq0zNs1c7WNKOBf/3YXplkC/1ZGQPADy/fPhZIqjoZgE9IY7rlPuRW ZqHGdVvpT6hjyjx9buwt+BAt7LbMZFrpH+KgqIy27NUu6icIQiZv5p1QTqHW4/MP mwk0aJcMZnCExOxBdRgKDzhiQRnKFgDZcbM2QeOLuuPZsLA/rPQA5UxlnXVGJ82s 1bm/UR896mg8Ziq42SuV2yl9S4cT/mNKoNgxTtVAOrNYajc5mcjQPalvDCitBQTk L9ieGsR6I/+jYgJVCoc9vHuYkJuX7B52HcHH2rC/9bmSKqr1ea7xFcG7eA3iViJz rQzlj+z9wxfi+81TJSPXsUZmFkFhKXaZNQEgt7rhjtwiv2aafkFpOp6vN7dlrkrW OyvLd59uapsslRXXBAlyqMbnHEhg69c/Pqk5bup1Cj5WU4zhK2OmMk3sR2Vu80cD /fMGl+l+ =zOoe -----END PGP SIGNATURE----- --5fouo2tqrgcca44q--