From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8296C3ABAC for ; Tue, 6 May 2025 13:35:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF5486B008C; Tue, 6 May 2025 09:35:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B7DE86B0092; Tue, 6 May 2025 09:35:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A43FB6B0093; Tue, 6 May 2025 09:35:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 81E8A6B008C for ; Tue, 6 May 2025 09:35:03 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8796E1403D3 for ; Tue, 6 May 2025 13:35:04 +0000 (UTC) X-FDA: 83412578928.22.ABE7A72 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by imf14.hostedemail.com (Postfix) with ESMTP id DF002100011 for ; Tue, 6 May 2025 13:35:01 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=fXb5f0XZ; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf14.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 198.175.65.12) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746538502; a=rsa-sha256; cv=none; b=Cp2RGlSss6v0qSinNmRsrxgWgrxOE3/BpRR6Le/YyrS+aO16kMV2xL4Ywguo3mwk+t6tYb h776O29mgdD/4QyrJoKff5G0HFGlSaH0jJ1s1ekZy7cGxhKRj6azVsDdaP31S3AaX+H5i7 lR2ySjEQHCHBZir/UNH0iMlGL5GoFfk= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=fXb5f0XZ; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf14.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 198.175.65.12) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746538502; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DlASEFhi1253zM1EudNtv5uHpIuF9pfCHYWwnRC1YAE=; b=dnUuVkWcl/ouu1EZ/h7+X/JrNsegCcltIJG8Fdfq1wL3pRXtR1VAln9NO+0RsNfT3MRhra GIe1Rq27Z4CAPfPkzmrQPzvH+Fn42up/widzL8W1YjCGqJq1SIaZV3KpIMB1TiSk5cSpnh Wd77fN/wVa8yrVZ1K76Lb0e7LB31P0I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746538502; x=1778074502; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=2kMQEO2OriJkGJpX55hEsYnmu+hvezoN+vmiLvl+mpU=; b=fXb5f0XZcOzNRc3qoGQd85FaEbcxqNUq2VsaQbAXmOizyxScQyr1foaK smpjxM6uCiky8u7TdpVAGuFd84DwH8BYN5IckL9ir0pfBIIQZsn21Jz4/ H1H8Ks6rhXzaO4mLk6grH0Ujbhmk3GOcuQAuLNWiyWyinSQAtTaVe8MDq VPTyKiu0sRjVg6sNW2z2GFfmAMIkQMWFShs2QhsE+B8OSJT5EyylFJicj 77UH0eeABbqUu03Y7AAkBmkTPkJj3a05pvwYiU7DXcU2yCYxeZuOrTPxe zpbT6hoW54ZNuKv7VT+oRl+ar5uVzotM521ifXcQ0ZqmOvULFXFjJMfso Q==; X-CSE-ConnectionGUID: V4tDDjimQfyAcYk2LlEIIQ== X-CSE-MsgGUID: mn/Qv+/USs+lKQPgn7rcYA== X-IronPort-AV: E=McAfee;i="6700,10204,11425"; a="59597951" X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="59597951" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2025 06:35:01 -0700 X-CSE-ConnectionGUID: 9ewK3vwlT7GxsMFqB+rx2Q== X-CSE-MsgGUID: lUjOG8a8Qg+oFT5g5xbqFQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="135503705" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa010.jf.intel.com with ESMTP; 06 May 2025 06:34:57 -0700 Received: by black.fi.intel.com (Postfix, from userid 1000) id D5F4C172; Tue, 06 May 2025 16:34:55 +0300 (EEST) Date: Tue, 6 May 2025 16:34:55 +0300 From: "Kirill A. Shutemov" To: Brendan Jackman Cc: akpm@linux-foundation.org, vbabka@suse.cz, surenb@google.com, mhocko@suse.com, hannes@cmpxchg.org, bp@alien8.de, tglx@linutronix.de, david@redhat.com, ast@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm/page_alloc: Ensure try_alloc_pages() plays well with unaccepted memory Message-ID: References: <20250506112509.905147-1-kirill.shutemov@linux.intel.com> <20250506112509.905147-2-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: DF002100011 X-Rspamd-Server: rspam04 X-Stat-Signature: 7f1xsaaxo6gsc98mj4i95u311te3j1sj X-HE-Tag: 1746538501-366602 X-HE-Meta: U2FsdGVkX180++1p4joH6ksDcpmuWIW6pzrd44cw1rDx3XmERYR6DkjoMbl6T/x0RlAmMS0gCDZXDBrZQeUIVSySHCM028miUMQIzp47/7Ur6ksk9EAlI4CEDg+zwr2T2idt+8gkrtm19K61wdSenXsjeOUngczTdO5Y96wuqDRIvQ3d2kWom9AJE0+PcwK8I/1th1aHgWAxnfqsrPHcUr+mzYLjE7m8WfHyZ1ExbY7VEzbHNlviKf4pPXa5rD2X0DveacMCKkx95DygX22MN1RsmPVSqmqNmCt+KOx0pkKM70EhNrJoYCn7BJxMtKkXHHDWQI1xy5mk6ymENAflOlLTxWmptp4Osl4EsKKLgrz3GlV22YH9oT1o8d+CAsq+7rWGJCtJA54J332TgcDz7AB1lZ/BjwrCpsRuyvBa9xiiWEyPorNJCpVyxeSTXzHNJA7qFC2RUntep/uhiDdYMV/P4TsqwQ8wzQv9ihxQeU2eC4wUa6tPRbJTgkZh2fyWiHqHLrUqrgkT18fTeIHZReqFceWGpw010m1SVzKveb7qVF0rhaIpNT4oq6CWHk4Hx0/AE7i954dBmsV7IdNhdygMh3bWqVFQEq8SIh3EDpnlJxE5PDoLFFaigIvYLM1sYjUY/YHNMI/JacGuT+e8kgO6GNbG/fR9sCVtJBkQWcoxygUovUBZ78pd/gmE7SoA6sJT8pKwLwNjHgB6mDbd2dH5WOqArK76B+oZF6ZmmyqWlK4WjEZSbc1hhgFkXrYcC0lJEeNN5Szkr4pmCRQJX0FEaf6d+m+wbBc2nAEy1Wb5TQy6z+NIdOHdJEvSVbqo59i4ukhRVNbDu9bWHi44hZaObgznRSGQEsQOJQKwDzaNn5bp3E0cRVEk235ANTtQTJj9ht23yqHdrI0/S50vEykL2Gx1iN+G9fXVbhkpg5n3miAwkJhDWSn7E7LRg7n2Ovp5QBw/GjyB+/ekBBi sbmly2za DRRZGFAeG7baczgpwfXQBYkp3LhAbOGYENeDZRZSFd64SxyQX4SQu+QfCjTRTdh19YlXkjra5Z4BO/6adQIGpaICIZX8g+ZBFfJxkPCDUmeFWli5Zfou3yT4mLKjnC05JHinFCpzr/2Gzp1hiYiFqbmlVcGOHyVf//nTtmR1HpCPKVYxnIkgFwXJVXjNtin3fu8WqJ1i3GfEPjvtY0LOrY4wMJQ43VuMfSMy9cd5dg3DVltQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 06, 2025 at 01:20:25PM +0000, Brendan Jackman wrote: > On Tue May 6, 2025 at 11:25 AM UTC, Kirill A. Shutemov wrote: > > + /* Bailout, since try_to_accept_memory_one() needs to take a lock */ > > + if (alloc_flags & ALLOC_TRYLOCK) > > + return false; > > + > > Quick lazy question: why don't we just trylock it like we do for the zone > lock? It is not only zone lock. There's also unaccepted_memory_lock inside accept_memory(). -- Kiryl Shutsemau / Kirill A. Shutemov