linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Shakeel Butt <shakeel.butt@linux.dev>
To: Suren Baghdasaryan <surenb@google.com>
Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev,
	vbabka@suse.cz,  hannes@cmpxchg.org, usamaarif642@gmail.com,
	rientjes@google.com,  roman.gushchin@linux.dev,
	harry.yoo@oracle.com, 00107082@163.com,
	 pasha.tatashin@soleen.com, souravpanda@google.com,
	linux-mm@kvack.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] alloc_tag: mark inaccurate allocation counters in /proc/allocinfo output
Date: Tue, 9 Sep 2025 22:18:10 -0700	[thread overview]
Message-ID: <hp7kdpo4wqlyge2mjivfieibcfxu2jxestrqfwll27v4gsoqja@stvbcth6zc5v> (raw)
In-Reply-To: <20250909234942.1104356-1-surenb@google.com>

On Tue, Sep 09, 2025 at 04:49:42PM -0700, Suren Baghdasaryan wrote:
> While rare, memory allocation profiling can contain inaccurate counters
> if slab object extension vector allocation fails. That allocation might
> succeed later but prior to that, slab allocations that would have used
> that object extension vector will not be accounted for. To indicate
> incorrect counters, mark them with an asterisk in the /proc/allocinfo
> output.
> Bump up /proc/allocinfo version to reflect change in the file format.
> 
> Example output with invalid counters:
> allocinfo - version: 2.0
>            0        0 arch/x86/kernel/kdebugfs.c:105 func:create_setup_data_nodes
>            0        0 arch/x86/kernel/alternative.c:2090 func:alternatives_smp_module_add
>           0*       0* arch/x86/kernel/alternative.c:127 func:__its_alloc
>            0        0 arch/x86/kernel/fpu/regset.c:160 func:xstateregs_set
>            0        0 arch/x86/kernel/fpu/xstate.c:1590 func:fpstate_realloc
>            0        0 arch/x86/kernel/cpu/aperfmperf.c:379 func:arch_enable_hybrid_capacity_scale
>            0        0 arch/x86/kernel/cpu/amd_cache_disable.c:258 func:init_amd_l3_attrs
>       49152*      48* arch/x86/kernel/cpu/mce/core.c:2709 func:mce_device_create
>        32768        1 arch/x86/kernel/cpu/mce/genpool.c:132 func:mce_gen_pool_create
>            0        0 arch/x86/kernel/cpu/mce/amd.c:1341 func:mce_threshold_create_device
> 
> Suggested-by: Johannes Weiner <hannes@cmpxchg.org>
> Signed-off-by: Suren Baghdasaryan <surenb@google.com>

Acked-by: Shakeel Butt <shakeel.butt@linux.dev>


  reply	other threads:[~2025-09-10  5:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-09 23:49 Suren Baghdasaryan
2025-09-10  5:18 ` Shakeel Butt [this message]
2025-09-10  6:25 ` Vlastimil Babka
2025-09-10 14:50   ` Suren Baghdasaryan
2025-09-10 21:02     ` Usama Arif
2025-09-11 12:30 ` Johannes Weiner
2025-09-11 15:03 ` David Wang
2025-09-11 15:47   ` [PATCH " Yueyang Pan
2025-09-11 16:00     ` Usama Arif
2025-09-11 16:18       ` Suren Baghdasaryan
2025-09-11 17:25         ` Yueyang Pan
2025-09-11 17:35           ` David Wang
2025-09-11 18:13             ` Suren Baghdasaryan
2025-09-11 18:51               ` Yueyang Pan
2025-09-11 19:59                 ` Suren Baghdasaryan
2025-09-11 21:31       ` Andrew Morton
2025-09-12  0:25         ` Suren Baghdasaryan
2025-09-12  2:02           ` David Wang
2025-09-12 10:52           ` Yueyang Pan
2025-09-12 19:38             ` Suren Baghdasaryan
2025-09-15 18:31               ` Yueyang Pan
2025-09-15 23:04         ` Suren Baghdasaryan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=hp7kdpo4wqlyge2mjivfieibcfxu2jxestrqfwll27v4gsoqja@stvbcth6zc5v \
    --to=shakeel.butt@linux.dev \
    --cc=00107082@163.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=harry.yoo@oracle.com \
    --cc=kent.overstreet@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=pasha.tatashin@soleen.com \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=souravpanda@google.com \
    --cc=surenb@google.com \
    --cc=usamaarif642@gmail.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox