From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F26FC282DE for ; Wed, 5 Mar 2025 19:09:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 15847280016; Wed, 5 Mar 2025 14:09:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 10BF8280004; Wed, 5 Mar 2025 14:09:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1509280016; Wed, 5 Mar 2025 14:09:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CF38B280004 for ; Wed, 5 Mar 2025 14:09:14 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6318CC0352 for ; Wed, 5 Mar 2025 15:29:46 +0000 (UTC) X-FDA: 83187882372.13.CCA188C Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf07.hostedemail.com (Postfix) with ESMTP id 69F114001B for ; Wed, 5 Mar 2025 15:29:44 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=ZkFx7Dja; spf=pass (imf07.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.171 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741188584; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HJupkM+49yv8MwK8wcb6WNoJ1NpGq4LlpEvaQpfLjVU=; b=b/Zn8+v7XLTGsOjtPBPV0zKLYG7tgMQwgEKajO8LWKZvCQbPPSJ6UEac895w8qk5Rm2Iag Xg4+MsUhVho8heCHtK7h/A81H9MDWgTMyeSpN/LfiUzaGGuNlkDIL6xCKadTcfMYU5pGHH 6Nk2oaBYU96r5LvkU45Jp7nQ8/inzqY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=ZkFx7Dja; spf=pass (imf07.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.171 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741188584; a=rsa-sha256; cv=none; b=o4XQ1seJNE3Dx0CUjndr/c31GSGUiu/K26uMMu3dpJedisnMnHmjSIcHEQl9Cg7HefcSHf Yzb8YjnELcrcFM2jgn5K7uDIHyAV17uc4PUi6n9lVaN/X8zT/0u+dYrUZAndzVNBaVnfu8 Kud0FZUb14MbRQyQ1e9YfS5RA/NHKlI= Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-224019ad9edso12211075ad.1 for ; Wed, 05 Mar 2025 07:29:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1741188583; x=1741793383; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HJupkM+49yv8MwK8wcb6WNoJ1NpGq4LlpEvaQpfLjVU=; b=ZkFx7DjaGC+GeUpwtQxV75mAXQzaoFVpAEGEdDJTsc3GTjLTExVX9xb+O0csvf64AY s+riYGHQkMv+w4VqOpsPovEBviIG07ojG15VGE0t2An7HMN57y/cpLrm7KX9Fqa3cZtC KBJqfbIBtaqPfZAknajH5m2Mwl5WomTNesAiw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741188583; x=1741793383; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HJupkM+49yv8MwK8wcb6WNoJ1NpGq4LlpEvaQpfLjVU=; b=VxCy3PbXpVinhQ/NivmXoB/KBE8VJ8FPQ0ggKwt/4kd2/PxmUB3UwrtjFJMxSDmOCV l6ALg97oj8XeXt3tHQW0H2yI1zdnAn3mjPAMPyGizRPu6Y9F7YM6Glk7Y2b6s/R9wo+z pavk4HsGGS3sNN7K6PTa7UQdAI3ewr/d7hO+SMeioNQesy2JgqsobWSaP4EZJBLM4bu0 BH1CH1Ks7rCJXiKYIE354diRK346nFwLdijqPNQJ/ZsRWJ4hzB/f+Ec37Mut4EwutynY cFXOxS7ByfXrfxClUYAS8se6arntwHqKVWn/kmVFwDThydKVIKOHjrFWQeD+2Yy3OsRC 7lXw== X-Forwarded-Encrypted: i=1; AJvYcCUNwZxM7wYWxnKOAPDKab3A65TEDgkpEf6icmwlKpLWromRDCTj4a8wrLpZUMAp9kwaVNqfMJLjgQ==@kvack.org X-Gm-Message-State: AOJu0YyRwBaEIN0z+SqSKNW8m1cdN5SSssw1/fv1720KmZOVrqOqIY0F rZu9BWt/I2+nxZDEvIVg4FIWjzFaGw6Nn++o8bcAEmoDLjGsT2pjzOisepX/Tg== X-Gm-Gg: ASbGnctgGUMV5l+hQ8ZIx5WKJ49qkMydSZ73osvtA9ozG1a/rV3Z7rQUTAaB/vnbBpv vIJ8L/1e7SAdv5ZL5V1OlQMfi6EslPsy+mUqI0JMeR2Qa9JvKGpcriOZReCdIGq83IeqFLEvz52 W9yGFtrBoHCiwOeAAiUKv0tjTHRPZfUTFqtWhMgCBtA5iFtM5yDHD3VaHrBupMMY2b7B6vX3ik7 ygHZSzL7xJJw4hx8v/tjHerra4xHRstMHFGrDw8eaCVAPwrSHg+tdyqCrTw56RGslbJk8WDeyGm 9N3VcRcYBNGia26Vc6eFfCplpOF8asJfog0SHMBUquwUWWM= X-Google-Smtp-Source: AGHT+IHlNaCE6Hu5QstTVt76LsHlgPtKPgJoDodoeCDDsIrWsN0DOA2kft0VN0kYtpvgulqgypLrVw== X-Received: by 2002:a17:902:dacc:b0:223:501c:7581 with SMTP id d9443c01a7336-223f1c985d6mr55423855ad.16.1741188582954; Wed, 05 Mar 2025 07:29:42 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:5a4:b795:7bd9:7ab7]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-223504c596esm114569435ad.152.2025.03.05.07.29.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Mar 2025 07:29:42 -0800 (PST) Date: Thu, 6 Mar 2025 00:29:37 +0900 From: Sergey Senozhatsky To: ffhgfv <744439878@qq.com> Cc: minchan , senozhatsky , akpm , linux-mm , linux-kernel Subject: Re: kernel bug found and suggestions for fixing it Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 69F114001B X-Rspamd-Server: rspam09 X-Stat-Signature: a49tt3uphq1bo8g98menkruun7tzjccd X-HE-Tag: 1741188584-540169 X-HE-Meta: U2FsdGVkX1+K+qkVPDD1qInxh7O7TpXFjmiitXqxGFM6b4Dmw3mJ0eucxGY8zjRWrvhwEaYTLJxFlEYECwqUbNqcpfQIvcTbFmLD4b3BATeJiCpI4TLYw5etJbhGImqK3oJ32Hgw0BeS5/5mppyyoQ2f16nJFb9Rmqt0nanEMV2QZJxguspecgkA0TPsk8PcLqZrsPD+o2qxlUx1NIpHNThoH9Rj34lZQ3A5gbBQJzMMuNelvTvfJT/of6M27CBDvO5y+g8SdyRJK9d0NSXrNZoYDXyKWILpiu77x2wXplyOsiFtea9OT4UQCpbhz919aU20EVJ5vG38KcmpxDqCwks9EGQCcroKTR0V7j5/e1yOj8gzh5nBeFf6xwZoWklDAxmzB4FfX+JexfGCKrDn/fU9dg09egwOkk9QnUc+FJzlVJ1GfndlolCTkF5blfN1NN5q4DQQZVoZRj120Jx/jpQrHw3QZXeWOtZ0ukgV3zg0oA9y2sj2Uh0XgiydrHK233CP0BoRfRPSio3QMAuslsJb+4SW6QZC0gFHh4VCTltzCRpAORMvnW1eYepG+CspkjRZngtGwlTdn+us54IJ3oQN8POpwQahTGN7/0TrOXYty7hEaouplqFcZuumwX+tD1qA3YS2UKHYugrGGQXL1xzCbjiGOmUOLhjTkWnK43NnbQhEWc0GHS+e9diK7Uxcx3yLMPHO9+q04x4WIkzUIdCytwJTcyxGu9nuqlr5A2iR8mRd3oxRgMIDg3c8AMkD1t/Ta1V+1wIBh9fbsK3Fk82iTqzTMIyTb2zcLQtbstJr1bw7g55OJ8HrhAZmq2yR0CbOo7XCVsFaIFup6CDtuFkHGGQrAABUdobLChP2eXgE6YsebtxqodKkcjH5opq3XBegZLUEzO9yz5WzeZI5+Q+Inx4mPs+yqAdQPMYvCbvoHpnzHMSMQ7+Hzsp8vBpPnrrDJWkT2Q8jXD6sE/+ zz9rTUBs 2wUaKJZh+haunO73O+P360WutAF24hPieiGoLchyVvW5bFJJ9HrkG9lm1ofpNm+H5HljAp2wm8o7ZzPk+nyoeuWfsMgRLzAzM4GKnfQA37GTGwaXXHTuPZ/9hvQBKFq3ZJtsJc7g9CVDP+eapfjtkFvJpoUQLrb/yItaQBvXHPetHt9iFSCxq7hzECyjEZgqvu4ylT+3rqs1Mpl0FS8tXVR4lu8a+CIdCZVVaHq2H3WCCwtvvkLYmyOlSrDyoxsRdXEBLmDq0xVwCQt1K4leWKXE4HHSGmuGuQHkAbiboaYGEMVUVIEyXl1Qr4m53phkgE4D6fj8yiqXbAx+Sfsa76sR1SmmPDoMH/OcE X-Bogosity: Ham, tests=bogofilter, spamicity=0.204247, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/03/05 09:49), ffhgfv wrote: > Hello, I found a bug titled " BUG: corrupted list in fix_fullness_group " > with modified syzkaller in the lasted upstream related to ZSMALLOC. [..] > static int fix_fullness_group(struct size_class *class, struct zspage *zspage) > { > int newfg; > > newfg = get_fullness_group(class, zspage); > if (newfg == zspage->fullness) > goto out; > ++ spin_lock(&class->lock); > remove_zspage(class, zspage); > insert_zspage(class, zspage, newfg); > ++ spin_unlock(&class->lock); > out: > return newfg; > } fix_fullness_group() is *always* called under class->lock. zs_malloc() calls it under class->lock, so does zs_free().