From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6D93E77184 for ; Thu, 19 Dec 2024 15:44:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 655446B0089; Thu, 19 Dec 2024 10:44:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6049D6B008A; Thu, 19 Dec 2024 10:44:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F33C6B008C; Thu, 19 Dec 2024 10:44:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 309126B0089 for ; Thu, 19 Dec 2024 10:44:06 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CFD341C849D for ; Thu, 19 Dec 2024 15:44:05 +0000 (UTC) X-FDA: 82912128642.10.0B7C00B Received: from out-170.mta1.migadu.com (out-170.mta1.migadu.com [95.215.58.170]) by imf23.hostedemail.com (Postfix) with ESMTP id D23A5140020 for ; Thu, 19 Dec 2024 15:43:41 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=kFBaxCNY; spf=pass (imf23.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.170 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734623021; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7g/PF04FsAPs2GzOKqJJ1GMhuC0DMBMF8FNWeAiFFPk=; b=ZTWREQOni5COqMW9wiNjbIw6q95CPB59KoNRePPnlulPXdkJwfsE2rqknt2IAyxf5mDUEp cJlfKkYEriMbPD5gyiB0JLgYgltITP4sTRG1kRWWQiDDA30Ak7DTZs02rSOmP/8SbaRWLr YNuFz0mZCsXR/G/NXDWBe/a7Qddyh7A= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=kFBaxCNY; spf=pass (imf23.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.170 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734623021; a=rsa-sha256; cv=none; b=h5Qs37ZTWmT8T/tSW8CzYgHDDd8sh7M8RF9qdamhgTUO5dwsIlyeMzN2YAFuyRlspPSTEa L7aTvRnV0uRc52oWxI0LtLfZonmKwcvMDdFzbyddztS3Vc7CmaglKtxAX/thT3lAnIH+Wo 4uX3qYERlajGnVnPk5P0Hxn1pP/mx3w= Date: Thu, 19 Dec 2024 07:43:56 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1734623042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7g/PF04FsAPs2GzOKqJJ1GMhuC0DMBMF8FNWeAiFFPk=; b=kFBaxCNYE5umwjL8ZWMQqcdXKESsQOP9fus8r4bTmlZYBrIfLRLDDrp1QJJN2MnWG9ce+T XbbZmLqpn6pdz1VN0dX9iu8Y8r1n/jOeQMqY2+TM+y9Z256+LiSr6KqebyHdoPDCdejL/x lOct0DX+44+A84dXzWDVv9HEVuN609E= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: David Hildenbrand Cc: Joanne Koong , miklos@szeredi.hu, linux-fsdevel@vger.kernel.org, jefflexu@linux.alibaba.com, josef@toxicpanda.com, bernd.schubert@fastmail.fm, linux-mm@kvack.org, kernel-team@meta.com, Matthew Wilcox , Zi Yan , Oscar Salvador , Michal Hocko Subject: Re: [PATCH v6 4/5] mm/migrate: skip migrating folios under writeback with AS_WRITEBACK_INDETERMINATE mappings Message-ID: References: <20241122232359.429647-1-joannelkoong@gmail.com> <20241122232359.429647-5-joannelkoong@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam05 X-Stat-Signature: am3t5hxmsqcjng34miupxiyt1oa6wh4r X-Rspamd-Queue-Id: D23A5140020 X-Rspam-User: X-HE-Tag: 1734623021-75331 X-HE-Meta: U2FsdGVkX1+7oYfxBElDtBzP7+w8xPV2c4pbtAC0MJQqkcNx8BdEIC+aZaAHiTtTUb3np5xkhJt1jjfDT6S9cAgHyMG2Vj++Vq625zXIvrcFbgdUyD+9GJSiqEUC7+Xd+ge3bbxdV4pc03WjGxW3UnNPiVudn7CxMJazHa7wjhp5UzA2k/xW1xl/UlcFEv9HCtuqc7FWj75x3wJRcN0pdaRGPbZn0y7+lqfglizt1CcF+5DC+LupLW5g3q8EAlUpFPs2xyX7id5W/FO5WFI34+u4f8MDUhSMt8iWNndudHVJNO5sKgJmpreHNHks1bAKW4AM2awoXhSXnF1pwPKXpYVibnjz7NvlKpKfn65Vod8CaoksKSjJPYJiiEhfes+qbX2i8S+4qmGPgQqdVVdD25bry7yGTq+VbtQ+YOPzvTW3tZu+Czn1tqh4wBW5az6bXEZD6v+uAQT8SdWk1t56RoytwpAV/s2+OPIML8BMdidvGLxWTL3qQYuW8cpYFrXwFKwRXPpJJze11gg130K1jP2Ess3Zu2O2z3tJLjxEmbuF2ZBTfVccQ9DPW+vfDtQhvS74sNLVKQclql30HVFkC8y9rNQHztnbeUATnaXkXadUti7laxDO1oFq0aqY8Q4KqSlHAsBv/MigLS09hVWUCpuo4qqB2ll6TaaKgO8kVAI9AXC0qksnSU69ocbkpNDHPGOK+upUlRJJGVfXvoo5SgpYDTmSNMlmh5Kh37Aj777jxXPW7SQbwgks5dshpcxIxExfBhrOU+YH1kplz7QRGq0uADndZ7pCVy0vUKHh4z3BBr+GfQDWQePS/hfSKXT9XLkRuGq8Pg70EYNicZw4nGt5seIfnkkKWtEB1mai8o2F4eE8Xd0AjOeAXYVn3di0r2AxszoKsZ3lnJeOwswVoTHYfHpLGtMMq9jjCZCluvuet4a5uLnaUCJ2GnxXCzi/yh7Bh6WlSs2uIBf/tr9 hsKxIcXX 7mmiF+FhwWApOrj+xyb6yISrcDyBuzJ8qCPRIOBf1mHOQKfsFvD+bIucc3nl9zIOCraIJHLySj99NSTq6kn5s61u/4cOZkRbJ6DNDIvVNs2n4Z3ugPBzo6WMkpNxEzNk4Lb/+uHOQ2bKLIJF5Y0FyoaaaC/KiYfkD6opH4Mob5NFXYj4DOkJ89uqVZC/n+X0EKjeaY/gBNH0b4UzZ8azyP6556w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 19, 2024 at 02:05:04PM +0100, David Hildenbrand wrote: > On 23.11.24 00:23, Joanne Koong wrote: > > For migrations called in MIGRATE_SYNC mode, skip migrating the folio if > > it is under writeback and has the AS_WRITEBACK_INDETERMINATE flag set on its > > mapping. If the AS_WRITEBACK_INDETERMINATE flag is set on the mapping, the > > writeback may take an indeterminate amount of time to complete, and > > waits may get stuck. > > > > Signed-off-by: Joanne Koong > > Reviewed-by: Shakeel Butt > > --- > > mm/migrate.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/mm/migrate.c b/mm/migrate.c > > index df91248755e4..fe73284e5246 100644 > > --- a/mm/migrate.c > > +++ b/mm/migrate.c > > @@ -1260,7 +1260,10 @@ static int migrate_folio_unmap(new_folio_t get_new_folio, > > */ > > switch (mode) { > > case MIGRATE_SYNC: > > - break; > > + if (!src->mapping || > > + !mapping_writeback_indeterminate(src->mapping)) > > + break; > > + fallthrough; > > default: > > rc = -EBUSY; > > goto out; > > Ehm, doesn't this mean that any fuse user can essentially completely block > CMA allocations, memory compaction, memory hotunplug, memory poisoning... ?! > > That sounds very bad. The page under writeback are already unmovable while they are under writeback. This patch is only making potentially unrelated tasks to synchronously wait on writeback completion for such pages which in worst case can be indefinite. This actually is solving an isolation issue on a multi-tenant machine.