From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2DFAECD9AA for ; Fri, 6 Feb 2026 00:40:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BD0B6B008A; Thu, 5 Feb 2026 19:40:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 66AC96B0092; Thu, 5 Feb 2026 19:40:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54C2A6B0093; Thu, 5 Feb 2026 19:40:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 436276B008A for ; Thu, 5 Feb 2026 19:40:05 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BB7951C613 for ; Fri, 6 Feb 2026 00:40:04 +0000 (UTC) X-FDA: 84412174728.12.9DAD56E Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172]) by imf14.hostedemail.com (Postfix) with ESMTP id D14DB10000C for ; Fri, 6 Feb 2026 00:40:01 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=PBX6ioe2; spf=pass (imf14.hostedemail.com: domain of yosry.ahmed@linux.dev designates 91.218.175.172 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1770338403; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j9x8Oha2FCRFhdP6sFQHAlg53hGqhvSeJttZv66OvZ8=; b=w6v16482EaPt0EybVKoel/7fQVtwwJWyb6IiekRw7xVgxIRfgTfQOoSkEjPwC3Qo7QLHsk 2OC4OnVUcEJBDk4k/ssr40NfDxqGMlCLDy6EkGGaP0ZzzfvZ6s9IJmgoA7GLlL9ZHYIFsh V2S0unqjz5YxLNpsTYWN+deLhGPTENs= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=PBX6ioe2; spf=pass (imf14.hostedemail.com: domain of yosry.ahmed@linux.dev designates 91.218.175.172 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1770338403; a=rsa-sha256; cv=none; b=nwYDmPTv8FEKIOuimClqi9EtJ9yAsCseWQIiRIxZslFj+wfZJ7SkfISBhaIzqLdKzVxDeb rh5zdFX2RLJ7AdJjv4ziliryPrH9QapgJWTV1oZYeww6cZlzxwnfaVZOQbfYMS5m/gMQ7p fyyNgRrJDaNfD5GU9lSWU+q3V3NJ8/g= Date: Fri, 6 Feb 2026 00:39:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1770338399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=j9x8Oha2FCRFhdP6sFQHAlg53hGqhvSeJttZv66OvZ8=; b=PBX6ioe2oqYVg2VIrumnJ5LBuevyOQhXyW2HDSYuOkiAbnLGQKkZOnXszTzLZ3cAgq8/Tw by0miBErTtiCs3CQx/DwEYoCUFeEajenBetDIISemUatz6Z2UmyO5vpj2QPNtdJqHQCeAn pTn1Kb/cEEe1P4i9RX10dHJ5P695r2M= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yosry Ahmed To: Jiayuan Chen Cc: linux-mm@kvack.org, Jiayuan Chen , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Nhat Pham , Chengming Zhou , Andrew Morton , Nick Terrell , David Sterba , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] mm: zswap: add per-memcg stat for incompressible pages Message-ID: References: <20260205053013.25134-1-jiayuan.chen@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260205053013.25134-1-jiayuan.chen@linux.dev> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D14DB10000C X-Stat-Signature: 6aar7js6oundpeawhe33es4ajqzwc8c8 X-Rspam-User: X-HE-Tag: 1770338401-321847 X-HE-Meta: U2FsdGVkX1/JbuHpP4BcrtBeqROCY/BJGlM3Xl2CN9Jp4fZ4YPhviMoHKqJ0IaFiQI2eWOsdRAcTpsN1DwfqZzvIc6svjQy9GS0/iLvkOuf357Wyl2PyRps8WfySvvWwrfXUN21PZpXlNKs4nPKc/2AJtYsYKJlRj528BGJ6YR5xg7VLON/pj8UrqALQe0XXitJbNoTF1ce+Cwlesp40pS9UYyID+H1YJeBwQrG2kn8nskAIsfbE/8syJCBbnul7O9wZRQ340wwkfCcTA+hLgPUcZzyBrQiiFkJFJGl1yq73srdKAuH7La/VgC4symdeK/E9dkhpjdt46WaYc1jD9E5OkwdEf/H0AhooXSR+heia8HunATTEVM0B9ASvF71F6mC3L4cOqPuITewV11tR+1BPrnYNIzoSAlaiy2ZWygpYJ6D+s+WG2J+bB/cqT2SBjOR+2+G5jN8A/V2m3YvlJwZCo6thwnV3wyr9++y0g3rArD43/YqhYU4yxc+UJe2PXI5Bu1KmNLxUtY4Jf4h1N1d0BtGAvN1XtZs83lxftX7K9p6XA6C+uzYu07Rj0jznoU5dOQlVmDXzvui57nSjNIzZpBIt2bgKKTIDteuxbmk15sEp5JekjTybgtdN/RFYw/3UgZh4fyNT6sAJjdnYb2PMS/9P7gH8aFiG4/g1VMF3b/9WMJG3hpz1evSmFS4AMfMrZayTDg4afxiZc6p9wUc81Do1bcJOVGCsIu6r1k/FiIUPJzpCBrPHrjXIGKGE4KeaTBCZiXDmVJ+hNA3vOAdWFHrvbOgSXXNxPNsqAgyNaQJxjUvDhaCi+rOe2b+3GsYBnJSdo320TY18U2o9eyHgfW08Il0oY8iHFPczPZcmPczBtSSj0i7DlUylk7evxlLpibgoxkErrzUYDRyij1aBAXQXKWVz7y5ew0Ttz44XYluIe1QU4AmZIA8HveT9Z8mdL6537dGSSYwy0U2 Hfy6ymVK 6nCVbKXYVUiP6bNnCVR/bVxsBY8PQBg1Ssy2KRUoQVqYFX1x704jObGAmmYvwa0iNSo6KDxNrrxyq6AZapt+daj93x0dRX0DbAsjJeteKgFukBd/NoxbqS+5N1/z4ffrIXzt4CNyPMoBc+57Z3x3MNYcoIRxcdRYjQr4c/wph7V+kIex/LqNbzsxhE0n91EV5lWhgAmad4D0b/88jhtupIDQN9a1hjGNy/Opwbqu3JQyNwMqdUl9GFl8lcDZ94O47/KAz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 05, 2026 at 01:30:12PM +0800, Jiayuan Chen wrote: > From: Jiayuan Chen > > The global zswap_stored_incompressible_pages counter was added in commit > dca4437a5861 ("mm/zswap: store to track how many pages are stored in raw (uncompressed) form in zswap. > However, in containerized environments, knowing which cgroup is > contributing incompressible pages is essential for effective resource > management. > > Add a new memcg stat 'zswpraw' to track incompressible pages per cgroup. > This helps administrators and orchestrators to: > > 1. Identify workloads that produce incompressible data (e.g., encrypted > data, already-compressed media, random data) and may not benefit from > zswap. > > 2. Make informed decisions about workload placement - moving > incompressible workloads to nodes with larger swap backing devices > rather than relying on zswap. > > 3. Debug zswap efficiency issues at the cgroup level without needing to > correlate global stats with individual cgroups. > > While the compression ratio can be estimated from existing stats > (zswap / zswapped * PAGE_SIZE), this doesn't distinguish between > "uniformly poor compression" and "a few completely incompressible pages > mixed with highly compressible ones". The zswpraw stat provides direct > visibility into the latter case. > > Changes > ------- > > 1. Add zswap_is_raw() helper (include/linux/zswap.h) > - Abstract the PAGE_SIZE comparison logic for identifying raw entries > - Keep the incompressible check in one place for maintainability > > 2. Add MEMCG_ZSWAP_RAW stat definition (include/linux/memcontrol.h, > mm/memcontrol.c) > - Add MEMCG_ZSWAP_RAW to memcg_stat_item enum > - Register in memcg_stat_items[] and memory_stats[] arrays > - Export as "zswpraw" in memory.stat > > 3. Update statistics accounting (mm/memcontrol.c, mm/zswap.c) > - Track MEMCG_ZSWAP_RAW in obj_cgroup_charge/uncharge_zswap() > - Use zswap_is_raw() helper in zswap.c for consistency > > Test > ---- > > I wrote a simple test program[1] that allocates memory and compresses it > with zstd, so kernel zswap cannot compress further. > > $ cgcreate -g memory:test > $ cgexec -g memory:test ./test_zswpraw & > $ cat /sys/fs/cgroup/test/memory.stat | grep zswp > zswpraw 0 > zswpin 0 > zswpout 0 > zswpwb 0 > > $ echo "100M" > /sys/fs/cgroup/test/memory.reclaim > $ cat /sys/fs/cgroup/test/memory.stat | grep zswp > zswpraw 104800256 > zswpin 0 > zswpout 51222 > zswpwb 0 > > $ pkill test_zswpraw > $ cat /sys/fs/cgroup/test/memory.stat | grep zswp > zswpraw 0 > zswpin 1 > zswpout 51222 > zswpwb 0 > > [1] https://gist.github.com/mrpre/00432c6154250326994fbeaf62e0e6f1 > > Signed-off-by: Jiayuan Chen > --- > include/linux/memcontrol.h | 1 + > include/linux/zswap.h | 9 +++++++++ > mm/memcontrol.c | 6 ++++++ > mm/zswap.c | 6 +++--- > 4 files changed, 19 insertions(+), 3 deletions(-) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index b6c82c8f73e1..83d1328f81d1 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -39,6 +39,7 @@ enum memcg_stat_item { > MEMCG_KMEM, > MEMCG_ZSWAP_B, > MEMCG_ZSWAPPED, > + MEMCG_ZSWAP_RAW, Please change the name as Shakeel suggested. > MEMCG_NR_STAT, > }; > > diff --git a/include/linux/zswap.h b/include/linux/zswap.h > index 30c193a1207e..94f84b154b71 100644 > --- a/include/linux/zswap.h > +++ b/include/linux/zswap.h > @@ -7,6 +7,15 @@ > > struct lruvec; > > +/* > + * Check if a zswap entry is stored in raw (uncompressed) form. > + * This happens when compression doesn't reduce the size. > + */ > +static inline bool zswap_is_raw(size_t size) Internall as well, please rename this to zswap_is_incompressible() or zswap_is_incomp(). Not a big fan of the helper because it doesn't add much, but I don't feel strongly either way. > +{ > + return size == PAGE_SIZE; > +} > + > extern atomic_long_t zswap_stored_pages; > > #ifdef CONFIG_ZSWAP > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 007413a53b45..32fb801530a3 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -341,6 +341,7 @@ static const unsigned int memcg_stat_items[] = { > MEMCG_KMEM, > MEMCG_ZSWAP_B, > MEMCG_ZSWAPPED, > + MEMCG_ZSWAP_RAW, > }; > > #define NR_MEMCG_NODE_STAT_ITEMS ARRAY_SIZE(memcg_node_stat_items) > @@ -1346,6 +1347,7 @@ static const struct memory_stat memory_stats[] = { > #ifdef CONFIG_ZSWAP > { "zswap", MEMCG_ZSWAP_B }, > { "zswapped", MEMCG_ZSWAPPED }, > + { "zswpraw", MEMCG_ZSWAP_RAW }, Here as well: zswap_incompressible or zswap_incomp? Other than the renames and doc, LGTM. > #endif > { "file_mapped", NR_FILE_MAPPED }, > { "file_dirty", NR_FILE_DIRTY }, > @@ -5458,6 +5460,8 @@ void obj_cgroup_charge_zswap(struct obj_cgroup *objcg, size_t size) > memcg = obj_cgroup_memcg(objcg); > mod_memcg_state(memcg, MEMCG_ZSWAP_B, size); > mod_memcg_state(memcg, MEMCG_ZSWAPPED, 1); > + if (zswap_is_raw(size)) > + mod_memcg_state(memcg, MEMCG_ZSWAP_RAW, 1); > rcu_read_unlock(); > } > > @@ -5481,6 +5485,8 @@ void obj_cgroup_uncharge_zswap(struct obj_cgroup *objcg, size_t size) > memcg = obj_cgroup_memcg(objcg); > mod_memcg_state(memcg, MEMCG_ZSWAP_B, -size); > mod_memcg_state(memcg, MEMCG_ZSWAPPED, -1); > + if (zswap_is_raw(size)) > + mod_memcg_state(memcg, MEMCG_ZSWAP_RAW, -1); > rcu_read_unlock(); > } > > diff --git a/mm/zswap.c b/mm/zswap.c > index 3d2d59ac3f9c..54ab4d126f64 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -723,7 +723,7 @@ static void zswap_entry_free(struct zswap_entry *entry) > obj_cgroup_uncharge_zswap(entry->objcg, entry->length); > obj_cgroup_put(entry->objcg); > } > - if (entry->length == PAGE_SIZE) > + if (zswap_is_raw(entry->length)) > atomic_long_dec(&zswap_stored_incompressible_pages); > zswap_entry_cache_free(entry); > atomic_long_dec(&zswap_stored_pages); > @@ -941,7 +941,7 @@ static bool zswap_decompress(struct zswap_entry *entry, struct folio *folio) > zs_obj_read_sg_begin(pool->zs_pool, entry->handle, input, entry->length); > > /* zswap entries of length PAGE_SIZE are not compressed. */ > - if (entry->length == PAGE_SIZE) { > + if (zswap_is_raw(entry->length)) { > WARN_ON_ONCE(input->length != PAGE_SIZE); > memcpy_from_sglist(kmap_local_folio(folio, 0), input, 0, PAGE_SIZE); > dlen = PAGE_SIZE; > @@ -1448,7 +1448,7 @@ static bool zswap_store_page(struct page *page, > obj_cgroup_charge_zswap(objcg, entry->length); > } > atomic_long_inc(&zswap_stored_pages); > - if (entry->length == PAGE_SIZE) > + if (zswap_is_raw(entry->length)) > atomic_long_inc(&zswap_stored_incompressible_pages); > > /* > -- > 2.43.0 >