From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE2C1D743E8 for ; Wed, 20 Nov 2024 22:10:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D8CF6B0088; Wed, 20 Nov 2024 17:10:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 389056B008A; Wed, 20 Nov 2024 17:10:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 277936B008C; Wed, 20 Nov 2024 17:10:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 07C116B0088 for ; Wed, 20 Nov 2024 17:10:59 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D83D6141122 for ; Wed, 20 Nov 2024 22:10:57 +0000 (UTC) X-FDA: 82807867800.30.87C5CA2 Received: from out-181.mta0.migadu.com (out-181.mta0.migadu.com [91.218.175.181]) by imf28.hostedemail.com (Postfix) with ESMTP id 76FB5C0002 for ; Wed, 20 Nov 2024 22:10:00 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=mBDa0v6w; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf28.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.181 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732140470; a=rsa-sha256; cv=none; b=VJif3dzOJsGqdW3DGQyv1Ol6/DTT1o9uY30ois7WdE5N1C2v5QyDvVVqt8k/LM1giXFnwf 9cF8H94xEswiTw3LmH+gnGZrVwa2cWHMGppvUeUjwrIl4SRuaghiN3QuMZQCjYis6KH80U aQmODTGXszcnfhe2vwmh/L6eC/gmDHE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=mBDa0v6w; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf28.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.181 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732140470; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8cs8VVTVD+23VdT89LFoH5HWxtkWRny1Wmf3NO7BV6A=; b=VwpD+LcEc6MCPDudoBeav++DmJEB00lVjUgCPOoK47BPcSTEpQQWmZQouiz1p6ZVguGr4E xlmChlYsNvF2kPLOrpjg64LvkLy+bvrZsWeJFEMmW4ZXua3espbIx72R1sbkrwHsVk8LyA TsZpFoc5RaKhQRNu5hu2CTw9mGDDS1Y= Date: Wed, 20 Nov 2024 14:10:44 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1732140653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8cs8VVTVD+23VdT89LFoH5HWxtkWRny1Wmf3NO7BV6A=; b=mBDa0v6w+ZIILU3a23i0M+A8JQuPtLJWfVTPZjgdv5rq8qzG4fwppkr1qRs55/Rh4dJt51 w4a/539L3vnXx9bYqmyjTem4s2XJiZ9dl01PHx33ofw2v8YW4cVbihM8uMjgUbbBoPSnu2 j/iVy02qFkKjCg0Xn15RNiUw7102Aw4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, minchan@google.com, jannh@google.com, souravpanda@google.com, pasha.tatashin@soleen.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v4 0/5] move per-vma lock into vm_area_struct Message-ID: References: <20241120000826.335387-1-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241120000826.335387-1-surenb@google.com> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: 63kajwiui3cnfa6u4ab1ysbmdhiqq6ik X-Rspamd-Queue-Id: 76FB5C0002 X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1732140600-592758 X-HE-Meta: U2FsdGVkX1/5Ilbs+S3vV8bfVRLbTd9V6yloBgbCsyTjQuBTcpR/BPbWkH1oamW6QdmYaOWatNmZTAxrtUlZcY9TEJtjxE/d+3oC0gVbF+bgts2+ZCKDXakdSzbJDldl6t0EezBr+qSuylffXEHgZ6GM91R81IQh/ZffL16ryLCdcbOfrFux9irA5yQc9e9ddt7oUk/nWOiWRAjujdOkXaAM+NvN570mla1d873XRApOdTdowZ6AzY4yJh1iUjX41GBTXoLZ7VvFOsOuF/yvJW7aakZp6lMj7BecmZPN9X6w2L02r0X9TX3cSAFXsUJmC7PxtkbhbHJvpuSlThQNJkeC2JrQYw+ziiFZPWu3dM3grKmGMTp+8s7w10gL5IuVYqXckxL6kjf+7MDmfI9QBiH6FGJdGII8+osR0ak64lC8fPkfaomdU/koxpqSmc7CdO43Oag5MbakvaSYT2e16MrhoHCgjS8WvDJe9g8/nRHYrGUN5ogOldXSYtDM9JWBMQGMI6gBTa8ItrzMlnETWeO9P7QVGW6KuJ7jOFmIll47eGPrQjHWhDGDPhEQuclHnin+EM7sUmcWTDRsfkZszrq/ByE7bdDxcI6SGzjZJzF3tfrljfR5H47sSIii1Eb+xdNe3QocUjmHZfZPC9OEKzOHYzzuEngKtPjYUYDY43gIGygWbqriT/7hRdQxs1UosKOhxPKGkyMSnGeAcmyh4paWB3WZdC3c34CZTHHoGXs0CALD84iCA0l1vwZX4TnKTQwL27Uo5YM68h/66g0JDQC4XC8sLOyYv1//wOAByWA0oFGyEg4S0ZgYD29jA3PX9uluyrKj/k/r88pmYLF/7Ku3SiM/s0L1vKcVFNX85PEbEyoUPORt/I2syWfcOHmmeigVH/rApts9qD7r+x3iZNignwNjD6gzp0jnjRfZaoPn6zdZf2t9u/DdVrwcJTqDCNq4Q3ZZ7cWYER5+GnF M7UuE48M 4vX4r1BqjF+Gb0ZdNoVCk749taF1JNlWHGX7lvgTYZBXW9YAXF4tmDR0TTF8qLOxnCrz73fwGcwhTt+TVP0qVEFgEKi7v0LD0LOvceNJrP/c6RqZV1ohDnHFbCwUny/t0ZbkpW11NJ29a3Dg/1QQoIC56vkzeloNzjOej+jjZgMu9gGuxSot/Vzz0cwakdyXjMl8K X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 19, 2024 at 04:08:21PM -0800, Suren Baghdasaryan wrote: > Back when per-vma locks were introduces, vm_lock was moved out of > vm_area_struct in [1] because of the performance regression caused by > false cacheline sharing. Recent investigation [2] revealed that the > regressions is limited to a rather old Broadwell microarchitecture and > even there it can be mitigated by disabling adjacent cacheline > prefetching, see [3]. If 'struct vm_area_struct' is prone to performance issues due to cacheline misalignments then we should do something about the __randomize_layout tag for it. I imagine we can identify the fields which might be performance critical to be on same cacheline or different cacheline due to false sharing then we can divide the fields into different cacheline groups and fields can be __randomize_layout within the group. WDYT?