From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8E65CF258D for ; Sun, 13 Oct 2024 07:56:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 889A76B0082; Sun, 13 Oct 2024 03:56:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EC446B0083; Sun, 13 Oct 2024 03:56:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68C0C6B0085; Sun, 13 Oct 2024 03:56:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 46B7A6B0082 for ; Sun, 13 Oct 2024 03:56:24 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B2C4AA0651 for ; Sun, 13 Oct 2024 07:56:10 +0000 (UTC) X-FDA: 82667821278.21.D60F654 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) by imf24.hostedemail.com (Postfix) with ESMTP id 3088A180015 for ; Sun, 13 Oct 2024 07:56:18 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="Iomn/F5+"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728806026; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D0UXcPMAQT863fxE4oQ4MKBp1lB0tO0dk2FFTCPvlSg=; b=x1W+717w7IiujnZebHyvrdL7xwqgvdcG3LqiGfJooskb72oKUCgTc6vpprVaOOBuImpEeW Ar6PzqIBTxpwyDo95SQbQvq4Lp7PWPjcr3/+hJFmYeoR5/H/ZfKATRmQv7X3IKzSHdZhdN GozXBdWZzH5BzfKvmtRb7V3iQqpLW3s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728806026; a=rsa-sha256; cv=none; b=XQ+jcaFqWIRrf/CMIIfQYTjOOQ/qBl4LSeIm+O1NiecRt3YqGPDRvDf41ABM7Y993wiiR8 c9NE3quypzP/ejcRmC1oUt5yXzZQlwUs2pX2BLd+VEdIz7vjUq69ZPFMBqgMzdsujl9jPE TWNHXSIpeOtOzP2/Q+Kk+0DGSU1gYFQ= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="Iomn/F5+"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev Date: Sun, 13 Oct 2024 00:56:06 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1728806176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D0UXcPMAQT863fxE4oQ4MKBp1lB0tO0dk2FFTCPvlSg=; b=Iomn/F5+0IbVe9vPsCt6+XNegFm9DNq5lMEs2+zgyH9i5XOVeX7QKHF5n4be2iaQZPTtgx 9mtfJmlXtGjkfSbxNFNZsYlW4VWzbMrugNJaow6+tl7D16Q32YKmL7VLxtlj98fYMdHCrh 3BQtze4tvpI5QIqJthFZdCdYyOvSn6A= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Andrii Nakryiko Cc: linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, peterz@infradead.org, oleg@redhat.com, rostedt@goodmis.org, mhiramat@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, jolsa@kernel.org, paulmck@kernel.org, willy@infradead.org, surenb@google.com, akpm@linux-foundation.org, mjguzik@gmail.com, brauner@kernel.org, jannh@google.com, mhocko@kernel.org, vbabka@suse.cz, hannes@cmpxchg.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com Subject: Re: [PATCH v3 tip/perf/core 1/4] mm: introduce mmap_lock_speculation_{start|end} Message-ID: References: <20241010205644.3831427-1-andrii@kernel.org> <20241010205644.3831427-2-andrii@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241010205644.3831427-2-andrii@kernel.org> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3088A180015 X-Stat-Signature: odbjfgeu31964s4ty9owpozud198dq5s X-Rspam-User: X-HE-Tag: 1728806178-765427 X-HE-Meta: U2FsdGVkX1/3Y+2XFGCKIPG5YIW9euxBOUIaOpotkfw0NIQa45/UGoTcNfrgB5XwJTC0DLnx4NQ3Hd/q3wu3VVzJckOAlehTCCMDmaZZESMjcylwGo5ONVy3iaKBNvX/Vz8OsObR7PCvMZCaNdSvJ7xyegx/oAFbcx/bMJUWL2PN2qFjQeBjfsc1mb4l3naAJ8PB3j2ivO1gsssiElBLqSbn001y1T9a+i1TEj1mAG7BdaR+TRI8i824b7wN3YUGF7MtxHXiDJe/gtWPI/K+IAEIMSm4Vdg4B/SDkUo+KVhxJZ2/Z7YMmkOtzmFchUehHx7wQC7UW8ZMwlLYPvOMvJ4m1BufrJpzD2cTjTwPCXCkpQu6M+JiO7jLcwCYzPdf2Pn7sXt+VnTiB2AWrPT/puyOpR9KfeWz16kXRKTiY7Bizs7296V79FOKZeZWHiofJQ6mGCCatiJy8xRRrJti7M49Ppc7rN60mqwjztcyE4ycJ4cEo/Tm3zO4k1NbvgZivusPa5bRMewTBGwFkvWUz1xJu6U06010zpcYKax5KLDhZPgDWoYYlplKiZZTmSZqINDRy/ZKFKA8WyqlOIJRXCV87BaFOqj0J0jfOP9IDa9KD+5uosB3MJhx4RKxX6w1GqCmbWQ7FhXCsnIWSVN+3hZmXFvCiJ3FmCJq1LHOhx9KZ/2OqgmgN8MZQIzz3iKbWjmlJ5n7k0SAuMNcXlyX+luPFKuWL3jIHpEXwhRyJ4j3I+E5YTICiL6T8e059hVopJAzQzX5EJf1yPjoog5/clTrGTtGj4cTlVeRqPPkV0rn3UpF3t8uJGCvwYTWPz4i3VvCRXh7RQwh4DArbiJkLZd0mfOaacRrlworoN4VMeMTOxlfaU4Bslo6BU4e6U4Iqht8YTBlNhO8vSciZFKeSOc5S5tjm2YAuspbo+8Z8a+RHn3g6UanP5vmfIslL3WDmCIj22W6KtruUSIPv+F u+mT8bFo GHUJ+G/ClXffH2QKEsymj5QzP4T43FQbUZw5AGtgbLPWBSrsNVwldGK8hDsnrllhCI/Ozhdmqr30ckza95zVn7kqzGj9JTG60ayXGWMkt4fYNeVCWjlX0LvHbv5/W+KZwtp0z8ZlDcmlqGmUkOkJbAwSyfoBwKnCZwrSG0z2Ey4P3zwrWvO5nAf60DBowZqFE83MdLCtl3y6ZGcO3xlNdP02kwlxU5ceVVkvMVO6UhVywPzOgvSPJ2Keu/dl/npkGhtZu1AtEVu/Kx+HhWjDbuTOwSB3JHfXUk//s9sHdhd4yB/dBgeytjWK9+L4YJECHk55EDoiHDYBoVbo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 10, 2024 at 01:56:41PM GMT, Andrii Nakryiko wrote: > From: Suren Baghdasaryan > > Add helper functions to speculatively perform operations without > read-locking mmap_lock, expecting that mmap_lock will not be > write-locked and mm is not modified from under us. > > Suggested-by: Peter Zijlstra > Signed-off-by: Suren Baghdasaryan > Signed-off-by: Andrii Nakryiko > Link: https://lore.kernel.org/bpf/20240912210222.186542-1-surenb@google.com Looks good to me. mmap_lock_speculation_* functions could use kerneldoc but that can be added later. Reviewed-by: Shakeel Butt