From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB37EC47073 for ; Sun, 7 Jan 2024 18:23:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F5E26B0072; Sun, 7 Jan 2024 13:23:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A5C36B0074; Sun, 7 Jan 2024 13:23:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76E096B0083; Sun, 7 Jan 2024 13:23:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 652C36B0072 for ; Sun, 7 Jan 2024 13:23:33 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1B1CC80688 for ; Sun, 7 Jan 2024 18:23:33 +0000 (UTC) X-FDA: 81653337906.06.36A598C Received: from postout1.mail.lrz.de (postout1.mail.lrz.de [129.187.255.137]) by imf17.hostedemail.com (Postfix) with ESMTP id 7CFF840019 for ; Sun, 7 Jan 2024 18:22:52 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=tum.de header.s=tu-postout21 header.b=GeWplGkk; dmarc=pass (policy=none) header.from=tum.de; spf=pass (imf17.hostedemail.com: domain of paul.heidekrueger@tum.de designates 129.187.255.137 as permitted sender) smtp.mailfrom=paul.heidekrueger@tum.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704651773; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r4TLIXJVf378b8n0ZfXXP0YHeN+RfpBipucVEujnFDQ=; b=z3JqmTXWWE7mpnn9KyVIQs0Xzice5Nd4KjqmxhXyVFn52KSvtO0FBKrG5H5RQGD/wE6HfN haV3OdIEpXgGv5zx6jPN4ZzCXFbeWi2QiUHOBVpSSHAd0qetZG0fsgXhtBtAtdHOKTS/HJ NwA9Okz0ATs59Ol4XTUJ/+Z1AnN1wwA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=tum.de header.s=tu-postout21 header.b=GeWplGkk; dmarc=pass (policy=none) header.from=tum.de; spf=pass (imf17.hostedemail.com: domain of paul.heidekrueger@tum.de designates 129.187.255.137 as permitted sender) smtp.mailfrom=paul.heidekrueger@tum.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704651773; a=rsa-sha256; cv=none; b=H2C7yCy8kwXzn2bTKh6Aa8WzuWXWSNAXOxKd5vwO2Dm5nX58toCTY9MPafT8U4jjMjxxlI rbV0Wj/5KN2uWLTBiC7l538wyRT8WSglb2VxOvdKWgQLxOQWapbHqBmF1poF2Y9NnWdg+2 1SF+UXyOf9sKUjYvZrQxaLJJMsWF5QE= Received: from lxmhs51.srv.lrz.de (localhost [127.0.0.1]) by postout1.mail.lrz.de (Postfix) with ESMTP id 4T7QXn28G3zyTZ; Sun, 7 Jan 2024 19:22:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tum.de; h= in-reply-to:content-transfer-encoding:content-disposition :content-type:content-type:mime-version:references:message-id :subject:subject:from:from:date:date:received:received; s= tu-postout21; t=1704651768; bh=DY2NeegPvDuYc7q9sD4qdhEYd83m+YBsQ XNiUYkZvL0=; b=GeWplGkklJrYhr0n0+tH6jD8ZDfKz4bKpyyKvV8IEMY+2z1yk acmU9bNWLSY7w5xcgBuihLEFQVu8TV4GWLjXaQPiFr4Gi91y350SytQ5qRtyQIXR Xy8LHmY6c2Q3xg+fBVYP+rBnvYAzC1hZ4kRs8tRwVT95Xv7vreqJhv7x2pNJ5qio 9O6egFdE91R6W29YZrnDGFLLuBFVOUF/uUWo2eYxTDGa71ekm5Qwt86vp3TZXdWH vqtTTzDn+147tBw5nb8QYslOeRFRh7SMLoIQv1uUH4l/vL21DSTPL8NxlDl5UtF2 6Ou5OLYmiKtnyMgd9VqaLCYv2GRVxcZdXX5aA== X-Virus-Scanned: by amavisd-new at lrz.de in lxmhs51.srv.lrz.de Received: from postout1.mail.lrz.de ([127.0.0.1]) by lxmhs51.srv.lrz.de (lxmhs51.srv.lrz.de [127.0.0.1]) (amavisd-new, port 20024) with LMTP id SnoGITx3fP0N; Sun, 7 Jan 2024 19:22:48 +0100 (CET) Received: from cerulean.fritz.box (unknown [IPv6:2001:a61:24c8:fe01:dd4e:2513:1e73:cb01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by postout1.mail.lrz.de (Postfix) with ESMTPSA id 4T7QXl54jLzySv; Sun, 7 Jan 2024 19:22:47 +0100 (CET) Date: Sun, 7 Jan 2024 19:22:40 +0100 From: Paul =?utf-8?Q?Heidekr=C3=BCger?= To: Marco Elver Cc: Andrey Konovalov , Steven Rostedt , Peter Collingbourne , andrey.konovalov@linux.dev, Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov , Masami Hiramatsu , linux-trace-kernel@vger.kernel.org, Nick Desaulniers Subject: Re: Re: [PATCH v3 1/3] kasan: switch kunit tests to console tracepoints Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Stat-Signature: hsabifdqtyy6uchihh467epccd9t98jd X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7CFF840019 X-HE-Tag: 1704651772-795573 X-HE-Meta: U2FsdGVkX19KQDw1EYKbuzAjLA03vI1Q1201RBdfnQxFLXH8EwajuO6o1wAG+h6geLRpdxonO/zTvXZDtDCCsNnurqc7L3q5VMpX8wo9x55wdPOut/w2qeUHFKCKKQMPjQTxnLpcKomt43pYiairlhCmoVqkMJcNQNfGu1pcuHpJPWmOS8ZcMzmwDzOY2oHYg3ECWeE8wqEIWNUQlfSFL5y6RXiUbyENypsE0+JhG2Ea9pPsRFQathSHQcbMYewoHkobZ+dX56jRooqr3FSz6j8IPDEOBC+MzdbJQehE/WjuCZf3rdrcTmLoWg5OyzXIHdLWA5xcT2iyaHuoNx16IkTRZ++An5C6oGeoHgyHO67sGJm6IopQ4vmp/mQn8mZlY+GHt8tLrBdLT+mZbKnEktqt5n1SsHTmHuVhYFSx/pi5o5z8Hdbzl2C5gPsgnlwT3MXnv84IZ8R28F1YHGxXDLuPM/AFp4w2EOIhD/BM6g2+IJo/0HLS5JaWqoJbT0hKQyQ4FiL0ymcvYsCpfT++Gadx6aNOhm6f4r0U8O++iHg03yrIEJpadyIw8FQdF/V+UH8XlAWig/9aF0WbhSyOL6bFXbZ0Guq7NPWgrdR5QbwDoYPDJgDiQv/rJaWTRie+VL5MsXLhHFsqJiDDSo1JvNQbsnr3cCtTqTfBra+1/NJuWNihHGX6IZSlufK5j9vWX+F4qPoXCOTAjSKHT69uXZCVrS+fKRt03az7TKh3M8egPk+x8Q/H3BlqIqh+PZesWQHT/CxUZonaObiJnp0vxohmWWKGNn6wsIf3eCcP8qETnM/cFUP2fGlw1Rq19tVUnFqFJ25U8LvfsbyK/dVzWFabVUyIVa/ra8vFcxchj5HKuISjo/WN3T3K9h7nkTsPFOvLXa5g0LYz1/Onep2Lt3ffT1Vx1klPZs4DRfTmHd5rmYnK6FOL/8cjNRboAj0z6QUaU+DlAt87RdUDa4X 0jjvMU3Y LnoCsRwIknHBw65LnmfX5N0vbM3wFi2tG+smzCv4k0SvM/H8LX4c14+INv66oy5IPqRedv6FG9POCreJlFOxwFA6PHSHLICk+NXeT+N72JRqQ4EZKqUuR4KCwwDbIti7gsp9IuukvBVG1ULDoOPxlIP8cWjtI00ciLQkM5qM0Y9AYthBr8L5zH7cIy3ZPCjsInzlsiFbSDAhpE4TGtII5icn4Ty3rWHfLFNoPUMNYKB5p3ZeDWLEpKDrGo2P/FndOF4bbeNjyef7aN8PpwUugGk0Lp5fCpVXC/L2ZLbZ8TtiOROs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.12.2023 10:32, Marco Elver wrote: > On Tue, 12 Dec 2023 at 10:19, Paul Heidekrüger wrote: > > > > On 12.12.2023 00:37, Andrey Konovalov wrote: > > > On Tue, Dec 12, 2023 at 12:35 AM Paul Heidekrüger > > > wrote: > > > > > > > > Using CONFIG_FTRACE=y instead of CONFIG_TRACEPOINTS=y produces the same error > > > > for me. > > > > > > > > So > > > > > > > > CONFIG_KUNIT=y > > > > CONFIG_KUNIT_ALL_TESTS=n > > > > CONFIG_FTRACE=y > > > > CONFIG_KASAN=y > > > > CONFIG_KASAN_GENERIC=y > > > > CONFIG_KASAN_KUNIT_TEST=y > > > > > > > > produces > > > > > > > > ➜ ./tools/testing/kunit/kunit.py run --kunitconfig=mm/kasan/.kunitconfig --arch=arm64 > > > > Configuring KUnit Kernel ... > > > > Regenerating .config ... > > > > Populating config with: > > > > $ make ARCH=arm64 O=.kunit olddefconfig CC=clang > > > > ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config. > > > > This is probably due to unsatisfied dependencies. > > > > Missing: CONFIG_KASAN_KUNIT_TEST=y > > > > > > > > By that error message, CONFIG_FTRACE appears to be present in the generated > > > > config, but CONFIG_KASAN_KUNIT_TEST still isn't. Presumably, > > > > CONFIG_KASAN_KUNIT_TEST is missing because of an unsatisfied dependency, which > > > > must be CONFIG_TRACEPOINTS, unless I'm missing something ... > > > > > > > > If I just generate an arm64 defconfig and select CONFIG_FTRACE=y, > > > > CONFIG_TRACEPOINTS=y shows up in my .config. So, maybe this is kunit.py-related > > > > then? > > > > > > > > Andrey, you said that the tests have been working for you; are you running them > > > > with kunit.py? > > > > > > No, I just run the kernel built with a config file that I put together > > > based on defconfig. > > > > Ah. I believe I've figured it out. > > > > When I add CONFIG_STACK_TRACER=y in addition to CONFIG_FTRACE=y, it works. > > CONFIG_FTRACE should be enough - maybe also check x86 vs. arm64 to debug more. See below. > > CONFIG_STACK_TRACER selects CONFIG_FUNCTION_TRACER, CONFIG_FUNCTION_TRACER > > selects CONFIG_GENERIC_TRACER, CONFIG_GENERIC_TRACER selects CONFIG_TRACING, and > > CONFIG_TRACING selects CONFIG_TRACEPOINTS. > > > > CONFIG_BLK_DEV_IO_TRACE=y also works instead of CONFIG_STACK_TRACER=y, as it > > directly selects CONFIG_TRACEPOINTS. > > > > CONFIG_FTRACE=y on its own does not appear suffice for kunit.py on arm64. > > When you build manually with just CONFIG_FTRACE, is CONFIG_TRACEPOINTS enabled? When I add CONFIG_FTRACE and enter-key my way through the FTRACE prompts - I believe because CONFIG_FTRACE is a menuconfig? - at the beginning of a build, CONFIG_TRACEPOINTS does get set on arm64, yes. On X86, the defconfig already includes CONIFG_TRACEPOINTS. I also had a closer look at how kunit.py builds its configs. I believe it does something along the following lines: cp .kunit/.config make ARCH=arm64 O=.kunit olddefconfig On arm64, that isn't enough to set CONFIG_TRACEPOINTS; same behaviour when run outside of kunit.py. For CONFIG_TRACEPOINTS, `make ARCH=arm64 menuconfig` shows: Symbol: TRACEPOINTS [=n] Type : bool Defined at init/Kconfig:1920 Selected by [n]: - TRACING [=n] - BLK_DEV_IO_TRACE [=n] && FTRACE [=y] && SYSFS [=y] && BLOCK [=y] So, CONFIG_TRACING or CONFIG_BLK_DEV_IO_TRACE are the two options that prevent CONFIG_TRACEPOINTS from being set on arm64. For CONFIG_TRACING we have: Symbol: TRACING [=n] Type : bool Defined at kernel/trace/Kconfig:157 Selects: RING_BUFFER [=n] && STACKTRACE [=y] && TRACEPOINTS [=n] && NOP_TRACER [=n] && BINARY_PRINTF [=n] && EVENT_TRACING [=n] && TRACE_CLOCK [=y] && TASKS_RCU [=n] Selected by [n]: - DRM_I915_TRACE_GEM [=n] && HAS_IOMEM [=y] && DRM_I915 [=n] && EXPERT [=n] && DRM_I915_DEBUG_GEM [=n] - DRM_I915_TRACE_GTT [=n] && HAS_IOMEM [=y] && DRM_I915 [=n] && EXPERT [=n] && DRM_I915_DEBUG_GEM [=n] - PREEMPTIRQ_TRACEPOINTS [=n] && (TRACE_PREEMPT_TOGGLE [=n] || TRACE_IRQFLAGS [=n]) - GENERIC_TRACER [=n] - ENABLE_DEFAULT_TRACERS [=n] && FTRACE [=y] && !GENERIC_TRACER [=n] - FPROBE_EVENTS [=n] && FTRACE [=y] && FPROBE [=n] && HAVE_REGS_AND_STACK_ACCESS_API [=y] - KPROBE_EVENTS [=n] && FTRACE [=y] && KPROBES [=n] && HAVE_REGS_AND_STACK_ACCESS_API [=y] - UPROBE_EVENTS [=n] && FTRACE [=y] && ARCH_SUPPORTS_UPROBES [=y] && MMU [=y] && PERF_EVENTS [=n] - SYNTH_EVENTS [=n] && FTRACE [=y] - USER_EVENTS [=n] && FTRACE [=y] - HIST_TRIGGERS [=n] && FTRACE [=y] && ARCH_HAVE_NMI_SAFE_CMPXCHG [=y] > > I believe the reason my .kunitconfig as well as the existing > > mm/kfence/.kunitconfig work on X86 is because CONFIG_TRACEPOINTS=y is present in > > an X86 defconfig. > > > > Does this make sense? > > > > Would you welcome a patch addressing this for the existing > > mm/kfence/.kunitconfig? > > > > I would also like to submit a patch for an mm/kasan/.kunitconfig. Do you think > > that would be helpful too? > > > > FWICT, kernel/kcsan/.kunitconfig might also be affected since > > CONFIG_KCSAN_KUNIT_TEST also depends on CONFIG_TRACEPOITNS, but I would have to > > test that. That could be a third patch. > > I'd support figuring out the minimal config (CONFIG_FTRACE or > something else?) that satisfies the TRACEPOINTS dependency. I always > thought CONFIG_FTRACE ought to be the one config option, but maybe > something changed. If we want a minimal config, setting CONFIG_BLK_DEV_IO_TRACE, CONFIG_SYNTH_EVENTS or CONFIG_USER_EVENTS seem like viable options, for instance. But AFAICT, setting them in the context of KASan doesn't really make sense, and I might be missing an obvious choice here too. What do you think? > Also maybe one of the tracing maintainers can help untangle what's > going on here. > > Thanks, > -- Marco Many thanks, Paul