From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5886C369C2 for ; Tue, 22 Apr 2025 12:11:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2CA376B0005; Tue, 22 Apr 2025 08:11:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2524B6B0007; Tue, 22 Apr 2025 08:11:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CB836B0008; Tue, 22 Apr 2025 08:11:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E56DE6B0005 for ; Tue, 22 Apr 2025 08:11:36 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B4CB9160FE2 for ; Tue, 22 Apr 2025 12:11:37 +0000 (UTC) X-FDA: 83361565434.29.E7C4471 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf13.hostedemail.com (Postfix) with ESMTP id 8F9DC20015 for ; Tue, 22 Apr 2025 12:11:35 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=c+teU+uT; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf13.hostedemail.com: domain of mkoutny@suse.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745323895; a=rsa-sha256; cv=none; b=jeyDX9f3N4eyX1sfeZokBvGQcAzPdiIY5EszYfmQLWrYzvLWXlz2DDDcec9kQt+PCY3k3G Hbjl3Q3Fpz3Bwl6lNP/IuLkLOJ0SHm81D/BQW5bX2xM555XyF7fX97iBVZqYx8XYMlnNDx firJUzbD/+OF0cFWjhA0MbVoMUKFWlY= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=c+teU+uT; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf13.hostedemail.com: domain of mkoutny@suse.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745323895; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KT1JxRWSPsmY8fesz3r5b2lILhpBpQyPhmAe3rmQpu8=; b=dfN1AduJ/PGFLooO7jd5KoBrllFNcprE/M4etIywxtPqyAaaMExQ00ZzNoValhco64cvw7 upvXFWpZqx/AqQ/1lWxKUZaBrKfi6HVSVq7wadQ7i8Rw/l0xnkqF75umy5o74e+YR2Xs/r qVHhO1rHM9FpSkvqcjQYaRXO1Weh570= Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-ac3b12e8518so842248066b.0 for ; Tue, 22 Apr 2025 05:11:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1745323894; x=1745928694; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KT1JxRWSPsmY8fesz3r5b2lILhpBpQyPhmAe3rmQpu8=; b=c+teU+uTOseG+EJTzM4ViJYYdiZdZ2HTRjCAWpbeC2A0Pin/l2QrgkT+QMVOk7PKUx XB1Lx/LMAxTBWPDqbtJe2ZpBt6s2GqxfP/uEBx/FKgY3/eQpxGbF5aFqcjL8G16eiOAg lwY7w1rjpW0uQq2t4rQfU8oidctrWI04exlwvHyh/LJaep3NgnfA/AtrjfyPD1cPjyGT COHmq4quxO4rE4dO/F14b057jZDXkhAIhyw3xryz97fozC2gNAf+QUPvGZbT6J2RdWhh eHIureXxG50JInvesltap3PTYwLNP6c5PgZSXgRFGvdffXTzOyRiqn2+Og0Ud9pdPmwW EhfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745323894; x=1745928694; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KT1JxRWSPsmY8fesz3r5b2lILhpBpQyPhmAe3rmQpu8=; b=FKl1NEqb9k6rVgpdQ0R+Jvk0ejd2fW+EqaC5fxU/hAbxnE7Bx0HE36mh1JAIP0liFf Ejhxdj21/QBr0CI8cVAR5drq26OsvdHDGw5mhr2oVdVMPT9SXVSBnuVMPa0s83nPVcr3 BSML2RiQ29RtsYA8XGPgf273zczTDSxjcLi1/n3S1sDCGt5lXSRfApaiwK7Z8QoQFwO8 esIZOFLM2fbmSe9PvjNYdZgy/ONs897X5CM+3s4lDKBwJCI+LtWbpoxvJeIG6oX4xlzj O8NhjXXEtLjobq96CmNvgLu3zlrfdEOBy9ZA7lUjGAnMgVAh9kISgwnukE3eKp+vgBkW t/Zw== X-Forwarded-Encrypted: i=1; AJvYcCX4GDp3yZaL+EcgTw1A0resm3wOp92RSbMWOLNFhONzI5qh3HXaUIWwE+dr25+/ndt+ufoaJa38gg==@kvack.org X-Gm-Message-State: AOJu0Yxsd6IlfsGvyXdptlwy1gV7lE9KrHSGCFyPhxTL5MRTqDKeg0RB CqOvzicBsMjrJ0/4mNjcQbTKCQMVeAUkRN04J3mZCKHA1YTl++KmDA9U8iXOawU= X-Gm-Gg: ASbGncutm73QYtQ2hyOj+gVDKeXMNSPoGy0DkIM8TEjLHRlj6SScaGQazBpcYgDfMMR 2oU56XT0dfi/4bagsmjMchFjFsQhsaWRZAmmde7R5vdz0T38yxLhyzXxHkMfvSqRKlNAAmQiH0i 7/w5q/NqMXRlEIcwUyDmCfjYP02TASdtiTNo1Nm7I7jVddgOQ3jAY1E8CAxufrTN8+z+Uk1Inja u178rk/Yjofm6spvA1fvkmtnZ1jxHQzUDLRGwPXVwK9Bm/iruOC9ciaTZ5n8nZKnKOPRiC4TxUo 4qD19mRmN9G8jpH/XreHk9aqxDEmq3FDTzseBJIkGEY= X-Google-Smtp-Source: AGHT+IFyYmcZlvcAITMghOEvilutpzLwoU5xPOnInSRoTQAJsg2jq3a94IEVeo4CoWvMA1NEnQNxKw== X-Received: by 2002:a17:907:96a4:b0:abf:19ac:771 with SMTP id a640c23a62f3a-acb74adabfdmr1382972966b.2.1745323893733; Tue, 22 Apr 2025 05:11:33 -0700 (PDT) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acb6ef4ac41sm644389366b.152.2025.04.22.05.11.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Apr 2025 05:11:33 -0700 (PDT) Date: Tue, 22 Apr 2025 14:11:16 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Waiman Long Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Tejun Heo , Shuah Khan , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v7 1/2] selftests: memcg: Allow low event with no memory.low and memory_recursiveprot on Message-ID: References: <20250415210415.13414-1-longman@redhat.com> <20250415210415.13414-2-longman@redhat.com> <0033f39f-ff47-4645-9b1e-f19ff39233e7@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sq3j7fc2pogean7z" Content-Disposition: inline In-Reply-To: <0033f39f-ff47-4645-9b1e-f19ff39233e7@redhat.com> X-Rspam-User: X-Rspamd-Queue-Id: 8F9DC20015 X-Rspamd-Server: rspam04 X-Stat-Signature: w9d8q64w8fe1qzhsxnsk6s1xemorpon4 X-HE-Tag: 1745323895-806667 X-HE-Meta: U2FsdGVkX18Lr5u4VGcRzjejIiFKaZScpCNDpqaJcTC7mBrNOmJmRz5qdlk5bBv5gYYhBTAv2GNUpwkNVz2WqD5v33mFnDLjvnrz5OOGfmIzdTa7yHj5eBCxfZ9PlDjhx+1wNwyAoz4TESX2zWb0QCW9wEsXXvlDCx/e5G6cNTimf1vA+YjaulXEIsAZejgpc3tnH11JyMIfbnS2+qC7K698NzQx0NlPztiSAqGW8Lmo9IzgxnJUgaI2voUMW6v4bjz0y2kYaZDixABv1l4pzLE0Tw/Lj3zPe7u2tlIBJW5C+hvviAd+oQp/Qnc8gwYvD3MTIZC/68HfKt9DsIZFvCGAaXpaNM+plDigQc+RGHUAqWvL6BT0kOtPAxXEKCKAIwHbQnC4QZlY7TJnoHsy+LaU2SzZk2/Kw588ClzfG5JMhF50BgXfP1js9UNO0ZderI3SLY06W17zDPbZtN9GoRzftuJYaeMHl9X9Il/Sfzg32/6N+NLTG4cQm4jWgb1Z6JGNpx5xyub4htZy7p3qxaJORYravI+SB/E0EZbvtQsPQaaxIgi6A8YM9vD4ehxB3/jEYlo3/cdI8pTgumyW7QgQMXi7OWv8XyARbPqVE8esHAMUJLJOk3qFWIELFuKbktDQHxjyzc176R5WJJjrK0P5zvyz4unlOS6TD8D9TYNz/GBw6BHGQ3kgmiy/cqbDytHDPV/+V3wcQZr/avAyng3XKCUKCcrzfDe5fIk2P5kfFAhrwDpt3ecD0YmIZvyDDgcycVtb29rG9ZPSkQXXHKAwE/bVwY0ZBPKidYXO/ZpPXtFVE1LVMVVEuK1dlEuQGKNLxKv3cZzRN9cG/ExE8kdFtJqnMSxydfrlQKHmCLgMfqvsiQN9tAV5PRp0rSy9IiZ9xAvmWPf9dHWJntTicdRUTGPtJB0M3PO+XVP1HH/s3eLUJlQA+g7+JFJgJcRJnq/x4X7WdwEmjTIBQTN MaQ1i2if IXybnDqE3ErLNq4xEz21KTDgQkrCuuVjrsIWfte/vg3NkUH5tSxohyT8FG9zL901EpyaPDobnmvrwKk0qSM6H1yKa/q+GZ+7Nn/mzqqPAPUGMArP8/6Me2gngfmLO9rGq67t/OeXFS6nEZ4RYdkqWWcj6mUYRrJtkaq9SCAG8SqtdM2C0yFDTsZ6DYvMwXx92wNYCTOUxsODEhN6m4WKE8CUrwfaeyW+ofGDUnuNcvC2+4jNbTxTM1/jpz4MC9nxIpxzKCGnVaggNllXS0VHNcqgc2UugTWtvi6hC9q3tmFgSVRjhwpmzQhLf73Hqfj4TK9VrD63fstVL+F7ZFAV07nqFdd8RoO1CcmmOVvMjWxTBS/+RGhBPTbnm8EHrS77jgi2CZKt9edird0+F44x6wcYhmu1iC66bkGqegijln2bKtfCASvdoH0ejLuh23rhUBZGfNOdJhGnZfLIw5fiR8aCihLXMGLk3Sdz8QeyUg6N0jiKfsVvhcQ4vkX4AL1hDF1JO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --sq3j7fc2pogean7z Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH v7 1/2] selftests: memcg: Allow low event with no memory.low and memory_recursiveprot on MIME-Version: 1.0 On Sun, Apr 20, 2025 at 05:48:15PM -0400, Waiman Long wrote: > I was referring to the suggestion that the setting of memory_recursiveprot > mount option has a material impact of the child 2 test result. Roman > probably didn't have memory_recursiveprot set when developing this selftest. The patch in its v7 form is effectively a revert of 1d09069f5313f ("selftests: memcg: expect no low events in unprotected sibling") i.e. this would be going in circles (that commit is also a revert) hence I suggested to exempt looking at memory.events:low entirely with memory_recursiveprot (and check for 0 when !memory_recursiveprot) -- which is something new (and hopefully universally better :-) Michal --sq3j7fc2pogean7z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTd6mfF2PbEZnpdoAkt3Wney77BSQUCaAeHYgAKCRAt3Wney77B STU8AQDtPchwdDd7GvYG9/lftHphnD62oj3o0m0hpo2aWJjY4gEAjv+IF2GZLFKQ 73DPixoPDX77bf3ZdvlqpW53y0lI8wo= =3Mvf -----END PGP SIGNATURE----- --sq3j7fc2pogean7z--