From: Hao Li <hao.li@linux.dev>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: akpm@linux-foundation.org, harry.yoo@oracle.com, cl@gentwo.org,
rientjes@google.com, roman.gushchin@linux.dev,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] slub: clarify object field layout comments
Date: Wed, 7 Jan 2026 23:10:48 +0800 [thread overview]
Message-ID: <h3t66dtapxvm4fwm7rrappffipb67kofq24x3dlwjmrte5m4ef@awbg6bhc54je> (raw)
In-Reply-To: <0a2474ae-013f-4c9d-b70e-5461367abe6f@suse.cz>
On Wed, Jan 07, 2026 at 11:35:49AM +0100, Vlastimil Babka wrote:
> On 12/29/25 13:24, Hao Li wrote:
> > The comments above check_pad_bytes() document the field layout of a
> > single object. Rewrite them to improve clarity and precision.
> >
> > Also update an outdated comment in calculate_sizes().
> >
> > Suggested-by: Harry Yoo <harry.yoo@oracle.com>
> > Acked-by: Harry Yoo <harry.yoo@oracle.com>
> > Signed-off-by: Hao Li <hao.li@linux.dev>
>
> Thanks, that's a great improvement. Adding to slab/for-next.
> Wonder if some ASCII art diagram would be also feasible to add, if you feel
> like trying :)
Great idea - I’d be happy to give it a try.
--
Thanks,
Hao
>
prev parent reply other threads:[~2026-01-07 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 12:24 Hao Li
2026-01-07 10:35 ` Vlastimil Babka
2026-01-07 15:10 ` Hao Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=h3t66dtapxvm4fwm7rrappffipb67kofq24x3dlwjmrte5m4ef@awbg6bhc54je \
--to=hao.li@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=harry.yoo@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox