From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D5F8C25B74 for ; Mon, 27 May 2024 13:15:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0363A6B0085; Mon, 27 May 2024 09:15:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F27856B008A; Mon, 27 May 2024 09:15:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEEE16B008C; Mon, 27 May 2024 09:15:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C45BE6B0085 for ; Mon, 27 May 2024 09:15:20 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5950C1414DD for ; Mon, 27 May 2024 13:15:20 +0000 (UTC) X-FDA: 82164222000.01.791379A Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) by imf28.hostedemail.com (Postfix) with ESMTP id 15D0DC0006 for ; Mon, 27 May 2024 13:15:16 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=bg34lXVZ; spf=pass (imf28.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.171 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716815717; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fAbpqHYArlgEA4jndUz59wBOUYS1i0aiS/4KxphB4UI=; b=Xe9wewrwM5e75QxvS2w+JVFfjXIss1pmDqPvos0Ahe4i0hBZas2NJHnwZboksEbgA7ViDU che+pCpZS0hIAhDRtkTJElpYriLOFC9FXw4t8+g2Ag5bjLbuc9pc157wP48KlyldqOBCp4 zzx0Osg4ZaetC5Qywz0jDTlSocmmnFg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716815717; a=rsa-sha256; cv=none; b=2udZpYgwts8JHblGctQTOTYMq0ZJHp1q3XXKILfsEY/re0AvyrWvkQcsThtm+jJcODbMsm 1jRXjTA2ATnARCEhd5dmF+d11t1+DwOQLKtzx13CsWpTeOQ8h7btCjJ6gBf9g4xsLbOB09 kjexFr0XaQLSQdk/oqvyQpDuPAsB38g= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=bg34lXVZ; spf=pass (imf28.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.171 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Envelope-To: vbabka@suse.cz DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1716815714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fAbpqHYArlgEA4jndUz59wBOUYS1i0aiS/4KxphB4UI=; b=bg34lXVZhV597vXyWDG4RuvE8RbwP3Lwxz6YxhMDRmvdkRdQ9zgF/aLMSysVqr3vIk0XXR Gl7GlJa2JfxJLxT93Qf5EGxprVZuKjkPdnMvHnZdTW+x2+5yCkX/mTlIAoKjnOLWiYVP/N k1No0gau4uhxJvwiIcwpHCuAhrT+8SQ= X-Envelope-To: cl@linux.com X-Envelope-To: rientjes@google.com X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: roman.gushchin@linux.dev X-Envelope-To: 42.hyeyoo@gmail.com X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: surenb@google.com X-Envelope-To: keescook@chromium.org Date: Mon, 27 May 2024 09:15:10 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Vlastimil Babka Cc: Christoph Lameter , David Rientjes , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Suren Baghdasaryan , Kees Cook Subject: Re: [PATCH v2] mm, slab: don't wrap internal functions with alloc_hooks() Message-ID: References: <20240527090127.21979-2-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240527090127.21979-2-vbabka@suse.cz> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 15D0DC0006 X-Rspam-User: X-Stat-Signature: 33yukq9rgghyh7ru4w1daryx5qjy3hts X-HE-Tag: 1716815716-256757 X-HE-Meta: U2FsdGVkX1+LPaRAsUW0iqVjKqf4/9PPMTL/urfmKQCXyFHNtAXAkr09HDb0CPqyYjQZMlXnr0nYYogMNNryOrgxWUc3NmOKRiHPkJ9kz2QvtFCwzpfoM4wZpZ2Ah+vS/IExcqav1+2aS5rqisK6itrM7S+tUJQZvoNDSh+8Gtq/AVk7Pq4I7MJCO8o22nPDy9a+z4fHFfnL3jM410kpw1XCAB79/WaKfRhlSFWJmIrklOxxyqZyHd/X5UxXSE1i1STU0GBd7RWJavj6pCVrTsnOkdEEoiuTLI9PisVeyAzbn5sv5+U0YXnaVpvjPQkqbKVIoArIvxKOcB48FoanrJzt0fQuzc0+3BvCF8A8uQtD8i8xBm/pXqJnkMmGLRqsL+MlO7+RgT3cG85rBjBqjt1FTrEX35IwvIaJONKwrf66s+Ws2/K4RqpmuWMzCnutGc8Hy0A3nnxyKm+WR9yG2niwt2bNO3s2FVWqUUPkmuhzsccW6XuoUgiD3EcI3tEmIwC3n9o2LqxgweA9q7qPvKTuRY4ir2ZqsiGTk637c7Y5Y1viypiK0F3p1OUMZuL7+cB06ua08QcTgAmyAi+28LN/1LA+2yPtgPLFIwV+du2o2Pumu3b2WwAG33Skwckjn0wrRxnVwvu37VM8cMJnLEDEelpO1UEoIP2r3kVSxNeN76ZwCqT/sgnhQrrOLPU2lf73RokvZFgFIV1pL1sd2wV78mwYQNmf5F7gEKKwew02wIliyNvFCdJ62h1j3+CcT4YoE3i131Jm9PxlRmvq3AsF+HxfyNS4IN+UqLgEPNjN2LhrgaL9AVEFF8SDUE4EUcwraZuHYh6DBSPyjvrnjYpFqzkIHRp7EDLPgsMDjF0sVRmXHGlMxJ8rIRqliMEU+3dGaXqWuYuDicI9ElaihK1hazMuVYEpYHxiUBBNRYixqC17BADhIK5chTjpSybtardqteAafvcVfwCDuPM BccDby7B wcDIlwcLVNbzoo2Fr9y7oZQ45NKXLoSChtfLw+L8P3YpD/Uy7ljrgBBKrXW+tEAVPltdf/+zZmekaPnRPRBVFGLD4kpLfmGH2eIRsDaXECs3g2zowZSR8HSzCNOdNxZHt3OeHDy0DVWEPajmSypg7WApMwhC5rYDyyfeLXGKxoOlK1LyYnF9MaTb+tDwMoCwYH6EaJVkkT8WP0QJGbsOzAXaZYggTWWJ9qTu720BdHpT0AE8ZVyAyX1WQwMV8Y8dcr2Hyq3N7X7fy95MdrgreW7ZeMjmHS0EEErcL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 27, 2024 at 11:01:28AM +0200, Vlastimil Babka wrote: > The functions __kmalloc_noprof(), kmalloc_large_noprof(), > kmalloc_trace_noprof() and their _node variants are all internal to the > implementations of kmalloc_noprof() and kmalloc_node_noprof() and are > only declared in the "public" slab.h and exported so that those > implementations can be static inline and distinguish the build-time > constant size variants. The only other users for some of the internal > functions are slub_kunit and fortify_kunit tests which make very > short-lived allocations. > > Therefore we can stop wrapping them with the alloc_hooks() macro. > Instead add a __ prefix to all of them and a comment documenting these > as internal. Also rename __kmalloc_trace() to __kmalloc_cache() which is > more descriptive - it is a variant of __kmalloc() where the exact > kmalloc cache has been already determined. > > The usage in fortify_kunit can be removed completely, as the internal > functions should be tested already through kmalloc() tests in the > test variant that passes non-constant allocation size. > > Reported-by: Kent Overstreet > Cc: Suren Baghdasaryan > Cc: Kees Cook > Signed-off-by: Vlastimil Babka Reviewed-by: Kent Overstreet