From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5FD8C4829A for ; Tue, 13 Feb 2024 21:32:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 562676B0075; Tue, 13 Feb 2024 16:32:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5134B6B0078; Tue, 13 Feb 2024 16:32:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B36C6B007B; Tue, 13 Feb 2024 16:32:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2A90B6B0075 for ; Tue, 13 Feb 2024 16:32:11 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 01FF9A06BB for ; Tue, 13 Feb 2024 21:32:10 +0000 (UTC) X-FDA: 81788078862.29.4234C43 Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) by imf05.hostedemail.com (Postfix) with ESMTP id 41CEF100010 for ; Tue, 13 Feb 2024 21:32:09 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=0svSCnOw; dmarc=none; spf=pass (imf05.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707859929; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SqfwDLtYqZ4YXjfJ2o5OE5yS66S2VvSjmgmc52Til+A=; b=HgVR8Yz9H2WIdjEYd65/LT0KM8zHGJ4+Igzr0sXkNqQKurLfbtWnGGdrPOynHbVK6QXhCX hrdZKEd6bMcZsb1M1VGYBRuJoDmGg9suK8bgrvS8GrSzbWfsnqtkKfrvPsSbj6Zp2LitCJ Ow7UBFM0bJ8PEEXUKJU0r2tSz4zu+7w= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=0svSCnOw; dmarc=none; spf=pass (imf05.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707859929; a=rsa-sha256; cv=none; b=3or6sDdNxiqNDPPiHKvQb48VJocD/yCUzX0jCvT2ThNHBKYhm9NIIqbuQwIsfxGup5M3g/ 8p5jc4e72DqphbzW0fSoRfX4fzi4xFP0+8kv4pD44N6pW4xRHcYZF8b6eZxCIJ1ZWiP9jM DfSQV0ykT5pY7w8rYGAXe32J5W8n/60= Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4TZF056B7cz9sq5; Tue, 13 Feb 2024 22:32:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1707859925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SqfwDLtYqZ4YXjfJ2o5OE5yS66S2VvSjmgmc52Til+A=; b=0svSCnOwg9+TLKRVdZO3GM1vAQEP8qcoMdwMPzywRhFTm6ciAv/y+bs9rov5029K9a9h6H O9bUtcbYcRsbJfeX98f0iztvh0pB5Vchn/xzbBKUgc5T2z7xCpxNrWd2yxfgcGnjCootlJ 2cErrMI2Z78Sb67Cyg8L758Sk/1Je6bzP/3VkGOBUv7MvfNXTjk+h/KxZQzUSfuSQlwTh/ NbXHPZfCoDzNDOPjfwk4PN+br0WErcQ8AoKv1N9/Y9mA3r6znSHor39N6rdoEQbaWORKIA 1Ne1R2MIAUwb1UEeH2fb7K84qsFbCkJSPWavauvSoeYnIchz3x6GxL3hcycIuQ== Date: Tue, 13 Feb 2024 22:32:03 +0100 From: "Pankaj Raghav (Samsung)" To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, akpm@linux-foundation.org, kbusch@kernel.org, chandan.babu@oracle.com, p.raghav@samsung.com, linux-kernel@vger.kernel.org, hare@suse.de, willy@infradead.org, linux-mm@kvack.org, david@fromorbit.com, Dave Chinner Subject: Re: [RFC v2 11/14] xfs: expose block size in stat Message-ID: References: <20240213093713.1753368-1-kernel@pankajraghav.com> <20240213093713.1753368-12-kernel@pankajraghav.com> <20240213162704.GQ6184@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240213162704.GQ6184@frogsfrogsfrogs> X-Rspamd-Queue-Id: 41CEF100010 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: nzhxzkkmzykrkfdw7dzac1mguind5w4i X-HE-Tag: 1707859929-926824 X-HE-Meta: U2FsdGVkX1/QrziOw6LlZVZqCbghE+BtJ3Dt0JKdgC24XoUSv7ll522lKrW4/iGF3fhfpcR1hFHCWLp6amiCbuVHtuugWUSsNP84fXWAVuOfpYKsfUHHOek+8c89rEOn1AUMilCNEg7wiNRg4IO4iwKlEgWjVpWuLAGccKomYEdbB7e9Cz6MFL4PN53KqrJBDwFPTcsDDZuH2tVP8RqeORvudlFHvYjl1Im3aDT7Rn0qjA5CT320obJcwM7yJ+mToZIt4eoQV192uMCaZ99CwQtSt9fIpWlgOuYvexSrv97HtU8Q9YgR7sUHtvWjuEHgwIx6twWIk0kpNM9OH360kXiTza+qFzCC7bVzs8xhcUP5eJY/00B9C8ybRQUzfmiG5G+suJIpf2a/ZQQ2yDz3XOgcCorxpqGCmpLiQcZ3dWCQTdBh5Tn+7AsyMpRalSzfbzJMDP6Z1Ycsan/rC3rEyraX7MkwqQWCfTAi9A3vbh9ddpLuSXyUUwk0z7Wjrt40pZJwkZlTq2niAQO3Xb4oNBWgVtDgm8RooWfyimSsO88lyzCABNMuiKcRqvkxks/MX2/vDOS/aBWKrvAFVrxIhiKBfpxXPQABOt6Xynb4XumlCbi97t1zT10VWKB+dRKXjz3Q0t+TCsjW3RRiT8R9r9kPuhW8EYyxNLA7aUngscw/DvD+3bDfnyjqgHQpww7X8kYV8bsSaX2ZMWdcwCG/s0catOY/iX0zuCY7bHds6n64ImMn1eMOihBMt3KGr7yd1v+ApaWHZpPq0BF3A/rcuFCTmeK3k95Hh2dpLy5M8yKaevdG0MPRsdVhFL6xyWI1nRu8SO3JD3CpvbFXNXjGEmCbHxHh/mgD3S0FF/WdUxF0+I+RGHi+HqWF9zbUBu66jPFgwvcjNwSjHQHDqfA0/fpKiQ78HajvFMx8cmopa72rE9mFl0BI+rH76Gk3kFr8HQSKBNgeWLdJuesFNh1 6Kq8TMnc YQ1hAmssBPNf87wEZsmJAnxK8Q3NjHhRf4Zk155k84Xbc1J1g3qFBQgj+tkkuP3pPyqWnl00uyJertlezFMkf+PwNxksyTadXBjXXucPWvkuaySRVq+RXvIR35VT+u3gJGJb3PLX2WK3vLld+iWd0zHtRTUf4/0jvJDjuwdl07xd595U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c > > index a0d77f5f512e..8791a9d80897 100644 > > --- a/fs/xfs/xfs_iops.c > > +++ b/fs/xfs/xfs_iops.c > > @@ -515,6 +515,8 @@ xfs_stat_blksize( > > struct xfs_inode *ip) > > { > > struct xfs_mount *mp = ip->i_mount; > > + unsigned long default_size = max_t(unsigned long, PAGE_SIZE, > > + mp->m_sb.sb_blocksize); > > Nit: wonky indentation, but... > > > > > /* > > * If the file blocks are being allocated from a realtime volume, then > > @@ -543,7 +545,7 @@ xfs_stat_blksize( > > return 1U << mp->m_allocsize_log; > > } > > > > - return PAGE_SIZE; > > + return default_size; > > ...why not return max_t(...) directly here? Sounds good. I will add this change. > > --D > > > } > > > > STATIC int > > -- > > 2.43.0 > > > >