From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B62DFC636EE for ; Wed, 28 Aug 2024 19:11:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A2D66B0082; Wed, 28 Aug 2024 15:11:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42BC76B0083; Wed, 28 Aug 2024 15:11:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CC596B0085; Wed, 28 Aug 2024 15:11:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0BA076B0082 for ; Wed, 28 Aug 2024 15:11:28 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 84A26A06FC for ; Wed, 28 Aug 2024 19:11:27 +0000 (UTC) X-FDA: 82502597814.22.CDD7178 Received: from out-185.mta1.migadu.com (out-185.mta1.migadu.com [95.215.58.185]) by imf06.hostedemail.com (Postfix) with ESMTP id A9C2E180008 for ; Wed, 28 Aug 2024 19:11:25 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=B3LfUWA8; spf=pass (imf06.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.185 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724872197; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5GJ0kQNrYXX9msho8J4AhvERHyhJZ0duOS+e8oU72YE=; b=k7wIGtw485ipPzP9wDWaV6jX+mqGYxeN9H6sCCiyQPCRJN6t6DN6OUuBi7arfXL3YLmzGS 24Qfk2Juzr/YOLWBHebPKyDjjMe4Xecd5G7/e4408wGmHvAOl3hkUYA2PntuqLHOADUJKn mUcSv9nRfhSInlGwtyEUqISKpIga8Ug= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724872197; a=rsa-sha256; cv=none; b=NA+51nKYFFy1781IRs4lQHYkZ65ALd+Iv+ufLnrBADzZrXNaOijXRKVEcnrYDjnSE4Zl+R HLBW1cvgMbFaOzMwZ2luina3H8yu8VZ7f5VIglUuim7brR9LsAb2EBVryVPGdrbCWEtJM0 bK/RwTPHQwCvNbVKP1rhhCBdec8JBMI= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=B3LfUWA8; spf=pass (imf06.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.185 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Wed, 28 Aug 2024 15:11:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1724872283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5GJ0kQNrYXX9msho8J4AhvERHyhJZ0duOS+e8oU72YE=; b=B3LfUWA8l8mmjSaFE6ClHPtuaOFidM2PzSFwePSZfiEQifAAVqUkYhY10DynXMQw3ODDYY QIIZoSt1z0wfqLJjUt0+eDfyko6JI/8MBw4Ua5La8XdmAHWRV6QgjkssZBcW9o8SG9Ppma KeyI1odcm9BVsEUCU0PgAQIPhHNFed4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Dave Chinner Subject: Re: [PATCH] bcachefs: Switch to memalloc_flags_do() for vmalloc allocations Message-ID: References: <20240828140638.3204253-1-kent.overstreet@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A9C2E180008 X-Stat-Signature: zp8zcp88e65kmbzri67sgf5dwjiishuz X-HE-Tag: 1724872285-402419 X-HE-Meta: U2FsdGVkX19eh51mwLaogk+uNuDKsCQGYe5h7+Iwuo4VmgobF/NP8WO5vJBsv2uRIlg/uuEQfYY3RVMJJyYHDSCKTA2EqR4BA7R/M5sE/hGwm64t0nAkpg4y353xl7fv8ozPCze/l6SP3E4uiubCAm/DStrus7dG2yWJ4LgMFKDz0xTfRuo8O1UK/dhgPfyNuFNDPa5sl4NgLUodAqzfLCj0XiuwASbFduDmtMiceQnmQA4q3mDIjQ2L492aRyxRXMVQJ1iZ/pxpmNS/xlhP2VHRUT6KLQEVlksayc3ogYppAwlKwR1Yfutir/A8ys1F+v0Uze/awOhG0QCE5q2LShHOsB7A07WzyeAYDUdsoLsR4zlu82vFCiUF1P/CsZGj+syymhNiESTn1Nxnisi7bli/lQrMwqRp/20aqO451EwAJgPgUjd4KjxJWs00a9do1iI4gVwm6HAdbTmh89axWZf+fY914D1h3Fw4qpzhl+HFCoSJYJ4rEQqp7ODA9T3U87zkLpnJScEVscX4hB0pWaWHrK7u0f6z/botJgRzTeA/1ui/Pe5vtVKw9IYgjetekyzDLNQMyRRjV2H8KzoYESijunHeMrbLWrvdvEHP1f24B9eBuVCawVuEQ5YjdTIT268c4KR0ITukJ/pTXj53GTFc/WhcxNNigtv62lxShtSOTPpikWcxV7EpGVfSNEthL5E28FuxDgBSoAb6zZCuc/rI/FrUWn68TIO80kFHql4DSs2yOSqn5pd2go6fLtfXUO3uQ/BchmrHSWpU+ALp+MpupgUNuDNLr51dvCj2VLXZkoPDPcRJITHN/KKPZBP6P81MRDNYSTjBpeOS9Wi/+ufUCG6ExC31zKVxitqOUyae8epDDq3YVSW+tk81EnnxyDNDQ6fh04odKwZqKHTMID9QYUZPBvNY99Vzj16lb4G/Q2wsuKl+aSpCMYrQmJaBA+mCYsbeEV/lO+AtY5a W90LHFcD L096a65WjMN7hvdo0SMW7bVHgvpBEEvEjMIG4c2eTxFyjfv8BXZY/JRPuqa48uJQ68RaeMzzuLIzvHHDiSD4cNP3OigQnXU0AK3tby6BX49MYhEL9MttwUw8C6L5HYdXdAJZKpssbn+iM+Byb6eOfMhDJutrFKxxUvkV337leuAQTyuHOf8PzOCWwlzwSEQbkIpzQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 28, 2024 at 07:48:43PM GMT, Matthew Wilcox wrote: > On Wed, Aug 28, 2024 at 10:06:36AM -0400, Kent Overstreet wrote: > > vmalloc doesn't correctly respect gfp flags - gfp flags aren't used for > > pte allocation, so doing vmalloc/kvmalloc allocations with reclaim > > unsafe locks is a potential deadlock. > > Kent, the approach you've taken with this was NACKed. You merged it > anyway (!). Now you're spreading this crap further, presumably in an effort > to make it harder to remove. Excuse me? This is fixing a real issue which has been known for years. It was decided _years_ ago that PF_MEMALLOC flags were how this was going to be addressed. > Stop it. Work with us to come up with an acceptable approach. I > think there is one that will work, but you need to listen to the people > who're giving you feedback because Linux is too big of a code-base for > you to understand everything. No, you guys need to stop pushing broken shit.