From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: akpm@linux-foundation.org, maple-tree@lists.infradead.org,
linux-mm@kvack.org
Subject: Re: [PATCH 0/4] maple_tree: current split may result in deficient node
Date: Sun, 20 Oct 2024 16:34:03 -0400 [thread overview]
Message-ID: <gufk3c2pfwpjfbouhfxk7dvxwqdm6zigk3dppz6diu3bd34e4l@7aaq57d47czg> (raw)
In-Reply-To: <20241020024628.22469-1-richard.weiyang@gmail.com>
* Wei Yang <richard.weiyang@gmail.com> [241019 22:46]:
> Here are 4 patches related to correctly split node.
So I haven't worked through your last bunch of patches and I had not
fully responded to v3 before v4 came out.
These things take time to go through because you are changing fiddly
things that may break things or cause regressions, but you keep sending
a new series while another is in flight.
>
> Patch 1: adjust the calculation of split
Split calculations exist with +/-1 to avoid jitter, but I will have to
look at this in minute detail.
If you screw this up, then we may lose data.
> Patch 2: add a test case to check deficient split
> Patch 3: the min value for mab_calc_split() seems not correct
> Patch 4: during validation, we skip right most node on each level
>
> Wei Yang (4):
> maple_tree: current split may result in deficient node
> maple_tree: add a test check deficient node
> maple_tree: use the correct min to calculate split
> maple_tree: only root node could be deficient
>
> lib/maple_tree.c | 8 ++++----
> lib/test_maple_tree.c | 28 ++++++++++++++++++++++++++++
> 2 files changed, 32 insertions(+), 4 deletions(-)
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-10-20 20:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-20 2:46 Wei Yang
2024-10-20 2:46 ` [PATCH 1/4] " Wei Yang
2024-10-20 21:55 ` Liam R. Howlett
2024-11-03 23:47 ` Wei Yang
2024-11-08 2:30 ` Wei Yang
2024-11-08 2:49 ` Liam R. Howlett
2024-10-20 2:46 ` [PATCH 2/4] maple_tree: add a test check " Wei Yang
2024-10-20 2:46 ` [PATCH 3/4] maple_tree: use the correct min to calculate split Wei Yang
2024-10-20 22:00 ` Liam R. Howlett
2024-10-29 17:49 ` Liam R. Howlett
2024-11-08 3:02 ` Wei Yang
2024-11-09 1:24 ` Wei Yang
2024-11-08 2:55 ` Wei Yang
2024-11-08 3:19 ` Liam R. Howlett
2024-11-09 1:40 ` Wei Yang
2024-11-09 4:01 ` Liam R. Howlett
2024-11-09 12:22 ` Wei Yang
2024-10-20 2:46 ` [PATCH 4/4] maple_tree: only root node could be deficient Wei Yang
2024-10-20 21:56 ` Liam R. Howlett
2024-11-03 23:15 ` Wei Yang
2024-10-20 20:34 ` Liam R. Howlett [this message]
2024-10-21 1:30 ` [PATCH 0/4] maple_tree: current split may result in deficient node Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gufk3c2pfwpjfbouhfxk7dvxwqdm6zigk3dppz6diu3bd34e4l@7aaq57d47czg \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox