From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA0B1C0218F for ; Fri, 31 Jan 2025 20:28:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA9666B007B; Fri, 31 Jan 2025 15:28:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E31B46B0082; Fri, 31 Jan 2025 15:28:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CAA776B0083; Fri, 31 Jan 2025 15:28:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A91E46B007B for ; Fri, 31 Jan 2025 15:28:02 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 364AC1C848A for ; Fri, 31 Jan 2025 20:28:02 +0000 (UTC) X-FDA: 83068883604.08.F7F234A Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [95.215.58.183]) by imf20.hostedemail.com (Postfix) with ESMTP id 618B31C0016 for ; Fri, 31 Jan 2025 20:28:00 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=lrsblSRz; spf=pass (imf20.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738355280; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7BhC7vLoh7VtzfmXLESUsTqxQbrPIF6WzzF0QtgvNjc=; b=SsI1bCRY1tpCsbHvOL+CZYoZH1VWybzOB2ObRVlh652fsV2c1m3Z2WbYP7kM5v2i+t+V1G WvTWAbiD3DZMcmbrK2hWG9Ft+W0YfrWbfZylCVsqb74UMMhWKV4HnwBjNcNpoU86g5NgHt KA4ez1dleAaFHc/hQh1KK/h5QdoUmCw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738355280; a=rsa-sha256; cv=none; b=lfL6rodFeeTsY9vIJl7/gR+GztPtmnhow1By9Lv81vCUEDGYEvDiTbrljGKpG6Pu991rEI PJa+nsMtLOCoW9jyAGR/2EzsimhwMgsNNBdLCVn6ywqIAnrTbyyLEwB3hHk63GCueRrpP0 AgA2J/SOCTFBpq25p5Jk/4tKBMYdcXA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=lrsblSRz; spf=pass (imf20.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Fri, 31 Jan 2025 12:27:40 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1738355268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7BhC7vLoh7VtzfmXLESUsTqxQbrPIF6WzzF0QtgvNjc=; b=lrsblSRzlb3U+VBSguFAbcREpGVVQMrtG0UN6409a/fosRBCk4L0jLE6FhAQypEB2fAOSm N2A2tLZnVmRItxbwLORJuWRgDvy7Gkv2CDnNDSNBFBiBFJxyAqrUf95g9+GCYJkAmPEa8U BHDzzwIL0WWDQKyoESpoRnvF5jGA2nk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: "Kirill A. Shutemov" Cc: Andrew Morton , "Matthew Wilcox (Oracle)" , Jens Axboe , "Jason A. Donenfeld" , Andi Shyti , Chengming Zhou , Christian Brauner , Christophe Leroy , Dan Carpenter , David Airlie , David Hildenbrand , Hao Ge , Jani Nikula , Johannes Weiner , Joonas Lahtinen , Josef Bacik , Masami Hiramatsu , Mathieu Desnoyers , Miklos Szeredi , Nhat Pham , Oscar Salvador , Ran Xiaokai , Rodrigo Vivi , Simona Vetter , Steven Rostedt , Tvrtko Ursulin , Vlastimil Babka , Yosry Ahmed , Yu Zhao , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCHv3 02/11] drm/i915/gem: Convert __shmem_writeback() to folios Message-ID: References: <20250130100050.1868208-1-kirill.shutemov@linux.intel.com> <20250130100050.1868208-3-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250130100050.1868208-3-kirill.shutemov@linux.intel.com> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: 84gfz8wrdon9m9n9e4q3n7wobxeefd5z X-Rspamd-Queue-Id: 618B31C0016 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1738355280-302189 X-HE-Meta: U2FsdGVkX196eQisxMkmS019NfuEem+w294vmQDgW8+PUWdBsiD2jHZNjNENQcJU+79oUJtaWkjenvViSoHfOyp9onesnBOcUzflRHzVzy4qOoIUxI6xq8BTAzr+uS7DMkvhzwaUjWrqr8nPZ3OAhIBv5uLQMAEAUgzPQGqbftyasszMkcYQLEvrLLHyGfS8BHWO3ToaopsywflZMQWRvbWh8G4gZhiYN5bc64H3hQ4zsY7cBE4TACqLuhLqJzw/DyTHksxI9BvjbGa5ipjnIR21jTg55FIbJ+MqGsH7D+M25qlk0Oi1KuUFodrOLqXsQg49kalHSF4X31OlTX5d0i04H9yaP10fGSIfAzSPqzjrp0w3gErbBb7lfNY4KgYS230W6ONGXl4VOeqxqyHm88FnDLE35UehgzxssoxoV/6FYL2E9kEhyoGrmQIvpzZHYE6aCXUOhv7riFINFBegURkinoSv72Mv12+dqJ+IKNqNtQPKVopmilEJXDp996Ex0lI46nmC5xdk5nxg40CJ8rT4RMkiMQ9tJ/sJ/od47XJZ5NSlhhWsyLJmpSvKXtxhmvVkZB9QAwlmpmly98rSJlxK/Kh7sVipnjGvIj3jnHf2UrkSGJvs8QC6kf2fMroRgQ3FZ4lC5Unzh1qBEdJj1a5G28KsryEWrGfUrTs9aiKOTVp42sdhYxdw+nadRGcuiGGnJJ9Lnir1nvWrHch3+P91icD6Gr8gIXVEW96pFEq5K604fCNmg9GQSXZz7TUI5MSKCh0OhJftoIfojHDK4M70H33sAfkrFnrWZVxNaaWqYUfPaHKci1mcztkmugiZCKAf/8qGKfLpgqpZIUB2HxSGJsq2yxAtQcxM12P+7O+dpPh9QZBhME1qmK/7d6qVHnWw/ppeDtIbhSJ4SPdQeuxVpxgpmyRIgdkEPH0UUBL9GihjUy4FmMyoo1YlccXabV4PewW64eOt8YU0w6l 2us+OkSL L4nT3VNb7bKFoHc+ImRRatcPkKf6EvZamPYCK7Q6b1iahO95YUvuHxQRJFHFjmtEtuFrUs81AZOGhkmMYRCY58NlhlXIK8bzqEdNa2Eu+gFYyiPVoPVJcavK9CtMW1q1loHeS3A9FTAZsM52rvoSPUx95waT+wnuNGP+fDt5X3Ewcl1Jm7yxj1qM2kpOTcMHdcMPMXTzsR+8T1TlPRkDcum5k4j6MFPfl5P0GCA5+tLAiUJLtcPpMpQbjZJzdlWq2Bf2X/nUXlvksy91WPTIZEurH+g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 30, 2025 at 12:00:40PM +0200, Kirill A. Shutemov wrote: > Use folios instead of pages. > > This is preparation for removing PG_reclaim. > > Signed-off-by: Kirill A. Shutemov > Acked-by: David Hildenbrand > --- > drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c > index fe69f2c8527d..9016832b20fc 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c > @@ -320,25 +320,25 @@ void __shmem_writeback(size_t size, struct address_space *mapping) > > /* Begin writeback on each dirty page */ > for (i = 0; i < size >> PAGE_SHIFT; i++) { With folio conversion, should the iteration step be folio_nr_pages() instead of 1? > - struct page *page; > + struct folio *folio; > > - page = find_lock_page(mapping, i); > - if (!page) > + folio = filemap_lock_folio(mapping, i); > + if (!folio) > continue; > > - if (!page_mapped(page) && clear_page_dirty_for_io(page)) { > + if (!folio_mapped(folio) && folio_clear_dirty_for_io(folio)) { > int ret; > > - SetPageReclaim(page); > - ret = mapping->a_ops->writepage(page, &wbc); > + folio_set_reclaim(folio); > + ret = mapping->a_ops->writepage(&folio->page, &wbc); > if (!PageWriteback(page)) > - ClearPageReclaim(page); > + folio_clear_reclaim(folio); > if (!ret) > goto put; > } > - unlock_page(page); > + folio_unlock(folio); > put: > - put_page(page); > + folio_put(folio); > } > } > > -- > 2.47.2 >