From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 041B6C71157 for ; Tue, 17 Jun 2025 10:05:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D15D6B009F; Tue, 17 Jun 2025 06:05:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 982716B00AB; Tue, 17 Jun 2025 06:05:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84FAA6B009F; Tue, 17 Jun 2025 06:05:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 756746B009F for ; Tue, 17 Jun 2025 06:05:44 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 27927102FA6 for ; Tue, 17 Jun 2025 10:05:44 +0000 (UTC) X-FDA: 83564461008.08.5FE4042 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf12.hostedemail.com (Postfix) with ESMTP id E454F4000A for ; Tue, 17 Jun 2025 10:05:41 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=WQDfhpwm; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=NrBo2tY1; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=WQDfhpwm; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=NrBo2tY1; spf=pass (imf12.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750154742; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C/1izpnjb4TYfec4R1JpDo8StS/h7UWyf7xuC9Z4Hyw=; b=tRJPk8Y42N/wzuJDCV6OKX/rBX6BGAexwtv4uVzHKbXP7zbr21heG6nKJ3xOm/0iEpWtVj OgyLfOgynd/Jk/wah7BgwF889152CQgH2+jDHzx8LLiGlbqQo5QQlZIwPaPJGr4ID0WCFQ muhoFtYuYNPRaCb1cf3JmiDwTrV9kyU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750154742; a=rsa-sha256; cv=none; b=QI0MisdM+FPRPKh5dEsHKgigfSfvtVPeizwDQu54CAna2AYxVe+NmV8B9MqMVlP0uWw+Cz PSiEkYzRn/YsWLstT77ioKQBSgb7/LJyqB9gW2CAC4OoY2Dd73K749u8luEiMP3dBuZezL /oLvj4o0wEz4rAbNUpvy1+59pjVyAd8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=WQDfhpwm; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=NrBo2tY1; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=WQDfhpwm; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=NrBo2tY1; spf=pass (imf12.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 01BFC21190; Tue, 17 Jun 2025 10:05:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750154740; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C/1izpnjb4TYfec4R1JpDo8StS/h7UWyf7xuC9Z4Hyw=; b=WQDfhpwm6V87NT9z/A204y/3daztxVfitFICfHOJXVLDwuByiO2e6vsTYBDE6FG4qqCUJX 3HzGzjWxaQtyqKsXL+IvjDNtRiiJiJLsgvCFneuBuoU1vbXUzQkZ8tq3BMjIC8HSg5ocP3 Gay+RGH2nYC05chnnbilbsgAdzN2LlQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750154740; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C/1izpnjb4TYfec4R1JpDo8StS/h7UWyf7xuC9Z4Hyw=; b=NrBo2tY17T6YGKPQqIdgrtSHngXWXYF5et4lwD2HsUZ61mZfDbx42vWdF6Fc5le8jO5HvC BvGwhDZ7rlXldwCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750154740; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C/1izpnjb4TYfec4R1JpDo8StS/h7UWyf7xuC9Z4Hyw=; b=WQDfhpwm6V87NT9z/A204y/3daztxVfitFICfHOJXVLDwuByiO2e6vsTYBDE6FG4qqCUJX 3HzGzjWxaQtyqKsXL+IvjDNtRiiJiJLsgvCFneuBuoU1vbXUzQkZ8tq3BMjIC8HSg5ocP3 Gay+RGH2nYC05chnnbilbsgAdzN2LlQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750154740; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C/1izpnjb4TYfec4R1JpDo8StS/h7UWyf7xuC9Z4Hyw=; b=NrBo2tY17T6YGKPQqIdgrtSHngXWXYF5et4lwD2HsUZ61mZfDbx42vWdF6Fc5le8jO5HvC BvGwhDZ7rlXldwCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E29F713A69; Tue, 17 Jun 2025 10:05:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 4DsMN/M9UWixFgAAD6G6ig (envelope-from ); Tue, 17 Jun 2025 10:05:39 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 9891DA29F0; Tue, 17 Jun 2025 12:05:39 +0200 (CEST) Date: Tue, 17 Jun 2025 12:05:39 +0200 From: Jan Kara To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Jens Axboe , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Alexander Viro , Christian Brauner , Jan Kara , Benjamin LaHaise , Miklos Szeredi , Amir Goldstein , Kent Overstreet , "Tigran A . Aivazian" , Kees Cook , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Namjae Jeon , Sungjong Seo , Yuezhang Mo , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , David Woodhouse , Dave Kleikamp , Trond Myklebust , Anna Schumaker , Ryusuke Konishi , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Zhihao Cheng , Hans de Goede , Carlos Maiolino , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Dan Williams , Matthew Wilcox , Vlastimil Babka , Jann Horn , Pedro Falcato , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-aio@kvack.org, linux-unionfs@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev Subject: Re: [PATCH 02/10] mm/nommu: use file_has_valid_mmap_hooks() helper Message-ID: References: <5f120b644b5890d1b50202d0f0d4c9f0d6b62873.1750099179.git.lorenzo.stoakes@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5f120b644b5890d1b50202d0f0d4c9f0d6b62873.1750099179.git.lorenzo.stoakes@oracle.com> X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: E454F4000A X-Stat-Signature: cimfu3cjhmdtiwxzf1xfo46kdga7r3st X-HE-Tag: 1750154741-994783 X-HE-Meta: U2FsdGVkX18VsJQGXhYcQKO450v5EHBfhOgnjaLTxIfXZbuPFZ6N46VZjmPg0k5OyMbqOWKhs481iIiTDkYI7DSxLK/QcqRRr6+lXY5qE1teS63N0SmjTpE++CCpKGK54C8kJCz/Q9uU8yGHjY1jgaMur4y02zFd2YBFigVjOHQ+XgTK3/RNh4MRF97wNoyOiIc0NgC6lYvl0R7kIJXOg6F7v8M5kdz05+XoDljeYnQgZGGnPbHqvn9eh/oJIGvDc3hzT8We3Y+a+eAsJDBtT8g6mvZfwY3Rv+wpARz106+uRT/lFUQOye34zRm1hbWpjQOoifvYHmXrhfpoMSn2YvIELE8Az558kHZY9Gmf58jbFQYNRzL5cyNZWXRjWIN6f6UfUoROBzQBDThaTDRXo8AwTQ3T51nicdsfICY2etP0h2ltvUIg/dWwYk9wuHXhlwNS02uMk6rfAc/+PVdsFiqDBOnoAdHGelMOS0P2dKdyGBywO6u6YKxHBKjuR3412l4nltbyhVHwOJn7YVhQHVT+80ER25RlA9vQv22Rds9puwY3HJO111EZWqYeITEILfMRsogvxcbNq3tQbVkI9pS7kjA7WyXyuP1/bOx0WuuD2IC3cXiHvFqr1Vo39bG0dUR9zuy5GvNFR6rc3qrxpctds+wt27mrAh8VyOVFhZZYsIPCZKfYQDdBrI/NJiKu7jxvLbjNDYYqmUQjarHieaDALbGI8/fvJTYd7h+lHpbaCosdye/yCpMiV+3lnH8cPZmRwjzOjr0uQwqCtPQ3JIRdrSES8towZ+IFlzoZR1Ux8AKzzxBz3A+mZnCEoaaYVUfr6vgNJDaE5WaDH4ZFs3TONS6L8zllZD0t4X5kVgBPWXnCk0GZbSBAq7ZcDcohwldBYIOcKO6b7fUQ/SP+8o+ZWhoyuNyDu06Ua1wF0o2cLry7v4BL02WJY9xfxdLR3wo1hX1bsePX6C3ySnd atCLnZSx oSdLT0mANVxiEnW61RQCdkqfg13BXevuKcOsXxW9vm9GXg+q2fq4q5f/mAsk2vozXZygAC7u/2ZlVxotcKsYd0MdIt32LL97nApsfHfKJ2PokwOocG20Y0XccO3z53FT5b2Hv7ZHK0+Pc9GlqSfcrgHnaehSUwi3yyskKe9kuRB1e+lD0mXjQUdRqRj0WD7vutav5ftSf0VDeeUVMbiU1Mj46GnYZXUKiN2b1yZIkURVQBs8z9K1M6iBxLoeY2mRaflloHIGkyrCQ5uLQYyoEbVFxZUaJ6Btj+vEub6DeehKoB3fQHgLhHPIRHpMwsY/Cb84CaEtP/IWeC/1sFhvcZLwipwUgOjExftOZ8Z33UxaVBn4Woibemx/NrSpSKBcJXD0a0cOM4zO5odprtwckOQZ9MR0e1ScPgUhnPYSQl2BpWRZ4Ib3mjoDnEe+MJELAh1hHcxYYhj25TIoQpw0dg3ZsFr2d3ZYSz8itZJznXO4xYxk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 16-06-25 20:33:21, Lorenzo Stoakes wrote: > Since commit c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file > callback"), the f_op->mmap() hook has been deprecated in favour of > f_op->mmap_prepare(). > > Therefore, update the check for file operations supporting mmap() by using > the file_has_valid_mmap_hooks() helper function, which checks for either > f_op->mmap or f_op->mmap_prepare rather than checking only for f_op->mmap > directly. > > Signed-off-by: Lorenzo Stoakes Looks good. Feel free to add: Reviewed-by: Jan Kara Maybe Fixes tag would be appropriate here? Honza > --- > mm/nommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/nommu.c b/mm/nommu.c > index b624acec6d2e..38c22ea0a95c 100644 > --- a/mm/nommu.c > +++ b/mm/nommu.c > @@ -719,7 +719,7 @@ static int validate_mmap_request(struct file *file, > > if (file) { > /* files must support mmap */ > - if (!file->f_op->mmap) > + if (!file_has_valid_mmap_hooks(file)) > return -ENODEV; > > /* work out if what we've got could possibly be shared > -- > 2.49.0 > -- Jan Kara SUSE Labs, CR