From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8824C48260 for ; Tue, 13 Feb 2024 21:54:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B1BD8D0015; Tue, 13 Feb 2024 16:54:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 661B58D0012; Tue, 13 Feb 2024 16:54:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 529588D0015; Tue, 13 Feb 2024 16:54:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3C7068D0012 for ; Tue, 13 Feb 2024 16:54:17 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 059FC80B8B for ; Tue, 13 Feb 2024 21:54:17 +0000 (UTC) X-FDA: 81788134554.20.FE7603A Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) by imf05.hostedemail.com (Postfix) with ESMTP id 2D3A010000C for ; Tue, 13 Feb 2024 21:54:14 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=EDLT+gC7; dmarc=none; spf=pass (imf05.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.172 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707861255; a=rsa-sha256; cv=none; b=wKFmcvelJ+wzShX/mKxMslxLbEYU5wSj7RDyH4PvwamuIV7kC6GMSjtwgHiXNBhfB37wpD jc2J0wZjrLncfz/4iUJC288GtT0rgPl1WRya3A5SuC7S38NHrp/DVkfsHUXbTiYBGLrrAE 5X8tfB0iWgiNC8wEiXlgFAZIKNOVqRs= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=EDLT+gC7; dmarc=none; spf=pass (imf05.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.172 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707861255; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fLfN/RqiUV819JYDvf/UizxUNqpKwyIkdbN6p8bRWMU=; b=Nf2MY0fDgroj4OqnutZt9snitdhkcY7KZ/tQfGMQdKC5xwYyXVMUeYKSBaFu7eROmQYIKO Kqpj0Y+8iVZDPubZMTHj4uWdJWD8XHwpRzruFtivmxk7gUq+8R7LK6gHqKtPaSlxVmNTWI WCCbZR0yMAWNpUJFnhQB/z1LukN5dkc= Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4TZFTZ607Vz9sQ6; Tue, 13 Feb 2024 22:54:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1707861250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fLfN/RqiUV819JYDvf/UizxUNqpKwyIkdbN6p8bRWMU=; b=EDLT+gC7WlxNwFr2JeadPIMZdtKWjHPhxclVF3cNviBrsb8N7ok4CPPaF7j0bQx2PW2uCv bRlPykPX/3AneYpyIaOwC2kEYCOs6sW4Q9IxyvwD2QwULgu7+8X8gCphJJWU5oLqsD+TiA p8IabZ/wf7vc6f4s7J3MJiDiEf+4waNFhDZbRCUVRuheYZb44EHyJbnqALMjtck8jLMYjQ koODrBNcl8cwpiyRuJ5fsK6WZIB4OeFfSLSTl7lj5QA3HopJLN0n1f0t48OO5M/8CsNDqP XvDT56leprxz7x+1eEvuwPNQRHNOXYucpYfl1TEmZgo+H4VO+ItvHN5eey2Ydw== Date: Tue, 13 Feb 2024 22:54:07 +0100 From: "Pankaj Raghav (Samsung)" To: Dave Chinner Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, akpm@linux-foundation.org, kbusch@kernel.org, djwong@kernel.org, chandan.babu@oracle.com, p.raghav@samsung.com, linux-kernel@vger.kernel.org, hare@suse.de, willy@infradead.org, linux-mm@kvack.org Subject: Re: [RFC v2 13/14] xfs: add an experimental CONFIG_XFS_LBS option Message-ID: References: <20240213093713.1753368-1-kernel@pankajraghav.com> <20240213093713.1753368-14-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2D3A010000C X-Stat-Signature: 8rumgywikfesj39zyqm7hfemq7b6zkj5 X-HE-Tag: 1707861254-939142 X-HE-Meta: U2FsdGVkX1+y4nARkYKFLYLt7jzo+/P2d21WvW+tOLiBj1+SjojiomjR/WKO7kDHNtqc4XV+s/ne8JraZ1/dQ42N7Mer1RJo0xOGrvWd7dr2tbw6wrEH1HC+Ced0XiifALwsEXX1zgFwgr/0s/n03YMkdGJUdPsPtqsSClZ3hd0IMPK+/kDYGwWP0cgJfsvFjFJyYCYmH/g0/ojnlMjlNxsShU6/29g2OoXZxwk4illEF7h1fAKQh+xdhf3AsOAGS8I7dm5AaLaruD1o6Y71WCcDKpW3jB4Ps58O3o9SQtZohiTA8H+9L96nbMwWE5Tutk/cpiBL9wbVoQH6E/WE9aq2WFHEz33OSZ8Atabxsu38F27rMt6NDvaGSjFhIqg8EYhVpg3qGHT6YcyFsRrHC3YCLa88HWMBqbdX9Scz76V054UF6k5leiVQ12Lw72ySC/S1KU7KNKFc2dlBwbPDCOLr0zZnsFJSv4jDW4bIEnIZIj0AHFoWcfIEiu+2gAYM6BHXatUgwE7flywlesYuJaSS7tLh6jiEkC/+HDeZT9poF3W7jkhcNX0Mp/uAaNv3Gd2U6jrV5tHqZXv3CZ7wXdHGCBasp8UlsqXk/8wF9b6Kz8x8LSz97nGv5p8MxkxcEZsnD1SrQEgMarlGwMEHygGst0VOrunxTy6u4UKgbbBpjRlPgmBZqDZgyUs7iNZL+rIa0533G4onbEaa3EX+AFBvzUWITHqrZ2bFzmofFim8mBMu19fJBzh1m5SMr1cNpvMIAYERCauGztkfj9dvc2Ua2mPZqWiVk6AI8kBpjNtDTUlTddGEKTOFlgY8DmpnS1DyaBM7z4kzMLyES4JzgmEzLJdDE9mK5iMYGwx4lGjxh31laMOXc/jev6fVbwNh0UgxTi0ZrIojYFWZB/IuR06uGu7P3t6NliAfvbLrROQg6E7s5Q07egEmws6qzYroAoHTFNlo7Ui/1QuJcCS bo+sjh2x LJE3enuxrz6cCxxbONjEp+hethlfQtQxmNzlbVZeCXMy4/fPUXtS1xoLB29oBxAiVTxmVNZtAN9tZjnpov3ryd+r6qMxukoVDE7Yl+OUhmfYND4dGdj6ReIOI9FBGys8bJuQMTwhbotc/5yYdG2rXZ0tUrQ7tTs/9RI9R39cXg5wsdWGjACSdoVZn0jltGIaTgDqiMVrE9R5Nskdd2XGOjMORWn3hblRpmNWCV2VCKNv2viv5lHk04j/WXoDefOuap89DR0WxRvUJHNUb4wROEBLfTQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 14, 2024 at 08:19:23AM +1100, Dave Chinner wrote: > On Tue, Feb 13, 2024 at 10:37:12AM +0100, Pankaj Raghav (Samsung) wrote: > > From: Pankaj Raghav > > > > Add an experimental CONFIG_XFS_LBS option to enable LBS support in XFS. > > Retain the ASSERT for PAGE_SHIFT if CONFIG_XFS_LBS is not enabled. > > > > Signed-off-by: Pankaj Raghav > > NAK. > > There it no reason for this existing - the same code is run > regardless of the state of this config variable just with a > difference in min folio order. All it does is increase the test > matrix arbitrarily - now we have two kernel configs we have to test > and there's no good reason for doing that. I did not have this CONFIG in the first round but I thought it might help retain the existing behaviour until we deem the feature stable. But I get your point. So we remove this CONFIG and just have an experimental warning during mount when people are using the LBS support? > > -Dave. > -- > Dave Chinner > david@fromorbit.com