From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4AFFC48260 for ; Fri, 16 Feb 2024 12:56:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 172A26B00AC; Fri, 16 Feb 2024 07:56:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1225B6B00AD; Fri, 16 Feb 2024 07:56:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F04D36B00AE; Fri, 16 Feb 2024 07:56:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DE5DB6B00AC for ; Fri, 16 Feb 2024 07:56:57 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B02A61405DC for ; Fri, 16 Feb 2024 12:56:57 +0000 (UTC) X-FDA: 81797666874.24.97EC5C0 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by imf09.hostedemail.com (Postfix) with ESMTP id 287CE14002C for ; Fri, 16 Feb 2024 12:56:54 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="Mv/NXwTt"; spf=none (imf09.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 198.175.65.15) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708088215; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XPC9luHQLXJNvsEExYPohF2Sh1kO90QLxvjwQRI75nw=; b=26kipxoLTPhmixm4DNTV+KE2OcqOXNh6N/4UUe4LTeomYv3u4nz50UQ2gxEyLQkuRJUnzA u/boFsMrzRpEODGCt8fkcl1oN1Hn6cx4624+Kjiq0WpKKjrJv8SDxF9xlMUV/FocyOBad4 rAjygqMMs7cljZ3YnI5CQThbxhQsY84= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708088215; a=rsa-sha256; cv=none; b=7vxT7HdLDZIZgJZq/d4n3nhwMnlTYWXR7tGcrwYB5pWkq23GFjgPq3tC6sXbP4rdW6A9mt CJv/2Vn4btXQXTC2I+t5eGvL5070C6uwE3rX+DyBSryUCNfbTsszehDOk3bDpEU+C/jJtv VzIibrkR38v/7ER68e2soADs8BnWuvY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="Mv/NXwTt"; spf=none (imf09.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 198.175.65.15) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708088215; x=1739624215; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=n3nIo7ta+lpOf6Vkf5nvSLxYrw9xngsA3TZcxZbTcZo=; b=Mv/NXwTtcoo1GovIpTwXrbJzZ9Ys9aUo0AOF6jwaVRIjnMNH53lse3kH U1ydFPfVn6mVFPQSw6aXj6HE8TDqtC8ELVEVFDKm0M3yR9A+Vna4kaUI1 VJbC0G7KIibC/EnR6sbbO5DXWOVlGC9U8ZT0GgmYoyQc36lY997a5OEtw K8fZh0MXyiCWFYoSgBpZmxmwUzAoGX45zTzl0fUq3nJmCouhzvK4SNatg esROlGG/MBVkOTEM4a4FdFyra71pTBjwTvGAKtNE2nj86njYkyf0xnr7k wnfXJYuOnwZ6PzQbID7NkdNqRpsPLmBcot8MtIfpGDHLFY+XBd08mT7jI Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10985"; a="6041858" X-IronPort-AV: E=Sophos;i="6.06,164,1705392000"; d="scan'208";a="6041858" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Feb 2024 04:56:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10985"; a="935844562" X-IronPort-AV: E=Sophos;i="6.06,164,1705392000"; d="scan'208";a="935844562" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 16 Feb 2024 04:56:49 -0800 Received: by black.fi.intel.com (Postfix, from userid 1000) id 994342E9; Fri, 16 Feb 2024 14:56:48 +0200 (EET) Date: Fri, 16 Feb 2024 14:56:48 +0200 From: "Kirill A. Shutemov" To: Rick Edgecombe Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, debug@rivosinc.com, broonie@kernel.org, keescook@chromium.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, luto@kernel.org, peterz@infradead.org, hpa@zytor.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 3/8] mm: Use get_unmapped_area_vmflags() Message-ID: References: <20240215231332.1556787-1-rick.p.edgecombe@intel.com> <20240215231332.1556787-4-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240215231332.1556787-4-rick.p.edgecombe@intel.com> X-Stat-Signature: xh3zghooy1zr1epjq7si3bgj8cs15ff1 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 287CE14002C X-Rspam-User: X-HE-Tag: 1708088214-389428 X-HE-Meta: U2FsdGVkX18G2B8XEFsFdfz3OYuGWuXpR0s0BPt736zrSuyyKZB8I59uo9XQHTS5TfEQX71EgoZvXM2OftHnL4dBGzqAu4j/qlsL0JhvebDqpajOsuk8rC3JD1jEba0BUXLek8OZb4TtZM3LnOiuhfpzFNPhHryWQ+1dmFEpj6sEjot44dH+jmx1NTyz1HvTkzjhzcooCwsKpY7AHZ5aXtMj1R6aFMpv4RJXrd0GUKcSTY0V3Qj+HpWe62Nhf3G5nECw5pUYd1lpmXI2ieMxHEx41WDpyD3HvEA3ncqSAX7lST9XlPvJASgpNsasT8KU86xz1W+zXra8rxJUM45HHu+nWA8RdxoyCT/kcdWVlqN1bdatbD1wQXeZVqdSPEn4jMOe4bUapue5PwjeHAlSvi/rMNvVYt6Z3ccL5J4i4L7kKXJgMlMIMWqaQCVuw/rtUc6cRgGbl2caLrni/6zJS081FDrHkcknhWHgQqL92BEI0ZGPwnLLr/tQ0T9IEzXk2rUTCkrOwNJ+FVJSze/7zcKGp3ij46HrCjVJpb0ILjS2KvcbSpV7r3I3inyZyQ4zmrhdqPXn6/V38Es5aOMdiYniePZMuKxLXACNUL8rtyNkiGXKIlbsvMET57IiCs0x4jCm3WwlDrj39CRDp7mHPU3xBjDDf92sB/gTo3/2KOPv4xQi1PLtnSNdWbgfNC+NQu1++z0f924no2Fq00b1APn8dePq5gDd7cYInB9QhHTYinyZMJ6bqcEoz7zb1e3RQNpWB86sSVs+4Dzz7xikudgqCQRmFL7k0G44HCYzTh9S0P76/wqCIcCY3s/t94tyAkFKQ46vOWyJPO3OzBNaol7C81rwwun7Y18Lw1qL5YzQe8vW6GXzdNT8wKmKSkkBeCXK0EHiG6RsWFZpgr+6sFnhjWPJAt9M0WHS8+YdBIfkWB2hoFbrAzzGzyJhG7jspyHTkxPE+ZBYqSMb+ZZ wKEiimeM bT5UcL8aSNQRr+IANKGwrU/C4lZV2MoVfbAmfqftm8tzLwepwxHKz6oelRHwQBE1gfVUTrUMhDQBTX3lPZbTdJ0icTEfHm/PIa/tOw96VjdrREZQ/SFGlQ9RpHDnoJs6IALhBK86GZ7xjkosa+n6Gu2awMBdOYPCsmSHI64IZTWVEaVU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 15, 2024 at 03:13:27PM -0800, Rick Edgecombe wrote: > @@ -1879,6 +1879,12 @@ get_unmapped_area(struct file *file, unsigned long addr, unsigned long len, > return error ? error : addr; > } > > +unsigned long > +get_unmapped_area(struct file *file, unsigned long addr, unsigned long len, > + unsigned long pgoff, unsigned long flags) > +{ > + return __get_unmapped_area(file, addr, len, pgoff, flags, 0); > +} > EXPORT_SYMBOL(get_unmapped_area); Any reason it is not a static inline function in the header file? -- Kiryl Shutsemau / Kirill A. Shutemov