From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A70F7D33990 for ; Mon, 28 Oct 2024 15:07:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 403866B008A; Mon, 28 Oct 2024 11:07:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B2566B008C; Mon, 28 Oct 2024 11:07:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22BF56B0092; Mon, 28 Oct 2024 11:07:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0815F6B008A for ; Mon, 28 Oct 2024 11:07:32 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A7C941A067B for ; Mon, 28 Oct 2024 15:07:31 +0000 (UTC) X-FDA: 82723339650.02.0CD87BF Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf23.hostedemail.com (Postfix) with ESMTP id 19575140024 for ; Mon, 28 Oct 2024 15:07:12 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=hGBEAvZI; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=aUGueAO2; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf23.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1730127932; a=rsa-sha256; cv=pass; b=JZtH4XAwcr+gqpdY1ITJCwYFkLQm7Sg1jjd12mbDT8LfImXZjefHky7i4Lm6BLD0GcB0u6 J/7IrNNqSIbjfAIjpy1poEFVmgBh3dqz1+ARtrKjFL7eRnVED+8icqYjIE2fiibsr2e/pg YlP6fadvudZvZ6T5GZW0CP/nAIppXp0= ARC-Authentication-Results: i=2; imf23.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=hGBEAvZI; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=aUGueAO2; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf23.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730127932; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vtExjjNWz8YdJmHLF3QgudgrpkcHxfgOcTwEq5jNPrQ=; b=soNGXA0vEnxpppFC4bmYGgM8p5LpOdYU5Kqbs8gPYSMWIPY944tZLQk+FdNtZrQAWOjZl2 x4p2N91sc+l4I9BSng23rfSFKuNZwTAT0OTRvAPtx/+48/+FC4nSMAmG+erUuTliOxL5q5 uQOAVHbCFq4MQOOuKMxpnMZEki7Mkg0= Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49SEtbFi022362; Mon, 28 Oct 2024 15:07:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=vtExjjNWz8YdJmHLF3 QgudgrpkcHxfgOcTwEq5jNPrQ=; b=hGBEAvZIBon2oSShIdaRz2AAkXeSLSkvLb cjvodU0Vu3ku5XiPKoxES0e/O1ALixfFySXstZAg29tQfPS+ToWBjTIe8cbdOPq2 LP1J3klo7xmtn5vsg/se2zDyBc3OWSWX8r5WHaa01aBNOggKplcp2K0MpBxXWW1E phh+8pS4XKwtES7ozCyudtxl48rcixdhfIZNSGEd1S3RbiM4fq9pBL0K/W6Jur6o qYUJ++xohAeRp5CiksqT8kMC+AEDYG4+8MZYyeCsCCuWQCOxnCGdCmxiCVjeSywq KD2ID09oSpT7XC+UO2n2oVjeG1NWtxMi3wC0dWfZ12dngQeHrNZA== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42grdp349n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Oct 2024 15:07:26 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49SF4CqZ010165; Mon, 28 Oct 2024 15:07:25 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2044.outbound.protection.outlook.com [104.47.58.44]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 42hn8v98k1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Oct 2024 15:07:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HFiDQd2o4bPKub4LkfP08rGrbjSTuxno5FgGXGMW6UhmrTZcWLa0KxjwGHDGdUHYQWCu5xjfrBhQ5JVY+uU4jZBBYvUVi5+tiqmOXfkhL1HQYA1EHMlwctRoevaVM2SGfWVS184FnI0JJDa7jYYlMxVreyByufv5sHQ+ZrBIfUJ/M6ErkH9adOJ/RV74VQquy7/Zgraas8TKGBpNBQ2UiGAHUb78YtY1xZ+7ogtQXaVBrSMv5MH6E6TJrUZQuSrersv6k3lfP3MXHc/8OKHajFIj0qcLiFplPZmuqCzLGSTtttce3fRvH4ddLSdjF/9gBZqDUtz054mai+JukvF2gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vtExjjNWz8YdJmHLF3QgudgrpkcHxfgOcTwEq5jNPrQ=; b=t3YSeeu5xGsPk6FuvBzbTLV+vToMS/kwpBh5H9IzoEjhU9vUYjGrq5ssQCJuxod1mF30GhzuP1inSCnrM2w9u0gv6JLYS+8IjDgzS9QxG8R6XI/zYVEY5GTdjRUlIi+GwozmrHoTqZNIWHzVffq6j2ZN5txxT3ORx0XuF9fzz85qWLO12/9IrwQhdWJtGCj+KFMtEwiTfAPbhfoROePLlo3K8tf3K2/qiirRUy3yTZPFI+kdmZ0nIoZJTWPfI20UAG+jNw5jV4bTgIeeMcbCZ7lPVdz6XFw5l3a7myRtvoozenMFd/UiI2/kPVIVIG8uws5bAFISNbnqmS1h/exbTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vtExjjNWz8YdJmHLF3QgudgrpkcHxfgOcTwEq5jNPrQ=; b=aUGueAO2L69lnb8Tf/ngaRYmaCnvE0XI0z5BSsGzTS2k00LCr+VijDUaHS3szhNSeGgmZaCmjokWo6OCDOL2mXELIzuT+L5xNoiqG3d5CROrX2UeodpUDvTF1JL3KAOfVFdRnbmkZtrFk7FOBziAIrgv/6r22eE/SX3M6V3BmSE= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by CH3PR10MB7413.namprd10.prod.outlook.com (2603:10b6:610:154::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.25; Mon, 28 Oct 2024 15:07:18 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490%7]) with mapi id 15.20.8093.024; Mon, 28 Oct 2024 15:07:18 +0000 Date: Mon, 28 Oct 2024 11:07:16 -0400 From: "Liam R. Howlett" To: Lorenzo Stoakes Cc: Wei Yang , akpm@linux-foundation.org, linux-mm@kvack.org, Vlastimil Babka Subject: Re: [PATCH] mm/mlock: set the correct prev on failure Message-ID: Mail-Followup-To: "Liam R. Howlett" , Lorenzo Stoakes , Wei Yang , akpm@linux-foundation.org, linux-mm@kvack.org, Vlastimil Babka References: <20241027025629.14715-1-richard.weiyang@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT4P288CA0009.CANP288.PROD.OUTLOOK.COM (2603:10b6:b01:d4::14) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|CH3PR10MB7413:EE_ X-MS-Office365-Filtering-Correlation-Id: a4ae7bc1-59ec-4d22-adf3-08dcf7623724 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?i4YuksbA2xBem08Dx3t6veMNlGwf8U6XYtBVnAhx+UTpYANM7ILzSjldB7/3?= =?us-ascii?Q?TIC4mC3WyoyGIk/792pnBirZrBzJRDlObD6PcK+dy51VNkLPh49v1uAi989v?= =?us-ascii?Q?OtNprpxIqwXo/jJfYdpm16h0gQV/9cchYMCve7xWMKVddDAQVfBZVBdOlWjZ?= =?us-ascii?Q?uwZIwoRLyG4A0FNhhw3sosYSLroFTFdLJ+8vBgBx1juwGz0rM08TuRKE5rnP?= =?us-ascii?Q?+IuULwqrjsKUUgUhRVDwpj+imVE+KPiXe2jgNOTXkaBpF+xwk8FtcUC88qU6?= =?us-ascii?Q?LT8UmCBKIBd7qDZ8U4y2UIGzTJp9gxh3m0bKyyakEc3dGUCMbQL320OCzHIh?= =?us-ascii?Q?1pgf5FkHorkIUc9vf0jWbGfg5x2Y6d2gt7SBMVA9Njci90f4Lbf/xzpMSPGH?= =?us-ascii?Q?Rv7hzaze0pz3MDdLPi4q6eBHhJEE5t05eT0DUq/r/jPhX+YCTIjSTeOqGXkI?= =?us-ascii?Q?IIc9y+JHjOMh9/uXdkCSmyHWv100/EvxKmnjRRNVOh98lcrxVvAMSS3DoPup?= =?us-ascii?Q?ELYKA7Z6EfcN2q6KzWKUworKiBKeTFdXcm1kC3Fa98xgptUiYwOtngUKHKX1?= =?us-ascii?Q?F/qFV92XnS0tMdhb4y1VcG7XaxMiPjYAutQXF6TAH83ULRux7JNYsCd2Spl9?= =?us-ascii?Q?m5p3jEoZKsVfY5M1YHLdJiSH3e0PfrFESp5JloYW3vR0GeKR1nWqxz4TfTs4?= =?us-ascii?Q?gzFqMG4kCCH8GQeaciQOyb0aKAGfqtCjDOO5sV3h38y8M1jYVq8aCNxHyJSV?= =?us-ascii?Q?bi19c0+LN84CBfFmdOjGtr+uEc49c7JN+vh31kKWDdNPVwv//reqJqhJ+8wE?= =?us-ascii?Q?WWSz79wAeh9qLvGb1zdgC4G1EVV4WsnHZ1BSiqq8UAo/Jtez74HLhf5c/jJ0?= =?us-ascii?Q?70l3d0S6oOPZeByNvtMIl3qianB53Fy/o5BV5hd6VvduruKfXbJAN5XBjc7p?= =?us-ascii?Q?0gTGNWkxrVgYB6yfkAtan500nsSxwXW2nH4SLIMOR7RXHpREpejNeHLJ5uFc?= =?us-ascii?Q?TkDfg/Xqe8YERNYtfdNxYExNKoEgLr90IDSn9v7KLcjjnlx4gDlGtx9xajM9?= =?us-ascii?Q?ko3umWTSs+2cSosc98grKYqGqLeHiSUz8sQtAFohJPNUmmWKnYbJXUY9FPKH?= =?us-ascii?Q?e2SkyFuy/haw2CDCpaPmVW0Co1HHeHp3KlgOXOXdYlVKuOXrF7DMfX1767mU?= =?us-ascii?Q?mrkMNT/m6okXHiJMCEixsVAOIlb5OkF6y5JYz5Mua9RMAVG7r4RlKHDhVQ4r?= =?us-ascii?Q?EWKec6/2OVFO7vkZBWJd6RBpVjdV2TVqYri0JfUDF1A+lyjEWzOW+NX2PGI5?= =?us-ascii?Q?FM0aK7sQKDCkMx/Q4EFFXJ86?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KAHkjkoP+zPN4pY3RwaCV2Pbdpf1/+VZCMoAQ/uX5hUvsXewJ11+ForsAIQZ?= =?us-ascii?Q?0OJNDrB3woEZz+dTxuWkufwmQb/Io2R/nT9Lcufte9UMmrOsxCqfANCluHQY?= =?us-ascii?Q?i7oIp/SikHb5H/oMfSiXco+azEyw8fYgwC52bJtmRWgh96Fo6hnIh6+Fq2S/?= =?us-ascii?Q?5KRWKoAnN8kin8jIzlD4SnfVe+euD7paJ7pZuYzF92+9UvgPhipqekylMY0J?= =?us-ascii?Q?s1DTGaghQrFzBbg0rdxxwPOZQrJY2ZoJSl6Vd90qrdU3oa6dXCX+rbipnK6b?= =?us-ascii?Q?Ct6NMP1jLxnPzntvXYNpoAhBEDBKAAdlxh3U+Aj+CCDqrhrL/bpYt3zmkWA1?= =?us-ascii?Q?YCl9d/eXXyQFgTCzJYGroT1T21B7NCW/cp7b2dn8buN4uNSg0kpYt25uMHyh?= =?us-ascii?Q?DDQS8fGOzO7KR08uDqyzXDv1rPL9IyCWtAkPL3Z+i95JXBWwn4OGrAY64YEO?= =?us-ascii?Q?RArhWpBf2jkyZ0FhO4Tg65CVqTkJ7806b1inuthQJTnmcl9L8MjBuuYy/rha?= =?us-ascii?Q?Gq0a0a5cTcxbM0jLy7Ik/sa6xiVJWMxS2ixgfdS7H1FD2MGmJcnkeCLbkTOe?= =?us-ascii?Q?2wXRve9wvS8149buzj8cthAeacJIqkzYsFBsFkKh7H3Duk9vqEN5+NIG/z8v?= =?us-ascii?Q?O+fsndxCgwHfqN6Okj339/8DJWtRFcU87nZ6LxdTd+HMTUm5e/jxN94KYsqz?= =?us-ascii?Q?vdDtZqQqRLwxROQrQSXY1K4UvUK2c8h48EiQtKOSbsXGEQsuNdyf5KVb9x3L?= =?us-ascii?Q?dd+EuSErWKJpx3S2+DGux4wJoed6tT27JYBNz1JIiqEgtY4EfX+TQ0aLov8t?= =?us-ascii?Q?z4BCHzKjs55wgVbZDFwfKFmD6IlIqYStTIXq3RBWl2aDRm4oKVoAbpvJg+wh?= =?us-ascii?Q?fa9ZrQDGfJd6CtObHMFct9fD61gBnBLpe9lq1O41/l2ueixNLZAZniqdVM2X?= =?us-ascii?Q?JSQg4OqM8YIqiaTaLc1EX61KSR7QiLyjpUALXgrj9biZ3X0aRyvx+gAKMm6T?= =?us-ascii?Q?DDHmQbaB3CKmfPo7pnC4cBWKNBlmVEBTDvQwZLB4LLjKTruj6SDolN9RiqGl?= =?us-ascii?Q?uuP6BSTjBVW1PzuIzwnxBsNmVVPzfiUy7s4D9zYD65RqZlVBkB8H34brlVfw?= =?us-ascii?Q?ISWNsIT/b8b7tcXsTzafHm4VRCvYjZE1dwCvcEPMsC+j1id8aa70neb+h/Uo?= =?us-ascii?Q?LAJuIxaEDbVHPXvoqycCWAjrqWTWxndQENOpobMB9+6/BihV9Oqm3YYwYLs1?= =?us-ascii?Q?cg0wdgke611Ml4BkpHq3uuw7G3EJ2XNVN5Q+R1WEMrVk5qHGIA6zhOCT5LJ6?= =?us-ascii?Q?UItKQgl4AgB6KghpyBeEtye7hlHG+2xSsNML8PxuCoYzyhzxX1hGRNwibSLE?= =?us-ascii?Q?38skfAEq9VU9III4xeET6KaZsKUlavYCR2/lQO/RaB5pBTVf64iDiIrwWOux?= =?us-ascii?Q?qMvUyjP7qCyLONXl43FJRi6sthSNui2Xp4qy3let08Y/EQ4ylRrYwejV8GoI?= =?us-ascii?Q?EXoGNjQWOsClolX3qBMTa0yfeX6GRL1a9pzOzjcE1Lzki4GywaZDZNX4or6B?= =?us-ascii?Q?jsPDl2XHDAjAY+o2ruXXrL4M5TmKBOc+1UBkO0ZZoNT9WCAbJCRMx8JeWRbM?= =?us-ascii?Q?nA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: z6rUt48FZNXnuYLod1mpB/C+41ZHSUs9DB4t1Cgo9uLvX7MBMt95+x9K6tRn8BNcYRUyQddZI34z2/zyIuz2OSYhI2XJ0yWrhH1MIdGRqYIiqgFFZrBVPiuSybkU/CWlNtVX5XYD+pjcfgDA1b92BwieS1yXLfOpqHhf36le0w2DJiCwbxAI0ct3UobdnflhDSeTGwfxFoWBu2FXlIOY8HrPD6LPWIgE4uU1nfJzev5xVGn2erPBZAKXhd9RLCBiNhelOP8rMLPweY0so0tDTGxYBXPpVmkYi8Es74Ub52PVFe6rpNoxENK2lciG9VOrFZUs9rL5JQw0jVtlUPJwnei+vq5dkmyex0fs/6U6Tpx8fW/xV1jVqfKtjkFjvtXazC07CqTHLPtbBfeTNQkmpc9vx+HV3V1DH6jHcxqpy1u2p4cY0B3GXCs0xyQWCfZBEIVamlMRV1QZhMtsbVFYENN8yz4QPVT1V4d8QtsLZujCfjht/dNn/Vi0X341Z1is0E2aUoyjbzaRUhLvVSzfREoHiqx4nZzuqdVX3tKPpldrOlyDBY9vk4V8fpsmsmVbDU/Loa9pRUR2hrIJpiaZoBsr3elyfFu+Zxbw7hYOxD4= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4ae7bc1-59ec-4d22-adf3-08dcf7623724 X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2024 15:07:18.5139 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nNxNAfgK5naBWJfuXp0lZO0cKTLy3GIZNxAmEPMYYo7GoILnHcs4W6kX+CIKIlNafS1oUIJ9Yl5fyDy6kUMStw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7413 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-28_04,2024-10-28_02,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 spamscore=0 phishscore=0 suspectscore=0 malwarescore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410280120 X-Proofpoint-ORIG-GUID: wehHLugWnf57GFZ_0PootazdntVyle-b X-Proofpoint-GUID: wehHLugWnf57GFZ_0PootazdntVyle-b X-Rspamd-Queue-Id: 19575140024 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: fpxr7qm5dazh7bmcsb4ebjrx4tn6gx6t X-HE-Tag: 1730128032-282435 X-HE-Meta: U2FsdGVkX1/7ufR5cTgAN780EEMmj2liWbjPJ53p/hqBrPrCWvhIELLpAUubsWhiuSFrVWBLN3Ns1oh9gRj50IWdx79AZAdb6hqbjZoUVpwe/0X/QmHnvuuljhnq1FuU75EGOQiRsMgoISDAox1b7G9WRjHQ9FVhe0u3vLMruHPwqqqOT09zef1tlzY6t2B5aN++jTXpCA834AAcG9YpSWzN3Lu6V0paukI2RMrE6/ZbS2JLKlQJ/Ae+8Kl1e/WeSNmtFzy7fXKoRRDmRhe66gGUslt7/PPj8JSWl9udEuGdQiK6IUtYMfBG+IrDxFrGSp//S4LsUQ8fOt1bipDoqKI/T2K5KHOQLV2aSWI11WFNiI4ZQ4qvAxkW3A4G+/2pXQgTnAWL+qcBokZbqz9alpiKS41Mf+Cz8qUeq6Ohdcu+fKYHcCkr1Ad1iiowxfXuF8HtwBVvL72SORJ+3F5bUEn0Kuef+32PU1+dsVJAsgU9K8oxLhc1fkXPPTTQWFW1sAGYT3xb/p29mvMl7OjT2r/DS/3XEjsWLCcCx2Rd68xredZv0V9PICw+DXCFGqffih/eYGLFFd+2vmFgjWr9+1g48KSn3+2o0mbpobLHR7VTYWd0dK3WK+/0LbMLnaQEekOH+57Rl8dW8QBzqSK2lqhTUsY+t83PQPsEjc0tXP3LW1XdQG4a3LzzIR5wVCSFoAvZWx7Rz9ouvDX0joLkwbx7u38u9MWHf6inVENwe8z87VuM9RPahyIfeHtUAvL1ehCcuSqdVcfvU4XrfQotd7tkwPhZ6nIazBKbtaxEWBamctfBI8RjLnDmJWfn4z+3yjUPcr1WPVEPuHE579WzizjHM8oC4FPAQY/quRuHiC8C01DD9Yr6L4lcsSqQDtvoW5hf/onCa0F/0r/id96Q2r5bC1fvJ4yWzE5kH9NjGM2992z2tWBZ9P2rFrXmb/qvEav34pMgmcpyKhCYgmQ NfH6EDjV 1HHunTDz9qkR4Ii4yTusdAHLZrsSVgNhdwQpps9RCUTgHKWgHsKnSJBxUJv36sRPmnVA/q4ZraHlzUSTa+KIJ+RQ0yzJcu1ey8BNqwoBKC2kQ/p66TP073TpwXuRwtxumYDx5/Fd7H3JJWPOzNkLxPecgPBW2h5d2g09bhzCzGP/zzxkZtn2r6VKGTfuzuoA95QbdWDyH9oSW0aP+OeUKHP5ihWb4xT/S50bDG0Wpr8xX86gsvQrLEbeiYPnfUNt8XheZVRfHfHA9YM9fBedi9H78q0PWfMVz0DH/vPkJwZXUZ/Yt8AC5JBMibfbsAn9rnRL0bjDKV9ewq70DuzyIegS9kT9438/8IgF5y0/V8ulc5vM30L8MZP+rg2LYUIPEk7h/LTHHFPDUlTP240qazoz1tDx3FTq4TibBr4v1aqlK5LKu5kuQIwFXYRdDK4MjjEVv3LtdOfP8VyCpud9XYJBremb7nVhQAkHZ6tWsbHcXo2MptNkmoCoAQeOnNLxf4QLA/WTTdnIFNRK1Wo/djTyeMAqsmob0+iBn/4foSfetptph5jsyH4seIs9oxzGFmOjswgl4/e0oRUQmPNR4OwvghfZKhu3f0WWZk5SLjlrms0CpRJnEA9b+k0ECah2mS5av X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Lorenzo Stoakes [241027 07:43]: > + Vlastimil, Liam, Jann as this is VMA-related. > > We really need to bring all VMA-ish files under the VMA MAINTAINERS > block... will maybe address that once things around that file... calm down > a bit. > > But please cc all of us on anything that even vaguely relates to VMAs, > thanks! > > On Sun, Oct 27, 2024 at 02:56:29AM +0000, Wei Yang wrote: > > After commit 94d7d9233951 ("mm: abstract the vma_merge()/split_vma() > > pattern for mprotect() et al."), if vma_modify_flags() return error, the > > vma is set to an error code. This will lead to an invalid prev be > > returned. > > This is a great spot, but this commit message is missing critical > details. This is only meaningful for apply_mlockall_flags() which is both > ignoring errors AND assuming mlock_fixup(), even on error, is correctly > updating the prev state. Which is imo wrong. > > So I'd _add_ a bit more information here like: > > Generally this shouldn't matter as the caller should treat an error as > indicating state is now invalidated, however unfortunately > apply_mlockall_flags() does not check for errors and assumes that > mlock_fixup() correctly maintains prev even if an error were to occur. > > This patch fixes that assumption. > > We'll also need to backport this, so a: > > Fixes: 94d7d9233951 ("mm: abstract the vma_merge()/split_vma() pattern for mprotect() et al.") > Cc: > > Needs to be added, and make the next revision [PATCH hotfix 6.12 v2] to > make it clear this needs to go to 6.12. > > > > > Signed-off-by: Wei Yang > > CC: Lorenzo Stoakes > > --- > > mm/mlock.c | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/mm/mlock.c b/mm/mlock.c > > index e3e3dc2b2956..8c3f9cf8f960 100644 > > --- a/mm/mlock.c > > +++ b/mm/mlock.c > > @@ -478,11 +478,12 @@ static int mlock_fixup(struct vma_iterator *vmi, struct vm_area_struct *vma, > > /* don't set VM_LOCKED or VM_LOCKONFAULT and don't count */ > > goto out; > > > > - vma = vma_modify_flags(vmi, *prev, vma, start, end, newflags); > > - if (IS_ERR(vma)) { > > - ret = PTR_ERR(vma); > > + *prev = vma_modify_flags(vmi, *prev, vma, start, end, newflags); > > + if (IS_ERR(*prev)) { > > + ret = PTR_ERR(*prev); > > goto out; > > } > > + vma = *prev; If we move the assignment *prev = vma to the start of this function, then we can just get rid of the "out:" label and return on errors. But the v2 seems fine, Liam