From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF712C54E58 for ; Thu, 21 Mar 2024 21:15:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 845426B008A; Thu, 21 Mar 2024 17:15:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F74B6B008C; Thu, 21 Mar 2024 17:15:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BCC96B0092; Thu, 21 Mar 2024 17:15:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 58DB36B008A for ; Thu, 21 Mar 2024 17:15:55 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 063DD140A3C for ; Thu, 21 Mar 2024 21:15:55 +0000 (UTC) X-FDA: 81922303470.23.6E7E693 Received: from out-181.mta0.migadu.com (out-181.mta0.migadu.com [91.218.175.181]) by imf10.hostedemail.com (Postfix) with ESMTP id B182CC002B for ; Thu, 21 Mar 2024 21:15:52 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=eH8oK6O3; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf10.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.181 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711055753; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Zg+YcWxUSQ4PW9xsrv1Bq8A+bJWYc2oFdFSsmHcvMpk=; b=yMiOv5oOrNPUju+ObSVwJJaGx/y910l1o2zpi/JNjgCooayUdVqaweh3as4TqB12rVOK6s uWEXzD+jRzFD7ihKiduicRzS4k8/qgiRslUEbKDG+gC2GefdcWedag09KBkOX0MHm57Az9 cfsRJio0mH8cMnA9NvoWTCXvz3jkE4Q= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=eH8oK6O3; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf10.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.181 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711055753; a=rsa-sha256; cv=none; b=A6N8xoRzu+A8PyvXHPtD4yLD9wsR42v8dEUOq3B93IylMiNH5oiWylrwGvDXWYvo8tYKGt OQEfEPoY9KzIk60W5wjnfdliQU88t7fl7aRyb8waukG8NZlmA2lZsrkcwaSPv7aZUhR9Za KU45qnNRyuJhsGeBQt/04y2l+W21qME= Date: Thu, 21 Mar 2024 17:15:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1711055749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Zg+YcWxUSQ4PW9xsrv1Bq8A+bJWYc2oFdFSsmHcvMpk=; b=eH8oK6O3whN+5xkQZG4KRvkGEfJMaEROLYSVyvOMEmAr0vx034qCIMnxAzZq0oacFIqlx6 /4Zdupvf6beqxj+COUxVFOfr1DlCfPrxyCpAol5RsNR1a/MYKHHQcVdvNOqefJ+OE0+SxY ThPaS33U901JNoVemYhAKPtdu/kPXRU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Andrew Morton Cc: Suren Baghdasaryan , mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, Alexander Viro Subject: Re: [PATCH v6 05/37] fs: Convert alloc_inode_sb() to a macro Message-ID: References: <20240321163705.3067592-1-surenb@google.com> <20240321163705.3067592-6-surenb@google.com> <20240321133147.6d05af5744f9d4da88234fb4@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240321133147.6d05af5744f9d4da88234fb4@linux-foundation.org> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B182CC002B X-Stat-Signature: apu7nofq6qz3jfcgxyro9477jnxsxkfe X-Rspam-User: X-HE-Tag: 1711055752-271320 X-HE-Meta: U2FsdGVkX1+YPaTXGbazPoSDHfWezdLDn17gjIBIM49vCDpgaL4XduUEZQ53z3g4kg7I0LNUUnL/YLhxaq6kGww1EN1wLfQCu2TZWYOwXEuan+E5X4pOVh35rbi23C7qlMrYtXjbSLLPcvOGRLlFcM393X/KV00cOeTd4ZMQcES0OknPyWeD1AYMXGH9/XEWIluYyJcrGREPwsGC8hmbnId1hNfDgn3wZYbXtIXEzEDYEZ4zgtGmYnhD4x1+Uga79eF6tTJapomYiZxYEtezjFQcq0LBQ8nhD5pzIjD7JrqIRvFwm9eikNa4do/+JXTJ0EOe7FQLVKoVS6POmd0y+JacN5cOOg/sXVwK/jYWmS0T+ePpVA+F3mJh4eoMLXbveJl1CIbA3xhZko/lNqVFCTg9c06ixOBaUmG0Nrq2OLEd2L5gCuegK/naNKxCo4py4cU1OM5+J13jdW2V+4BjlgFKh5Ylzl55jXiQLNKz/pLdTZzIOnw+PRkQIm7jSNrS7yco5E5O4RX0pMMf7MA9dRJdo3rMgy7A0qQlnklZOIT3hQYEFrYJM8Sy5mzRW+1V+2n4YreFp/0Lv1dgrWO74e0qyl7DU4drP+4MNij1UMqa3fDz/vuxfJO2xLWQp4b+CJ7eohfPpSAcnWI6VFMizr5199WpBF8XaaeyW422sEJvPodhRt0rz1yLa8OGr6v696ZMeJnZzV071PpnldnkrULqmoF1PnKMp3yDThphhuYPUbzU4k1gfDNP5c5jakgsOi2cSYc1S7nnT+74FCxgQ9gyEdC74KhHkz64iOwT9zil65duAhc4ZypTtl/72yLRUX4HvgQ/HjP0DHoX5QsdxA5eLBQ7/0MZ/YBP1KDaxoy3b/AdQ/R06WP2ch1ZG4LJUnEEPkp/5dmIIc3+inCp6PgEuaF+HkPpi3hg11u1R2zGtn1zqi8ecwiJ8xYZLuTkt2nfVsvmoKeBWCokb5G Fp/ru8UO OuNWrBxJCcTaVCVazrR051U56qXh1sPeMPT8u0jLia/hSYHVA7FrEfjS9pqzjEDezEiFbyCOYu+cI/OL7yMonNMOL7bXfmf+rsd8AQ5FnOtMsVFXZrUSMM/+mIMnGd1rJNlUeinfZFh+w+ALA+ppEtn6odEZB5jjPTup/ZePqx6aF9KgAITgOunpWxHrfT5azd42OZ3BWrOubK7fvGElIo9UoNCKGfmxKOk2rihChsLvvxrY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 21, 2024 at 01:31:47PM -0700, Andrew Morton wrote: > On Thu, 21 Mar 2024 09:36:27 -0700 Suren Baghdasaryan wrote: > > > From: Kent Overstreet > > > > We're introducing alloc tagging, which tracks memory allocations by > > callsite. Converting alloc_inode_sb() to a macro means allocations will > > be tracked by its caller, which is a bit more useful. > > I'd have thought that there would be many similar > inlines-which-allocate-memory. Such as, I dunno, jbd2_alloc_inode(). > Do we have to go converting things to macros as people report > misleading or less useful results, or is there some more general > solution to this? No, this is just what we have to do. But a fair number of these helpers shouldn't exist - jbd2_alloc_inode() is one of those, it looks like it predates kmalloc() being able to use the page allocator for large allocations. > > > --- a/include/linux/fs.h > > +++ b/include/linux/fs.h > > @@ -3083,11 +3083,7 @@ int setattr_should_drop_sgid(struct mnt_idmap *idmap, > > * This must be used for allocating filesystems specific inodes to set > > * up the inode reclaim context correctly. > > */ > > -static inline void * > > -alloc_inode_sb(struct super_block *sb, struct kmem_cache *cache, gfp_t gfp) > > -{ > > - return kmem_cache_alloc_lru(cache, &sb->s_inode_lru, gfp); > > -} > > +#define alloc_inode_sb(_sb, _cache, _gfp) kmem_cache_alloc_lru(_cache, &_sb->s_inode_lru, _gfp) > > Parenthesizing __sb seems sensible here? yeah, we can do that