From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DF3CC02183 for ; Thu, 16 Jan 2025 15:19:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DDD56B0088; Thu, 16 Jan 2025 10:19:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 18E656B0089; Thu, 16 Jan 2025 10:19:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05578280002; Thu, 16 Jan 2025 10:19:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DAA966B0088 for ; Thu, 16 Jan 2025 10:19:12 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 94E0AA0DFE for ; Thu, 16 Jan 2025 15:19:12 +0000 (UTC) X-FDA: 83013673344.24.2D0D2F2 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by imf04.hostedemail.com (Postfix) with ESMTP id 91B9940015 for ; Thu, 16 Jan 2025 15:19:10 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=Pb1D7vxv; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf04.hostedemail.com: domain of mkoutny@suse.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737040750; a=rsa-sha256; cv=none; b=IzS1kYPyDTYuqs7cJrYV+cVtlumg7PrDRPDN5Zl6ZEg1AjjVTGPfcajjFrQkVBLtvQxxdo Q2a1BXEvjg4oVp6snsmJRQRNHVUEhQnpemD4nOSsRZ/tT8i7M34x36Q6yGPIgNO+BkrQaQ 4gWItHqsTPmCQ1PMcI92dORZGAfWsB8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=Pb1D7vxv; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf04.hostedemail.com: domain of mkoutny@suse.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737040750; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3M1DKP2VZ97EYmAW4sCRoH3vFNxeWQORDKqGMpvw6ew=; b=RBo4TXcKFGf4HawInx+tmQ1my67qnwnXF2eDJVE8GAwSIqOMEVaHVKGdg6W0pmOsO6LEhc DaRA7/GVTaaq+tVPk+P0X5xkQhL3t1lFNicnXIkPPSgMZAngSdTynRYpjXtbKOhaSQHWQl Q0XZFWrxcv3FdnXEzvJpYzyyvK6RJn0= Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-385ddcfc97bso902397f8f.1 for ; Thu, 16 Jan 2025 07:19:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1737040749; x=1737645549; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3M1DKP2VZ97EYmAW4sCRoH3vFNxeWQORDKqGMpvw6ew=; b=Pb1D7vxvEW/jwtXewdGk+Rvnbv/HxXQThVbU16x4wF3KyLbivHBt9Tc35XUIEaMiK7 QBHAfkpg5aq9oTyYx281/LxmaRh1yk83ylmgfwfKKF/opqLQbCLQf5utIn/KSghShU0G 6OpPIG3tB2KGp33U4vpBuYKhIAl10PA0dHaZhzrpy9NesQ22DwHxdTKxu+KmQ5JCEWPp hmC3tnTE0ChCDhPjwRGwTNDf7VJVlk6lr6aiguZ8AlZZUAD/QW/cY4qhKLG02qq/lWfl 93oG0m8bO28jkkvh4ONy6FBeyvfQuGdIXC42CBqJBYt3nQfAcfd+Qj2HyiGRy5DUPvuu uvfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737040749; x=1737645549; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3M1DKP2VZ97EYmAW4sCRoH3vFNxeWQORDKqGMpvw6ew=; b=N8jmOWqWq9RrhPGcEUQerygMyi6ot7b/zBgJ3tyw1sAy8DCX/RAb/r3xFuGO7tAq+c uQcNl3vJmcQgt2gObwgTifZbIU04NsrRn86T3uPXSxD181YdA0V1icKV9GZ3w9CZWHBX BNqYb4QLxw21WQzcLTVNMYr4XbuO8kqZkSVSJOIkASzoiriedSk6/EsS0isF945rLFvT rFPq1gvWAi9mMHvlBUS7cMEZCVkGcRz2oTj3NFy7t5qu5nH5qMvNFWeh7w+FSvBFu/oM O3hArAPqIBbUaZ+F5iSWQzN02WbHRJNvFHfKZ/+3H7YLkPAQ/7SEMXP5Ig3gg+JO7XVn 5Now== X-Forwarded-Encrypted: i=1; AJvYcCVqTZngMHbiEai2IUa1vfw9p52sLVFgwYUrHJoPH7icsoxpUIRjnu52rTDiWxipZSNZJU0/RE6+Dg==@kvack.org X-Gm-Message-State: AOJu0YwIEVchpJFaCdY+iSGAfsbRytOotAtxZhARmAiuN2oVhna8MOs4 JnCD9FCjhtIsflAW8evKsqycCXixifrXrUY+vHkKy83VMp4QiEt99dVXHWGkWlM= X-Gm-Gg: ASbGncvUaUmr6spxcy3RNIUPBT8KSo7HnAsXvECjOFey6jYD+Xhr7fIZOEULU/XxEHm iSoQBU/opIXwS93FUbAuPwrpapo4vHaZvRlbe2Wt/8Ne4uutezMoo0CopJfYcq2NtTOMvz4845h zUP45oqwgI/ihw2ckx4zkMoKvtxZQ4S3IeOf0PfG5nMWsrfZfr5tfNvT8lKNvxPPmOTVdJ1qBSB vysKb2Xgcch5328N3ChV90U6pULtyb8EvK0p65MLA0A+A8T5fKzcjZmTUs= X-Google-Smtp-Source: AGHT+IG6FI+0yboxU6K4HwBhGMIcNCd6nFsTJz/hOtKorzaZu6B5u9WiUiOchSPpaiA6weWNX/GwVw== X-Received: by 2002:a05:6000:2aa:b0:385:fa26:f0d9 with SMTP id ffacd0b85a97d-38a87086c15mr32092084f8f.0.1737040749057; Thu, 16 Jan 2025 07:19:09 -0800 (PST) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf3279388sm107522f8f.75.2025.01.16.07.19.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2025 07:19:08 -0800 (PST) Date: Thu, 16 Jan 2025 16:19:07 +0100 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Shakeel Butt , JP Kobryn Cc: hannes@cmpxchg.org, yosryahmed@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, Tejun Heo Subject: Re: [PATCH 0/9 RFC] cgroup: separate rstat trees Message-ID: References: <20241224011402.134009-1-inwardvessel@gmail.com> <3wew3ngaqq7cjqphpqltbq77de5rmqviolyqphneer4pfzu5h5@4ucytmd6rpfa> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tyxvgw4r6watmyar" Content-Disposition: inline In-Reply-To: <3wew3ngaqq7cjqphpqltbq77de5rmqviolyqphneer4pfzu5h5@4ucytmd6rpfa> X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 91B9940015 X-Stat-Signature: rqz41xioznemwztn65fo5j1nn7okzp6b X-HE-Tag: 1737040750-342267 X-HE-Meta: U2FsdGVkX180d+uY0YAZOaFwRTfFn9CNfoWxjlZpDo7t7R0ueOyN56PboTAU1kZPvPYOcjIfrqrFn71/S6mxhVZxnG3jaF1xPfOwQbP+xNYpJNBK+vhqLRriEkFbrSJo9A73Ifqjpbygs7Qb+gLSrxi031GHA/vByfuSfQRA+qhI6GsqhsrN4HSzd5ThYEKJTwjxQOJKaA0x+hCmkgjnjiiqPGdBuUl1ENQsf+hxHlemf0WDXysn3SmxU5MFnWPNyrYXMccbd4KtM9zMlwyLPGHS/SJzA3uuYulKsw/Jsn9p72VhBWSeCWBJcP+AvbWSf/gY8t95bRAPLhJnrURRI3EJP52xmKdKEi9gCLL4Hr7hau5zDSBxitzOYfIhtVbyoJikxxMK0DKFwUW4a4ZsRDrQP2OmsdjrcYeCfjdDV/ra3DYVH+wZRjWzsKmSm5vZFGffsIEXKPoY6vzoMcD5X7BzpmqZ0JzBJ+6eFRM0lwOHKBCDYb6TlLgFfWNaZ1DKrIFmzVnkRPhkeEZko21nUwpSX+7ih6WY43ghIqshZ9JWqPvyGyJaUm1c3JeNxhVGczMzo4kMVCBL/eA7wmdgqrc3XGtOC5t/4BsoNR5qRwOXGUgzvhPRS040sMaQnGvytJtICi2K6k4TaDZuv+D1Q48sfg//KPEv51ka+fuc6mrihQlWJL4j7Kg6EtrvsW0yEluu3w6FZ2HuUGsE/k9k3ROeoTNkOkJtC09XCcoS7xJ53gF+si2fxCZ5zRFNZXzF/BodvcBwJzVEdc09X9T6sQpycR4wV309SLXLHrE5mdadS3v/h3DmYfEHm3Q7i5js1anugJZEMKfVBrlrW/q3EqowaPDhk/N1AZGc3mvY5X2MnjZprBexRw/+/eMVq8XHOLnS3tz7rtBBsjgR4wVQsqPX1WTdzpEvGyTrtv5eu5QTQqIMtFU9y21DEfxiX+nUAofSOFmDmhhge6CI1Li GHp/QStT xONCfYfT6cEezv8Jeplqp3nMS2/bCBqhBQgfikBrJW05jUAhyEsXVRDeYYu7LQsmfdkqP4Fo4w4GMP/bUBCf4CWsIFhFzhl6FZJKprojBm5RxMBYC+U7SY987AqAgJl6gJVJRjhgwjvUCqmNzhDzTW5cZXGEsAHrVnO3FTsIfGnGMaZgc5Rdz5vvSsPascXdspUpQoekKstkrPGOFusxnxpZsZT+FrhYP+9T7JWoXuCPuW2KNB4bp4t19Icdi5OlFwwPcAH/8PWCJIve7ymQq6p3GuDVVG7zRTktsT8q+Hkw/Xkohp3iuBZQ8sX/Ups9o0wBoB+AQqJAlcX2HVGnBdorlg+nU8LuSTLlEYfckESrox1cE6faxwQ41M48NQ97GkXsCDKDYIAOKYX7CtjOknePUB/rJS7Nksx3eIVUb+zriek05ty/Bs0ekVg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001608, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --tyxvgw4r6watmyar Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH 0/9 RFC] cgroup: separate rstat trees MIME-Version: 1.0 Hello. On Mon, Jan 13, 2025 at 10:25:34AM -0800, Shakeel Butt wrote: > > and flushing efffectiveness depends on how individual readers are > > correlated,=20 >=20 > Sorry I am confused by the above statement, can you please expand on > what you meant by it? >=20 > > OTOH writer correlation affects > > updaters when extending the update tree. >=20 > Here I am confused about the difference between writer and updater. reader -- a call site that'd need to call cgroup_rstat_flush() to calculate aggregated stats writer (or updater) -- a call site that calls cgroup_rstat_updated() when it modifies whatever datum By correlated readers I meant that stats for multiple controllers are read close to each other (time-wise). First such a reader does the heavy lifting, consequent readers enjoy quick access. (With per-controller flushing, each reader would need to do the flush and I'm suspecting the total time non-linear wrt parts.) Similarly for writers, if multiple controller's data change in short window, only the first one has to construct the rstat tree from top down to self, the other are updating the same tree. > In-kernel memcg stats readers will be unaffected most of the time with > this change. The only difference will be when they flush, they will only > flush memcg stats. That "most of the time" is what depends on how other controller's readers are active. > Here I am assuming you meant measurements in terms of cpu cost or do you > have something else in mind? I have in mind something like Tejun's point 2: | 2. It has noticeable benefits in the targeted use cases. The cover letter mentions some old problems (which may not be problems nowadays with memcg flushing reworks) and it's not clear how the separation into per-controller trees impacts (today's) problems. (I can imagine if the problem is stated like: io.stat readers are unnecessarily waiting for memory.stat flushing, the benefit can be shown (unless io.stat readers could benefit from flushing triggered by e.g. memory). But I didn't get if _that_ is the problem.) Thanks, Michal --tyxvgw4r6watmyar Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTd6mfF2PbEZnpdoAkt3Wney77BSQUCZ4kjaAAKCRAt3Wney77B SXpBAQDi8Zo/4YSATiE9l3oV1JeCJjzTixddSW3iLnfRRh2A8QEA9hf3+VQTof+P v6kWsbf/WLqI9WQ+t2SSMxrdeQkwcg4= =/nGe -----END PGP SIGNATURE----- --tyxvgw4r6watmyar--