From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F0B0C369BD for ; Wed, 16 Apr 2025 09:51:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A21F0280110; Wed, 16 Apr 2025 05:51:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A89728010F; Wed, 16 Apr 2025 05:51:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84797280110; Wed, 16 Apr 2025 05:51:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 65D2D28010F for ; Wed, 16 Apr 2025 05:51:04 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3743659393 for ; Wed, 16 Apr 2025 09:51:05 +0000 (UTC) X-FDA: 83339438490.24.E92BB5C Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by imf09.hostedemail.com (Postfix) with ESMTP id 2191714000B for ; Wed, 16 Apr 2025 09:51:02 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=dCxRnYvP; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf09.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744797063; a=rsa-sha256; cv=none; b=xX0cJCpGWIqWbZXfgePtXaHmQNv1oGOXzy1V0vS/Tq9bB7YgC/7pXfAjObTI/sVF5/gQKL hakL5LUPyHIswXUGgq28/gU7Tu7KyQhLIxLmiYnYBfMvXbyAkDMs/ZzidTC7Zh0tcrVxbS bZiADnxvUZOhSaMYaHETbHm9TDAOxN8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=dCxRnYvP; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf09.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744797063; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3pMApbq5ztRYsS7cQ1NuhLQedG7v93kqCIhd8VmUafQ=; b=qEK7uW6nASIHVIw2hxyWtxpApzzKnM4YQiB2bFjY3/ToWb8qajoLl+0ZoS2WiKHv/oHzeA zCft1saABpybelMBaLmpqOSWY/4RcOjNzQCj2BQmIDHtgMB/VPxlWAju0KsYiIit79gGdF 7LL3MnRhT5qzqrguUrRDbCU0vHXT9TU= Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-43cf257158fso46645815e9.2 for ; Wed, 16 Apr 2025 02:51:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1744797061; x=1745401861; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3pMApbq5ztRYsS7cQ1NuhLQedG7v93kqCIhd8VmUafQ=; b=dCxRnYvPpbeOnQvbfvK2IGWS8Mcj7oYq+MxpuQhaPscuhSvlQz9rLxEmIIxVQQ7mhB VUXc1KFRDjf3ScJ9qma3nFMLt00FgIqEUQNsVhz0Ht7Qa0X6rq0B6A2n3OekAkHPSjf/ t3PX3g2/RDCUuvhS77gtoY3mVMlRe7awjUsitLGu28JAmrt1hWOi0B5nqeBQI1r2+Bny 5iJG9f8my2+jFIFtpvst5/JjPHPar8gg9W2BrXC3Ryh3djpYdcFY1OTZTa09myMaAMsw h4JHoTAP9sJop1bOdNKjMIViLXuRxRD9454w044xa+odKSpIqCIuX0IMzqxKtEg/TYiz WWTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744797061; x=1745401861; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3pMApbq5ztRYsS7cQ1NuhLQedG7v93kqCIhd8VmUafQ=; b=CGc+OMwZlgSP36So2ATvLlwyGL7AZtcaXY4Y1YmfU0a6DGy7c1GaDC95k5iyMFSxAA fFP0E3vLVKRyJ5nrXjGuesnej8z4PeHkwpclrcQes7zzRGhO29y9HLTWuBpP7pFJoa/s kUeKrUo50yuqVK1Ga8tGqZ6IGHfeB4IClry9PyBTQF4IQVhXxfgxQ52SmwMsiqPlYIH0 P9JMfBFkoeMcMIOqodQQtI8uPxAGoax6nFEvZgYJRzjvQNPtraeWlCweaoTKVQLn+egU I2Eg3okBK06l71yZGUiX4fn8vFQfYU42ToXpxZXXLiXyB/mhf5qufnR9/4fqsfmoRDfW P4MQ== X-Forwarded-Encrypted: i=1; AJvYcCVYBrhnG2EApC+E3tKUodw430bS994ZCZNAqQr5ITaSjEYO4e0/4hRYVTOFj69TbNN1ClwS6Agr7g==@kvack.org X-Gm-Message-State: AOJu0YzPtDTfMEgLJ/DA0AzKzY4jCa6W2Vg2avvKD9ZPGK1ugc3Gr76x 1hs4gcJJb5TwkkKN1jVfm3BDRq4LaRX+BjgnZSmMCTE2P8esSqbaA9IaCZXFC3Y= X-Gm-Gg: ASbGnctdOsqGbuAkTzUN17YZ1ufigIn7/p5c+2sKWOL56oZ5LpuxBwd5kIobWGGtxfp sHJ2Hj+Wocej7nOxb62kyz9iOS7LybJyrSk/kKLdOIh6e/Si/8mn6U48+UFouGPXE4eq2r3ijdY LjRzwSv5wMXOrPxyoqKLG1U73RF0JEKQLwluxq3vfrU5Elr1F1rRXAJH9Zuz+Y205UjRkUpniu3 7nMoY5a1pug3sBYsQcJeIMyZUazTdGgPhSuiMEnJWoo1/9ccjuxbnSpJaZs9lwwbgJSLfMhuTIl GZ5b2CFJRAdrDj5rd8UlJhbF5MblSw4TPCTTLKDAQXqnn2kXUqGwPA== X-Google-Smtp-Source: AGHT+IHJF/p17Dufq7LhZBJTAZkShM8WLci6d/4iSrWFNucbDiEWU9bcds7Vn1ogvPpZZ7U89v3B/g== X-Received: by 2002:a05:600c:a0e:b0:43d:d06:3798 with SMTP id 5b1f17b1804b1-4405d6adc5emr10705965e9.20.1744797061518; Wed, 16 Apr 2025 02:51:01 -0700 (PDT) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4405b4f3ed7sm15893355e9.24.2025.04.16.02.51.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 02:51:01 -0700 (PDT) Date: Wed, 16 Apr 2025 11:50:59 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Tejun Heo Cc: JP Kobryn , shakeel.butt@linux.dev, yosryahmed@google.com, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v4 5/5] cgroup: use subsystem-specific rstat locks to avoid contention Message-ID: References: <20250404011050.121777-1-inwardvessel@gmail.com> <20250404011050.121777-6-inwardvessel@gmail.com> <3ngzq64vgka2ukk2mscgclu6pcr6blwt3cwwmdptpdb7l7stgv@vhpyjbzbh63h> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="e3omb6cioty2fwbc" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 2191714000B X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 8rhmhf359c9tybncyfrmum6dfhdjdjrb X-HE-Tag: 1744797062-977427 X-HE-Meta: U2FsdGVkX19Ywkrduq09aWhHaD8iYFWLaQRzJRE/hEgsBOVqach58IxcgqHeGhMT5NFmjFOZmpZUa/Bh8geHG40ot3UOw+ProOxEBioki3Ys2zYktOO2gQnm97w3NolAA6UfLTO/Sn3jT6dEoLs/SjAtpEzoa3wO1dJ+tmkdUa0bfEqQMl0EHMtve3sGGZfjl/qpm4bxYl8qc9FZqHzLQe9BFr+jicnkrfxUs04XS+vczxdCyALtLK4syTLtva/9mbz8BhRf5W4J5A6cPJqiKjSAMV+/6l49dicENoHFyJDFYiZQaycM5VwGA6CRZalXVhT3xrCvr/8NLVOSdPMcvmT9Rs++fusOHWzkNHHGjsR1l27F7Orpl2sVb7N1sfyTS9E1qfdjyvh4hKKjrznswCJE41l0IpqGRWAPlrewalKE5Wt3aE6WEHOooaoMkfVmH884czF2cvH4e7QZzgwcXHOuidQMAQOYP1obfwzLU79N59QOFjBOR72jGX9dOHkmgEMIDG7udN/6qsrqZyr/aSgol4mNEU3RiTwA1P2gZyq6+yQu7wdJRBpx273uEwGyDTd+/l8N5iCx1/VgU9fhqfacZTKdQuZu/++uUlqFNaUuQGe+hlYcoUjLnpuqfHCh4RdYsIXZEFjb4thFKqkMtYcVh0MKm3oLidp9rqYgfmwRq1iA/btsJ6Y+C8SZqoa5iDlxroxJWdxIT7epcmi8A00IAr5XuEijWIV386GzXukFo3o+9hYYRb46/JLUBhIuqlNJjE3FjiE0R52OIV13dVyf7ABJFawVgBdEC1Q758y3bDaFwq0IyTrjdQpptf/qPp48y5IgmVyyShPpsnjMK1lsMo3nESbYphu11wjNV990FatkvQVZ8yXUGYjAKfJnCn60hEZ3pGmb74KuT8eyyM1XnOKdQjhEr7tMLi/6iaQf9w0BqpWzxvT65632JsFnQRGnxKNWlin9uHhJHM4 /WyAP3rZ IKc+O4RM6t4VT4vDoc0lvXbgcMtb94vtshx2BCIObDWA0xsJuLrLLVfms/LxeL10m9E7sPj+V2r99rObsl6RIQa7AkTydDTDOiXow8aKu7QFLxtRHAXddswKNwKP5+vvQ1Ldg6W0QTQCJhG2RN9JtJf5M6HHPoSrirRt4MSy/fxZw7OSRiXa0fh6PfkqW1fvgbq6ThL5PmfFNT9Q7T3NfCugYoNfBPG9Kkf20WD7BXU3Lmt1QsbNY9HrYALeSk4jwot83dQB9dmyBg0g/F8V6XBiD/8YNCY1YkDur4aA2KfNCb3P38C1F0AztCS1REIiRKnFTMu3U3wseiR/QSDklwvBPsvsbsBPKB29v9XoAKmJPGGX/KWMwXG0PaxEOmB3eM1v8OFne3SpwLvTYeIr3NlW5yrQmbIMsRiI6DjgD48tVOiUXhhzrkkD6UkFfeec9CudUB5fdXUQ/4+WsNfBU/sqHRvqO0HxbqPUP X-Bogosity: Ham, tests=bogofilter, spamicity=0.106339, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --e3omb6cioty2fwbc Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH v4 5/5] cgroup: use subsystem-specific rstat locks to avoid contention MIME-Version: 1.0 On Tue, Apr 15, 2025 at 09:30:35AM -1000, Tejun Heo wrote: > I don't know whether this is a controversial opinion but I personally would > prefer to not have __acquires/__releases() notations at all. Thanks for pointing it out. > They add unverifiable clutter IIUC, `make C=1` should verify them but they're admittedly in more sorry state than selftests. > and don't really add anything valuable on top of lockdep. I also find lockdep macros better at documenting (cf `__releases(lock) __acquires(lock)` annotations) and more functional (part of running other tests with lockdep). So I'd say cleanup with review of lockdep annotations is not a bad (separate) idea. Michal --e3omb6cioty2fwbc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTd6mfF2PbEZnpdoAkt3Wney77BSQUCZ/99gQAKCRAt3Wney77B SSBhAQCs10FlWiypOfGmgQpV+PJhecrxt3yL9WWOZDAaD9OWZAEA6UgNdBlY55Es /MXqH6C2ak3lSh51C3Ta9g/yOILvlgA= =eOoB -----END PGP SIGNATURE----- --e3omb6cioty2fwbc--