From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A858C4345F for ; Tue, 30 Apr 2024 23:00:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD1F76B007B; Tue, 30 Apr 2024 19:00:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C80806B0082; Tue, 30 Apr 2024 19:00:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B48206B0085; Tue, 30 Apr 2024 19:00:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 942426B007B for ; Tue, 30 Apr 2024 19:00:52 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DAAFFC09BB for ; Tue, 30 Apr 2024 23:00:51 +0000 (UTC) X-FDA: 82067719902.26.6904B69 Received: from out-175.mta0.migadu.com (out-175.mta0.migadu.com [91.218.175.175]) by imf19.hostedemail.com (Postfix) with ESMTP id E2B931A0026 for ; Tue, 30 Apr 2024 23:00:48 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=sEmKXuMs; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf19.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714518049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZUW4oNFaD0o6Bd2QS09RU7OZsgb/vrqxqdIPqn7qFTM=; b=ZEaFnYE8ff2/vXywWCBICUmaeeORtAHZssQ2Y5gYNutjGuJ6mk4TOF1dald2XGufzr0J2+ 6AbXe4U133faHFdUjFALv0kyZVP/Usi1hZXF1DZlCfgfQrZqTLnrdwf4bSgTSPUsO6hM7p ivIakaPOWN20oP7PA4jL56eXGNPLzcU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=sEmKXuMs; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf19.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714518049; a=rsa-sha256; cv=none; b=JyrDmP0PNy+HvOmJwTVUWk67eDjG46E4o35w3EwH8OzZPxgi81dw3P1fhrhyZ/QXFxsQGM Z9ObB4oRhMt1CdrTiq0TnJM90THfdFF8jH3B0KO5jmjSZ4CMkuxWavI7eCC6sh4NMaJE+i P84sCnpPOG2Mz5gZr4FKbR2yARgGquI= Date: Tue, 30 Apr 2024 16:00:42 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714518046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZUW4oNFaD0o6Bd2QS09RU7OZsgb/vrqxqdIPqn7qFTM=; b=sEmKXuMs/tKb6YFbpFESPjYFZZneT4newThJeg2ABphFxrhnt/dYKudgLEjR8CmGYem0HV 5pxkQ+/qWntvBI7Mxgy0YzGMKozzD0M80LEqFnTeTBUm3lw3mzdr3UYNBhDt/WRj3Sixkz 9RlUVI277LiDMnD31IAQvgoqF0I6cyY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Yosry Ahmed Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , "T . J . Mercier" , kernel-team@meta.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/8] memcg: reduce memory for the lruvec and memcg stats Message-ID: References: <20240430060612.2171650-1-shakeel.butt@linux.dev> <20240430060612.2171650-5-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E2B931A0026 X-Stat-Signature: cmsgrjkiqk1g5xa9pyrwoukwozrf99yc X-Rspam-User: X-HE-Tag: 1714518048-392561 X-HE-Meta: U2FsdGVkX19IvUVBHsGfRFipW5wWeCu/R3jt2Sb8mJ3o92x+bUtoE2UPRyJoV/D8QEeZ4dyrULbFSnWdh4omdnyHOJLxAWnc9bY65tKzbJ8/TLRbgJgrB7tKirrSp5oB11MvG0ws3vZ0swyL3CF6rJ4xlDCBSmrrkudE0V9yuSI+Hl4Z2MhYxFcGPfeHHyQYio01ARIqGcbkd+YI1YHUKtfZReqJxedzbgmbRz/z9jhFuzBcVSaZQXabhwDfbQq8lfNj0HeWhe701kKajZKIvh2jGyJXEsMuiSVue9xxt9JCnhVNtYuUGXYOjQuou6fOrnNdXxj0UUntJ18CL3oNvdDMrS6YFZFKQaUY+F7B3hJAJFW0DC5Vs0xf09U9QQdYoWqb8GOUKfrDbF+M6zxdMOOBSNEazE4E2oA+7V4lzRmHB7Lcc4p9475+yFnvvgIAPuh4AN6VCmWbRXhCmlVmMS/KkjiT++mfbsVtlljP+7kIX7tYwdNReh0myuWt1OnOPIxap5MSt1LkgHxXvUwNJPsgcLtY+Tfor2m85nfmRSr/ee/+29J1+dG4Do8xNJBOk7eRNitYX3ZK5ZvzO0JGTSeB4L3pW8YHoRDYQz854ADJYToOkq/k5XAae3zSlz/bO/J0QJu7VO4AVLb8qxO+eZrRTLmYWi7H7wWI0DJXrM0fEnIKY/4tQBHOjKMtCtsi1XEXXQIANHDE2XMwNo2T6IVsOdIGu+RiEaa4zHCHJipXHeSV2YatGmBwtSRGIWPM+cdvv5qnFLLZiKXMhndS7SuW3PrfpmeZHTmV2nKSrmnZe04WOSRyYE3fMnZ1TxElBlrk2g98uLOB122thsA0sbiDMwr4XSPundnHzseEmUzJNPet6lJB6tH6Xw6l4rTzXujCJYV0OopdBKIF1G7b7zXP4ae2wL72VvxnKoy76iyYt2pbF30O98tHQZKzxrSaOaTEFbWwuf9k5SONeK6 orGHOjoM m+OxxkMvZmpvFNw07zxQBjj3jLEB61pMVgKrE9CazXq/tvev1OMPp+pJvOoo3eIyRIdwQ2P2Heb7Jv9d7tj0OUCqP8yi52eaPUilBm1Nal1w5e4sdAwV8xjTisA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 30, 2024 at 10:41:01AM -0700, Yosry Ahmed wrote: > On Tue, Apr 30, 2024 at 10:38 AM Shakeel Butt wrote: > > > > On Tue, Apr 30, 2024 at 01:41:38AM -0700, Yosry Ahmed wrote: > > > On Mon, Apr 29, 2024 at 11:06 PM Shakeel Butt wrote: > > > > > > [...] > > > > + > > > > +#define NR_MEMCG_NODE_STAT_ITEMS ARRAY_SIZE(memcg_node_stat_items) > > > > +#define NR_MEMCG_STATS (NR_MEMCG_NODE_STAT_ITEMS + ARRAY_SIZE(memcg_stat_items)) > > > > +static int8_t mem_cgroup_stats_index[MEMCG_NR_STAT] __read_mostly; > > > > > > NR_MEMCG_STATS and MEMCG_NR_STAT are awfully close and have different > > > meanings. I think we should come up with better names (sorry nothing > > > comes to mind) or add a comment to make the difference more obvious. > > > > > > > How about the following comment? > > The comment LGTM. I prefer renaming them though if someone can come up > with better names. > I will be posting v4 and will change the name (still thinking about the name) becasuse: > > > > +static void init_memcg_stats(void) > > > > +{ > > > > + int8_t i, j = 0; > > > > + > > > > + /* Switch to short once this failure occurs. */ > > > > + BUILD_BUG_ON(NR_MEMCG_STATS >= 127 /* INT8_MAX */); The above should be MEMCG_NR_STAT instead of NR_MEMCG_STATS.