From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E96D7C282CD for ; Mon, 3 Mar 2025 15:20:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C5D86B0092; Mon, 3 Mar 2025 10:20:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 769106B008A; Mon, 3 Mar 2025 10:20:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E3EC6B0092; Mon, 3 Mar 2025 10:20:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 40BED6B0089 for ; Mon, 3 Mar 2025 10:20:35 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3CA4151BC0 for ; Mon, 3 Mar 2025 15:20:33 +0000 (UTC) X-FDA: 83180601546.02.66BE874 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by imf13.hostedemail.com (Postfix) with ESMTP id D2D192000B for ; Mon, 3 Mar 2025 15:20:30 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=YsRM0tvc; spf=pass (imf13.hostedemail.com: domain of mkoutny@suse.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741015230; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PT8hIH46ghzeJYoH2LwftKa+OP7HKfkS3jL/D2rOeU4=; b=hfOAB+Nmcune4APLSDhNfOU3Kuqf6e/pw0XUhUOnUOuIuUOx1CtQKD64X1sQ7hjqxjcJ0d vQebuytw2PLxwi2KncJ0eXdvB+4NzatcUyl5exjh0f9mJ80dS9eIRdu3AY3tYgpH5TxOO3 LdM5c9mOkd79jITtcAk0ErJO30UwsRc= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=YsRM0tvc; spf=pass (imf13.hostedemail.com: domain of mkoutny@suse.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741015231; a=rsa-sha256; cv=none; b=gqFCdL5EKu3PWUdXLn5V8sHz8QuIiwGii3jW95LMot3dWXGCFq0yNlAE3WFJRrudaXERZX PQZBY5/ayU2/QVUubBYuXxGyGPZqR1zyqcmn/NYUmIa6cnkq/fnCiMCqRghE1/7M9JFqIa cZmlYLl4zL6hkCSMfzhSSy7dSK5WMbw= Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-39104c1cbbdso693227f8f.3 for ; Mon, 03 Mar 2025 07:20:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741015229; x=1741620029; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PT8hIH46ghzeJYoH2LwftKa+OP7HKfkS3jL/D2rOeU4=; b=YsRM0tvcPtASgpfI4w5pHVAdinAMV9GjTiISs34bPpQjnyiFhLtCadhSKAPAFImG5J 24DGlfYeJ94VaCzZcIilUASe1bEIjdpLY6oy2t8uMJMS/2imObepjfUaXRjkux1LuuO5 cf70UsOU07SH1nLvpFtnPyJiCvZuCXOMrTBWnqGgkUDfqLohlBehdZaWCFR74uF9zBDE aAL+kyYBDQ1Cr/DtKSZcFw+dMmtCLPCVmG+Vrm1ZVQ18vQyoIj8beOFd2ynjKkMmH84R lf0oV1mrokrwrGNP52tFvP4Nogsrg+ypsaW/mTHhj2bsPXemZf580SnyTvEmLyNdIHrd RWhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741015229; x=1741620029; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PT8hIH46ghzeJYoH2LwftKa+OP7HKfkS3jL/D2rOeU4=; b=EXjw6qo9hzzpwMSrSAqYW8qxJew+eWhwqvieIbCGXZ9HABRNwBoGljqInqVOrYqLiK FfY4pcu2kRpP0tGEIxpGkWrLp43W/Cd4GejMCeIBMISZubutHF3bQpdtxsAbPGArgMmH lhAhCjP3FmEMp3EbYyWyiXNdH5byA+/7aZ1UiomB4W43hIg/aMIApvePQtTq2Bv4Pimt ImfTYuwKd+jH6cCc6H3jas/T5KEQ9nfbOHSx+Yo4UyI6D3SyVFnyw75ZISAfANwYIj0c TVhpL6hty2Z5LzzVpAMa6XEVKfApBdLsknOtrfUpjeyNw9EmGB4nZDQrxY0P6dZXeBSM QGpQ== X-Forwarded-Encrypted: i=1; AJvYcCWOF1LCNNiOrx+oQ6DcN4IzgBWwj6SrjMmmLbngU2Rb3/KpQ/eZp882EfiHZDK7p4TGazVj6el/pw==@kvack.org X-Gm-Message-State: AOJu0YxFq7q+TLqj+uye4/pK7yo6D8oZylCxJMQZI3EEqCyJ+PBblcA3 J00Vshx3eoImhitezUYIuiKZyHWgjJ79mfJ3aNeMHFBPFtlqXnsPV7yPHxXvvt4= X-Gm-Gg: ASbGncvHTriOkhtwRP/lvwMVxyn3//O5n+kA3kLZ+c4GygyfLaQY5q3i63yXBVreVHb 7yiRNgkGT7WQOkqrHLhddYaPQa6DtrPWD7vo6Bz4WcqM+4gHKt7HSsgRI9CCf+SpCsrp1QP+uUb +Gq36g5vKqjv5HXLNvIMZfv1JQK8CW7G5c8xz8+0ZsavLbSaKKwgVG9TRxZxpmlUErr/76HGz1k sfPUjq5uv2R6LR3gjZUrpMSVCn7p63E9+TqvWVXQomu49yoryS4rZuZlNZBsl/BTJBPeTBFd0xI G27oONbUR4LnKe0MZkII8/GdQpqyEuZkKUWLsQMzVkmpxoM= X-Google-Smtp-Source: AGHT+IFgcdKlV4KN4Ns6CbroK7lY5wl/9jYO7RuRWHGQ+RkhY0tkO1j5V1H+eO9bwNfsdUP+Zaa9bg== X-Received: by 2002:a05:6000:1563:b0:390:d796:b946 with SMTP id ffacd0b85a97d-390eca414efmr12713565f8f.44.1741015229384; Mon, 03 Mar 2025 07:20:29 -0800 (PST) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390e46f580bsm14580280f8f.0.2025.03.03.07.20.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Mar 2025 07:20:29 -0800 (PST) Date: Mon, 3 Mar 2025 16:20:27 +0100 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: inwardvessel Cc: tj@kernel.org, shakeel.butt@linux.dev, yosryahmed@google.com, mhocko@kernel.org, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 1/4 v2] cgroup: move cgroup_rstat from cgroup to cgroup_subsys_state Message-ID: References: <20250227215543.49928-1-inwardvessel@gmail.com> <20250227215543.49928-2-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ajgjukcubjc7bifs" Content-Disposition: inline In-Reply-To: <20250227215543.49928-2-inwardvessel@gmail.com> X-Stat-Signature: scrmf1mjee48ayjgzu7t3r6n1hzokbzt X-Rspamd-Queue-Id: D2D192000B X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1741015230-780334 X-HE-Meta: U2FsdGVkX1+PBH6yy/UmwYrfVmw8O5R8JLfvppd1GtZnnXglpKLPmQFjtD3vAVXMpl0B4tsYXo4VYYiaCxc8t8RU5iGRlDyQM5UnQTUMfrldKTI9/Q43jhY5ByK2Ryc49TVPo/XyB55q7k5USyeLPZkqH327zy8cTOw+jxscC/8E7CnMn9Xn776wbLPkgxXeG3naaVZjO3nv2Omzg1I26bworHZoCDCcw2QJdwDTVCzKPc0Hm0ngEO1UzdUkh+zEV6rBEtpnhZDUcf+Gk8yv/5Rp4OqBDpKz8WMGJlMPBMXCMADGmGru8/vs8NzkBMlmcc0J9am6h2BKni1aFZMrC+xFX6RLyS3YZPSCuvaN1SK1PV8tiXZ96G0C6IO2x/gVg+eFsXOzHBC8Dr/Z4bKZc1zsTKCA5UzKW7EZ3SrT6cVkOc/i+QXYipianyKC6DPHmo33M6ro1r9amiFKOWH8/pTaTU/J6toO8CYRYJIO9qtwXwK1WEbb3LtpbeOPFj4NoA/R4BbMXwmjLndkwLObgByJqcoKzqXXrDaUYwRxIctwiRq9uPhvn5A4rnuj1ZpP/ic3PP+bw81pP49GvGMNO3tiplNYgmo8XXdylm08tPqGVcy1JLt4VZ3kvSYxHSc3798UeuU842hB0ztfSE6Mr3MF+Fvl38fYoRHWzexw8lo2ng9l9PUXf3WengKiwXsA+31ZvJyjohfxcbuxGkhUpj1S9ifwWClgE2NLAI70YSHr2xPgMjWtYNZdeb0x2kS9XQDl4FmWMhyaJDfrdYqyysfY4yjrbNhz9gdiQcLtfICYN7cG2+l9yw88sFmAh67iLr1d3YB14xAwouref09d8IgUgFOUq/ngRcw+vxl4AEDsvqlXzDk3EmXhjE3g1fJkpGRDhxhFmVacwuva3/uB8M7fdJFk/+FhvIcz5HVaN8pUDIBJEG6sOVs7L+DTdNpDM/wyNJzhOcIQfClkwCs AyOyBpOc e+ar2WefERrFuWXu5YNJgYjGh6gLwK2am8SkQzqKBOJK2BBrhmRIuGgvKvvn1IRqD4jnmAaXYm4b+copnvd6f3iOJfQP3SxUe7aCKrUxk+QVn8FyFlIPAMAQWWxHWxuK2WsMJ6mfDxYndyLIh57yCMvAqM7FdIhUQDsiGqbipKfd+ISYavnwIY9f3JTZq1aH9VTDPCdqCr7hZRk5YPXicK8y9LRBCx8QsxhtBqMg4fV0ERUaS1hO8v7PefVxm1lC2HVuxghSn36WzdDt/FD5XbyRMt9rS8NRs8mWThu6bE9kA9AaMT9JpeXoBEjne5r0OwijY+kroEHCI9IipYMMKUp/IYXFXVtiFDdAXYrd48b3/VwJ3uSUjK9bn7NewqTBNs6rMWAZz0zSaHyON1FlVfZBlCg/RE+Q3qhfsbf0e6hS71EdLAPRh7UQ+rnGJ77vSyEZk47T5MmD3QgsYCCLunlXcT1AQFErdAzJAbiGBl+ybM2A/z6qyNZbD21mwo3ED2tGv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --ajgjukcubjc7bifs Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH 1/4 v2] cgroup: move cgroup_rstat from cgroup to cgroup_subsys_state MIME-Version: 1.0 On Thu, Feb 27, 2025 at 01:55:40PM -0800, inwardvessel wrote: ... > --- a/kernel/cgroup/cgroup-internal.h > +++ b/kernel/cgroup/cgroup-internal.h > @@ -269,8 +269,8 @@ int cgroup_task_count(const struct cgroup *cgrp); > /* > * rstat.c > */ > -int cgroup_rstat_init(struct cgroup *cgrp); > -void cgroup_rstat_exit(struct cgroup *cgrp); > +int cgroup_rstat_init(struct cgroup_subsys_state *css); > +void cgroup_rstat_exit(struct cgroup_subsys_state *css); Given the functions have little in common with struct cgroup now, I'd not be afraid of renaming them to css_rstat_* so that names match the processed structure. (Similar, _updated and _flush and others.) --ajgjukcubjc7bifs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTd6mfF2PbEZnpdoAkt3Wney77BSQUCZ8XIuQAKCRAt3Wney77B SV94AP4saMw3ibrbjwN8HcxInkXlNMb7HYSvooBl0KbOqGTUbAD+KN8yJ7U3s4M9 mdHNJeONgwAI48p7vxXj8a5rTz7O6g8= =wP0y -----END PGP SIGNATURE----- --ajgjukcubjc7bifs--