From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 080D1D149C3 for ; Fri, 25 Oct 2024 16:23:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 612006B0085; Fri, 25 Oct 2024 12:23:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C1CC6B0088; Fri, 25 Oct 2024 12:23:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B0BB6B0089; Fri, 25 Oct 2024 12:23:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2BA3E6B0085 for ; Fri, 25 Oct 2024 12:23:12 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BA73A120CB8 for ; Fri, 25 Oct 2024 16:22:53 +0000 (UTC) X-FDA: 82712643762.16.E155F38 Received: from out-182.mta1.migadu.com (out-182.mta1.migadu.com [95.215.58.182]) by imf21.hostedemail.com (Postfix) with ESMTP id B20391C0018 for ; Fri, 25 Oct 2024 16:22:31 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=M6kK4d9r; spf=pass (imf21.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.182 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729873312; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4/s1HiPozNDCLY2sfzZo8MbsmZBXS0D1TUxHd6nmBpk=; b=bT379tz+XWdaMDqYBQKEHTk9kMSXtYsYKoD5PRk975Tie9cpBlW+Z9GEBMpzB1l8hLvqKv 7dDNhlmyEKkSYApnzAK7zNMfxl5BtYlp1Gwsl5FajEfDIXQlsRHrZ1u1vKTtgqx0UcZEUs sNFBhmS/1iiieFCjgyWBcQ9ogqyIwn4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=M6kK4d9r; spf=pass (imf21.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.182 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729873312; a=rsa-sha256; cv=none; b=HacgQxqGA95i9zbA5pe2VtMjeF2teHzixmd72nrBJa1wrZ8StcopfF09Q45Ei7cpNyUbMV eLRYxLSg7ng+VbM7DJdxeFyovLXksuEbFP6RiMnMX+vkY5ejBPyJ+6KwzjUwp16lTKHdK4 bAnsTZbcfF27LsaGyS0dugUQMFKvXcU= Date: Fri, 25 Oct 2024 09:22:59 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1729873387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4/s1HiPozNDCLY2sfzZo8MbsmZBXS0D1TUxHd6nmBpk=; b=M6kK4d9rwA4Hp5N257wzdPh4zptGcZCPuDWy9mskFI3SACn3X4z03/xCukMcVbf/GC/A84 7fakSeuXQltzo5xL0B7PDYz9OLPIh9kDQqVLlhD4EtL9Vkeb8/g+tNEYLTftJIsdGm9co1 z81irbOwTKsros3zRK2LdmJcCWmqcAs= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Michal Hocko Cc: Andrew Morton , Johannes Weiner , Roman Gushchin , Muchun Song , Hugh Dickins , Yosry Ahmed , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, Meta kernel team Subject: Re: [PATCH v1 3/6] memcg-v1: no need for memcg locking for dirty tracking Message-ID: References: <20241025012304.2473312-1-shakeel.butt@linux.dev> <20241025012304.2473312-4-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: B20391C0018 X-Stat-Signature: f67hfn1g5tokbobrynsf1iytf6tnt1np X-HE-Tag: 1729873351-117498 X-HE-Meta: U2FsdGVkX18gfjlHdqw+ZXzmcOv6QQq0AVUMvEp0qWV6VhfUdJH1audiZuWn7YIBTh54GoJPhLFSles0sEfh5cQniVMOs3EMkW3XWLFGUaMz6n+kl/wfW/BIr8SB5nL2psiul8p+ZtNgnNU48sUt/TOq67PfDBV8oF0USVioA29UimMztb3JBV3kNDlbF6+UXVOI98jfMwWomXFNTCV3JJxlxBtkw1FwbH4HxkQM71QpfEgsY8z7kTFAhpIaVvDBsngZo2+0d+/d1ETlxlAzFx8gUv8ywESzeEMtxb98+DWsLTjcX/G+AxdJTrxIfw4hDKegEXE9NAT1YPkzAk0ifWsCnjIWYFxhB+r/aG4vPlFq6aMq5EDSFU0yMNUKXU2l2QfTFtBKWZl/aUhH46r44IQo+DlxQ/jNgG1iclydPiC/2SbuWtLizyewrrzBo/MYPEUvmielXas2lIhNtBdk3mgG+BxTqOK4EinR8Rcw6TyYzEgNI+oTZWwbVZUlEX2h+ZxUdKdJKlps4ZxdCl6WxvyxhJiqdB0gPpi7jVB3pBK4zY9/QBBmLeBxd75W8Cqu9Bhrj3HKIlFnvrNDUDPBBodJeNRu4AqUbYnAlG+3yFYVd+HUlBKaQ2c+usdUx3euftj43UF9/7ZXnrtUwoBtRYCFLx9KO3WR6Xn9I67C5kZiwh0eVkIsFRqYdNZ7zzT3SovpT47Vk3q64Jya8E0xL51j+Kms2S8IO8BtO7w8+HRRi1WdfQUuBK5075sZyW7Vr2EQ9s7I0z44O26HLc9f1mfhKvD7K7jyFQZqIz5IMqzcLFZ+0VVYVdm6t01EgfUygO0ZMBRRBnD+4sQJQ12hjhoGbDhOJhup7qg1PspEaejuEj1hSyphvMDOGSS2CYSgKOFIn+RvCize0uebrqzWLw8RHsorXlv1Psg9fNF4E9LZ/lD+eL0g5fYrD2nm/TtJ15/kc3aqM7eMDEuPAf8 gaWx+3AZ 3VFCJo40VV2kUeiWs2GVugUVZoaszZo/wcI0XNvruHqmMDdEAeh3UErMqji6oJkKih5BS/KLG+6r009wrO8xMtdiDNnoBM9ygd1U2o15fR5wOANyC4/m8SQG1oLVk96tQ/fesTX5UEFUS3j2f/qhHGYO5rYwIEYxatdiJxlPipL6gpuiR6QNwhzBs4ifQsdu5quy2hxIfVA6s9+w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 25, 2024 at 08:56:14AM GMT, Michal Hocko wrote: > On Thu 24-10-24 18:23:00, Shakeel Butt wrote: > > During the era of memcg charge migration, the kernel has to be make sure > > that the dirty stat updates do not race with the charge migration. > > Otherwise it might update the dirty stats of the wrong memcg. Now with > > the memcg charge migration deprecated, there is no more race for dirty > > s@deprecated@gone@ > > > stat updates and the previous locking can be removed. > > > > Signed-off-by: Shakeel Butt > > LGTM otherwise > Acked-by: Michal Hocko > Thanks Michal for the review. Andrew, please fixup the commit message as suggested by Michal when you pick this series.