From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F6B6D1813F for ; Mon, 14 Oct 2024 19:59:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D15186B007B; Mon, 14 Oct 2024 15:59:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CC4B96B0083; Mon, 14 Oct 2024 15:59:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB3696B0085; Mon, 14 Oct 2024 15:59:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A22E26B007B for ; Mon, 14 Oct 2024 15:59:46 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6010480272 for ; Mon, 14 Oct 2024 19:59:39 +0000 (UTC) X-FDA: 82673272794.20.DB8CF25 Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) by imf18.hostedemail.com (Postfix) with ESMTP id CB68F1C0004 for ; Mon, 14 Oct 2024 19:59:41 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=GwhEfiuP; spf=pass (imf18.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728935912; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iTE7/S0xDM06pUJ9VNa5Wo36gDyiHFav6hHVDX9r4m4=; b=Z2ChfyoyiM+51w9f5gxyYfwK+GhqfgWvRG0XRazi06hy8yOnnIPi75r+vCTZtCRgVxmI7f sti3HJK9BinzXU0S6qZXBFlbcrRuTVSKuzicBY8CAfZ3/02eNsSSdYt2trkZXLBQfqOj2D o5EEcFUCCG2+LPFmXQxkIa1qPiCKT4k= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=GwhEfiuP; spf=pass (imf18.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728935912; a=rsa-sha256; cv=none; b=LTUgk8M2zKsPBr5XbMAKDmE4W7dXsDmBjwgAruGjxy5JtkBCns5+vL1kYJVUirTtHGzwXf RyP5QWpn1BtClKAD3Q1x2L6h3xxrlTpnwlUGWPOVFtqrUT4g3xCG8a5aJdByFd+aHhgDe7 jB0+f0X9Pc0mqBkpU9AmxpahCgfsqYU= Date: Mon, 14 Oct 2024 12:59:34 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1728935982; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iTE7/S0xDM06pUJ9VNa5Wo36gDyiHFav6hHVDX9r4m4=; b=GwhEfiuPp6MoGGp1Aioj+7ur6yEcn+ocYBzCb30EQRLtAKMNNE8nxgFs4uK6/sg8culqeY L0aZ3xtr/LgxeGCJYsNXYUqxVlpHbHM0ncBUeyS3nntD4DBW+/OqgbBVP9xZpvFKLuiKMb rWMZp2AKBj8kGxEMWDnqJz6Dcqu9m+U= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Ryan Roberts Cc: Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Greg Marsden , Ivan Ivanov , Johannes Weiner , Kalesh Singh , Marc Zyngier , Mark Rutland , Matthias Brugger , Michal Hocko , Miroslav Benes , Roman Gushchin , Will Deacon , cgroups@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH v1 03/57] mm/memcontrol: Fix seq_buf size to save memory when PAGE_SIZE is large Message-ID: References: <20241014105514.3206191-1-ryan.roberts@arm.com> <20241014105912.3207374-1-ryan.roberts@arm.com> <20241014105912.3207374-3-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241014105912.3207374-3-ryan.roberts@arm.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: CB68F1C0004 X-Stat-Signature: oqfn6tw9gkf1frmtbiujo3fh9k4xky5e X-HE-Tag: 1728935981-716331 X-HE-Meta: U2FsdGVkX18khz3RfifGb1kbZGN0BGZ0SpZR7vh+24+kD+hVE4aL0Byigku8b3RE5T/YKv0/ngRDjsSkl+EzB49W7NvCEVQ5LDqoZouf2JTCfNXVCJK7YseU2lZrr0H+BgWhgt/U8tZf7obHpz6OdSz2aTAnRBa1tXFCYGEepdhTmkpXz55sHiWcK10LAfKrLqLMdmxMjxpjdJ3aniGFmipYyhr+2xz+DDMajahnMlCDM3P02V1b3uwNV5CatlGEiVhk9XqltBNnji3zbNagDlsU2DauxQAQz5qwKwPBT7NaOHy0MmIwjxdsPOIHGX0LO+k9rKLc3xYa4NfagBy1Z4zf6rPRP+2w4SNwlfG+LtLIX9ptQmjwlgoWtGhPRERBbK3Z5BykNstpVW39ru1/LMEnMXs7BzByCOCFwWyiph0KgnbqOaNEDhmSGNLV38uiw0MeOiJNzYPedjttyhWkS6LDTOiwjyR4AcFMrnlnbl2kTIQdC4ILyM0KLGb/UKZ8TzDMkKksmFtO651l7NY3bLuY9SpwKHvVSShoHEQ6auHWinlClTEJIrfL0XV1Ug4Ad5gucA4hZSEMRFi1psfQYjd7+KOMwnbVIdhQlFKwr4ss4kerplhnpHLsEtaiu4sohQomHKxdsx9p2ZB24ZwkSr4yY1yRcZKnzkalP0On2CYhXWOfiGH55XMn9AqxggKcVpfUD1c15xcuZZhtEuZ2bILpmLufjy0UswH3aeFokGtcpxbBvp19o4o6UrClEiYSFVV7KfZiYJo/8MDga2tiKeKLRheFQsQNGiK1EYSHa4L6cMjTyD2pexz1XC2fyUFDPjKbQ9MpN4PVIzLWbtocFwSn5CYbE8Y/aSUQeIiVMR053shp7J6nFWWCm3MZF4Gou3YIDFCJQOqFPtuH4TFz9pLu+YQLwAq5DaTDZlVI3twd3NZI3JYnwiefczTd61O/nhWz8kvZBnmJs/qvKQZ bEvLeufE ZLFy1KHhpXb1nYylq3CqbG8ph7YhszT+awRJ4gsSCpK1tgGoM7a8ckp4xc7ikRP1DxdNFhZdHpP6z8GrtI4hvd6+f4K270k0+4jWWVzPjpFdIgzGBlbXDlAyOc3Ij/QYGfvwl47xt3/XoVAtfhU5PBJkcyewM6CHtjHW26KFHo0Sh+rpGgRp5XTK/nFofucnpVJC1yA45Sho+Q+VhD30R7itXRaKhz3OfnbhFY97QFyzLPA+nJgJ/4cemqM3q6pkzQTZ7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 14, 2024 at 11:58:10AM GMT, Ryan Roberts wrote: > Previously the seq_buf used for accumulating the memory.stat output was > sized at PAGE_SIZE. But the amount of output is invariant to PAGE_SIZE; > If 4K is enough on a 4K page system, then it should also be enough on a > 64K page system, so we can save 60K om the static buffer used in > mem_cgroup_print_oom_meminfo(). Let's make it so. > > This also has the beneficial side effect of removing a place in the code > that assumed PAGE_SIZE is a compile-time constant. So this helps our > quest towards supporting boot-time page size selection. > > Signed-off-by: Ryan Roberts Acked-by: Shakeel Butt