From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D71FCA0ED3 for ; Mon, 2 Sep 2024 09:54:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F0308D00B5; Mon, 2 Sep 2024 05:54:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A0078D0098; Mon, 2 Sep 2024 05:54:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7410B8D00B5; Mon, 2 Sep 2024 05:54:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 51BB48D0098 for ; Mon, 2 Sep 2024 05:54:10 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id EA4ED161C0B for ; Mon, 2 Sep 2024 09:54:09 +0000 (UTC) X-FDA: 82519337418.19.2BDDC9B Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) by imf10.hostedemail.com (Postfix) with ESMTP id 1AC34C000D for ; Mon, 2 Sep 2024 09:54:07 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=CkNLDlH4; spf=pass (imf10.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725270825; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9/nHM/VVP4A0TXNpwjoUe9SG01QPiNcoM3DvPaMwq+A=; b=F+PRc6eI8XGlEwF0hPT/FSgEt9OKbyEJrC5jAFUpQvUOLSj9OdUm8yctKtvaUcpI+EUg8/ 1MP5KumWjrOFwDkxfTpjeU4oPTunT3M/nGIyVGLA89nEecLsvGT8D+FB6xi0y6J09P8cEP X5/4cgHdIcq2+KIL5LsSxhCkE3DGR5E= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=CkNLDlH4; spf=pass (imf10.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725270825; a=rsa-sha256; cv=none; b=Cw62PjlghJsUUnPRRdlVSez2MU35wMUmuMMMEHgjLSOwkI3QTf5t2RH5RfXIXgfzkly6jp iy8JcS/nLABsEXplX8g+OQ6+PoEBR7otIfX6kH2gamtAEvQuxn++Fs+D3AjMTnCq8Y/xJX mxsxmiiB2RS+uiLQyV2smyDMV4pkBzU= Date: Mon, 2 Sep 2024 05:53:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1725270845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9/nHM/VVP4A0TXNpwjoUe9SG01QPiNcoM3DvPaMwq+A=; b=CkNLDlH4YmUt7qngTBEDKimfB5JnCJrNXlLgkCcW0RzLdZQ+5s0GAqAwtbBp6P4Lg4C2JM +8wmwvdryLnMgmCqryPH+iAjeoKRxbv/Y8WKwKq5qyZRWLuw9i3Sv/WH2E1zUsIy7pH5z5 4KggrwyIykguR/mvUoaLICLzI5vrDlg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Michal Hocko Cc: Andrew Morton , Christoph Hellwig , Yafang Shao , jack@suse.cz, Vlastimil Babka , Dave Chinner , Christian Brauner , Alexander Viro , Paul Moore , James Morris , "Serge E. Hallyn" , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-bcachefs@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2 v2] remove PF_MEMALLOC_NORECLAIM Message-ID: References: <20240902095203.1559361-1-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240902095203.1559361-1-mhocko@kernel.org> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: dx8xf6m9h7ickdygwdfngikjejopjj9x X-Rspamd-Queue-Id: 1AC34C000D X-Rspamd-Server: rspam11 X-HE-Tag: 1725270847-152825 X-HE-Meta: U2FsdGVkX1/EnWOMh7nWRt2wFkh9XefdN2KcSbVLiCVMNHJTScXBTjO3GB9t5lkuoiVukHvssFonjGAnWHsW0oU12S7yICEpBTSxPBWqJ3CYS5Kd7PfhQyFG0P9rjEk03CPnQ3GCTwTCcfZ/+E28qa4ADylSalgL6H7fnZ0IlevOjb5bx0ujrzrSyjp0jW13B8JK6TPzFKe7hjC86kl2xCmq0pu/+UAEdbK4ZhScXcvue89u30+FEB4CcEWEtS/VJR45ktTvrQi/bjkJeckdQ7WmCLulIIZTeDyuLiGFh7e+2BpcesmzvlUO4sUOHZbYBlo8S7urY9iJO14BI0xLyn5wlgEfGZsYeln+6Co3COo3c0ax4odv+JSlPQK0+YcKRtZcbdC4ii7P3b+ldBsH5QqFrjbvwIchcQk7EKHMTG9h7sJ8hesBHr/CXyJllyJ6LCX18ypziz/8Jh7rUJbD3jJ//mFqB8nVJh7kLIrSB5GQelt0clNQ0k06yY4O2E2Nqnw8Cu0MdUNyewzoxZq2ZEApBAujXirGZ4VR9+1S5wdZ2/GOT1+eQSToaIu66TNRF/2Yu/XW+yK5l8l733XZzCe223rUO+ae+LEU3AyTLzExv+3GvDB7N/Lnqj70HTsPDFi3oMjV8+4oPtmKcYNOnwrBKxfURUT81CgMVxBjRNB1/n5kExsm/haOcDvuc+pRSRwASRlfUpHPVrV8YhJ9Xt6dMQRMfvuLq3Py4gQQ5Pp85nAVGg5K3R/+xWGSSpDYpwlueph30to+1UR5wkL4VoL83GDWkLmv0RSXxMygYiHFm73vnrw5QKFaQlI2N0ajk0IuGqiHFJiOwXlrL9aeaLh+g2hVxRDLwivoxRw6kCiuGVKDM8XDOjvYuI0Tem9uQNe9EEDamEWtA6phNfwVvlbtgdMaEKWPcCB+pnp3vi4TgGKBI997cbyNlUWNPgLuExIRlqiAtV3rEIDfgrh SfX36wxr Z/sa6YHKE46WHng/Q8XwBXnraPlOPzHcQbLJT2yUV41ckTylV6JfP4DQtO62GVBjWgEL5pCMlo7E+wX0YWq38x8TVQu+rPGg2nkaC2R3LxwtlGxiCrsRvsYL+yQRRxC6NeynPdIGqZYTmrujAzvSrCe/tfxyL2y5UHlNXCzUMc3MNhYN2b5iLDsDg1pEZpfdVZZXd1nZKoGFqYj7A2ehHLqwPV3l44nMPI1a/OaF/MBJgM3QFpwWlEDZltv9id4g/+SKZJwQs4ejKTiM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 02, 2024 at 11:51:48AM GMT, Michal Hocko wrote: > The previous version has been posted in [1]. Based on the review feedback > I have sent v2 of patches in the same threat but it seems that the > review has mostly settled on these patches. There is still an open > discussion on whether having a NORECLAIM allocator semantic (compare to > atomic) is worthwhile or how to deal with broken GFP_NOFAIL users but > those are not really relevant to this particular patchset as it 1) > doesn't aim to implement either of the two and 2) it aims at spreading > PF_MEMALLOC_NORECLAIM use while it doesn't have a properly defined > semantic now that it is not widely used and much harder to fix. > > I have collected Reviewed-bys and reposting here. These patches are > touching bcachefs, VFS and core MM so I am not sure which tree to merge > this through but I guess going through Andrew makes the most sense. > > Changes since v1; > - compile fixes > - rather than dropping PF_MEMALLOC_NORECLAIM alone reverted eab0af905bfc > ("mm: introduce PF_MEMALLOC_NORECLAIM, PF_MEMALLOC_NOWARN") suggested > by Matthew. To reiterate: This is a trainwreck of bad ideas. Nack.