From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3984E77184 for ; Thu, 19 Dec 2024 16:40:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 634A06B0083; Thu, 19 Dec 2024 11:40:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E4F86B0085; Thu, 19 Dec 2024 11:40:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AC8A6B0088; Thu, 19 Dec 2024 11:40:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2DED86B0083 for ; Thu, 19 Dec 2024 11:40:53 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D2294A181A for ; Thu, 19 Dec 2024 16:40:52 +0000 (UTC) X-FDA: 82912272114.11.054150B Received: from out-180.mta0.migadu.com (out-180.mta0.migadu.com [91.218.175.180]) by imf09.hostedemail.com (Postfix) with ESMTP id 4FF25140011 for ; Thu, 19 Dec 2024 16:40:28 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=OztNAEf4; spf=pass (imf09.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.180 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734626426; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wWPJuiiJybDd1Rz94btJfDZ/lmxqC2aRO87v8CIWY9o=; b=4ZTfBe6WDhTwUv4D9q5wOFKMszS+6v8WTtOKRpTc5WOG/Nej+1cNPfeddonsUwO9I49ijv fW9wien+316MCGqIUXOU/4kxrpY7sxxsR+5WBBG1TY8/Irc/ol3XLRqQCdzKEzoOrNIqSX DIlNfZbgGX8MhIA8O/o4kZ+b4qVagGA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=OztNAEf4; spf=pass (imf09.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.180 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734626426; a=rsa-sha256; cv=none; b=Vy+1g9lzQ+0BcRsaaLrQjU8SUfpFK3Mq0xrt/wjg7A/ZMBOqt2FqNm6gmVaQjdGtDDdG99 79Y4QtSuxN7zAn4PiUdplgkoA3+o14tilVm8paXhmYgFbV9CU4PWzBswx33p3knzPUv7TR l4OdVmxmjmE3RG0j18HqbWIZoYJmv8E= Date: Thu, 19 Dec 2024 08:40:43 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1734626449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wWPJuiiJybDd1Rz94btJfDZ/lmxqC2aRO87v8CIWY9o=; b=OztNAEf4VQcRYqQ8PjONb0fiIA+KLKq1ajAKT58JAgzQlRbVHeNd5LBYRabfA1K7ZHHsk5 HG7Zug/9UNJ6vlR+8JiRtBembrH6i6Rq2F3Rm+R7ZRZ8ZC+AhKSwBkMAWYE25AM6/JEetb RyKjyH73LrAq5RSUFXIBvm+jFnlaun8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: David Hildenbrand Cc: Zi Yan , Joanne Koong , miklos@szeredi.hu, linux-fsdevel@vger.kernel.org, jefflexu@linux.alibaba.com, josef@toxicpanda.com, bernd.schubert@fastmail.fm, linux-mm@kvack.org, kernel-team@meta.com, Matthew Wilcox , Oscar Salvador , Michal Hocko Subject: Re: [PATCH v6 4/5] mm/migrate: skip migrating folios under writeback with AS_WRITEBACK_INDETERMINATE mappings Message-ID: References: <20241122232359.429647-1-joannelkoong@gmail.com> <20241122232359.429647-5-joannelkoong@gmail.com> <43e13556-18a4-4250-b4fe-7ab736ceba7d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <43e13556-18a4-4250-b4fe-7ab736ceba7d@redhat.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 4FF25140011 X-Rspamd-Server: rspam12 X-Stat-Signature: 7bnhzfz5mgs3drnakafzsg9oontjpcwk X-Rspam-User: X-HE-Tag: 1734626428-595989 X-HE-Meta: U2FsdGVkX19MrPrIIjqsMsTj2a/bONstUBDya0Q+/btb81Jnn3uyh1k4VLHd8FJEQeC4TYNLTsvYA4wW+oC++EkwD4Q/5vQ2Ia5mApEMWal85nkcPLiWHzP0QvR4Z7nzQgk8FO7Tm1jTKZD0OuFfwTJ0um64a2cNL8XdKq5svY688owrTQmc/P96xTYHATB1m0yre320q4az856pjOq2xRZmhfxsIr2FguBpK5R6d3JFbKC7KaZWGFxaTNhHNeh8qs97NModea5dgbOgR1Pl5tAvs3+rmM36JQpwY1qUQ+dshEgjP6hdWPKGscNeB/TFeplqy/Oj+dYl/zoBvEwioqW1KHG5aa81I25a4Cn1rXbOQvQFPhXtiPIfXE5k/N9C5XlSOJyA0wa9YY6vd/Zc29Cg8oyyt1GwP1SClTj+yUwWywQt0t44CWYONB44MLgsRx3a6Q7nImXepi9hs1mutxF8FPTAVcNL7BUsMRMibWnF181/BAo1YgNq2zFjTFtsi5DKx7DiUTNXsrCVXfj7904mPZKCFzhxpg1updFosJGe8ghLBoyiuZLY4UeZu5mdaVrQq2Hxi2LlZXw9hnSE5Q94E9Jqz2nr+IC4NalWxGTcieYHZol96IYjO1fGcqHKX3d12uXEsozf+cjullFYcv2Zs4ZYLdUHpefDcEfTYK6zyb1v138VPsAANRsMYCl1ZRsrnmsCagZ5fQnmaP76u8DXPNL/6pkvogp8V8hrfwsdY9YdjJ6RVrTS/6kkEq6QwJM/K7QE62jbI0TxxI+QO4driOFwg65K5EDP4jLiAIkfnoo8H1yAzp/Y8oXaOXZS+goK/M68BfEZtwUYbwER3btK+5PoNgtWLaRCd26mBTcQoUbFaotfsqYbPZcOC4cTDxTpt03wL2BJI/bRxQYF76gUwS2N8VLdBcz9W2zr+/K3luJqJOUV1e8G62EdlFTE2X11qyTgS/AGBK8VAII XVGi2hrz gdfT5kYqSUll7A9glv18RZL/pmr+wegA0M0OgiThwCRwR2jTWTkHECHUYKAzGP8kkYPG5a8SDt8Hw8cJqVnpgO9DfwdgzO8s2CYpq7QU+TB6a7Y5KB6Hsmi2m3WQi2eEnJt3E6n9QCPguiTZary4PeCiNKezVtJaTCp3TGHCw+BWij84wHlSakrj4JPsX04CH45Sb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 19, 2024 at 05:29:08PM +0100, David Hildenbrand wrote: [...] > > > > If you check the code just above this patch, this > > mapping_writeback_indeterminate() check only happen for pages under > > writeback which is a temp state. Anyways, fuse folios should not be > > unmovable for their lifetime but only while under writeback which is > > same for all fs. > > But there, writeback is expected to be a temporary thing, not possibly: > "AS_WRITEBACK_INDETERMINATE", that is a BIG difference. > > I'll have to NACK anything that violates ZONE_MOVABLE / ALLOC_CMA > guarantees, and unfortunately, it sounds like this is the case here, unless > I am missing something important. > It might just be the name "AS_WRITEBACK_INDETERMINATE" is causing the confusion. The writeback state is not indefinite. A proper fuse fs, like anyother fs, should handle writeback pages appropriately. These additional checks and skips are for (I think) untrusted fuse servers. Personally I think waiting indefinitely on writeback, particularly for sync compaction, should be fine but fuse maintainers want to avoid scenarios where an untrusted fuse server can force such stalls in other jobs. Yes, this will not solve the untrusted fuse server causing fragmentation issue but that is the risk of running untrusted fuse server, IMHO.