From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8978C83F34 for ; Thu, 17 Jul 2025 22:17:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 64EC28D0002; Thu, 17 Jul 2025 18:17:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 625D08D0001; Thu, 17 Jul 2025 18:17:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 562F28D0002; Thu, 17 Jul 2025 18:17:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 461058D0001 for ; Thu, 17 Jul 2025 18:17:22 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EA38012D218 for ; Thu, 17 Jul 2025 22:17:21 +0000 (UTC) X-FDA: 83675168682.30.3539FF9 Received: from out-181.mta0.migadu.com (out-181.mta0.migadu.com [91.218.175.181]) by imf26.hostedemail.com (Postfix) with ESMTP id D0D9A140004 for ; Thu, 17 Jul 2025 22:17:17 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=i172STiy; spf=pass (imf26.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.181 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752790639; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ByQdKtZyzhaIQ24Myi/U0d7Rpd2vwY+O9UsiHyxh+bo=; b=1/jgUtQ/YYNRP95bU0hIRpqtoz8AWI8E0t8DyRTXC8pCKyIkup3hRhv3xkJ2hEwdnWxhsS +r0k/l6cyus+KXs7vZdhHmMaruKhu5oO6vzhxtBXYxhk5MRjrb9kmm4glxxs566gG5SZPL CGJ2pNYDTPduuhgabzjJcyoYsMyWAjU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752790639; a=rsa-sha256; cv=none; b=4OVOUNDzzCmVJ6OtzHgnz//SFrV3nc1ZpiQVfVZ/Ee0xyufhNjLf33QSR/h4xnJvpLDIzn UXybFfxm3Z3zE6OlXN71HAYFWOevhHV6XE9qSROdBBS8RY23YeE1ljOOjqc8ROvWJsFTFo AP4x2TXtPdYWFRTBvaWmq9ouRwSwiXw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=i172STiy; spf=pass (imf26.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.181 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Thu, 17 Jul 2025 15:17:09 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1752790634; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ByQdKtZyzhaIQ24Myi/U0d7Rpd2vwY+O9UsiHyxh+bo=; b=i172STiygyv8IcHD0OtVefvqlgsMSu/5vnXyNdWKCRFm73a8u27QWiMOKI+VMNZsiEbF4T RcJdDsEUxuQtAEgpV/Tnb40xNr8BeDBsXch7q2FxUun2q0FCbLj3QlSBWRUQJOIqaPyPce ffxXcYJW8hou6q5aSCwQRBxlbIyxjw0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Davidlohr Bueso Cc: akpm@linux-foundation.org, mhocko@kernel.org, hannes@cmpxchg.org, roman.gushchin@linux.dev, yosryahmed@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] mm/memcg: make memory.reclaim interface generic Message-ID: References: <20250623185851.830632-1-dave@stgolabs.net> <20250623185851.830632-3-dave@stgolabs.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250623185851.830632-3-dave@stgolabs.net> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: D0D9A140004 X-Rspam-User: X-Rspamd-Server: rspam09 X-Stat-Signature: aokgh4enskn4pod6kwfs3xerwcusyt9f X-HE-Tag: 1752790637-249281 X-HE-Meta: U2FsdGVkX182W6VFocfU7ZGM5VE4t2nUL4YIPN4JrE/dhHA4ab6K/quJCYKu12nlJGOo/+4KiCaLF4z3IsJVmhCmaBsLHqjIHSsNON3Gt1sL4JkRlFfjGFu/BQ/WE7A4r4w9Y05lQFh9vPkNniz3nQ5AUainKs1XtFiIwo2zGmGwqEUMbxv5Oa1QMXZkuNS4ykgjHdOFypoXXBiCZyqYar7kYWvgg7M6lrcMnqnMB4u+s9w/u+4YB63c1S1A7Le00YF1o599V3qsKIszEuGwkskHvh1uWDXo4UNBh5XpcsYsppab2C/UfW7ar/Y3NMKZ08yCW9OdHVaSxoaPPKRBTwo9gIYWOIpMd611npAzuYyiKQQCE2eFCfHDSJzfVlE+jP95CVFhgLgMKZmspgI8TNXX7fSPeJGsjDGq3i4a1IAxqkZ92TcZ1eENBmvrfNu9oD7VXzZ40gF+bStRFxbOikYe74FUlwAW+17tdNX0B+m699v8dEr4ld0JZzBjev4SpPOTVmu4F1w3zaQPkhVdhzpjxiPIOX4Fz2uhDLBHd8vdYob17r3Qy08vTHPds1Jip3I5o3z1ks20KC0TNwH4j7hKs2YGoBJciiGcgQ9VeT7sinYUEQSu8PXbYBiLh1ENWwDz42ExpdE3G3996glwZ3aKg3evQfdp8dLweP0G4qDrJv1hFV504AOMkl9HeOPL2ZdT+A9PqkdNbQVS5QoQux3iPBPIKV1415CZ7KZSUicgHInGZxEBJohMU3eq2emnSoMV0MHyTIvb1YftucJ4LJO+Dg5Np6jHJMFmXeOu8NSxe7nf3+hQlX5+WNi5lBZrL0g8rpNrgoZadJ4qeAdwhJpfBntXM4ywsYHWnQN5Zevme38hjl+HWQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 23, 2025 at 11:58:49AM -0700, Davidlohr Bueso wrote: > + > +int user_proactive_reclaim(char *buf, struct mem_cgroup *memcg, pg_data_t *pgdat) > +{ > + unsigned int nr_retries = MAX_RECLAIM_RETRIES; > + unsigned long nr_to_reclaim, nr_reclaimed = 0; > + int swappiness = -1; > + char *old_buf, *start; > + substring_t args[MAX_OPT_ARGS]; > + > + if (!buf || (!memcg && !pgdat)) I don't think this series is adding a use-case where both memcg and pgdat are non-NULL, so let's error out on that as well.