From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91F8ACD37AA for ; Tue, 3 Sep 2024 19:53:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EADE58D01D9; Tue, 3 Sep 2024 15:53:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E5E1A8D016E; Tue, 3 Sep 2024 15:53:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C89318D01D9; Tue, 3 Sep 2024 15:53:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A71258D016E for ; Tue, 3 Sep 2024 15:53:55 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 40777403B5 for ; Tue, 3 Sep 2024 19:53:55 +0000 (UTC) X-FDA: 82524477630.08.9C2403A Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf04.hostedemail.com (Postfix) with ESMTP id A9B324001D for ; Tue, 3 Sep 2024 19:53:51 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=cnwlwLuV; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Uf56RUAH; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf04.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1725393161; a=rsa-sha256; cv=pass; b=h6mpMWjv5bl3KijL1B6MW7mFrS3GhgPgrrW/U7JXRAfVLdX9yYHint7HI5e7xfLEWtEYL7 CabWJ8NmSDXoysO8YXCQWePRGUkE+nf4zif8hXkZFPOyA+ud//Q1a+BE3ZAs0qAJ59D4eL NBzrtJP786XPK7kxqFcxLYOL59LFwNE= ARC-Authentication-Results: i=2; imf04.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=cnwlwLuV; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Uf56RUAH; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf04.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725393161; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=50rWvrp+90UwEqABhht4MrwtvagX7Hz1yGRpVqFwURc=; b=Gt72TZJnNDniA3compwQSdNrgsnIDIjFG7MW96iUDfoMEUO8h6SEtkKoX8am0gv4aTOlCn QE5ZwSicAipHNoB6oHQ3E9X9fEPgZdjM0O89oiSNL2jTNZYCuni3hhNhKjw10HGmHfSJoF KLtqrFACbEp8qLLmlgvrkJARjbxyM+8= Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 483JXUMn025995; Tue, 3 Sep 2024 19:53:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= date:from:to:cc:subject:message-id:references:content-type :in-reply-to:mime-version; s=corp-2023-11-20; bh=50rWvrp+90UwEqA Bhht4MrwtvagX7Hz1yGRpVqFwURc=; b=cnwlwLuVj6nyPSlY2NR+HEEQIFeFAM/ Xv6m0vQM3ck/ZqY9c5zP9R+SFNZZRmbxEAJV/iFNazQ3HE7agJ/ZHzNQVpCA5kZL emVpQVvVaNEhnKZcyGxyYZvkkhq+QaMM/MyGeoXmSTYkeh0BfF8Y79P4u7+oxGtD Xxm9IC8lqLUpQcaKFO/B1N7iqoRlD1tob0jXC0WvyOtuNBm0fj73k2c1yboNItOJ bmCoe8p9g/eYgzD/YfIVye2wm/DwKvRuodBcOV1ZVXTVeg25vRB/OB6caIea+pdj L3RrBnMd5TapB0cKsmYluronP8JdqYyasMx/Wo+MwgP8TjmcI/BUoHA== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 41duyj1vx0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 Sep 2024 19:53:49 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 483JRofY032727; Tue, 3 Sep 2024 19:53:48 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2175.outbound.protection.outlook.com [104.47.58.175]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 41bsm9cbxh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 Sep 2024 19:53:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TT3w0DFnAEstvRC3sc4tu3DBTYzKaCIzQYckY8dY7Uwj/38BLoDoij9ppw7h1YHiUJ1A7IdNWXqKJi6s8gufGSzLaOZmc27il3ateAqbycrvn5dRaB/3trVM9E4CcAg9xVtRF7bbdS1WpJCgf8koJE0wPNN5ycsaQ8mx/o3Jyz2/BQ/gE1DEm7+yeN9+h4WZEED5Q0jwYcnU87lsemG1J+9Vzg3V2qUmv4gK/5P9X7O23HupVeA1aRtRhBiJKqB1kZYcX6Nb3bkBeSjdjroGoPVp1vmSqk/n/udxMH766uigmfdwsWPjudHu2wkfbiz4034Rpr14N49fc5Yhktd0rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=50rWvrp+90UwEqABhht4MrwtvagX7Hz1yGRpVqFwURc=; b=D1MttWMwQL8DOXQ1GZHZfR0IPiwc4WlDYJvRMQ1Zij8nkaWZBcAD6LDMl/ZkT5QzxP3dSY4FRlkFultr6lrhPIm6RUR0z1SYf4gg81VzhLJIyFfmTG+Xne6oA9SGBai9zGgmhUZoq49SFxg/oD7C8oYKdtp2a9yKaFPd7h/fUQ6xX+aw4aZLDjx+ZQsaeHm2RzM1lt7wpsgSHOyu7gTZi2FZbCyOUXv02h0PByHo1JVjw4NpB0yRCNCXAsKMaHJNBN1SkWpriEx6svUMae+0NepG1vkNRMvEqE3LKM1AnaFiTSlXvwE5cQ+RJmUA6YhYvJ6y5zWajKF3mMokj8wSLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=50rWvrp+90UwEqABhht4MrwtvagX7Hz1yGRpVqFwURc=; b=Uf56RUAHPf4d0+ZAOgJNR0FL1tPUCCO2KbWMd+m5QCY02Q/Jlu+u8mJIQyIG80pnJfI9QPGyXSGO7O3vpVjZDqcvsbKtuVkO2OGH0fdr/oL47TlWqdsbqziGrA0kpwhMtOh2gwhTMao+T4PT4GYGFeiU1iBarBi1l8v/JK1tsNk= Received: from LV8PR10MB7943.namprd10.prod.outlook.com (2603:10b6:408:1f9::22) by CY8PR10MB6633.namprd10.prod.outlook.com (2603:10b6:930:57::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.24; Tue, 3 Sep 2024 19:53:44 +0000 Received: from LV8PR10MB7943.namprd10.prod.outlook.com ([fe80::a8ec:6b6b:e1a:782d]) by LV8PR10MB7943.namprd10.prod.outlook.com ([fe80::a8ec:6b6b:e1a:782d%7]) with mapi id 15.20.7918.020; Tue, 3 Sep 2024 19:53:44 +0000 Date: Tue, 3 Sep 2024 15:53:42 -0400 From: "Liam R. Howlett" To: Wei Yang Cc: akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v3] maple_tree: cleanup function descriptions Message-ID: Mail-Followup-To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org References: <20240830220400.2007-1-richard.weiyang@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240830220400.2007-1-richard.weiyang@gmail.com> User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT1PR01CA0087.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:2d::26) To LV8PR10MB7943.namprd10.prod.outlook.com (2603:10b6:408:1f9::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR10MB7943:EE_|CY8PR10MB6633:EE_ X-MS-Office365-Filtering-Correlation-Id: b8cc1d67-0172-41eb-ed6c-08dccc521e3c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?fnjCOJKfEZy076VSO1cRudNwdDvXsPuxJ3ksYcGPVCKYLDQAvPsf2Pk1qIyG?= =?us-ascii?Q?lUj5fr67k8HdH8oaV6k7Hcp/EsAWrh/Txm5zik1Lbbs3sseUva7JBzfib45p?= =?us-ascii?Q?FydxkhsWPD59iBfDZ3IiXVdMqTTEfIP29Dotu2/gcHBfQnzZQ4Vfg8wQryjY?= =?us-ascii?Q?jY6v2X+W0DzUhefX5GbdvxPCb73KJRKG3CvpC2grBGnsf0CSZLIqCMX1mE1H?= =?us-ascii?Q?RhfaarOPPHm+kn/3gQAIc+MIlbvMi8Ofqn8JsxQff/q3AsGwSz5BcGjWQe3Y?= =?us-ascii?Q?c9Bnz1vAhurbH+xd2jQhanWxVVBnX9+Pnl3Gq3mxBmzpCo8TeYiPfmxH0K4t?= =?us-ascii?Q?TLEKWinBSCvRNgXYfBRbZZdfe24pQK+dHf39Dwg4pWWri8ATycmcGPcRM4E0?= =?us-ascii?Q?3JPwnwoshvT9UZeN/i1fd6wJHHAGDqRy/FpTfO13/VvPjDShfqpHHFg3cTs7?= =?us-ascii?Q?hgOI5ToXBllvhz2KqMbMOfBff5l2MyB/wZbNY0LfdpP3qnZP5RgyON6pO81A?= =?us-ascii?Q?tTCWUJ4FgyGMXuMwRsm6qJ0SQEY4qOvcP0hvoo31E4t2YsqhkpYHw+B9/gQZ?= =?us-ascii?Q?guLzr46ygrzYaLMztGX16B2gNoCZuqXnaDkGSb6DnEgFEBAPT3buqGqngIjk?= =?us-ascii?Q?Sc5qns3nn6w4MKBxgSK1RMpsOizZYPtuLr62biQLSlbie6/bgcCtMhrwqZom?= =?us-ascii?Q?ZQCVOZA5fzuD7JgdRa6jYdTfEpqfBrMnDSUfdiUFm+1NqkQCF5oKLjx4HT56?= =?us-ascii?Q?Yk8B+0Z6enD7+Im6yVTLhoWh4yZG7a5ntxAwMYzqbKdXvGEGrj/R/nG+WIXR?= =?us-ascii?Q?ewVtT7zkmVeFmjFtgiGLB2pvmJixi//wmwiB3pxegzegex2ohlvbzYcMrL2h?= =?us-ascii?Q?QziKe1Wd/OeMZppncBrPKyPFLInyUFPdNko1CiVfx95nqS1WqvCifzx69++j?= =?us-ascii?Q?AbVfA5kKsC73gnp7y+239kxqaS5Y+yEeufwJbM+OL9uKFKpzNsXvP5eayhZX?= =?us-ascii?Q?6sbOBJwQK4AFH68kzstfJSyeBCr9zbkJNz7i23OJXDlgT/u1uIXW0Aaj1FVN?= =?us-ascii?Q?nlkaypkAXEC4zzs/HUG5rkRQzbMgRDIOkp2y7cPzm6IDRHFwzp95btn2JCtX?= =?us-ascii?Q?9dXPd2sYny7XZR4FYbJeI1/oW9lQwMqUSd7tYjxntYK4+CWfPureERI1bmha?= =?us-ascii?Q?O4i9Gv3MleihZhdbGwzyR1FK0RG+M9uUDVf3222DxIXyUDLBNVHkRsKBWlwF?= =?us-ascii?Q?Rn5z/SCmt+tGqfYRZh2MHXRN+WSsNxCMhDxNc908eVUybW7VLzPoaDyUW+T5?= =?us-ascii?Q?x2qx4NWTiqhnGOl6FjWSq1+efDgPx08Bks76WoLFvAA1gQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR10MB7943.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AFDMlvazZeW/aD6+PDphM1z4DDk+IXdylggGWFIgWFh5u8jdsrETpXu4opad?= =?us-ascii?Q?W5ESHhpbVvSVvIRv8yDBbmEcMt8Oj5mciGUO8ivWPoFaaMXPPDTw5Bl+GDJU?= =?us-ascii?Q?L8N2n+kmN8GeKIAFyQyggdEhJJdKrNlcLkHd25zTmCx9MRZfIln/+ZJqc44u?= =?us-ascii?Q?T1GVlbkew/9lYge2uXADtov+lmS5ZrhfLc9aS1qy0TkHZA/5fOg9xb6cUcrS?= =?us-ascii?Q?xnb7/mXD60U64AqYvcji7SL4bA+vIT8xzTIHdTRqoGI9MEj9UjhE3u+J5Ixv?= =?us-ascii?Q?HVhIB1XstlJ310LBCYLxlQqMwT7CJ073tANTLW1D2zbn05S2kZl9NnQEMEd2?= =?us-ascii?Q?GtiipSmKpgkJqKGzKVkdVjcVYiVsFsfsanmdxsD7lLgr+px6iP/+BO3qw6yY?= =?us-ascii?Q?CJfPPAa21HlNkUd2iyTflb8JrVrqjiV2PWxD8UHyQnh8eRwzsABlNbonnDWP?= =?us-ascii?Q?Ub7MLNC/HqYqWQy1SnvvcEghYPfH7EEAhZu0FicaRkojCfH5/a1OBVHtp7dB?= =?us-ascii?Q?LSDNljC8tb3ijJEEJTP+7o7f3UaFOFPcJGP9jJASZUYFDkhOmdB6lVCpgPj3?= =?us-ascii?Q?BMl7QL1vBsg+rOE45IwYKLjgBbPvELhUb4K2FSv5AvsNdxIa+NS+fAixl4e4?= =?us-ascii?Q?nlPdiqVnpPhZ5ABVTFZ8yzKd8Prdzh4N6r/zTnHtEkk1bodWRkOhC2LpE/mX?= =?us-ascii?Q?MacbeFsoO2RLGOkqk1IX9FVk2G7qImVxzy0DKK9tzBuDZgKtu3pwcwtJx09C?= =?us-ascii?Q?M/8N/EkOcyNxLZ3a8YteEKevUKsDxkUbtzqYuSPvMrWHvGkyA5UxUOT8Xvjv?= =?us-ascii?Q?EnpyYFYaE9Q70+3afUb9Y5yLrTwGzbPhS5+lh3e0QPme8tBxA7QIy+SIVVM3?= =?us-ascii?Q?LhiX6d12slZigkB5OgG3g/n3JBP4dkpM1R35nlOozlq8dXHsuEp8SJoi3NGd?= =?us-ascii?Q?deh6YW0V/DOD+zRnTKe/ik94S5fKzmaQBamBsoS98zqjd7W6a/KspNc8S9x9?= =?us-ascii?Q?4m4vUjkH2zDJULqEM6IODxC/wr6jsztk3dHHbmTtE5zCdGqDgYIAfvS4f4kd?= =?us-ascii?Q?gCTZek2IeWifsp3IT0380an3vGPCxVYa0fBidHvD0S7n60FMDI0lnZkNwps2?= =?us-ascii?Q?NXqP1tEqOpvLJRElOsB2DCPlSr+mSzbd6A7dTRpagyhZCocJlBgtYO0hu5i8?= =?us-ascii?Q?Bni9c/hdVqG9/PQkSQyBjjrZ61g3HDPReYjPkGugbf2i+p/VxyDNYhSD4kPm?= =?us-ascii?Q?PZeWOtLmLnExkM1GpkLDP+IuLyIvJC+4xCAWG9dcO7x0Y45cVVT7tPpX1/Un?= =?us-ascii?Q?XE0HUBokDOcksXnwfLkqk/1wU/oTBKSfXxh1v+2bacU7mW7bA1qjsqfXYw7H?= =?us-ascii?Q?8Glc/3xVFOPPxJezw8jJtkp8oG36gzfz+QnlL11M/cJ64/VCQEZufmsOZIpV?= =?us-ascii?Q?PJrB47OPNLfF0hj7vV/lDWK/JqK9MCbd1lKEYVx9xHomodwiM742bTBIiM7D?= =?us-ascii?Q?LXbaEN4oPh48m7BVWDNLGE2uCDTbiGVyYYpXHXFbJYRL7bPprzo2+FG31ium?= =?us-ascii?Q?xp7EBzozNiuswVkGP7FF/XDte20tyRaYPC9DPDdi?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Nvv76tj0k9acitikzUnw9dtdTSZ2hB+hdMcfleiWuHTog28Es6EQPqYY6j+59/pD5/cZkYANiwlR7AfbYm2/2pkfqo1q8Jpjx9bOCbMq0uROPlJaw3/xvd1pdiKnN2ih0MsaSNUkQb3R/O4Mew6ndN/7BRqn9wNIaeZ1VMuir99CQy/x76RfTq1iMKjvD+nWLwk7MiiLZfgYWW4ACmRNa763EouEw/y3Mfs17g1IbwAWmhriT3rcpA/MzJVf50OiJzebE487bnTY/WiGbtmY6sgxJDWhA1M2s33izMcGwtcmWJj0Ltx7GD13iw5IhWilAAcw+XHV1Tj+wTlec7IoD32DqPrmrrlZZhdCsvF6qpCPGGIa3N014CaHstGXf1e+AXV6vaXZC3pR4gWBZG8YkmdRgcK13DVZLB4w/WQ31KwsoAGLkn3EyXAfZOkq4uiOYoMKiYi1BHQJOKfLUe4nBrU8QU+hUi1TFvuXjlS5frlZ9UjCSAeEEMsYPRfH7V+GorEcfYOhHs6YcQEMSFN5OY+kcTwY+9/3EahpQd5zSSNHo3dr7QFIlWnDwsZDeaxRIEJqHkXICYrs6QXfzOh2xt7/raK1ud3r5n2E5BfxxYc= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8cc1d67-0172-41eb-ed6c-08dccc521e3c X-MS-Exchange-CrossTenant-AuthSource: LV8PR10MB7943.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2024 19:53:44.8161 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dehDYXYksHgEbKJoyruqEfVGmAs5HNd74Y3q+wMKHwzn3T7esJKZlnlFjqoOEPxrwvFJ6HqTDk/eo72BaMFQbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6633 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-03_07,2024-09-03_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 phishscore=0 mlxscore=0 bulkscore=0 adultscore=0 malwarescore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2407110000 definitions=main-2409030160 X-Proofpoint-GUID: FAiHXan5trYvwAznW9R2QLa9_Yt6Io_N X-Proofpoint-ORIG-GUID: FAiHXan5trYvwAznW9R2QLa9_Yt6Io_N X-Rspamd-Queue-Id: A9B324001D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: f6e84gpr5gr45f9q6wercxm4kj4aco3r X-HE-Tag: 1725393231-719884 X-HE-Meta: U2FsdGVkX19S7IYua2y6s118pxuPyQuIenjiI5OWB95opxf6bBmBcBOijygzvROI9WAD6aYH12pVA3NrkqPBva6f0PpoqdTcpKY2XpRvRO8zqf5jFKpyypvoIHWxW+hi+KlwUebo715gRnliNN7aeF0ndzMaUFj07f8ZickuFnIZww9G2Wrx9euSTnP07nvLos3bu80RyUwHidbgwLs3OnzF6g3JfLlMfEC5HmEvfiDJSylHRvnycCnR+N32fmv6VB6QOX0CgGVP1xag/0m5V2SuzpY+IbjKUmcv9oZZybrnup5pt02WjIbGRHngF8ZQDkyHoBbi+TG6YCOu8rM1TfZHfrT8SpdesKZRMQtDDm/ytLBv9hUpcAe2hQYzwDLWpjItylbw57lBFw864YIRcrWq6ilCprg814YNaOohQlssfRxLu/GCbrkealncbjipIz57tIs7KP2pw5p3xedi0573TmxS0t7tfSFNgfLQ94fCZ+dzzvvRqAzXuyNlYcb1G4M2ozSrsDdLMdI+4/X6D1F1IEra6EPSPJnzMm9vCYpivSKQjqU+DV1TNJHqbDHXGroHhylyt3N3rjA4JCL4ixSnxf3brqiVfVCJC4KcHLLT2+2sPsNfF3g+a9xwKeL+PspaCvt8VVeSyROITegH5QerGvv/Ykhdy6l7O5pLHWv8v7svYHb3XBoI2JEdkgoeG///4N3MOI28sBzWTDc4ISEF9+ERhMxOKKQBBTqN5uERGe7cYJq1P9lJi9Gr+9nZvX53Z9OVuwrCrI615rl63D99iqNDFmv4mRsT6ymivqoWyrAppRHO5LqAEe10qfR1tmEbn9pbGw9JshRfauvm5qmntn1UFmxjHDwfV4IbpPDElxYXYSTaMmEhCz36s4kQDOZBOgD3E9SCzAZTnvf+1QntMADiAVexNrDXUWLgalvCb62GQp7C3AoZ89XG2VqhpQfi2y2wXg4tsGlXHhB cMNzMfXY LNvS3y/fkDF+ukAoSq6rGj+OIuB8yavmR1FNQMF/4conmYw+u/STnxPEtOxCsN6Mpm9bHi8lyYUnunjpAjMAKXXjrX9a7/76lO0zlgKZuT0hz3vLf2h7sPykqLSNqu6FuWghqxSNr/V7uHYFIUjqHlV7wmBiv5EG9W1E0F8t6ttYApvxR40HrfINI8/cNzYFAcpIAsD+ThSm5eSJhAcMsdWPB3nHUCKJxgnOyQNSBpO1eu4ycK3sLNIz4XK0Y/DlfsS8vPTDOsUcWajGHijQ0GaSUA/w00sTuCoDEj/WWebBHbb47brqQwi8mnn55FvIO6aiGf3dtv1dopVZIPOBP8afE+RHnBxI/eoW4QDyPxy05KwrE6vMnEwPbLhGV30FSCdefEJMnWNzDjuJIUhvpCZMpLrZQwJ96suesL+SgS/2qG52+O3vi16jiPxsJo6En1NW7jp68WfdxJgZdS4UrmU+R3M4rIUJpOrRabaeBhd8vE4yte5Immq+fIHw/CWkVS3fhws2aNriJODl1Q10WxkLZVLdSHdU/04tywhdHqT5tCYj+v3jfK+JLJQYbhj2/oSlxUdDvf8M7qEG4+6zMVwl/Lag8x7+7e1P3FmM+0585kb/jqTnL19uo/nluiiZA7JZ8g1MuqQ+0eabeyjE4XVBk9or3wxoN9sGV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Wei Yang [240830 18:04]: > This patch tries to cleanup some function description: > > * function name mismatch > * parameter name mismatch > * parameter all end up with ':' > * not prefix '*' if parameter is a pointer > > There is still some missing description of parameters, I didn't add them > since I am not sure the exact meaning. Thanks. Reviewed-by: Liam R. Howlett > > Signed-off-by: Wei Yang > --- > v3: > * s/interface/function/ in change log > v2: > * not change them to kernel doc since they are inline functions > --- > lib/maple_tree.c | 105 +++++++++++++++++++++-------------------------- > 1 file changed, 47 insertions(+), 58 deletions(-) > > diff --git a/lib/maple_tree.c b/lib/maple_tree.c > index b0ccd5539913..dda8e292c25b 100644 > --- a/lib/maple_tree.c > +++ b/lib/maple_tree.c > @@ -474,6 +474,7 @@ enum maple_type mas_parent_type(struct ma_state *mas, struct maple_enode *enode) > > /* > * mas_set_parent() - Set the parent node and encode the slot > + * @mas: The maple state > * @enode: The encoded maple node. > * @parent: The encoded maple node that is the parent of @enode. > * @slot: The slot that @enode resides in @parent. > @@ -534,7 +535,7 @@ unsigned int mte_parent_slot(const struct maple_enode *enode) > > /* > * mte_parent() - Get the parent of @node. > - * @node: The encoded maple node. > + * @enode: The encoded maple node. > * > * Return: The parent maple node. > */ > @@ -641,8 +642,8 @@ static inline unsigned int mas_alloc_req(const struct ma_state *mas) > > /* > * ma_pivots() - Get a pointer to the maple node pivots. > - * @node - the maple node > - * @type - the node type > + * @node: the maple node > + * @type: the node type > * > * In the event of a dead node, this array may be %NULL > * > @@ -665,8 +666,8 @@ static inline unsigned long *ma_pivots(struct maple_node *node, > > /* > * ma_gaps() - Get a pointer to the maple node gaps. > - * @node - the maple node > - * @type - the node type > + * @node: the maple node > + * @type: the node type > * > * Return: A pointer to the maple node gaps > */ > @@ -880,8 +881,6 @@ static inline void ma_set_meta(struct maple_node *mn, enum maple_type mt, > * @mt: The maple tree > * @mn: The maple node > * @type: The maple node type > - * @offset: The offset of the highest sub-gap in this node. > - * @end: The end of the data in this node. > */ > static inline void mt_clear_meta(struct maple_tree *mt, struct maple_node *mn, > enum maple_type type) > @@ -939,7 +938,7 @@ static inline unsigned char ma_meta_gap(struct maple_node *mn) > /* > * ma_set_meta_gap() - Set the largest gap location in a nodes metadata > * @mn: The maple node > - * @mn: The maple node type > + * @mt: The maple node type > * @offset: The location of the largest gap. > */ > static inline void ma_set_meta_gap(struct maple_node *mn, enum maple_type mt, > @@ -953,8 +952,8 @@ static inline void ma_set_meta_gap(struct maple_node *mn, enum maple_type mt, > > /* > * mat_add() - Add a @dead_enode to the ma_topiary of a list of dead nodes. > - * @mat - the ma_topiary, a linked list of dead nodes. > - * @dead_enode - the node to be marked as dead and added to the tail of the list > + * @mat: the ma_topiary, a linked list of dead nodes. > + * @dead_enode: the node to be marked as dead and added to the tail of the list > * > * Add the @dead_enode to the linked list in @mat. > */ > @@ -977,8 +976,8 @@ static void mt_destroy_walk(struct maple_enode *enode, struct maple_tree *mt, > bool free); > /* > * mas_mat_destroy() - Free all nodes and subtrees in a dead list. > - * @mas - the maple state > - * @mat - the ma_topiary linked list of dead nodes to free. > + * @mas: the maple state > + * @mat: the ma_topiary linked list of dead nodes to free. > * > * Destroy walk a dead list. > */ > @@ -999,7 +998,7 @@ static void mas_mat_destroy(struct ma_state *mas, struct ma_topiary *mat) > } > /* > * mas_descend() - Descend into the slot stored in the ma_state. > - * @mas - the maple state. > + * @mas: the maple state. > * > * Note: Not RCU safe, only use in write side or debug code. > */ > @@ -1448,7 +1447,7 @@ static inline unsigned char mas_data_end(struct ma_state *mas) > > /* > * mas_leaf_max_gap() - Returns the largest gap in a leaf node > - * @mas - the maple state > + * @mas: the maple state > * > * Return: The maximum gap in the leaf. > */ > @@ -1530,7 +1529,7 @@ static unsigned long mas_leaf_max_gap(struct ma_state *mas) > * @node: The maple node > * @gaps: The pointer to the gaps > * @mt: The maple node type > - * @*off: Pointer to store the offset location of the gap. > + * @off: Pointer to store the offset location of the gap. > * > * Uses the metadata data end to scan backwards across set gaps. > * > @@ -1634,7 +1633,7 @@ static inline void mas_parent_gap(struct ma_state *mas, unsigned long new) > > /* > * mas_update_gap() - Update a nodes gaps and propagate up if necessary. > - * @mas - the maple state. > + * @mas: the maple state. > */ > static inline void mas_update_gap(struct ma_state *mas) > { > @@ -1650,8 +1649,8 @@ static inline void mas_update_gap(struct ma_state *mas) > /* > * mas_adopt_children() - Set the parent pointer of all nodes in @parent to > * @parent with the slot encoded. > - * @mas - the maple state (for the tree) > - * @parent - the maple encoded node containing the children. > + * @mas: the maple state (for the tree) > + * @parent: the maple encoded node containing the children. > */ > static inline void mas_adopt_children(struct ma_state *mas, > struct maple_enode *parent) > @@ -1673,8 +1672,8 @@ static inline void mas_adopt_children(struct ma_state *mas, > /* > * mas_put_in_tree() - Put a new node in the tree, smp_wmb(), and mark the old > * node as dead. > - * @mas - the maple state with the new node > - * @old_enode - The old maple encoded node to replace. > + * @mas: the maple state with the new node > + * @old_enode: The old maple encoded node to replace. > */ > static inline void mas_put_in_tree(struct ma_state *mas, > struct maple_enode *old_enode) > @@ -1702,8 +1701,8 @@ static inline void mas_put_in_tree(struct ma_state *mas, > * mas_replace_node() - Replace a node by putting it in the tree, marking it > * dead, and freeing it. > * the parent encoding to locate the maple node in the tree. > - * @mas - the ma_state with @mas->node pointing to the new node. > - * @old_enode - The old maple encoded node. > + * @mas: the ma_state with @mas->node pointing to the new node. > + * @old_enode: The old maple encoded node. > */ > static inline void mas_replace_node(struct ma_state *mas, > struct maple_enode *old_enode) > @@ -1768,7 +1767,6 @@ static inline void mab_shift_right(struct maple_big_node *b_node, > /* > * mab_middle_node() - Check if a middle node is needed (unlikely) > * @b_node: the maple_big_node that contains the data. > - * @size: the amount of data in the b_node > * @split: the potential split location > * @slot_count: the size that can be stored in a single node being considered. > * > @@ -1816,6 +1814,7 @@ static inline int mab_no_null_split(struct maple_big_node *b_node, > /* > * mab_calc_split() - Calculate the split location and if there needs to be two > * splits. > + * @mas: The maple state > * @bn: The maple_big_node with the data > * @mid_split: The second split, if required. 0 otherwise. > * > @@ -2142,7 +2141,8 @@ static inline bool mas_next_sibling(struct ma_state *mas) > } > > /* > - * mte_node_or_none() - Set the enode and state. > + * mas_node_or_none() - Set the enode and state. > + * @mas: the maple state > * @enode: The encoded maple node. > * > * Set the node to the enode and the status. > @@ -2193,7 +2193,6 @@ static inline void mas_wr_node_walk(struct ma_wr_state *wr_mas) > /* > * mast_rebalance_next() - Rebalance against the next node > * @mast: The maple subtree state > - * @old_r: The encoded maple node to the right (next node). > */ > static inline void mast_rebalance_next(struct maple_subtree_state *mast) > { > @@ -2207,7 +2206,6 @@ static inline void mast_rebalance_next(struct maple_subtree_state *mast) > /* > * mast_rebalance_prev() - Rebalance against the previous node > * @mast: The maple subtree state > - * @old_l: The encoded maple node to the left (previous node) > */ > static inline void mast_rebalance_prev(struct maple_subtree_state *mast) > { > @@ -2358,9 +2356,9 @@ static inline unsigned char mas_mab_to_node(struct ma_state *mas, > /* > * mab_set_b_end() - Add entry to b_node at b_node->b_end and increment the end > * pointer. > - * @b_node - the big node to add the entry > - * @mas - the maple state to get the pivot (mas->max) > - * @entry - the entry to add, if NULL nothing happens. > + * @b_node: the big node to add the entry > + * @mas: the maple state to get the pivot (mas->max) > + * @entry: the entry to add, if NULL nothing happens. > */ > static inline void mab_set_b_end(struct maple_big_node *b_node, > struct ma_state *mas, > @@ -2379,11 +2377,11 @@ static inline void mab_set_b_end(struct maple_big_node *b_node, > * mas_set_split_parent() - combine_then_separate helper function. Sets the parent > * of @mas->node to either @left or @right, depending on @slot and @split > * > - * @mas - the maple state with the node that needs a parent > - * @left - possible parent 1 > - * @right - possible parent 2 > - * @slot - the slot the mas->node was placed > - * @split - the split location between @left and @right > + * @mas: the maple state with the node that needs a parent > + * @left: possible parent 1 > + * @right: possible parent 2 > + * @slot: the slot the mas->node was placed > + * @split: the split location between @left and @right > */ > static inline void mas_set_split_parent(struct ma_state *mas, > struct maple_enode *left, > @@ -2403,11 +2401,11 @@ static inline void mas_set_split_parent(struct ma_state *mas, > > /* > * mte_mid_split_check() - Check if the next node passes the mid-split > - * @**l: Pointer to left encoded maple node. > - * @**m: Pointer to middle encoded maple node. > - * @**r: Pointer to right encoded maple node. > + * @l: Pointer to left encoded maple node. > + * @m: Pointer to middle encoded maple node. > + * @r: Pointer to right encoded maple node. > * @slot: The offset > - * @*split: The split location. > + * @split: The split location. > * @mid_split: The middle split. > */ > static inline void mte_mid_split_check(struct maple_enode **l, > @@ -2431,10 +2429,10 @@ static inline void mte_mid_split_check(struct maple_enode **l, > /* > * mast_set_split_parents() - Helper function to set three nodes parents. Slot > * is taken from @mast->l. > - * @mast - the maple subtree state > - * @left - the left node > - * @right - the right node > - * @split - the split location. > + * @mast: the maple subtree state > + * @left: the left node > + * @right: the right node > + * @split: the split location. > */ > static inline void mast_set_split_parents(struct maple_subtree_state *mast, > struct maple_enode *left, > @@ -2468,7 +2466,6 @@ static inline void mast_set_split_parents(struct maple_subtree_state *mast, > /* > * mas_topiary_node() - Dispose of a single node > * @mas: The maple state for pushing nodes > - * @enode: The encoded maple node > * @in_rcu: If the tree is in rcu mode > * > * The node will either be RCU freed or pushed back on the maple state. > @@ -2600,7 +2597,7 @@ static inline void mas_topiary_replace(struct ma_state *mas, > /* > * mas_wmb_replace() - Write memory barrier and replace > * @mas: The maple state > - * @old: The old maple encoded node that is being replaced. > + * @old_enode: The old maple encoded node that is being replaced. > * > * Updates gap as necessary. > */ > @@ -3491,10 +3488,7 @@ static inline void mas_store_root(struct ma_state *mas, void *entry) > /* > * mas_is_span_wr() - Check if the write needs to be treated as a write that > * spans the node. > - * @mas: The maple state > - * @piv: The pivot value being written > - * @type: The maple node type > - * @entry: The data to write > + * @wr_mas: The maple write state > * > * Spanning writes are writes that start in one node and end in another OR if > * the write of a %NULL will cause the node to end with a %NULL. > @@ -4159,10 +4153,7 @@ static inline void mas_wr_modify(struct ma_wr_state *wr_mas) > > /* > * mas_wr_store_entry() - Internal call to store a value > - * @mas: The maple state > - * @entry: The entry to store. > - * > - * Return: The contents that was stored at the index. > + * @wr_mas: The maple write state > */ > static inline void mas_wr_store_entry(struct ma_wr_state *wr_mas) > { > @@ -4401,9 +4392,8 @@ static int mas_prev_node(struct ma_state *mas, unsigned long min) > * mas_prev_slot() - Get the entry in the previous slot > * > * @mas: The maple state > - * @max: The minimum starting range > + * @min: The minimum starting range > * @empty: Can be empty > - * @set_underflow: Set the @mas->node to underflow state on limit. > * > * Return: The entry in the previous slot which is possibly NULL > */ > @@ -4486,6 +4476,7 @@ static void *mas_prev_slot(struct ma_state *mas, unsigned long min, bool empty) > /* > * mas_next_node() - Get the next node at the same level in the tree. > * @mas: The maple state > + * @node: The maple node > * @max: The maximum pivot value to check. > * > * The next value will be mas->node[mas->offset] or the status will have > @@ -4576,8 +4567,6 @@ static int mas_next_node(struct ma_state *mas, struct maple_node *node, > * @mas: The maple state > * @max: The maximum starting range > * @empty: Can be empty > - * @set_overflow: Should @mas->node be set to overflow when the limit is > - * reached. > * > * Return: The entry in the next slot which is possibly NULL > */ > @@ -5111,9 +5100,9 @@ EXPORT_SYMBOL_GPL(mas_empty_area_rev); > > /* > * mte_dead_leaves() - Mark all leaves of a node as dead. > - * @mas: The maple state > + * @enode: the encoded node > + * @mt: the maple tree > * @slots: Pointer to the slot array > - * @type: The maple node type > * > * Must hold the write lock. > * > -- > 2.34.1 >