From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3108FC25B4F for ; Mon, 6 May 2024 15:59:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1D1F6B009C; Mon, 6 May 2024 11:59:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ACD066B009D; Mon, 6 May 2024 11:59:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BC356B009E; Mon, 6 May 2024 11:59:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7CB166B009C for ; Mon, 6 May 2024 11:59:37 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2A0F61408C3 for ; Mon, 6 May 2024 15:59:37 +0000 (UTC) X-FDA: 82088431194.17.139358E Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [95.215.58.183]) by imf19.hostedemail.com (Postfix) with ESMTP id B6CB61A000F for ; Mon, 6 May 2024 15:59:33 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=xvgj9ZeQ; spf=pass (imf19.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715011175; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PVBomsU1pkgWorTEFN1CEWB9RNQxy/wjf+w+O+s+tl4=; b=b49J9rOLEyNneCOXQ7lKhISWfX4jPozl1e0plOISh+6G1oflu20G4eZojxmE0s1gr7naHa 744oQQjfb2mo6P1TFPZORzcfdqrFn/F4tvh7+L9ugxeXzdUSA8VDIx7vvPs6nQoTJS5Sbo 78Nm+Oz3viRJaaPBpnV0vsR/zk82em4= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=xvgj9ZeQ; spf=pass (imf19.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715011175; a=rsa-sha256; cv=none; b=W0Wj3NNMENT5TdUWXS4ldNd6OqHLrogeHcwxvv6F/+XIWZDn9oPt8mzmsXE7CbeasIFJnd mZi0WBZfigABhSjU8OtCEK5NRgHwpP71stbsm88qCgiSnPBlx1oAkvzqH7deE7+KDlPPwN pGInRK3lHuPFKMxt1X1FL9MAbteG028= Date: Mon, 6 May 2024 08:59:26 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1715011171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PVBomsU1pkgWorTEFN1CEWB9RNQxy/wjf+w+O+s+tl4=; b=xvgj9ZeQkBGhC/+eTdpiuva+nypC87VBuujlemMoy4g8WBbc4t1XzK3S3YJRIOmfGmnRBf +hp2kIdPt9gjjQqmpVt63At7DdCgoHegyRzATUqfjgXg1FDLI2Q+kmbjyBh+2aXQuY06nN ToPt5JrYCo43mZMyEOroieswc9uk8oE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Yosry Ahmed Cc: syzbot , akpm@linux-foundation.org, cgroups@vger.kernel.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, muchun.song@linux.dev, roman.gushchin@linux.dev, syzkaller-bugs@googlegroups.com, yuzhao@google.com Subject: Re: [syzbot] [mm?] [cgroups?] WARNING in __mod_memcg_lruvec_state Message-ID: References: <0000000000007545d00615188a03@google.com> <0000000000001b9d500617c8b23c@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: B6CB61A000F X-Rspamd-Server: rspam06 X-Stat-Signature: xxpzfyws54n5x3gkbwup5aw3qbtxdyqf X-HE-Tag: 1715011173-464755 X-HE-Meta: U2FsdGVkX1/7zpdxeimPGikmBYFwm3yAM/b1aUwCsDUoWJBr9iFTUOAwYJdCG7FRSeTeYWam8Otxi5Zr3YSOXsCrBvW/2n+5nkFQzCp1AxUsqph+pmGeWFAEs6u+CeyMoJR7HPx7FhfNvI6ceOPtZa8TPjxhSEwXMzgf4OPcNGE1fdl/1rzhX83ghIBXZbjNfpwC0rWeIv/V1I8YqF6XRJOnGCMU/vYZVQFTk4qtJUcMPOXBdIXmpdvj8kIKhyFCFuh7CAsmD3kVeBeilnIWqLRJIV7eje8vIlJ3YirHLqBezf1U9JDUy48/JeVPDr3eRZ9TYL8nBIKaVhB8ZbSugijdTuGHjFgFtS8ph9XzYsH/MxJ09dhvdreMbO3Nb3bkt3bBLDbBfoLI/PAeA5SNSjwCx4g1DqBc6zQqSOCTVe0TOk+I+nOz3jcJ4+LR9sRS4HNUJ1pZcqxBGzJLu+UzDlTZmhSQYjul9FDlUqVE5OFfcqqU4Fk/b/DsfT1g7lXV3Aekk2Nteq+bstQIxWjM47tjg8OUGKOe1CJYhynNvteD3el6Q4pgxl0UGxnrViE5AlbsxMBfNzFUibi375QCACddgtK6HjKyYG4N3q35E8mBQutrt829aVsm8tgDzFZIkUjp35QkZNkQGpdloOVK0xFKZAVu/bAJmvunRc7gHQTz4ifR/Orfl2Dep4jY971PFY7h1m3MfFurqJRuEZf1tZe49oyb/Qnzft0pCTIHjY5QVIegT2Frq51l4Zjy7Ud5A9i1VQAxx6RGhw2aioh1tu+1URzMpi0+2uhN92vt0rh9S90P2mRKKke3d8lSqnny+bjv01i5Ab6H2i1n65WtENlvP7G7IfvsIOj3XGk8kmdz9o6rO5f2bbWz+WfPvQoQHwWj2EK+N9eIng4r5n43rZtzcNdSvoVNCON6kEJP0vA29d1p5UvLzzPBaR+H3JzkLKPpEmVzCKvtLNLBJzK P14ccLh2 ndv8xE2Px1VeqzYjKM1z0cjFudzGq/i5az7Pgm7P296juJ68i93OAgDRhdkngBXe9qXLH+Qh7r46+Iuccyqo2LJNcdtAQIIvYlOS8dn57Uby96pIBwX0EsreXd/Z9bS2QnayJxXgJLuCq7keRWJxroWkmT3o0oimY38ciG+XjkTXZU+hVzH4uTsaRcSzAWCv14SDEoaWMFU+/rldmvGCKI458jvNFmqgx3ZD4KLVDKTy3aXc9ccbjN4p17QqzGDoRSYI3Ron+vtUcO7MC3V97AGu1SLSRQe10dQj4YCJQboNpjRwmcpwQfveEK8uyOhdpC942/fgmF66p2blhpp+OiJokGulbD5ABm6GSnXEZr6EITyp3je7PNIxmc/dBXMmAvrLqe7yJtshBjsNLh4vgsuTcH/pJ7WxoRX1JUnRXtHQQsvPKT0pK+jDHwWY1fX0WHBJVxhOgUTQsKHlGueoJWqIszrNpnaw/z0NtGVr/UlVz5PZHfEdgwxuHPzF5cvrCe/Dg3bBzoeN3j6/+KYBqx8OxqHbpM+Epf9u5/nmLz1IF3NdJVz3G73ChCfJCEu5odPREgiZyt6y9rl+lswbHHuwkzg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 06, 2024 at 02:11:57PM +0000, Yosry Ahmed wrote: > On Mon, May 06, 2024 at 06:03:29AM -0700, syzbot wrote: > > syzbot has found a reproducer for the following issue on: > > > > HEAD commit: 2b84edefcad1 Add linux-next specific files for 20240506 > > git tree: linux-next > > console+strace: https://syzkaller.appspot.com/x/log.txt?x=1164931f180000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=b499929e4aaba1af > > dashboard link: https://syzkaller.appspot.com/bug?extid=9319a4268a640e26b72b > > compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=123d5d1f180000 > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=16527450980000 > > > > Downloadable assets: > > disk image: https://storage.googleapis.com/syzbot-assets/6a22cf95ee14/disk-2b84edef.raw.xz > > vmlinux: https://storage.googleapis.com/syzbot-assets/f5c45b515282/vmlinux-2b84edef.xz > > kernel image: https://storage.googleapis.com/syzbot-assets/9bf98258a662/bzImage-2b84edef.xz > > > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > > Reported-by: syzbot+9319a4268a640e26b72b@syzkaller.appspotmail.com > > > > ------------[ cut here ]------------ > > __mod_memcg_lruvec_state: missing stat item 25 > > WARNING: CPU: 0 PID: 5091 at mm/memcontrol.c:999 __mod_memcg_lruvec_state+0x18c/0x430 mm/memcontrol.c:999 > > This doesn't seem to be the same issue as the original one syzbot > reported. It's the same function but a different warning. I am not sure > how to tell syzbot that. > > Anyway, this warning is the one newly introduced by Shakeel. It is > firing because NR_SHMEM_PMDMAPPED and/or NR_FILE_PMDMAPPED are being > updated using __lruvec_stat_mod_folio(), which also updates the memcg > stats. However, these stats are not exported per-memcg. > > I think the following should fix it. > Hey Yosry, can you please post your patch with the signoff? The patch looks good and you can put my ack on it. > #syz test > > diff --git a/mm/rmap.c b/mm/rmap.c > index 12be4241474ab..d3a26ea4dbae2 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -1441,7 +1441,7 @@ static __always_inline void __folio_add_file_rmap(struct folio *folio, > > nr = __folio_add_rmap(folio, page, nr_pages, level, &nr_pmdmapped); > if (nr_pmdmapped) > - __lruvec_stat_mod_folio(folio, folio_test_swapbacked(folio) ? > + __mod_node_page_state(folio, folio_test_swapbacked(folio) ? > NR_SHMEM_PMDMAPPED : NR_FILE_PMDMAPPED, nr_pmdmapped); > if (nr) > __lruvec_stat_mod_folio(folio, NR_FILE_MAPPED, nr); >